Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | | fixing bit string test | Aaron Patterson | 2013-02-10 | 1 | -3/+3 | |
| | | | | ||||||
* | | | | Update activerecord/CHANGELOG.md | Guillermo Iguaran | 2013-02-09 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Use IN operator like arel for empty hash in where clause | robertomiranda | 2013-02-09 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Reverting e170014113 (Change behaviour with empty hash in where clause) | Guillermo Iguaran | 2013-02-08 | 3 | -12/+3 | |
| | | | | ||||||
* | | | | Reverting 16f6f25 (Change behaviour with empty array in where clause) | Guillermo Iguaran | 2013-02-08 | 6 | -14/+13 | |
| | | | | ||||||
* | | | | Improve changelog entries in AR | Carlos Antonio da Silva | 2013-02-08 | 1 | -5/+6 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Describe better the changes related to raising errors with empty array/hash values in where clauses. [ci skip] | |||||
* | | | | Change behaviour with empty array in where clause | robertomiranda | 2013-02-08 | 6 | -13/+14 | |
| | | | | ||||||
* | | | | Change behaviour with empty hash in where clause | robertomiranda | 2013-02-08 | 3 | -3/+11 | |
| | | | | ||||||
* | | | | Merge pull request #9207 from dylanahsmith/mysql-quote-numeric | Guillermo Iguaran | 2013-02-07 | 8 | -14/+60 | |
|\ \ \ \ | | | | | | | | | | | active_record: Quote numeric values compared to string columns. | |||||
| * | | | | active_record: Quote numeric values compared to string columns. | Dylan Smith | 2013-02-07 | 8 | -14/+60 | |
| | | | | | ||||||
* | | | | | Skip schema dumper extensions test if connection does not support it | Carlos Antonio da Silva | 2013-02-07 | 1 | -0/+1 | |
|/ / / / | | | | | | | | | | | | | | | | | Travis failed because the postgresql version installed there does not support extensions, so we just need to skip this for now. | |||||
* | | | | Run schema dumper extensions without creating real extensions | Carlos Antonio da Silva | 2013-02-06 | 1 | -9/+2 | |
| | | | | | | | | | | | | | | | | | | | | There is no need to create the extension in the database just to test if it's dumped, we can stub that instead. | |||||
* | | | | Do not print anything related to extensions when they don't none exist | Carlos Antonio da Silva | 2013-02-06 | 2 | -4/+16 | |
| | | | | | | | | | | | | | | | | | | | | When extensions are supported but there's no one enabled in the database, we should not print anything related to them in schema.rb. | |||||
* | | | | Add blank line after extensions to separate from tables in schema | Carlos Antonio da Silva | 2013-02-06 | 1 | -0/+1 | |
| | | | | ||||||
* | | | | Fix indentation of extensions in schema | Carlos Antonio da Silva | 2013-02-06 | 1 | -4/+2 | |
| | | | | ||||||
* | | | | Call super to use the abstract adapter implementation instead | Carlos Antonio da Silva | 2013-02-06 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Add changelog entry for #9203 about schema dumper with db extensions | Carlos Antonio da Silva | 2013-02-06 | 2 | -2/+7 | |
| | | | | | | | | | | | | | | | | [ci skip] | |||||
* | | | | add ActiveRecord::AbstractAdapter#extensions and ↵ | Justin George | 2013-02-06 | 3 | -0/+27 | |
| | | | | | | | | | | | | | | | | ActiveRecord::ConnectionAdapters::PostgreSQLAdapter#extensions to allow dumping of enabled extensions to schema.rb, add ActiveRecord::SchemaDumper#extensions to dump extensions to schema.rb | |||||
* | | | | improve tests to check for existence of extensions method, and skip testing ↵ | Justin George | 2013-02-06 | 2 | -8/+8 | |
| | | | | | | | | | | | | | | | | dumped extensions if they are unsupported by the database | |||||
* | | | | Add some tests to enumerate how extensions should be stored in the schema output | Justin George | 2013-02-06 | 2 | -0/+15 | |
| | | | | ||||||
* | | | | Enable hstore extensions on tests if it is not enabled and database supports it | Rafael Mendonça França | 2013-02-05 | 1 | -1/+8 | |
| | | | | ||||||
* | | | | Put .rdoc at the end of the files named RUNNING_UNIT_TESTS | Yuki Nishijima | 2013-02-03 | 1 | -0/+0 | |
| |/ / |/| | | | | | | | | So that they are printed nicely on GitHub. | |||||
* | | | Fix typo :bomb: | Rafael Mendonça França | 2013-01-31 | 1 | -1/+1 | |
| | | | ||||||
* | | | Fix typo | Rafael Mendonça França | 2013-01-31 | 1 | -2/+2 | |
| | | | ||||||
* | | | CHANGELOG review | Rafael Mendonça França | 2013-01-31 | 1 | -3/+3 | |
| | | | ||||||
* | | | Strict regexp | Rafael Mendonça França | 2013-01-31 | 1 | -2/+2 | |
| | | | ||||||
* | | | Extract the value casting to a method | Rafael Mendonça França | 2013-01-31 | 1 | -15/+23 | |
| | | | ||||||
* | | | DATABASE_URL parsing should turn numeric strings into numeric types, and | Aaron Stone | 2013-01-31 | 3 | -11/+68 | |
| | | | | | | | | | | | | | | | | | | the strings true and false into boolean types, in order to match how YAML would parse the same values from database.yml and prevent unexpected type errors in the database adapters. | |||||
* | | | Merge pull request #9119 from dazuma/database_tasks_for_unknown_adapter | Carlos Antonio da Silva | 2013-01-31 | 2 | -0/+10 | |
|\ \ \ | | | | | | | | | Raise an exception with a useful message if a rake task is requested for an unknown adapter | |||||
| * | | | Raise a specific exception with a useful message if a rake task is requested ↵ | Daniel Azuma | 2013-01-30 | 2 | -0/+10 | |
| | | | | | | | | | | | | | | | | for an unknown adapter | |||||
* | | | | class_eval should use __FILE__ and __LINE__ | Neeraj Singh | 2013-01-30 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Remove pre-emptive adapter name check from databases.rake so third party ↵ | Daniel Azuma | 2013-01-29 | 1 | -9/+3 | |
|/ / / | | | | | | | | | | adapters can register rake tasks | |||||
* | | | reloading type map on extension changing | Aaron Patterson | 2013-01-29 | 2 | -2/+15 | |
| | | | ||||||
* | | | fixing comment | Aaron Patterson | 2013-01-29 | 1 | -1/+1 | |
| | | | ||||||
* | | | Fix typo | Rafael Mendonça França | 2013-01-29 | 1 | -1/+1 | |
| | | | ||||||
* | | | Only search for enabled extension if the PostgreSQL version supports | Rafael Mendonça França | 2013-01-29 | 1 | -3/+5 | |
| | | | | | | | | | | | | extensions | |||||
* | | | Refactor to use each_key, remove extra spaces | Carlos Antonio da Silva | 2013-01-28 | 7 | -11/+5 | |
| | | | ||||||
* | | | add API to pg for enabling / disabling hstore | Aaron Patterson | 2013-01-28 | 3 | -7/+54 | |
| | | | ||||||
* | | | updates a dynamic method heredoc doc | Xavier Noria | 2013-01-28 | 1 | -2/+2 | |
| | | | ||||||
* | | | explains why the query cache checks arel.locked | Xavier Noria | 2013-01-28 | 1 | -0/+2 | |
| |/ |/| | ||||||
* | | Use Encoding::UTF_8 constant :do_not_litter: | Akira Matsuda | 2013-01-28 | 2 | -2/+2 | |
| | | ||||||
* | | Prevent Relation#merge from collapsing wheres on the RHS | Jon Leighton | 2013-01-27 | 9 | -22/+79 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This caused a bug with the new associations implementation, because now association conditions are represented as Arel nodes internally right up to when the whole thing gets turned to SQL. In Rails 3.2, association conditions get turned to raw SQL early on, which prevents Relation#merge from interfering. The current implementation was buggy when a default_scope existed on the target model, since we would basically end up doing: default_scope.merge(association_scope) If default_scope contained a where(foo: 'a') and association_scope contained a where(foo: 'b').where(foo: 'c') then the merger would see that the same column is representated on both sides of the merge and collapse the wheres to all but the last: where(foo: 'c') Now, the RHS of the merge is left alone. Fixes #8990 | |||||
* | | Fix typo: adaptors => adapters [ci skip] | Carlos Antonio da Silva | 2013-01-27 | 1 | -1/+1 | |
| | | ||||||
* | | Fix cases where delete_records on a has_many association caused errors | Derek Kraan | 2013-01-27 | 7 | -5/+49 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | because of an ambiguous column name. This happened if the association model had a default scope that referenced a third table, and the third table also referenced the original table (with an identical foreign_key). Mysql requires that ambiguous columns are deambiguated by using the full table.column syntax. Postgresql and Sqlite use a different syntax for updates altogether (and don't tolerate table.name syntax), so the fix requires always including the full table.column and discarding it later for Sqlite and Postgresql. | |||||
* | | Use `silence` instead of `quietly` to silence the `CheckPending` middleware. | Lucas Mazza | 2013-01-26 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | `Kernel.quietly` silences `STDOUT` and `STDERR`, which is useless if the logger is writing to a file, while `AS::Logger#silence` swaps the logger level to `ERROR`. Related to #8820 and #8052. | |||||
* | | Simplify type casting code for timezone aware attributes | Andrew White | 2013-01-26 | 1 | -10/+5 | |
| | | | | | | | | | | | | With the addition of String#in_time_zone and Date#in_time_zone we can simplify the type casting code by checking if the value has an `in_time_zone` method. | |||||
* | | Fix handling of dirty time zone aware attributes | Lilibeth De La Cruz | 2013-01-26 | 3 | -2/+32 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, when `time_zone_aware_attributes` were enabled, after changing a datetime or timestamp attribute and then changing it back to the original value, `changed_attributes` still tracked the attribute as changed. This caused `[attribute]_changed?` and `changed?` methods to return true incorrectly. Example: in_time_zone 'Paris' do order = Order.new original_time = Time.local(2012, 10, 10) order.shipped_at = original_time order.save order.changed? # => false # changing value order.shipped_at = Time.local(2013, 1, 1) order.changed? # => true # reverting to original value order.shipped_at = original_time order.changed? # => false, used to return true end | |||||
* | | Merge remote-tracking branch 'docrails/master' | Xavier Noria | 2013-01-26 | 3 | -5/+5 | |
|\ \ | | | | | | | | | | | | | | | | Conflicts: actionpack/lib/action_view/helpers/form_options_helper.rb guides/code/getting_started/app/controllers/comments_controller.rb | |||||
| * | | Fix typo | Tatsuro Baba | 2013-01-22 | 1 | -1/+1 | |
| | | | ||||||
| * | | Remove useless number sign | Tatsuro Baba | 2013-01-18 | 1 | -2/+2 | |
| | | | | | | | | | | | | I think that these signs are probably mistake. |