Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | rename AR::Model::Tag to AR::Tag - fixes #7714 | Francesco Rodriguez | 2012-09-20 | 6 | -14/+19 |
| | |||||
* | Freeze columns only once per Result | Santiago Pastorino | 2012-09-20 | 1 | -6/+9 |
| | |||||
* | Freeze columns just before using them as hash keys | Santiago Pastorino | 2012-09-20 | 1 | -2/+5 |
| | |||||
* | Merge pull request #7631 from jeremyevans/patch-1 | Aaron Patterson | 2012-09-19 | 1 | -1/+1 |
|\ | | | | | Freeze columns before using them as hash keys | ||||
| * | Freeze columns before using them as hash keys | Jeremy Evans | 2012-09-13 | 1 | -1/+1 |
| | | | | | | This reduces the number of allocated strings from columns * (rows + 1) to just columns. | ||||
* | | update AR::AttributeAssignment documentation [ci skip] | Francesco Rodriguez | 2012-09-19 | 1 | -5/+5 |
| | | |||||
* | | Merge pull request #7710 from guilleiguaran/refactor-ar-attributes-method | Rafael Mendonça França | 2012-09-19 | 1 | -10/+4 |
|\ \ | | | | | | | AR::Base#attributes= is just an alias for AR::Base#assign_attributes | ||||
| * | | AR::Base#attributes= is just an alias for AR::Base#assign_attributes | Guillermo Iguaran | 2012-09-19 | 1 | -10/+4 |
| | | | |||||
* | | | Fix out-of-date URL. | Alex Reisner | 2012-09-19 | 1 | -1/+1 |
| | | | |||||
* | | | Update changelogs to add entries about strong_parameters integration | Guillermo Iguaran | 2012-09-19 | 1 | -0/+14 |
| | | | |||||
* | | | Load the environment after creating the database | Jeremy Kemper | 2012-09-19 | 1 | -2/+2 |
| | | | |||||
* | | | Revert "Make sure :environment task is executed before db:schema:load or ↵ | Jeremy Kemper | 2012-09-19 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | db:structure:load " Breaks db:setup because it tries to load the environment before creating the database. This reverts commit 5ca11fefce6d83f5db399aa4412f1f1a0d42b2e6. | ||||
* | | | Improve the CHANGELOG entry for #6971 | Rafael Mendonça França | 2012-09-19 | 1 | -1/+14 |
| | | | |||||
* | | | fix querying with an empty hash | Damien Mathieu | 2012-09-19 | 3 | -3/+18 |
| | | | | | | | | | | | | Closes #6960 | ||||
* | | | Remove unused private method AR::NestedAttributes#unassignable_keys and ↵ | Guillermo Iguaran | 2012-09-19 | 1 | -5/+1 |
|/ / | | | | | | | reference to mass_assignment options | ||||
* | | Update AR::Base.create and AR:Base#update_attributes docs to remove ↵ | Guillermo Iguaran | 2012-09-18 | 1 | -11/+0 |
| | | | | | | | | references to mass assignment options | ||||
* | | Update docs for AR::Base#new to remove references to mass_assignment_options | Guillermo Iguaran | 2012-09-18 | 1 | -10/+1 |
| | | |||||
* | | Merge pull request #7251 from rails/integrate-strong_parameters | David Heinemeier Hansson | 2012-09-18 | 31 | -1320/+133 |
|\ \ | | | | | | | Integrate strong_parameters in Rails 4 | ||||
| * | | Set primary key with id= only if primary key exists | Guillermo Iguaran | 2012-09-16 | 1 | -1/+1 |
| | | | |||||
| * | | Remove mass_assignment_options from ActiveRecord | Guillermo Iguaran | 2012-09-16 | 18 | -162/+66 |
| | | | |||||
| * | | attr_accessible and attr_protected raise an exception pointing to use plugin ↵ | Guillermo Iguaran | 2012-09-16 | 1 | -0/+2 |
| | | | | | | | | | | | | or new protection model | ||||
| * | | Don't use assert_nothing_raised when assert_equal is used | Guillermo Iguaran | 2012-09-16 | 1 | -10/+6 |
| | | | |||||
| * | | Rename ForbiddenAttributes exception to ForbiddenAttributesError | Guillermo Iguaran | 2012-09-16 | 2 | -2/+2 |
| | | | |||||
| * | | Add tests for ForbiddenAttributesProtection in ActiveRecord | Guillermo Iguaran | 2012-09-16 | 1 | -0/+63 |
| | | | |||||
| * | | Remove mass assignment security from ActiveRecord | Guillermo Iguaran | 2012-09-16 | 20 | -1170/+18 |
| | | | |||||
* | | | ActiveRecord -> Active Record | Xavier Noria | 2012-09-18 | 1 | -1/+1 |
| | | | |||||
* | | | Use the CHANGELOG convention [ci skip] | Rafael Mendonça França | 2012-09-17 | 1 | -3/+5 |
| | | | |||||
* | | | Merge pull request #7661 from ernie/build-join-records-on-unsaved-hmt | Rafael Mendonça França | 2012-09-17 | 3 | -0/+24 |
|\ \ \ | | | | | | | | | Fix collection= on hm:t join models when unsaved | ||||
| * | | | Fix collection= on hm:t join models when unsaved | Ernie Miller | 2012-09-17 | 3 | -0/+24 |
| | | | | | | | | | | | | | | | | | | | | | | | | If assigning to a has_many :through collection against an unsaved object using the collection=[<array_of_items>] syntax, the join models were not properly created, previously. | ||||
* | | | | Fix warning: method redefine. Testcase name are duplicated. | kennyj | 2012-09-17 | 1 | -1/+1 |
| |/ / |/| | | |||||
* | | | improve AR/CHANGELOG [ci skip] | Francesco Rodriguez | 2012-09-16 | 1 | -44/+68 |
| | | | |||||
* | | | Merge pull request #7547 from danmcclain/pg-arrays | Rafael Mendonça França | 2012-09-16 | 12 | -53/+435 |
|\ \ \ | | | | | | | | | Adds migration and type casting support for PostgreSQL Array datatype | ||||
| * | | | Moves column dump specific code to a module included in AbstractAdapter | Dan McClain | 2012-09-14 | 12 | -53/+435 |
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Having column related schema dumper code in the AbstractAdapter. The code remains the same, but by placing it in the AbstractAdapter, we can then overwrite it with Adapter specific methods that will help with Adapter specific data types. The goal of moving this code here is to create a new migration key for PostgreSQL's array type. Since any datatype can be an array, the goal is to have ':array => true' as a migration option, turning the datatype into an array. I've implemented this in postgres_ext, the syntax is shown here: https://github.com/dockyard/postgres_ext#arrays Adds array migration support Adds array_test.rb outlining the test cases for array data type Adds pg_array_parser to Gemfile for testing Adds pg_array_parser to postgresql_adapter (unused in this commit) Adds schema dump support for arrays Adds postgres array type casting support Updates changelog, adds note for inet and cidr support, which I forgot to add before Removing debugger, Adds pg_array_parser to JRuby platform Removes pg_array_parser requirement, creates ArrayParser module used by PostgreSQLAdapter | ||||
* | | | Remove debug code :bomb: | Rafael Mendonça França | 2012-09-16 | 1 | -1/+0 |
| | | | |||||
* | | | Merge pull request #7651 from steveklabnik/issue_3956 | Rafael Mendonça França | 2012-09-16 | 2 | -2/+33 |
|\ \ \ | |_|/ |/| | | | | | | | | | | | Don't preserve SELECT columns on COUNT Closes #7651 | ||||
| * | | Don't preserve SELECT columns on COUNT | Steve Klabnik | 2012-09-16 | 2 | -2/+33 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The COUNT clause of a finder_sql relationship is being rewritten from COUNT(*) to COUNT(table_name.*). This does not appear to be valid syntax in MySQL: ``` mysql> SELECT COUNT( table_name.* ) FROM `table_name`; ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '* ) FROM `table_name`' at line 1 ``` This fixes the bug, as well as adding tests so we don't re-introduce it in the future. Fixes #3956. | ||||
* | | | Don't explain except normal CRUD sql. | kennyj | 2012-09-17 | 3 | -1/+14 |
| | | | |||||
* | | | Fix find_in_batches with customized primary_key | Toshiyuki Kawanishi | 2012-09-16 | 4 | -6/+38 |
| | | | |||||
* | | | Query for sequence info also should be markd as SCHEMA. | kennyj | 2012-09-15 | 1 | -3/+3 |
| | | | |||||
* | | | Query for loading index info should be marked as SCHEMA. | kennyj | 2012-09-15 | 2 | -2/+2 |
| | | | |||||
* | | | Merge pull request #7643 from steveklabnik/deprecate_silence | Rafael Mendonça França | 2012-09-15 | 1 | -12/+18 |
|\ \ \ | | | | | | | | | Deprecate ActiveSupport::Benchmarkable#silence. | ||||
| * | | | Deprecate ActiveSupport::Benchmarkable#silence. | Steve Klabnik | 2012-09-15 | 1 | -12/+18 |
| | |/ | |/| | | | | | | | | | | | | | | | | Due to its lack of thread safety, we're deprecating this, and it will be removed in Rails 4.1. Fixes #4060. | ||||
* | | | simplify rescue | Jon Leighton | 2012-09-15 | 1 | -3/+3 |
| |/ |/| | |||||
* | | Fix test | Jon Leighton | 2012-09-15 | 2 | -15/+21 |
| | | | | | | | | Accidentally checked in commented test code. Fail. >_< | ||||
* | | Ensure disconnecting or reconnecting resets the transaction state | Jon Leighton | 2012-09-15 | 7 | -9/+55 |
| | | |||||
* | | Remove our use of #outside_transaction? | Jon Leighton | 2012-09-15 | 3 | -61/+17 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This method was first seen in 045713ee240fff815edb5962b25d668512649478, and subsequently reimplemented in fb2325e35855d62abd2c76ce03feaa3ca7992e4f. According to @jeremy, this is okay to remove. He thinks it was added because at the time we didn't have much transaction state to keep track of, and he viewed it as a hack for us to track it internally, thinking it was better to ask the connection for the transaction state. Over the years we have added more and more state to track, a lot of which is impossible to ask the connection for. So it seems that this is just a relic of the passed and we will just track the state internally only. | ||||
* | | Remove the transaction_open variable | Jon Leighton | 2012-09-15 | 2 | -21/+33 |
| | | |||||
* | | Move transaction joinability into the transaction object | Jon Leighton | 2012-09-15 | 5 | -20/+36 |
| | | |||||
* | | Alter the naming structure a bit | Jon Leighton | 2012-09-15 | 3 | -108/+111 |
| | | |||||
* | | Split Open into Real and Savepoint | Jon Leighton | 2012-09-15 | 1 | -25/+38 |
| | |