aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | | Fix AR Changelog examples and improve syntax highlight [ci skip]Carlos Antonio da Silva2013-11-141-12/+12
| | | | | | |
* | | | | | | Revert "Used Yield instead of block.call" -- this causes all of ↵David Heinemeier Hansson2013-11-141-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | atom_feed_helper_test.rb to fail with "SystemStackError: stack level too deep". This reverts commit d3a1ce1cdc60d593de1682c5f4e3230c8db9a0fd.
* | | | | | | Fix that eager loading of polymorphic associations did not work with ↵David Heinemeier Hansson2013-11-143-4/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | association empty?/any? predicates any more (there is still a problem when select is applied to a relation, or if you try association#exists? -- but its easier to work around)
* | | | | | | Merge pull request #12893 from javan/to-param-addendumRafael Mendonça França2013-11-142-8/+28
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Addendum to #12891
| * | | | | | | Addendum to #12891Javan Makhmali2013-11-142-8/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix incorrectly named tests * Restore Object#to_param behavior * Ensure param is derived from a squished and truncated string
* | | | | | | | Merge pull request #12819 from vipulnsward/also_dup_column_typesRafael Mendonça França2013-11-141-3/+4
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | Also dup `column_types` in AR::Result `initialize_copy`
| * | | | | | | Also dup `column_types` in AR::Result `initialize_copy`Vipul A M2013-11-101-3/+4
| | | | | | | |
* | | | | | | | Merge pull request #12889 from kuldeepaggarwal/speed_upsRafael Mendonça França2013-11-141-3/+3
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Used Yield instead of block.call
| * | | | | | | | Used Yield instead of block.callKuldeep Aggarwal2013-11-151-3/+3
| | | | | | | | |
* | | | | | | | | Add AR::Base.to_param for convenient "pretty" URLs derived from a model's ↵Javan Makhmali2013-11-144-0/+65
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | attribute or method.
* | | | | | | | | Merge pull request #12832 from vipulnsward/move_schema_creationYves Senn2013-11-142-78/+84
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Move `SchemaCreation` to its own file instead of `AbstractAdapter`.
| * | | | | | | | | Move `SchemaCreation` to its own file instead of `AbstractAdapter`.Vipul A M2013-11-122-78/+84
| | |/ / / / / / / | |/| | | | | | |
* | | | | | | | | Merge pull request #12845 from amatsuda/should_ar_depend_on_railsGuillermo Iguaran2013-11-131-1/+5
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Refer to Rails.env from AR only when Rails is defined
| * | | | | | | | | Refer to Rails.env only when Rails is definedAkira Matsuda2013-11-111-1/+5
| | | | | | | | | |
* | | | | | | | | | Merge pull request #12772 from dmathieu/no_touchingRafael Mendonça França2013-11-135-0/+112
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Add No Touching
| * | | | | | | | | | add #no_touching on ActiveRecord modelsDamien Mathieu2013-11-135-0/+112
| | | | | | | | | | |
* | | | | | | | | | | fix weird Emacs auto indentation. [ci skip]Yves Senn2013-11-131-8/+8
| | | | | | | | | | |
* | | | | | | | | | | tests for merging Relations of different classes.Yves Senn2013-11-131-0/+19
| | | | | | | | | | |
* | | | | | | | | | | move Relation#merge tests into separate file.Yves Senn2013-11-132-121/+131
| | | | | | | | | | |
* | | | | | | | | | | Ensure that a column added in a test is being removed after allAkira Matsuda2013-11-131-0/+7
|/ / / / / / / / / /
* | | | | | | | | | Remove the unused, undocumented SQLite3Adapter#supports_count_distinct?Ben Woosley2013-11-121-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This has returned true since 3cc9b5f1, and is not used internally.
* | | | | | | | | | Drop a sqlite_version check because we only support SQLite 3.6.16 or newer.Ben Woosley2013-11-122-7/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Drop some comments that document the implementation rather than the interface.
* | | | | | | | | | Prevent the counter cache from being decremented twicedm1try2013-11-113-1/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | when destroying a record on a has_many :through association. :destroy method has own counter_cache callbacks.
* | | | | | | | | | Unifies mysql and mysql2 casting of booleans.Yves Senn2013-11-114-9/+16
| | | | | | | | | |
* | | | | | | | | | test cases to describe the MySQL boolean behavior.Yves Senn2013-11-111-0/+91
| | | | | | | | | |
* | | | | | | | | | Do not count "SHOW CREATE TABLE" queries when testing against mysqlAkira Matsuda2013-11-111-1/+1
| | | | | | | | | |
* | | | | | | | | | tidy Active Record CHANGELOG. [ci skip].Yves Senn2013-11-111-1/+3
| | | | | | | | | |
* | | | | | | | | | Avoid sorting an Array including objects from different ClassesAkira Matsuda2013-11-111-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | addresses "ArgumentError: comparison of VerySpecialComment with SpecialComment failed" in ActiveRecord::DelegationRelationTest#test_#sort!_delegation_is_deprecated
* | | | | | | | | | Load test fixtures where data are neededAkira Matsuda2013-11-111-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Without this, some tests here were not actually testing anything.
* | | | | | | | | | Merge pull request #12834 from dredozubov/has_one_association_replacementYves Senn2013-11-113-4/+26
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Fixes problem with replacing has_one association record with itself
| * | | | | | | | | | Fixes problem with replacing has_one association record with itselfDenis Redozubov2013-11-113-4/+26
| | |_|/ / / / / / / | |/| | | | | | | |
* | | | | | | | | | A tiny grammatical fixAkira Matsuda2013-11-111-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | | | | | | autoload ChangeColumnDefinition (Fixes #12835)Anton Kalyaev2013-11-111-0/+1
| |/ / / / / / / / |/| | | | | | | |
* | | | | | | | | Merge pull request #12749 from iantropov/issue_5303Rafael Mendonça França2013-11-101-0/+4
|\ \ \ \ \ \ \ \ \ | |/ / / / / / / / |/| | | | | | | | | | | | | | | | | Add test for ActiveRecord::Relation YAML serialization, for #5303 issue
| * | | | | | | | Add test for ActiveRecord::Relation YAML serialization, for #5303 issueIvan Antropov2013-11-031-0/+4
| | | | | | | | |
* | | | | | | | | use complete Relation API and not only `Model.all.merge!`.Yves Senn2013-11-091-88/+83
| | | | | | | | |
* | | | | | | | | Change array check for better aesthetics / reading the codeCarlos Antonio da Silva2013-11-091-1/+1
| | | | | | | | |
* | | | | | | | | Merge pull request #12821 from arunagw/aa-removed-missleading-messageYves Senn2013-11-092-2/+2
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | clarified missleading message
| * | | | | | | | | Changed message for Model.inspectArun Agrawal2013-11-092-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (No database connection) sounds not be able to connect database. see more #12804
* | | | | | | | | | improve Active Record Store docs when using PG types. [ci skip].Yves Senn2013-11-091-3/+4
| | | | | | | | | |
* | | | | | | | | | type casted PG bytea values are represented as a Hash.Yves Senn2013-11-091-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a follow up to: 97f0d9a0dd12e7ad634815eecfeff866f64aad92 This change is also related to: df0edafac9eb47cd971970a9e7b13a3eaddf214e
* | | | | | | | | | Document the bind returnRafael Mendonça França2013-11-091-0/+3
| | | | | | | | | |
* | | | | | | | | | Avoid shot circuit return.Rafael Mendonça França2013-11-091-8/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will make the conditional and to code clear
* | | | | | | | | | Improve changelogs formatting [ci skip]Carlos Antonio da Silva2013-11-091-8/+8
| | | | | | | | | |
* | | | | | | | | | Don't use Active Support where we don't need toRafael Mendonça França2013-11-093-3/+3
| | | | | | | | | |
* | | | | | | | | | Fix typo in AR store docs [ci skip]Carlos Antonio da Silva2013-11-091-1/+1
|/ / / / / / / / /
* | / / / / / / / log bind variables after they were type casted.Yves Senn2013-11-095-10/+36
| |/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The log output used to be confusing in situation where type casting has "unexpected" effects. For example when finding records with a `String`. BEFORE: irb(main):002:0> Event.find("im-no-integer") D, [2013-11-09T11:10:28.998857 #1706] DEBUG -- : Event Load (4.5ms) SELECT "events".* FROM "events" WHERE "events"."id" = $1 LIMIT 1 [["id", "im-no-integer"]] AFTER: irb(main):002:0> Event.find("im-no-integer") D, [2013-11-09T11:10:28.998857 #1706] DEBUG -- : Event Load (4.5ms) SELECT "events".* FROM "events" WHERE "events"."id" = $1 LIMIT 1 [["id", 0]]
* | | | | | | | Mark broken test as pendingRafael Mendonça França2013-11-082-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will avoid the broken window effect in our test suite
* | | | | | | | Remove more skipRafael Mendonça França2013-11-084-13/+7
| | | | | | | |
* | | | | | | | Don't skip tests if we don't need to.Rafael Mendonça França2013-11-0830-1023/+966
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We can conditional define the tests depending on the adapter or connection. Lets keep the skip for fail tests that need to be fixed.