Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | test bind value equality | Aaron Patterson | 2014-01-14 | 1 | -2/+2 |
| | |||||
* | translate exceptions on prepared statement failure | Aaron Patterson | 2014-01-14 | 2 | -6/+13 |
| | |||||
* | reorder bind indexes if joins produced bind values | Aaron Patterson | 2014-01-14 | 1 | -0/+9 |
| | |||||
* | expliticly make STI column a bind value | Aaron Patterson | 2014-01-14 | 1 | -4/+9 |
| | |||||
* | Merge branch 'master' into set_binds | Aaron Patterson | 2014-01-14 | 2 | -8/+7 |
|\ | | | | | | | | | | | * master: directly create the ARel AST Updated comment to mention the enum mapping class method [ci skip] | ||||
| * | directly create the ARel AST | Aaron Patterson | 2014-01-14 | 1 | -6/+4 |
| | | | | | | | | rather than allocating a new Relation, just make the AST directly | ||||
| * | Updated comment to mention the enum mapping class method [ci skip] | Godfrey Chan | 2014-01-14 | 1 | -2/+3 |
| | | |||||
| * | "string" isn't a valid column type for ActiveRecord | Aaron Patterson | 2014-01-14 | 1 | -1/+1 |
| | | | | | | | | | | Conflicts: activerecord/test/cases/adapters/sqlite3/sqlite3_adapter_test.rb | ||||
* | | take in to account existing bind parameters when building the bind list | Aaron Patterson | 2014-01-14 | 1 | -21/+20 |
| | | |||||
* | | match against bind values | Aaron Patterson | 2014-01-14 | 1 | -2/+2 |
| | | |||||
* | | comment out the sqlite3 debug code (for now) | Aaron Patterson | 2014-01-14 | 1 | -0/+7 |
| | | |||||
* | | fix statement cache execution | Aaron Patterson | 2014-01-14 | 1 | -7/+6 |
| | | |||||
* | | fix cache class interface | Aaron Patterson | 2014-01-14 | 2 | -22/+26 |
| | | |||||
* | | unscoping a where should remove bind values | Aaron Patterson | 2014-01-14 | 1 | -0/+2 |
| | | |||||
* | | remove dead code | Aaron Patterson | 2014-01-14 | 1 | -2/+0 |
| | | |||||
* | | drop the dual encodings table | Aaron Patterson | 2014-01-14 | 1 | -2/+2 |
| | | |||||
* | | where needs to bring the bind params when creating a new relation | Aaron Patterson | 2014-01-14 | 1 | -0/+3 |
| | | |||||
* | | `where` makes bind values, so stop manually creating them | Aaron Patterson | 2014-01-14 | 1 | -11/+3 |
| | | |||||
* | | switch to arrays for bind removal test | Aaron Patterson | 2014-01-14 | 1 | -4/+2 |
| | | | | | | | | we can't make bind values for arrays yet | ||||
* | | `where` creates binds, so do not create them manually | Aaron Patterson | 2014-01-14 | 1 | -2/+1 |
| | | |||||
* | | we should not be copying these. fixes ↵ | Aaron Patterson | 2014-01-14 | 1 | -4/+0 |
| | | | | | | | | test_find_all_using_where_with_relation_with_bound_values | ||||
* | | Merge branch 'master' into set_binds | Aaron Patterson | 2014-01-14 | 11 | -42/+135 |
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: don't establish a new connection when testing with `sqlite3_mem`. sqlite >= 3.8.0 supports partial indexes Don't try to get the subclass if the inheritance column doesn't exist Enum mappings are now exposed via class methods instead of constants. Fix fields_for documentation with index option [ci skip] quick pass through Active Record CHANGELOG. [ci skip] [ci skip] Grammar correction single quotes for controller generated routes [ci skip] Added alias to CSRF Set NameError#name | ||||
| * | don't establish a new connection when testing with `sqlite3_mem`. | Yves Senn | 2014-01-14 | 1 | -15/+21 |
| | | | | | | | | | | | | | | This fixes broken `rake test_sqlite3_mem` suite for Active Record. The problem is that that the old database with the schema is lost when establishing a new connection. Upon reconnting we are left with a blank database and tests down the line start failing. | ||||
| * | sqlite >= 3.8.0 supports partial indexes | Cody Cutrer | 2014-01-14 | 3 | -1/+25 |
| | | |||||
| * | Don't try to get the subclass if the inheritance column doesn't exist | Ujjwal Thaakar | 2014-01-14 | 5 | -8/+42 |
| | | | | | | | | | | | | | | The `subclass_from_attrs` method is called even if the column specified by the `inheritance_column` setting doesn't exist. This prevents setting associations via the attributes hash if the association name clashes with the value of the setting, typically `:type`. This worked previously in Rails 3.2. | ||||
| * | Enum mappings are now exposed via class methods instead of constants. | Godfrey Chan | 2014-01-14 | 3 | -10/+31 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Example: class Conversation < ActiveRecord::Base enum status: [ :active, :archived ] end Before: Conversation::STATUS # => { "active" => 0, "archived" => 1 } After: Conversation.statuses # => { "active" => 0, "archived" => 1 } | ||||
| * | quick pass through Active Record CHANGELOG. [ci skip] | Yves Senn | 2014-01-14 | 1 | -7/+9 |
| | | |||||
| * | Merge pull request #13669 from chulkilee/name-error-name | Yves Senn | 2014-01-14 | 3 | -2/+8 |
| |\ | | | | | | | Set NameError#name | ||||
| | * | Set NameError#name | Chulki Lee | 2014-01-13 | 3 | -2/+8 |
| | | | |||||
* | | | remove dead code | Aaron Patterson | 2014-01-14 | 1 | -3/+0 |
| | | | |||||
* | | | adjust AST tests to respect bind values | Aaron Patterson | 2014-01-14 | 1 | -21/+61 |
| | | | |||||
* | | | where uses bind values so we don't need to manually create them | Aaron Patterson | 2014-01-14 | 1 | -11/+3 |
| | | | |||||
* | | | remove test that does not apply anymore | Aaron Patterson | 2014-01-14 | 1 | -12/+1 |
| | | | |||||
* | | | explains for prepared statements should never have binds in SQLite3 | Aaron Patterson | 2014-01-13 | 1 | -1/+1 |
| | | | |||||
* | | | fixing column alias resolution | Aaron Patterson | 2014-01-13 | 1 | -1/+1 |
| | | | |||||
* | | | fix tests for explain plan + binds | Aaron Patterson | 2014-01-13 | 2 | -3/+3 |
| | | | |||||
* | | | replace bind values on calls to to_sql | Aaron Patterson | 2014-01-13 | 2 | -4/+8 |
| | | | |||||
* | | | do not clear out bind parameters on unscope | Aaron Patterson | 2014-01-13 | 1 | -3/+0 |
| | | | |||||
* | | | Merge branch 'master' into set_binds | Aaron Patterson | 2014-01-13 | 8 | -6/+45 |
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (24 commits) unscope should remove bind values associated with the where reverse_order_value= is not private, so no need to send avoid more dynamic symbols no need to to_sym recover from test runs that leave the database in a bad state updates screenshot data [ci skip] "serie" => "series" revises a few things in the getting started guide [ci skip] Favor canonical environment variables for secrets removed extra comma [ci skip] Only lookup `config.log_level` for stdlib `::Logger`. Closes #11665. Updated Changelog to reflect removal of :dependent => :restrict standardize on jruby_skip & rbx_skip fix bug in becomes! when changing from base to subclass. Closes #13272. highlight http://localhost:3000 in README.md. Closes #13643. [ci skip] doc proc/lambda arg on inclusion validation. Closes #13689. [ci skip] Skip Spring App Generator tests on JRuby fixes a typo in a CHANGELOG upgrade SDoc fixes the Gemfile generator templates ... Conflicts: activerecord/test/cases/hot_compatibility_test.rb | ||||
| * | | unscope should remove bind values associated with the where | Aaron Patterson | 2014-01-13 | 2 | -0/+11 |
| | | | |||||
| * | | reverse_order_value= is not private, so no need to send | Aaron Patterson | 2014-01-13 | 1 | -1/+1 |
| | | | | | | | | | | | | It's not public API, but is not private scoped. | ||||
| * | | avoid more dynamic symbols | Aaron Patterson | 2014-01-13 | 1 | -1/+1 |
| | | | |||||
| * | | no need to to_sym | Aaron Patterson | 2014-01-13 | 1 | -2/+2 |
| | | | |||||
| * | | recover from test runs that leave the database in a bad state | Aaron Patterson | 2014-01-13 | 1 | -1/+1 |
| |/ | |||||
| * | fix bug in becomes! when changing from base to subclass. Closes #13272. | Yves Senn | 2014-01-13 | 3 | -1/+22 |
| | | |||||
| * | use enum labels as form values. Achieved by `_before_type_cast`. | Yves Senn | 2014-01-11 | 2 | -0/+7 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #13650, #13672 This is an alternate implementation to solve #13650. Currently form fields contain the enum value (eg. "1"). This breaks because the setter `enum=` expects the label (eg. "active"). ActiveRecord::Enum allows you to use labels in your application but store numbers. We should make sure that all parts after AR are dealing with labels and not the underlying mapping to a number. This patch defines `_before_type_cast` on every enum column to return the label. This method is later used to fetch the value to display in form fields. I deliberately copied the implementation of the enum getter instead of delegating to it. This allows you to overwrite the getter and for example return a `Value Object` but have it still work for form fields. | ||||
* | | check bind parameter uniqueness | Aaron Patterson | 2014-01-13 | 1 | -1/+6 |
| | | |||||
* | | adding bind values to the manager object | Aaron Patterson | 2014-01-13 | 5 | -9/+11 |
| | | |||||
* | | bubble bind parameters up when building join dependencies | Aaron Patterson | 2014-01-13 | 3 | -9/+19 |
| | | |||||
* | | force table creation | Aaron Patterson | 2014-01-11 | 1 | -1/+1 |
| | |