aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* fixes markup of the CHANGELOG entry from 455d710Xavier Noria2013-03-161-14/+14
|
* If a counter_cache is defined, then using update_attributes and changingJohn Wang2013-03-153-0/+77
| | | | | the primary key on an association will make sure that the corresponding counter on the association is changed properly. Fixes #9722.
* Merge pull request #9734 from choudhuryanupam/masterRafael Mendonça França2013-03-151-2/+2
|\ | | | | Method #primary_key? is not reused
| * Refactored to reuse methodAnupam Choudhury2013-03-151-2/+2
| |
* | Fix implicit join references option reversion in testCarlos Antonio da Silva2013-03-151-1/+2
| |
* | Merge pull request #9733 from ↵Jon Leighton2013-03-154-2/+38
|\ \ | | | | | | | | | | | | senny/9712_option_to_turn_references_deprecation_off make it possible to disable implicit join references.
| * | make it possible to disable implicit join references.Yves Senn2013-03-154-2/+38
| |/ | | | | | | Closes #9712.
* / Cache the association proxy objectJon Leighton2013-03-152-1/+6
|/ | | | | | | | This reimplements the behaviour of Rails 3, as I couldn't see why we shouldn't cache the object, and @alindeman had a good use case for caching it: https://github.com/rails/rails/commit/c86a32d7451c5d901620ac58630460915292f88b#commitcomment-2784312
* Merge pull request #9683 from senny/deprecate_count_distinct_optionJon Leighton2013-03-1523-54/+123
|\ | | | | rename `Relation#uniq` to `Relation#distinct`
| * Deprecate the `:distinct` option for `Relation#count`.Yves Senn2013-03-158-15/+44
| | | | | | | | | | | | | | We moved more and more away from passing options to finder / calculation methods. The `:distinct` option in `#count` was one of the remaining places. Since we can now combine `Relation#distinct` with `Relation#count` the option is no longer necessary and can be deprecated.
| * rename `Relation#uniq` to `Relation#distinct`. `#uniq` still works.Yves Senn2013-03-1521-40/+80
| | | | | | | | | | | | | | | | The similarity of `Relation#uniq` to `Array#uniq` is confusing. Since our Relation API is close to SQL terms I renamed `#uniq` to `#distinct`. There is no deprecation. `#uniq` and `#uniq!` are aliases and will continue to work. I also updated the documentation to promote the use of `#distinct`.
* | Merge pull request #9686 from strzalek/cast_number_to_string_in_pgJon Leighton2013-03-152-3/+14
|\ \ | |/ |/| Cast number to string in Postgres
| * Cast number to string in PostgresŁukasz Strzałkowski2013-03-122-3/+14
| | | | | | | | fixes #9170
* | `#reset_counters` verifies counter names.Yves Senn2013-03-152-1/+9
| | | | | | | | | | | | | | Closes #9724. Raise an `ArgumentError` when the name of the counter does not match an association name.
* | ask column if it is a pkAaron Patterson2013-03-141-1/+5
| |
* | fix hash duping on 1.9Aaron Patterson2013-03-141-1/+1
| |
* | clean up pk delclaration in `create_table`Aaron Patterson2013-03-141-1/+8
| |
* | bumping arelAaron Patterson2013-03-141-1/+1
| |
* | just access the ivars rather than rb_iv_getAaron Patterson2013-03-141-5/+3
| |
* | hide more data in the schema cacheAaron Patterson2013-03-144-17/+34
| |
* | safely publish columns and columns hash infoAaron Patterson2013-03-144-15/+23
| |
* | dup and set the default proc to nil rather than looping through everythingAaron Patterson2013-03-141-1/+3
| |
* | you can provide uuid_generate_v4 as the default value for uuid columnsAaron Patterson2013-03-143-2/+52
| |
* | pg is the only adapter that supports the xml type, so push the method downAaron Patterson2013-03-142-9/+4
| |
* | Apparently people were mutating this array. :'(Aaron Patterson2013-03-141-3/+3
| | | | | | | | This reverts commit abba61e2bbe320894ba8449ebdf778a1d2af545b.
* | hashes are ordered, so just use the columns_hash ivarAaron Patterson2013-03-141-3/+3
| |
* | use the method so we do not depend on internal ivarsAaron Patterson2013-03-141-1/+1
| |
* | extract factory method and push common code up to abstract adapterAaron Patterson2013-03-142-7/+7
| |
* | MOAR cleanups.Vipul A M2013-03-144-6/+5
| |
* | Add support for generate scaffold password:digestSam Ruby2013-03-132-1/+8
| | | | | | | | | | | | | | | | | | | | * adds password_digest attribute to the migration * adds has_secure_password to the model * adds password and password_confirmation password_fields to _form.html * omits password entirely from index.html and show.html * adds password and password_confirmation to the controller * adds unencrypted password and password_confirmation to the controller test * adds encrypted password_digest to the fixture
* | fix typo in Active Record CHANGELOG [ci skip]Yves Senn2013-03-131-1/+1
| |
* | Also quote extension name in disable_extensionStephen Touset2013-03-121-1/+1
|/ | | A patch was committed recently which quoted the extension name in the SQL for `enable_extension`. But the same wasn't done for `disable_extension`.
* Merge pull request #9676 from neerajdotname/9567-destroy-should-call-destroy-allRafael Mendonça França2013-03-121-2/+3
|\ | | | | dependent: :destroy should call destroy_all
| * dependent: :destroy should call destroy_allNeeraj Singh2013-03-111-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit https://github.com/rails/rails/pull/9668 shows warning when `delete_all` is invoked with `:dependent` option `:destroy`. Unfortunately invoking `Post.destroy_all` invokes `post.comments.delete_all` as part of `has_many` callbacks. This commit ensures that instead `post.comments.destroy_all` is invoked and in the process no warning is generated. See issue #9567 for details .
* | Pass column to quote when copying a sqlite table.Matthew M. Boedicker2013-03-113-2/+23
| | | | | | | | To make quote escape binary data correctly it needs the column passed in.
* | Fix typo [ci skip]Carlos Antonio da Silva2013-03-111-1/+1
|/
* promotes change_column_null to the migrations APIXavier Noria2013-03-112-0/+27
|
* quick pass over the RDoc of schema_statements.rb [ci skip]Xavier Noria2013-03-111-122/+190
|
* documents how to DROP DEFAULT [ci skip]Xavier Noria2013-03-111-3/+7
|
* Merge pull request #9668 from neerajdotname/9567-delete-all-warningXavier Noria2013-03-111-0/+9
|\ | | | | Show warning message if delete_all is firing callbacks
| * Show warning message if delete_all is firing callbacksNeeraj Singh2013-03-111-0/+9
| | | | | | | | | | | | `post.comments.delete_all` will fire callbacks if :dependent option is :destroy . It will be fixed in Rails 4.1 . In the meantime display a warning . Look at #9567 for details .
* | default the reaping frequency to 10 secondsAaron Patterson2013-03-111-1/+1
|/
* add an missing assertion to inheritance_test.rbTakehiro Adachi2013-03-111-0/+1
| | | | | | assertion for https://github.com/rails/rails/blob/ad624345e54bd20802de67b2b5c9ef29ecf5 d5f4/activerecord/lib/active_record/inheritance.rb#L32
* Merge pull request #9650 from yahonda/group_by_oracleRafael Mendonça França2013-03-101-2/+2
|\ | | | | Address ActiveRecord::StatementInvalid: OCIError: ORA-00979
| * Address ActiveRecord::StatementInvalid: OCIError: ORA-00979Yasuo Honda2013-03-111-2/+2
| |
* | document habtm join-table name with custom prefix [ci skip].Yves Senn2013-03-101-0/+2
|/ | | | | | Closes #9643. The logic was introduced with 46492949
* Change uniq validation with conditions examples to use where with hashesCarlos Antonio da Silva2013-03-092-5/+5
| | | | Take the opportunity to showcase where.not.
* Merge pull request #9633 from senny/5321_make_it_lazyCarlos Antonio da Silva2013-03-093-4/+23
|\ | | | | | | | | | | Uniqueness validation uses a proc to specify the `:conditions` option. This is a follow up to #5321 and follows the general direction in AR to make things lazy evaluated.
| * Uniqueness validation uses a proc to specify the `:conditions` option.Yves Senn2013-03-093-4/+23
| | | | | | | | | | This is a follow up to #5321 and follows the general direction in AR to make things lazy evaluated.
* | Merge pull request #9618 from manvsmachine/fix-postgres-enable-extension-errorCarlos Antonio da Silva2013-03-091-1/+1
|\ \ | | | | | | | | | | | | | | | Bugfix for enable_extension in postgresql_adapter. The use of quotations is required to install extensions with certain characters in them (e.g. uuid-ossp).