| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|\
| |
| | |
Respect limit for PG bit strings
|
| | |
|
|\ \
| |/
|/| |
Refactor determination of whether the field has changed
|
| |
| |
| |
| |
| | |
The types know more about what is going on than the dirty module. Let's
ask them!
|
| | |
|
| | |
|
|/
|
|
|
| |
That data is internal to Active Record. What we care about is that
new records have the right default value.
|
| |
|
|
|
|
| |
/cc @sgrif
|
|
|
|
|
|
| |
Fix polymorphic to check for `options[:polymorphic]` instead of
`options.key? :polymorphic` and then reuse the method `polymorphic?`
method instead of constantly checking the same `options[:polymorphic]`.
|
|\
| |
| | |
Remove unused `initialize_attributes` method
|
| |
| |
| |
| |
| | |
This was previously a hook for a special case related to `serialize`,
which has since been removed.
|
|/ |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
This inlines casting for the most obvious types. The rest will
follow eventually. I need to put some tests in place, to make sure
that the inlining is not causing regressions.
/cc @sgrif
|
|
|
|
| |
the issue tracker. See also #15455 [ci skip]
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Nearly completely implemented in terms of custom properties.
`_before_type_cast` now stores the raw serialized string consistently,
which removes the need to keep track of "state". The following is now
consistently true:
- `model.serialized == model.reload.serialized`
- A model can be dumped and loaded infinitely without changing
- A model can be saved and reloaded infinitely without changing
|
|\
| |
| | |
Don't change values in `@raw_attributes` during serialization
|
| |
| |
| |
| |
| |
| | |
During `init_with`, the attributes given to the coder will be placed
into `@raw_attributes`. As such, we should read from `@raw_attributes`
when encoding, rather than `@attributes`, which has been type cast.
|
|\ \
| |/
|/| |
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Clear all caches calculated based on `@columns` when `@columns` changes
|
| | | |
|
|/ / |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The first case was not testing what the issue mentioned actually was (A
subclass of a class with serialized attributes does not serialize when
they come from the database).
The second case was a bad coder. It would fail if the model was `dup`ed,
or if the the model was loaded from the database and then saved again.
The third case wasn't testing anything that wasn't covered by the second
(and was also a bad coder for the same reasons as the second).
|
|\ \
| | |
| | | |
Rename attribute related instance variables to better express intent
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
`@attributes` was actually used for `_before_type_cast` and friends,
while `@attributes_cache` is the type cast version (and caching is the
wrong word there, but I'm working on removing the conditionals around
that). I opted for `@raw_attributes`, because `_before_type_cast` is
also semantically misleading. The values in said hash are in the state
given by the form builder or database, so raw seemed to be a good word.
|
|/ / |
|
| |
| |
| |
| |
| |
| |
| | |
This removes the case statement in `SchemaDumper` and gives every `Type`
the possibility to control the SchemaDumper default value output.
/cc @sgrif
|
| |
| |
| |
| |
| | |
This is an intermediate solution. It is related to the refactoring @sgrif
is making and will change in the future.
|
| | |
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Fixed #columns_for_distinct of postgresql adapter
Conflicts:
activerecord/CHANGELOG.md
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Many of the methods defined in `AttributeMethods::Serialization` can be
refactored onto this type as well, but this is a reasonable small step.
Removes the `Type` class, and the need for `decorate_columns` to handle
serialized types.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
MySQL and PostgreSQL provide a column type override in order to properly
type cast computed columns included in a result set. This should never
override the known types of full fledged columns. In addition to messing
up computed properties, this would have led to inconsistent behavior
between a record created with `new`, and a record created with `last` on
the mysql adapter in the following cases:
- `tinyint(1)` with `emulate_booleans` set to `false`
- `text`, `string`, `binary`, and `decimal` columns
|
|\ \ \
| | | |
| | | | |
Ensure we always use instances of the adapter specific column class
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
- Create a consistent API across adapters for building new columns
- Use it for custom properties so we don't get `UndefinedMethodError`s
in stuff I'm implementing elsewhere.
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Keep closer to other methods that touch @transaction
|
| | | | |
|
|/ / /
| | |
| | |
| | |
| | |
| | | |
Working towards re-implementing serialized attributes to use the
properties API exposed the need for this, as serializing a column
shouldn't change the order of the columns.
|