| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
The same test exists in `test/cases/relation/merging_test.rb`.
https://github.com/rails/rails/blob/v5.1.0/activerecord/test/cases/relation/merging_test.rb#L94-L101
|
|
|
|
|
| |
Since we have been using this `Arel::Table` since 111ccc832bc977b15af12c14e7ca078dad2d4373,
in order to properly handle queries, it's important that we properly type cast arguments.
|
|\
| |
| | |
Deprecate `supports_statement_cache?`
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
`supports_statement_cache?` was introduced in 3.1.0.beta1 (104d0b2) for
bind parameter substitution, but it is no longer used in 3.1.0.rc1
(73ff679). Originally it should respect `prepared_statements` rather
than `supports_statement_cache?` (fd39847).
One more thing, named `supports_statement_cache?` is pretty misreading.
We have `StatementCache` and `StatementPool`. However,
`supports_statement_cache?` doesn't mean `StatementCache`, but
`StatementPool` unlike its name.
https://github.com/rails/rails/blob/v5.1.0/activerecord/lib/active_record/statement_cache.rb
https://github.com/rails/rails/blob/v5.1.0/activerecord/lib/active_record/connection_adapters/statement_pool.rb
|
|\ \
| |/
|/| |
Use `flat_map` rather than `map(&:...).flatten`
|
| | |
|
|/
|
|
|
|
| |
* Remove trailing spaces.
* Add backticks around method and command.
* Fix indentation.
|
|
|
|
|
|
| |
Just use one `Event` class. Reduces duplication, makes the tests easier
to read. It might seem like each tests needs a different kind of Struct,
since we make a new one for each test case.
|
|
|
|
| |
Fix #28905
|
| |
|
|
|
|
|
| |
This change reverted in eac6f369 but it is needed for data integrity.
See #25328.
|
|\
| |
| | |
PostgreSQL 10 does not convert `CURRENT_DATE` into `('now'::text)::date`
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Address #28797
In the previous versions of PostgreSQL, `CURRENT_DATE` converted to `('now'::text)::date`
and `CURRENT_TIMESTAMP` converted to `now()`.
Refer these discussions and commit at PostgreSQL :
https://www.postgresql.org/message-id/flat/5878.1463098164%40sss.pgh.pa.us#5878.1463098164@sss.pgh.pa.us
https://github.com/postgres/postgres/commit/0bb51aa96783e8a6c473c2b5e3725e23e95db834
|
|\ \
| | |
| | | |
Set consistent typecast ENV["VERBOSE"]
|
| | |
| | |
| | |
| | |
| | | |
Add cases to ensure that environment variables VERBOSE and VERSION have
correct typecast.
|
| |/
| |
| |
| |
| | |
Set consistent type cast ENV["VERBOSE"]:
ENV["VERBOSE"] is true if it not equal "false"
|
|\ \
| | |
| | | |
Remove useless test case
|
| |/
| |
| |
| |
| | |
Cannot call private methods in `@klass` against `CollectionProxy`
(inherites `Relation`) because using `public_send` in `method_missing`.
|
|\ \
| | |
| | | |
Remove mysql2 database adapter default username root
|
| | | |
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| | |
mtsmfm/disable-referential-integrity-without-superuser-privilege-take-2"
This reverts commit c1faca6333abe4b938b98fedc8d1f47b88209ecf, reversing
changes made to 8c658a0ecc7f2b5fc015d424baf9edf6f3eb2b0b.
See https://github.com/rails/rails/pull/27636#issuecomment-297534129
|
|/ |
|
|\
| |
| | |
Mixin `CollectionProxy::DelegateExtending` after `ClassSpecificRelation`
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
`ClassSpecificRelation` has `method_missing` and the `method_missing` is
called first. if an associated class has the missing method in a
relation, never reach to the `method_missing` in the `CollectionProxy`.
I extracted `DelegateExtending` and included it to the delegate class
that including `ClassSpecificRelation` to fix the issue.
Fixes https://github.com/rails/rails/pull/28246#issuecomment-296033784.
|
|\ \
| | |
| | | |
`respond_to_missing?` should be private
|
| |/
| |
| |
| |
| |
| |
| | |
Follow up of 03d3f036.
Some of `respond_to?` were replaced to `respond_to_missing?` in 03d3f036.
But the visibility is still public. It should be private.
|
| |
| |
| |
| |
| |
| |
| | |
Add `ActiveRecord::Migration.verbose = true`
to be sure that verbose is turned on in the test.
Related to #28865
|
|\ \
| | |
| | | |
Replace \Z to \z
|
| |/
| |
| |
| | |
\Z was a mistake of \z. Replace \Z to \z to prevent newly \Z added.
|
|\ \
| | |
| | | |
Remove checks for Enumerator#size method
|
| |/
| |
| |
| |
| |
| |
| |
| | |
The Enumerator#size method was introduced in Ruby 2.0.
These tests were added when Rails 4.1 was current, and Ruby 1.9.3 was
still supported. Since Rails 5 only Ruby >= 2.2.2 is supported, so the
checks are no longer necessary.
|
|/
|
|
|
|
|
|
|
| |
'lookup' is the noun. 'to look up' is the verb. Looked it up just to
be sure.
cf.
https://en.wiktionary.org/wiki/lookup
https://en.wiktionary.org/wiki/look_up
|
|
|
|
| |
Fixes #24032
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
association saved in the callback
Related #18155, #26661, 268a5bb, #27434, #27442, and #28599.
Originally #18155 was introduced for preventing double insertion caused
by the after save callback. But it was caused the before save issue
(#26661). 268a5bb fixed #26661, but it was caused the performance
regression (#27434). #27442 added new record to `target` before calling
callbacks for fixing #27434. But it was caused double firing before save
callback (#28599). We cannot add new object to `target` before saving
the object.
This is improving #18155 to only track callbacks after `save`.
Fixes #28599.
|
|\
| |
| |
| | |
Fix quoting in db:create grant all statement.
|
| |
| |
| |
| |
| |
| | |
The database name used in the test would have actually shown this if it
had tried to execute on a real Mysql instead of being stubbed out
(dashes in database names needs quotes).
|
|\ \
| | |
| | | |
Don't fallback to utf8mb3 after MySQL 8.0.0
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
`internal_string_options_for_primary_key` is used for creating internal
tables in newly apps. But it is no longer needed after MySQL 8.0.0.
MySQL 5.7 has introduced `innodb_default_row_format` (default `DYNAMIC`)
and has deprecated `innodb_large_prefix` and `innodb_file_format`.
The purpose of the deprecated options was for compatibility with earlier
versions of InnoDB.
https://dev.mysql.com/doc/refman/5.7/en/innodb-parameters.html#sysvar_innodb_large_prefix
> innodb_large_prefix is deprecated and will be removed in a future
release. innodb_large_prefix was introduced in MySQL 5.5 to disable
large index key prefixes for compatibility with earlier versions of
InnoDB that do not support large index key prefixes.
https://dev.mysql.com/doc/refman/5.7/en/innodb-parameters.html#sysvar_innodb_file_format
> The innodb_file_format option is deprecated and will be removed in a
future release. The purpose of the innodb_file_format option was to
allow users to downgrade to the built-in version of InnoDB in MySQL 5.1.
Now that MySQL 5.1 has reached the end of its product lifecycle,
downgrade support provided by this option is no longer necessary.
The deprecated options has removed in MySQL 8.0.0. It is no longer
needed to take care newly created internal tables as a legacy format
after MySQL 8.0.0.
Fixes #28730.
|
|\ \ \
| | | |
| | | | |
`cache_key` respects the limit in a relation even if a relation is not loaded
|
| |/ /
| | |
| | |
| | |
| | |
| | | |
`cache_key` includes the size of a relation. But if a relation is not
loadded, the size is not respected even if a relation has a limit. It
should be respected for consistency.
|
| | |
| | |
| | |
| | |
| | | |
Raise error on the movement of migrations
when the current migration does not exist.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
I'm not sure why `Mysql2VirtualColumnTest#test_schema_dumping` passed
previously. But now the test not pass at least in MariaDB 10.1.9.
I fixed the regexp to respect `COLLATE`.
```
% ARCONN=mysql2 be ruby -w -Itest test/cases/adapters/mysql2/virtual_column_test.rb -n test_schema_dumping
Using mysql2
Run options: -n test_schema_dumping --seed 7131
F
Finished in 0.466304s, 2.1445 runs/s, 4.2890 assertions/s.
1) Failure:
Mysql2VirtualColumnTest#test_schema_dumping [test/cases/adapters/mysql2/virtual_column_test.rb:55]:
Expected /t\.virtual\s+"upper_name",\s+type: :string,\s+as: "UPPER\(`name`\)"$/i to match "# This file is auto-generated from the current state of the database. Instead\n# of editing this file, please use the migrations feature of Active Record to\n# incrementally modify your database, and then regenerate this schema definition.\n#\n# Note that this schema.rb definition is the authoritative source for your\n# database schema. If you need to create the application database on another\n# system, you should be using db:schema:load, not running all the migrations\n# from scratch. The latter is a flawed and unsustainable approach (the more migrations\n# you'll amass, the slower it'll run and the greater likelihood for issues).\n#\n# It's strongly recommended that you check this file into your version control system.\n\nActiveRecord::Schema.define(version: 0) do\n\n create_table \"virtual_columns\", force: :cascade, options: \"ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci\" do |t|\n t.string \"name\"\n t.virtual \"upper_name\", type: :string, as: \n t.virtual \"name_length\", type: :integer, as: \"LENGTH(`name`)\", stored: true\n end\n\nend\n".
1 runs, 2 assertions, 1 failures, 0 errors, 0 skips
```
```
> select @@version;
+--------------------+
| @@version |
+--------------------+
| 10.1.9-MariaDB-log |
+--------------------+
1 row in set (0.00 sec)
```
|
| | |
| | |
| | |
| | | |
Related #28399.
|
|\ \ \
| | | |
| | | | |
Add test for method `#attributes`
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
ActiveRecord::AttributeMethods#attributes
Extracted from https://github.com/rails/rails/pull/28159
|
| |/ /
|/| |
| | |
| | | |
Since 1a92ae83 all `indexes` methods are under the `SchemaStatements`.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
MySQL 8.0.1 and higher supports descending indexes: `DESC` in an index
definition is no longer ignored.
See https://dev.mysql.com/doc/refman/8.0/en/descending-indexes.html.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* Use keyword arguments in `IndexDefinition` to ease to ignore unused
options and to avoid to initialize incorrect empty value.
* Place it in `SchemaStatements` for consistency.
* And tiny tweaks.
|
|\ \ \
| | | |
| | | | |
Rename `association_query_handler.rb` to `association_query_value.rb`
|