| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
This reverts commit 487a1061cc496455dfe5ee84d1e49d509c1675b5.
This `#--` is necessary for the doc of `distinct`.
[ci skip]
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently `_default_attributes` doesn't work unless `load_schema` is
called before.
The `MissingAttributeError` is caused by `reload_schema_from_cache` is
invoked by `serialize`.
I added `load_schema` in `_default_attributes` to `_default_attributes`
works without any dependency like `attribute_types` etc.
Closes #31905.
|
|
|
|
|
| |
Followup to b988ecb, when I cherry-picked from my parallel testing
branch I didn't realize `drop` wasn't part of the commit.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
You could use the `VERBOSE` env var to turn off output for migrations
tasks but you couldn't use it for other tasks.
This change moves the `verbose?` check to a method so we can also use it
in create and drop respectively.
tenderlove and I noticed this as part of the ongoing work in parallel
testing. When the parallel tests boot the app needs to create new
databases for each worker. The output from these is unnecessary but
there was previously no way to turn it off. Now if `VERBOSE=false` is
passes to `bin/rails db:create` the text "Created blah blah db" will no
longer be output.
|
|
|
|
|
|
|
|
|
|
|
| |
Since #29572, test runner will be loaded as minitest's plugin.
Therefore, if specify a value in `Minitest.extensions` before the Minitest
initialization process, the extension will not load and the test runner will
not work.
https://github.com/seattlerb/minitest/blob/44eee51ed9716c789c7cea8a90c131cf736b8915/lib/minitest.rb#L86
Also, load processing of adapter is done before minitest option processing,
so set the adapter in the file so that the `-a` option works.
|
|
|
|
| |
@connection.more_results?`
|
|
|
|
|
|
| |
These are internally used only.
[ci skip]
|
| |
|
|
|
|
| |
:tada::tada::tada:
|
| |
|
|\
| |
| | |
Dump correctly index nulls order for PostgreSQL
|
| | |
|
|\ \
| | |
| | | |
Avoid extra calls to to_s
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
With #31615 `type_for_attribute` accepts either
a symbol as well as a string. `has_attribute?` and `attribute_alias`
also accept either. Since these methods call `to_s` on the argument,
we no longer need to do that at the call site.
|
|/ /
| |
| |
| |
| | |
This can not expand an array of aggregated objects correctly, and is no
longer used internally since 159b21b5.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This example was added in abdf546ad6d02ecb95766e73cd3c645a48c954de
but was inconsistent with `composed_of :balance` definition in the
'Customer'.
[Ryuta Kamizono & bogdanvlviv]
[ci skip]
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This reverts commit 755f7b58953c25790eea0574ff8928033ded2d88, reversing
changes made to 35db4603095e8ccc0a92d925a42d4b3d9462580f.
Originally `mapping: %w(balance amount)` is correct mapping example.
Closes #31346.
[Ryuta Kamizono & bogdanvlviv]
[ci skip]
|
| | |
|
|\ \
| | |
| | | |
Allow type_for_attribute(:symbol)
|
| | |
| | |
| | |
| | | |
Closes #31611.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Follow up of #31724.
If `composed_of` objects have multiple mappings, array predicate handler
can not correctly handle the expanded condition.
We need to handle it like polymorphic association objects.
|
|\ \ \
| | | |
| | | |
| | | | |
Fix not expanded problem when passing an Array object as argument to the where method using composed_of column.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
where method using composed_of column.
Fixes #31723
```
david_balance = customers(:david).balance
Customer.where(balance: [david_balance]).to_sql
# Before: WHERE `customers`.`balance` = NULL
# After : WHERE `customers`.`balance` = 50
```
|
| |_|/
|/| | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
|/ /
| |
| |
| |
| |
| | |
Since #29504, mysql2 adapter lost ability to insert zero value on
primary key due to enforce `NO_AUTO_VALUE_ON_ZERO` disabled.
That is for using `DEFAULT` on auto increment column, but we can use
`NULL` instead in that case.
|
| |
| |
| |
| |
| | |
MySQL supports descending indexes from 8.0.1 onwards:
https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-1.html
|
| |
| |
| |
| | |
Since #31422, `insert_fixtures` is deprecated.
|
| |
| |
| |
| | |
It was unused since 9e4c41c903e8e58721f2c41776a8c60ddba7a0a9.
|
| |
| |
| |
| | |
It is useless since 90c8be76a7d00475be5ff4db2eeedde5cc936c2d.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
driving table
This is a regression caused by 6beb4de.
In PostgreSQL, ORDER BY expressions must appear in SELECT list when
using DISTINCT.
When using `count(:all)` with eager loading, Active Record enforces
DISTINCT to count the driving table records only. 6beb4de was caused the
regression because `count(:all)` with DISTINCT path no longer removes
ORDER BY.
We need to ignore ORDER BY when DISTINCT is enforced, otherwise not
always generated valid SQL for PostgreSQL.
Fixes #31783.
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Avoid passing unnecessary arguments to relation
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Most of the time the table and predicate_builder
passed to Relation.new are exactly the
arel_table and predicate builder of the
given klass. This uses klass.arel_table
and klass.predicate_builder as the defaults,
so we don't have to pass them in most cases.
This does change the signaure of both Relation and
AssocationRelation. Are we ok with that?
|
| | | |
|
|\ \ \
| |/ /
|/| | |
Only enable verbose_query_logs in Rails server
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Should fix #31688 unless someone can point me to a better way to achieve
this goal. Essentially David's point was that verbose query logging when
enabled in Rails console tends to make things very noisy.
That's especially true if we display absolute paths to callsites which
sadly is still the case when we detect a caller that isn't part of the
Rails application — think gems.
Discussed this with both @matthewd and @rafaelfranca and went back and
forth between enabling if defined?(Rails::Server) or this implementation
and this one makes more sense for now.
Long term I think it'll make sense to let people override this default
disabling in Rails Console because they might want to use the feature
but for now it feels like the correct default behavior.
|
| | |
| | |
| | |
| | |
| | |
| | | |
It doesn't have to do anything, but it shouldn't fail.
Fixes #31766.
|
|\ \ \
| | | |
| | | | |
Postgresql bulk_change_table should flatten procs array
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Build a multi-statement query when inserting fixtures
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- mysql will add a 2 bytes margin to the statement, so given a `max_allowed_packet` set to 1024 bytes, a 1024 bytes fixtures will no be inserted (mysql will throw an error)
- Preventing this by decreasing the max_allowed_packet by 2 bytes when doing the comparison with the actual statement size
|