aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Avoid leaking the first relation we call #first onMatthew Draper2015-10-091-0/+6
| | | | | | | | With the previous implementation, the block passed to define_singleton_method, which will live forever as the method body, captures the parameters (args and block) in its enclosure. For the current_scope registry, that can include an AR::Relation.
* Merge pull request #21911 from tommyblue/masterRafael Mendonça França2015-10-081-3/+8
|\ | | | | Modify the scope method documentation
| * Modify the scope method documentationTommaso Visconti2015-10-081-3/+8
| | | | | | | | | | | | | | | | | | | | | | Adds a paragraph to the documentation of the `ActiveRecord::Scoping::Named.scope` method, explaining that the method is intended to return an ActiveRecord::Relation object to be composable with other scopes. In the case that in the case that `nil` or `false` are returned, the method returns an `all` relation instead. This unexpected behaviour is mentioned in #19249 #14256 #21465 and #21882 and wasn't documented at all. This commit adds this documentation.
* | Remove unused requireakihiro172015-10-081-1/+0
| | | | | | | | `require 'active_support/core_ext/string/filters'` was added in b3bfa36. However, it is no longer needed from 3ae981814.
* | Merge pull request #21913 from kamipo/fix_subsecond_precision_supported_versionSean Griffin2015-10-081-3/+1
|\ \ | | | | | | Fix subsecond precision supported version
| * | Fix subsecond precision supported versionRyuta Kamizono2015-10-081-3/+1
| |/ | | | | | | | | | | Fractional Seconds supported version is 5.6.4 or higher. http://dev.mysql.com/doc/refman/5.6/en/fractional-seconds.html
* / Remove unused `pk_and_sequence_for` in AbstractMysqlAdapterRyuta Kamizono2015-10-083-31/+4
|/ | | | | | `pk_and_sequence_for` is implemented for PG and MySQL adapters (not implemented for Sqlite3 adapter). But MySQL adapters are not using `pk_and_sequence_for` already.
* [ci skip] Change 'an URL' to 'a URL' as URL doesn't have a vowel soundtanmay30112015-10-061-1/+1
|
* Implement equality comparison on `AttributeSet` and friendsSean Griffin2015-10-063-11/+33
| | | | | | | Any gems or libraries which do work with serialization or YAML will ultimately need to compare these objects (albeit indirectly) to ensure correctness. These will likely never get used internally (as they're slow), but we should still expose them for others.
* Remove unused block argumentamitkumarsuroliya2015-10-061-1/+1
|
* Merge pull request #21872 from kirs/chore/attributes-cleanupSean Griffin2015-10-051-3/+0
|\ | | | | No need to declare ActiveRecord::Attributes::Type
| * No need to declare ActiveRecord::Attributes::TypeKir Shatrov2015-10-051-3/+0
| |
* | Merge pull request #21033 from dgynn/preloader_build_scope_tuningArthur Nogueira Neves2015-10-041-1/+3
|\ \ | | | | | | Skip _select! call unless needed for preloader
| * | skip _select! call unless :select values are specifiedDave Gynn2015-07-261-1/+3
| | | | | | | | | | | | | | | the default scope will select all fields. removing this improves performance and reduces String creation.
* | | Merge pull request #21005 from jaredbeck/patch-1Arthur Nogueira Neves2015-10-041-1/+3
|\ \ \ | | | | | | | | Docs: Update options for add_reference
| * | | Docs: Update options for add_referenceJared Beck2015-07-231-1/+3
| | | | | | | | | | | | [ci skip]
* | | | [ci skip] Fix ActiveRecord::Relation#update documentationakihiro172015-10-051-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * before ``` people = Person.where(group: 'expert') people.update(group: 'masters') Note: Updating a large number of records will run a UPDATE query for each record, which may cause a performance issue. So if it is not needed to run callbacks for each update, it is preferred to use <tt>update_all</tt> for updating all records using a single query. ``` * after ``` people = Person.where(group: 'expert') people.update(group: 'masters') ``` Note: Updating a large number of records will run an UPDATE query for each record, which may cause a performance issue. So if it is not needed to run callbacks for each update, it is preferred to use <tt>update_all</tt> for updating all records using a single query.
* | | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2015-10-042-1/+3
|\ \ \ \
| * | | | [ci skip] Fix commentyui-knk2015-10-021-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | `alias :migrations_path= :migrations_paths=`, so `migrations_path = some_string` is correct.
| * | | | adding basic change_column and remove_columns in CommandRecorder ↵Gaurav Sharma2015-09-291-0/+2
| | | | | | | | | | | | | | | | | | | | documentations [ci skip]
* | | | | Merge pull request #21860 from vngrs/wrong_usage_of_a_in_docEileen M. Uchitelle2015-10-034-4/+4
|\ \ \ \ \ | | | | | | | | | | | | Wrong usage of 'a' in docs fixed [ci skip]
| * | | | | Wrong usage of 'a' in docs fixed [ci skip]Mehmet Emin İNAÇ2015-10-034-4/+4
| | | | | |
* | | | | | Add Singleton in NullMutationTracker classacapilleri2015-10-032-1/+3
|/ / / / / | | | | | | | | | | | | | | | to reduce allocation of same object
* | | | | Merge pull request #21839 from andyatkinson/remove-unusued-scopesSean Griffin2015-10-023-10/+0
|\ \ \ \ \ | | | | | | | | | | | | Remove unused scopes
| * | | | | Remove unused scopesAndy Atkinson2015-10-013-10/+0
| | | | | |
* | | | | | Build the `AttributeMutationTracker` lazilySean Griffin2015-10-022-14/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For reads, we never need to construct this object. The double `defined?` check is to avoid errors in tests
* | | | | | Merge pull request #21539 from tgxworld/parameters_not_sanitizedSean Griffin2015-10-023-5/+61
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fix AC::Parameters not being sanitized for query methods.
| * | | | | | Fix AC::Parameters not being sanitized for query methods.Guo Xiang Tan2015-10-023-5/+61
| |/ / / / /
* | | | | | 💣Sean Griffin2015-10-021-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I misread this test in https://github.com/rails/rails/commit/1a693c79c32cba070256fdb7bd1990c3d07d554f
* | | | | | Fix test failures on MySQLSean Griffin2015-10-023-3/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There were a few places where I missed a `create` vs `new` before_type_cast check, and the semantics of `reload` became wrong.
* | | | | | Further encapsulate dirty checking on `Attribute`Sean Griffin2015-10-026-51/+99
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We can skip the allocation of a full `AttributeSet` by changing the semantics of how we structure things. Instead of comparing two separate `AttributeSet` objects, and `Attribute` is now a singly linked list of every change that has happened to it. Since the attribute objects are immutable, to apply the changes we simply need to copy the head of the list. It's worth noting that this causes one subtle change in the behavior of AR. When a record is saved successfully, the `before_type_cast` version of everything will be what was sent to the database. I honestly think these semantics make more sense, as we could have just as easily had the DB do `RETURNING *` and updated the record with those if we had things like timestamps implemented at the DB layer. This brings our performance closer to 4.2, but we're still not quite there.
* | | | | Refactor AS::Callbacks halt config and fix the documentationRoque Pinel2015-10-011-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Move from `AS::Callbacks::CallbackChain.halt_and_display_warning_on_return_false` to `AS::Callbacks.halt_and_display_warning_on_return_false` base on [this discussion](https://github.com/rails/rails/pull/21218#discussion_r39354580) Fix the documentation broken by 0a120a818d413c64ff9867125f0b03788fc306f8
* | | | | Merge pull request #20574 from repinel/fix-db-fixtures-loadYves Senn2015-09-308-14/+130
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allow fixtures YAML files to set the model class in the file itself Conflicts: activerecord/CHANGELOG.md
| * | | | | Allow fixtures YAML files to set the model class in the file itselfRoque Pinel2015-09-119-12/+130
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, `set_fixture_class` is only available using the `TestFixtures` concern and it is ignored for `rake db:fixtures:load`. Using the correct model class, it is possible for the fixture load to also load the associations from the YAML files (e.g., `:belongs_to` and `:has_many`).
* | | | | | Improve readability of docs by using code tag [ci skip]Prakash Laxkar2015-09-291-1/+1
| | | | | |
* | | | | | Separate `dup` from `deep_dup` in the attributes hashSean Griffin2015-09-285-6/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I'm looking to move towards a tree-like structure for dirty checking that involves an attribute holding onto the attribute that it was created from. This means that `changed?` can be fully encapsulated on that object. Since the objects are immutable, in `changes_applied`, we can simply perform a shallow dup, instead of a deep one. I'm not sure if that will actually end up in a performance boost, but I'd like to semantically separate these concepts regardless
* | | | | | Inline `Attribute#original_value`Sean Griffin2015-09-281-5/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The external uses of this method have been removed, and I'd like to internally re-use that name, as I'm planning to encapsulate `changed?` into the attribute object itself.
* | | | | | no more class methods for JoinDependency [ci skip]Gaurav Sharma2015-09-291-2/+1
| | | | | | | | | | | | | | | | | | `ActiveRecord::Associations::JoinDependency` now it’s own class` and `ActiveRecord::Associations::ThroughAssociationScope` doesn’t exists
* | | | | | Merge pull request #21793 from amitsuroliya/minor_doc_changesArthur Nogueira Neves2015-09-272-2/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fix minor docs [ci skip]
| * | | | | | Fix minor docs [ci skip] amitkumarsuroliya2015-09-282-2/+2
| | | | | | |
* | | | | | | Merge pull request #21783 from amitsuroliya/record_not_foundRafael Mendonça França2015-09-281-7/+7
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Fix `ActiveRecord::RecordNotFound` error message with custom primary …
| * | | | | | | Fix `ActiveRecord::RecordNotFound` error message with custom primary key [ci ↵amitkumarsuroliya2015-09-261-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | skip]
* | | | | | | | Merge pull request #21780 from yui-knk/fix_ar_sanitize_docRafael Mendonça França2015-09-281-19/+56
|\ \ \ \ \ \ \ \ | |_|/ / / / / / |/| | | | | | | [ci skip] Update docs of `AR::Sanitization`
| * | | | | | | [ci skip] Update docs of `AR::Sanitization`yui-knk2015-09-261-19/+56
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * add % style prepared statement and string examples for `sanitize_sql_for_conditions` * add array and string examples for `sanitize_sql_for_assignment` * add examples for `sanitize_sql_like` * add % style prepared statement example for `sanitize_sql_array` * align spaces of exampl code
* | | | | | | | Fix proper fonts in `change_column_null` method docs. [ci skip]amitkumarsuroliya2015-09-271-2/+2
| | | | | | | |
* | | | | | | | Fix regression in inverse_of on through associationseileencodes2015-09-266-14/+39
| |/ / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `inverse_of` on through associations was accidently removed/caused to stop working in commit f8d2899 which was part of a refactoring on `ThroughReflection`. To fix we moved `inverse_of` and `check_validity_of_inverse!` to the `AbstractReflection` so it's available to the `ThroughReflection` without having to dup any methods. We then need to delegate `inverse_name` method in `ThroughReflection`. `inverse_name` can't be moved to `AbstractReflection` without moving methods that set the instance variable `@automatic_inverse_of`. This adds a test that ensures that `inverse_of` on a `ThroughReflection` returns the correct class name, and the correct record for the inverse relationship. Fixes #21692
* | | | | | | Correcting `ActiveRecord::DangerousAttributeError` error message [ci skip]amitkumarsuroliya2015-09-261-1/+1
|/ / / / / /
* | | | | | Merge pull request #21775 from amitsuroliya/fix_column_alias_forRafael Mendonça França2015-09-261-1/+0
|\ \ \ \ \ \ | | | | | | | | | | | | | | `column_alias_for` method is no more supporting *keys [ci skip]
| * | | | | | `column_alias_for` method is no more supporting *keys [ci skip]amitkumarsuroliya2015-09-261-1/+0
| | | | | | |
* | | | | | | Fix `ActiveRecord::PredicateBuilder` docs. as `register_handler` no more ↵amitkumarsuroliya2015-09-261-1/+1
|/ / / / / / | | | | | | | | | | | | | | | | | | ClassMethod, Since commit https://github.com/rails/rails/commit/a3936bbe21f4bff8247f890cacfd0fc882921003 [ci skip]
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-01 16:26:04 +0000