aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* No need to gsub the stringRafael Mendonça França2014-03-263-3/+3
|
* Don't use send when we own the methodRafael Mendonça França2014-03-262-35/+35
|
* Make method privateRafael Mendonça França2014-03-261-5/+6
|
* Improve the methodRafael Mendonça França2014-03-261-5/+6
| | | | | | * cache `o.name` value * Avoid extra `concat` call * Avoid extra `<<` call
* Remove unneeded comments about feature support on the adaptersRafael Mendonça França2014-03-261-20/+9
| | | | | These comments will likely be outdated with time and doesn't include any information that can't be found in the adapters
* Invert the conditionals to make easier to readRafael Mendonça França2014-03-261-4/+4
| | | | Also improve some of the code conventions
* Fixes bugs for using indexes in CREATE TABLE by adding checks for table ↵Steve Rice2014-03-255-6/+25
| | | | | | | | existence Also: - updates tests by stubbing table_exists? method - adds entry for creating indexes in CREATE TABLE to changelog
* create indexes inline in CREATE TABLE for MySQLCody Cutrer2014-03-255-11/+58
| | | | | | | | This is important, because adding an index on a temporary table after it has been created would commit the transaction Conflicts: activerecord/CHANGELOG.md
* Use rails convetionsRafael Mendonça França2014-03-251-2/+2
|
* Merge pull request #14390 from huoxito/true-touchRafael Mendonça França2014-03-252-0/+13
|\ | | | | | | Still touch associations when theres no timestamp
| * Still touch associations when theres no timestampWashington Luiz2014-03-142-0/+13
| | | | | | | | | | | | | | | | Prior to Rails 4.0.4 when touching a object which doesn't have timestamp attributes (updated_at / updated_on) rails would still touch all associations. After 73ba2c14cd7d7dfb2d132b18c47ade995401736f it updates associations but rollsback because `touch` would return nil since there's no timestamp attribute
* | Revert "Merge pull request #8313 from alan/only_save_changed_has_one_objects"Rafael Mendonça França2014-03-253-22/+8
| | | | | | | | | | | | | | | | | | This reverts commit 6e3ab3e15faf782f6a937ccf5574a4fb63e3e353, reversing changes made to 39e07b64ce3f4bb55e60ba0266e677f8e4f4893a. Conflicts: activerecord/CHANGELOG.md activerecord/test/cases/autosave_association_test.rb
* | clarify CHANGELOG [ci skip].Yves Senn2014-03-251-8/+2
| |
* | Fix Generation of proper migration whenKuldeep Aggarwal2014-03-252-3/+20
| | | | | | | | | | | | | | | | | | | | | | | | ActiveRecord::Base.pluralize_table_names = false. Previously, generation a migration like this: rails g migration add_column_name_to_user name would not generating the correct table name. Fixes #13426.
* | do not rely on method_missing hitting arelAaron Patterson2014-03-241-2/+3
| | | | | | | | arel methods are not supposed to be public API for ActiveRecord
* | use ARel factory methods for building AST nodesAaron Patterson2014-03-242-17/+17
| | | | | | | | This abstracts us from the actual construction of the nodes
* | Clean up tables after each test.Guo Xiang Tan2014-03-222-92/+96
| | | | | | | | | | | | | | Follow-Up to https://github.com/rails/rails/pull/14400 This ensures that all tables are removed after each test and thereby allowing us to run the tests in a random order.
* | Extract with_example_table into helper method.Guo Xiang Tan2014-03-202-6/+13
| | | | | | | | This setups the helper method which other tests can benefit from.
* | Merge pull request #12955 from joshwilliams/masterYves Senn2014-03-203-0/+51
|\ \ | | | | | | Postgres schema: Constrain sequence search classid
| * | Postgres schema: Constrain sequence search classidJosh Williams2014-03-203-0/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The pk_an_sequence_for query previously joined against pg_class's oid for rows in pg_depend, but pg_depend's objid may point to other system tables, such as pg_attrdef. If a row in one of those other tables coincidentally has the same oid as an (unrelated) sequence, that sequence name may be returned instead of the real one. This ensures that only the pg_depend entries pointing to pg_class are considered.
* | | Remove extra indirection for testing exceptions and messagesCarlos Antonio da Silva2014-03-201-28/+12
| | | | | | | | | | | | | | | | | | assert_raise + assert_equal on the returned exception message work just fine, there is no need for extra work, specially like this overly complicated helper.
* | | Improve touch docs with extra attributes passed in [ci skip]Carlos Antonio da Silva2014-03-202-11/+10
| | |
* | | Merge pull request #14423 from yakko/persistence-touches-manyCarlos Antonio da Silva2014-03-203-2/+27
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | ActiveRecord#touch should accept multiple attributes Conflicts: activerecord/CHANGELOG.md
| * | | ActiveRecord#touch should accept multiple attributes #14423Thiago Pinto2014-03-193-2/+27
| |/ /
* / / only dump schema information if migration table exists. Closes #14217Yves Senn2014-03-202-1/+9
|/ /
* | Add counter cache test for class_nameArthur Neves2014-03-171-0/+11
| | | | | | | | Backport test from #14410
* | test should only pass if the pool.size+1 checkout failsAaron Patterson2014-03-171-3/+2
| | | | | | | | | | Previously, any of the connection checkouts could have failed, and this test would pass.
* | use a latch to avoid busy loopsAaron Patterson2014-03-171-3/+4
| |
* | Reap connections based on owning-thread deathMatthew Draper2014-03-187-68/+66
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | .. not a general timeout. Now, if a thread checks out a connection then dies, we can immediately recover that connection and re-use it. This should alleviate the pool exhaustion discussed in #12867. More importantly, it entirely avoids the potential issues of the reaper attempting to check whether connections are still active: as long as the owning thread is alive, the connection is its business alone. As a no-op reap is now trivial (only entails checking a thread status per connection), we can also perform one in-line any time we decide to sleep for a connection.
* | Teach PostgreSQLAdapter#reset! to actually resetMatthew Draper2014-03-182-1/+37
| | | | | | | | It wasn't doing anything beyond clearing the statement cache.
* | `where.not` adds `references` for `includes`.Yves Senn2014-03-174-0/+26
| | | | | | | | Closes #14406.
* | format ActiveRecord CHANGELOG. [ci skip]Yves Senn2014-03-171-8/+9
| |
* | Extend fixture label replacement to allow string interpolationEric Steele2014-03-154-1/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Allows fixtures to use their $LABEL as part of a string instead of limiting use to the entire value. mark: first_name: $LABEL username: $LABEL1973 email: $LABEL@$LABELmail.com users(:mark).first_name # => mark users(:mark).username # => mark1973 users(:mark).email # => mark@markmail.com
* | Merge pull request #14380 from ↵Yves Senn2014-03-1549-61/+51
|\ \ | | | | | | | | | | | | tgxworld/use_teardown_helper_method_in_activerecord Use teardown helper method.
| * | Use teardown helper method.Guo Xiang Tan2014-03-1449-61/+51
| | | | | | | | | | | | | | | | | | | | | | | | Follow-Up to https://github.com/rails/rails/pull/14348 Ensure that SQLCounter.clear_log is called after each test. This is a step to prevent side effects when running tests. This will allow us to run them in random order.
* | | Obey `validate: false` option for habtmCarlos Antonio da Silva2014-03-144-1/+39
| | | | | | | | | | | | Fixes #14383.
* | | Merge pull request #14387 from huoxito/touch-api-docArthur Nogueira Neves2014-03-141-2/+2
|\ \ \ | | | | | | | | Update callbacks executed on AR::Base#touch [skip ci]
| * | | Update callbacks executed on AR::Base#touch [skip ci]Washington Luiz2014-03-141-2/+2
| | |/ | |/| | | | | | | | | | As of https://github.com/rails/rails/pull/12031 after_commit and after_rollback are also executed
* / | Allow custom JDBC urlsschneems2014-03-142-2/+8
|/ / | | | | | | mitigates #14323
* / Avoid duplicated conditionalsCarlos Antonio da Silva2014-03-141-2/+1
|/
* No need to binds be optionalRafael Mendonça França2014-03-131-2/+2
|
* Merge pull request #14372 from arthurnn/fix_query_cache_bindsRafael Mendonça França2014-03-134-12/+24
|\ | | | | Make select_all on query cache accept a Relation without binds.
| * Make select_all on query cache accept a Relation without binds.Arthur Neves2014-03-134-12/+24
| | | | | | | | | | [fixes #14361] [related #13886]
* | Add test for deprecation warning for passing an AR object to `find`.Lauro Caetano2014-03-131-0/+6
| |
* | Test deprecation warning for passing an ActiveRecord object toLauro Caetano2014-03-131-0/+6
|/ | | | `exists?`
* passing an instance of an AR object to `find` is deprecatedAaron Patterson2014-03-135-6/+13
| | | | please pass the id of the AR object by calling `.id` on the model first.
* passing an ActiveRecord object to `exists?` is deprecated.Aaron Patterson2014-03-135-4/+14
| | | | | Pass the id of the object to the method by calling `.id` on the AR object.
* make tests pass on Ruby 2.2Aaron Patterson2014-03-131-4/+4
| | | | | | Apparently we've been using a buggy feature for the past 6 years: https://bugs.ruby-lang.org/issues/9593
* Use Sqlite3 adapter in examplesJulian Simioni2014-03-121-2/+2
| | | | | | | | | | | | | | | | Two bits of example code use sqlite as an adapter, which doesn't exist. Using the code verbatim will raise a LoadError exception: ActiveRecord::Base.establish_connection( "adapter" => "sqlite", "database" => "db.sqlite" ) # => LoadError: Could not load 'active_record/connection_adapters/sqlite_adapter'... Considering this is code a lot of people new to Rails might be running, it's especially confusing. Closes #14367 [ci skip]
* Merge pull request #14364 from why-el/better-docs-for-update-attributeArthur Nogueira Neves2014-03-121-0/+2
|\ | | | | Enhance docs for update_attribute [skip ci]
generated by cgit v1.2.3 (git 2.25.1) at 2025-03-25 03:45:06 +0000