Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Show the records in Relation#inspect | Jon Leighton | 2012-07-06 | 3 | -6/+17 |
| | | | | | | | | | | | | | | | | | The reason for removing the previous implementation of `#inspect` was that it hid from you that you were dealing with a `Relation` rather than an `Array`. But it is still useful to be able to see the records, particularly if you're writing something like the following in tests: assert_equal [foo], Post.where(:bar) If the assertion fails, you want to see what records were actually loaded. So this implementation makes it clear that you've got a `Relation`, but also shows your records. | ||||
* | Merge pull request #6927 from parndt/patch-3 | Carlos Antonio da Silva | 2012-07-05 | 2 | -3/+3 |
|\ | | | | | Make ArgumentError message more consistent in nested attributes | ||||
| * | Made ArgumentError messages consistent. | Philip Arndt | 2012-07-06 | 2 | -3/+3 |
| | | |||||
* | | Add documentation for inheritance_column method | Vitor Balocco | 2012-07-05 | 1 | -1/+3 |
| | | |||||
* | | fix quoting for ActiveSupport::Duration instances | Francesco Rodriguez | 2012-07-04 | 3 | -1/+15 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch fixes quoting for ActiveSupport::Duration instances: # before >> ActiveRecord::Base.connection.quote 30.minutes => "'--- 1800\n...\n'" # after >> ActiveRecord::Base.connection.quote 30.minutes => "1800" Also, adds a test for type casting ActiveSupport::Duration instances. Related to #1119. | ||||
* | | remove duplicate requires of mocha. | Aaron Patterson | 2012-07-03 | 1 | -1/+0 |
| | | | | | | | | | | Mocha is already required by AS::TestCase, so remove the duplicate requires. | ||||
* | | Don't need to use delete in the options hash | Rafael Mendonça França | 2012-07-03 | 2 | -3/+2 |
| | | |||||
* | | Add changelog entry for references statements | Aleksey Magusev | 2012-07-03 | 1 | -0/+13 |
| | | |||||
* | | Refactor references schema definitions | Aleksey Magusev | 2012-07-03 | 2 | -34/+24 |
| | | |||||
* | | Make references statements reversible | Aleksey Magusev | 2012-07-03 | 2 | -4/+40 |
| | | |||||
* | | Add references schema statements | Aleksey Magusev | 2012-07-03 | 3 | -1/+149 |
| | | | | | | | | | | | | | | | | | | | | Examples: add_reference :products, :supplier, polymorphic: true, index: true remove_reference :products, :user `add_belongs_to` and `remove_belongs_to` are acceptable. | ||||
* | | Don't mark the store as changed if an attribute isn't changed. | kennyj | 2012-07-03 | 2 | -2/+10 |
| | | |||||
* | | Update 4.0 Release Notes with changelogs [ci skip] | Carlos Antonio da Silva | 2012-07-02 | 1 | -3/+3 |
|/ | | | | | | | Also fix some wrong formatting. Related discussion: https://github.com/rails/rails/commit/ab72040b74f742b6676b2d2a5dd029bfdca25a7a#commitcomment-1525256 | ||||
* | Use strings for the table names | Rafael Mendonça França | 2012-07-01 | 1 | -1/+1 |
| | | | | connection.tables returns an array of strings | ||||
* | Unify the collation API for the database adpters | Rafael Mendonça França | 2012-07-01 | 6 | -15/+15 |
| | |||||
* | Merge pull request #6914 from lexmag/migration_tests | Rafael Mendonça França | 2012-07-01 | 2 | -37/+11 |
|\ | | | | | Refactor migration test_helper | ||||
| * | Refactor migration test_helper | Aleksey Magusev | 2012-07-01 | 2 | -37/+11 |
| | | | | | | | | and create_join_table_test | ||||
* | | Update AR and AP changelogs [ci skip] | Carlos Antonio da Silva | 2012-06-30 | 1 | -1/+13 |
| | | |||||
* | | Merge pull request #6913 from lexmag/column_exists_options | Carlos Antonio da Silva | 2012-06-30 | 2 | -10/+18 |
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | Add :default and :null options to column_exists? method Examples: column_exists?(:testings, :taggable_id, :integer, null: false) column_exists?(:testings, :taggable_type, :string, default: 'Photo') | ||||
| * | | Add more options to column_exists? method | Aleksey Magusev | 2012-06-30 | 2 | -10/+18 |
| |/ | | | | | | | Also fix failures in check options for nil | ||||
* | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-06-30 | 2 | -5/+15 |
|\ \ | | | | | | | | | | | | | Conflicts: activemodel/lib/active_model/errors.rb | ||||
| * | | update AR::FinderMethods#exists?(false) example [ci skip] | Francesco Rodriguez | 2012-06-28 | 1 | -5/+7 |
| | | | |||||
| * | | Mention effect of accepts_nested_attributes_for on association autosave ↵ | Chris Gunther | 2012-06-27 | 1 | -0/+8 |
| | | | | | | | | | | | | option [ci skip] | ||||
* | | | Fix collation database task to use begin..rescue..end | Carlos Antonio da Silva | 2012-06-30 | 1 | -4/+6 |
| | | | |||||
* | | | Extract collation tasks to database tasks. | kennyj | 2012-07-01 | 8 | -8/+88 |
| | | | |||||
* | | | Remove ActiveRelation#inspect | Brian Cardarella | 2012-06-29 | 3 | -5/+5 |
| | | | |||||
* | | | Remove unused responsibilities and add a few load definitions to engines | José Valim | 2012-06-29 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | Since plugins were removed, we can clean up a few methods in engines. We also use this opportunity to move `load_console`, `load_tasks` and `load_runner` to Rails::Engine. This means that, if someone wants to improve script/rails for engines to support console or runner commands, part of the work is already done. | ||||
* | | | Added an entry about fda24312d3 in the CHANGELOG. | kennyj | 2012-06-29 | 1 | -0/+15 |
| | | | |||||
* | | | Require URI | Chris Bandy | 2012-06-28 | 1 | -0/+2 |
| | | | |||||
* | | | Support collate and ctype on the PostgreSQL. | kennyj | 2012-06-29 | 4 | -1/+40 |
| | | | |||||
* | | | fixing typo in from documentation | Subba Rao Pasupuleti | 2012-06-28 | 1 | -2/+2 |
| | | | |||||
* | | | Remove some aggregation tests related to composed_of | Carlos Antonio da Silva | 2012-06-28 | 2 | -21/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since composed_of was removed in 051747449e7afc817c599e4135bc629d4de064eb, these tests were working "by mistake", due to the matching "address" string in the error message, but with a different error message than the expected multiparameter assignment error. Since "address" is not an attribute from Customer anymore, the error was "undefined method klass for nil", where nil was supposed to be the column object. | ||||
* | | | Move newly added multiparameter tests to base_test file | Carlos Antonio da Silva | 2012-06-28 | 2 | -35/+36 |
| | | | | | | | | | | | | | | | All other multiparameter assignment tests are in the same file, so it makes sense to have all of them here. | ||||
* | | | Skip test_setting_time_attribute because Oracle database | Yasuo Honda | 2012-06-28 | 1 | -0/+2 |
| | | | | | | | | | | | | does not have TIME data type. | ||||
* | | | fix: limit of enum columns of mysql | Yamada Masaki | 2012-06-28 | 5 | -0/+41 |
| | | | |||||
* | | | Fixes #6825, adds tests covering cases and error possibilities, also changes ↵ | Mauricio Linhares | 2012-06-27 | 3 | -16/+58 |
| |/ |/| | | | | | SQLite3 driver to correctly generate a time column instead of datetime | ||||
* | | Merge pull request #6880 from kennyj/fix_20120628 | Carlos Antonio da Silva | 2012-06-27 | 1 | -1/+1 |
|\ \ | | | | | | | Fix wrong testcase for db:test:prepare, and wrong environment in AR rake task. | ||||
| * | | Fix wrong environment. env should be RAILS_ENV or test. | kennyj | 2012-06-28 | 1 | -1/+1 |
| | | | |||||
* | | | Merge pull request #6856 from lexmag/polymorphic_generators | Carlos Antonio da Silva | 2012-06-27 | 1 | -1/+1 |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add polymorphic option to model generator For instance, $ rails g model Product supplier:references{polymorphic} generate model with `belongs_to :supplier, polymorphic: true` association and appropriate migration. | ||||
| * | | | Add polymorphic option to model generator | Aleksey Magusev | 2012-06-27 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For instance, $ rails g model Product supplier:references{polymorphic} generate model with `belongs_to :supplier, polymorphic: true` association and appropriate migration. Also fix model_generator_test.rb#L196 and #L201 | ||||
* | | | | Address test_basic_model test error with Oracle enhanced adapter | Yasuo Honda | 2012-06-27 | 1 | -1/+1 |
| |/ / |/| | | | | | | | | which ids start from 1000 as a default. | ||||
* | | | Setup each test with default ActiveRecord timezone settings to ensure each ↵ | Erich Menge | 2012-06-26 | 1 | -20/+8 |
| | | | | | | | | | | | | | | | | | | test starts with a clean slate. Fixes #6867. | ||||
* | | | Use args.flatten! in query methods when applicable | Carlos Antonio da Silva | 2012-06-25 | 1 | -7/+12 |
| | | | | | | | | | | | | | | | Try to use more destructive methods on *args when applicable, to avoid creating new objects. | ||||
* | | | Merge pull request #6544 from flexoid/issue-6431 | Piotr Sarnacki | 2012-06-25 | 3 | -6/+14 |
|\ \ \ | | | | | | | | | exists?(false) returns false | ||||
| * | | | exists?(false) returns false | Egor Lynko | 2012-06-25 | 3 | -6/+14 |
| |/ / | | | | | | | | | | `FinderMethods#exists?` finder method now returns *false* with the *false* argument | ||||
* | | | Ensure Arel columns are typecasted properly when grouping with calculation | Carlos Antonio da Silva | 2012-06-25 | 2 | -9/+13 |
| | | | | | | | | | | | | Fix build issue with postgresql. | ||||
* | | | Move to db:structure namespace, because these methods are global. | kennyj | 2012-06-26 | 1 | -8/+9 |
| | | | |||||
* | | | Remove session_table_name method because this is global and used only once. | kennyj | 2012-06-26 | 1 | -5/+1 |
| | | | |||||
* | | | Add a description about ENV["SCOPE"] | kennyj | 2012-06-26 | 1 | -1/+1 |
| | | | |||||
* | | | Change the behavior of db:test:prepare task when schema_format is sql for ↵ | kennyj | 2012-06-26 | 1 | -1/+1 |
| | | | | | | | | | | | | consistency. |