Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | DRY up the code which instantiates the association proxy | Jon Leighton | 2011-01-11 | 5 | -48/+60 | |
| | | ||||||
* | | find_target can be inherited | Jon Leighton | 2011-01-11 | 1 | -4/+0 | |
| | | ||||||
* | | Document the recent changes to association assignment | Jon Leighton | 2011-01-11 | 1 | -4/+9 | |
| | | ||||||
* | | Raise ActiveRecord::RecordNotSaved if an AssociationCollection fails to be ↵ | Jon Leighton | 2011-01-11 | 2 | -1/+18 | |
| | | | | | | | | replaced | |||||
* | | When assigning a has_one, if anything fails, the assignment should be rolled ↵ | Jon Leighton | 2011-01-11 | 2 | -21/+28 | |
| | | | | | | | | back entirely | |||||
* | | In a number of places in the tests, we only need to turn off transactional ↵ | Jon Leighton | 2011-01-11 | 9 | -43/+51 | |
| | | | | | | | | fixtures when the DB does not support savepoints. This speeds the test run up by about 8-9% on my computer, when running rake test_sqlite3_mem :) | |||||
* | | SQLite3 has supported savepoints since version 3.6.8, we should use this! | Jon Leighton | 2011-01-11 | 2 | -2/+18 | |
| | | ||||||
* | | When assigning a has_one, if the new record fails to save, raise an error | Jon Leighton | 2011-01-11 | 3 | -19/+19 | |
| | | ||||||
* | | When assigning a has_one, if the existing record fails to be removed from ↵ | Jon Leighton | 2011-01-11 | 2 | -5/+23 | |
| | | | | | | | | the association, raise an error | |||||
* | | Have a separate test connection directory for sqlite3 in-memory so that the ↵ | Jon Leighton | 2011-01-11 | 2 | -1/+1 | |
| | | | | | | | | tests can be run without having to specifically rename the connection file (which then causes git to pick up the changes) | |||||
* | | Enable the sqlite3 in-memory test connection to work | Jon Leighton | 2011-01-11 | 5 | -17/+25 | |
| | | ||||||
* | | has_one should always remove the old record (properly), even if not saving ↵ | Jon Leighton | 2011-01-11 | 4 | -11/+31 | |
| | | | | | | | | the new record, so we don't get the database into a pickle | |||||
* | | Return value is irrelevant here as the RHS of the assignment is always ↵ | Jon Leighton | 2011-01-11 | 1 | -1/+0 | |
| | | | | | | | | returned by methods ending in '=' | |||||
* | | Remove incorrect documentation about build_assoc on has_one. This is proven, ↵ | Jon Leighton | 2011-01-11 | 1 | -2/+1 | |
| | | | | | | | | for example, by test_successful_build_association in has_one_associations_test.rb | |||||
* | | For a singular association, it should be build_association, rather than ↵ | Jon Leighton | 2011-01-11 | 1 | -1/+1 | |
| | | | | | | | | association.build (as association may be nil) | |||||
* | | Correctly indent the bullet points under 'One-to-one associations', so that ↵ | Jon Leighton | 2011-01-11 | 1 | -10/+10 | |
| | | | | | | | | the lines are not broken in the generated rdoc html | |||||
* | | avoid splatting arrays by using concat | Aaron Patterson | 2011-01-11 | 1 | -3/+3 | |
| | | ||||||
* | | Fix polymorphic belongs_to associationproxy raising errors when loading target. | Ernie Miller | 2011-01-11 | 3 | -0/+16 | |
| | | ||||||
* | | only use one array when collecting split up queries | Aaron Patterson | 2011-01-10 | 1 | -1/+1 | |
| | | ||||||
* | | Always return decimal average of integer fields | Raimonds Simanovskis | 2011-01-10 | 2 | -9/+10 | |
| | | | | | | | | In previous version if database adapter (e.g. SQLite and Oracle) returned non-String calculated values then type_cast_using_column converted decimal average value of intefer field to integer value. Now operation parameter is always checked to decide which conversion of calculated value should be done. | |||||
* | | use SQLite3::VERSION rather than the deprecated class | Aaron Patterson | 2011-01-10 | 1 | -1/+1 | |
| | | ||||||
* | | Aligning master changelog w/ 3-0-stable | Kevin Moore | 2011-01-09 | 1 | -1/+9 | |
| | | ||||||
* | | Adding postgresql template option when executing db:test:clone_structure | Katrina Owen | 2011-01-09 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | Specify the template to use in config/database.yml, e.g. test: adapter: postgresql template: template_postgis If no template is specified, postgresql defaults to template1 | |||||
* | | remove unused string substitution | Aaron Patterson | 2011-01-08 | 1 | -6/+1 | |
| | | ||||||
* | | use select_all because not all database adapters support bind values | Aaron Patterson | 2011-01-08 | 1 | -1/+1 | |
| | | ||||||
* | | join the cult of cargo. reduce the number of NoMethodErrors in the system | Aaron Patterson | 2011-01-07 | 1 | -1/+1 | |
| | | ||||||
* | | stop creating intermediate AR objects, just construct AR objects from a list ↵ | Aaron Patterson | 2011-01-07 | 1 | -1/+2 | |
| | | | | | | | | of hashes | |||||
* | | no need for to_sym | Aaron Patterson | 2011-01-07 | 1 | -1/+1 | |
| | | ||||||
* | | String#insert() mutates the string, so no need for lasgn | Aaron Patterson | 2011-01-07 | 1 | -1/+1 | |
| | | ||||||
* | | fewer funcalls to the cached attributes variable | Aaron Patterson | 2011-01-07 | 1 | -1/+1 | |
| | | ||||||
* | | Add test for e0e3adf | Jeremy Kemper | 2011-01-07 | 1 | -0/+6 | |
| | | ||||||
* | | Refactor HasOneAssociation#replace | Jon Leighton | 2011-01-07 | 1 | -26/+22 | |
| | | ||||||
* | | Don't not remove double negatives | Jon Leighton | 2011-01-07 | 2 | -5/+5 | |
| | | ||||||
* | | Clean up create, create! and build in HasOneAssociation | Jon Leighton | 2011-01-07 | 1 | -14/+8 | |
| | | ||||||
* | | merge_with_conditions is not necessary because the conditions will already ↵ | Jon Leighton | 2011-01-07 | 1 | -9/+0 | |
| | | | | | | | | be in the scope_for_create hash in the scope | |||||
* | | Not really worth having the HasAssociation module for just a single method | Jon Leighton | 2011-01-07 | 5 | -21/+9 | |
| | | ||||||
* | | Construct an actual ActiveRecord::Relation object for the association scope, ↵ | Jon Leighton | 2011-01-07 | 12 | -125/+76 | |
| | | | | | | | | rather than a hash which is passed to apply_finder_options. This allows more flexibility in how the scope is created, for example because scope.where(a, b) and scope.where(a).where(b) mean different things. | |||||
* | | Use encode_with for marshalling | Jon Leighton | 2011-01-07 | 2 | -0/+27 | |
| | | ||||||
* | | send() will raise an ArgumentError, so we should leverage ruby | Aaron Patterson | 2011-01-07 | 2 | -17/+7 | |
| | | ||||||
* | | no need for parens | Aaron Patterson | 2011-01-07 | 1 | -1/+1 | |
| | | ||||||
* | | use a hash for caching aggregations rather than ivars | Aaron Patterson | 2011-01-07 | 2 | -14/+9 | |
| | | ||||||
* | | method is never called with arguments | Aaron Patterson | 2011-01-07 | 1 | -4/+2 | |
| | | ||||||
* | | only rescue from Mysql::Error exceptions [#6236 state:resolved] | Aaron Patterson | 2011-01-07 | 1 | -4/+9 | |
| | | ||||||
* | | just use a hash for doing association caching | Aaron Patterson | 2011-01-07 | 6 | -15/+17 | |
| | | ||||||
* | | no need for self | Aaron Patterson | 2011-01-06 | 1 | -1/+1 | |
| | | ||||||
* | | adding an `encode_with` method for Psych dump/load methods | Aaron Patterson | 2011-01-05 | 2 | -0/+23 | |
| | | ||||||
* | | make sure new objects can round trip | Aaron Patterson | 2011-01-05 | 1 | -0/+6 | |
| | | ||||||
* | | make sure that Psych can roundtrip an AR object | Aaron Patterson | 2011-01-05 | 1 | -0/+13 | |
| | | ||||||
* | | AR internals expect a normal hash, otherwise there are serialization ↵ | Aaron Patterson | 2011-01-05 | 1 | -1/+1 | |
| | | | | | | | | incompatibilities | |||||
* | | no need to specify self | Aaron Patterson | 2011-01-05 | 1 | -1/+1 | |
| | |