aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* fixture setup does not rely on `AR::Base.configurations`.Yves Senn2013-06-153-4/+21
| | | | | | | | As you can also configure your database connection using `ENV["DATABASE_URL"]`, the fixture setup can't reply on the `.configurations` Hash. As the fixtures are only loaded when ActiveRecord is actually used (`rails/test_help.rb`) it should be safe to drop the check for an existing configuration.
* regression test + mysql2 adapter raises correct error if conn is closed.Yves Senn2013-06-153-3/+36
|
* cleanup, remove trailing whitespace from AR changelogYves Senn2013-06-151-4/+4
|
* Merge pull request #10953 from acapilleri/fix_typosYves Senn2013-06-151-1/+1
|\ | | | | fix typos
| * fix typosAngelo Capilleri2013-06-151-1/+1
| |
* | Merge pull request #10898 from dmitry/find_first_refactor_duplicationRafael Mendonça França2013-06-141-11/+10
|\ \ | | | | | | Refactored ActiveRecord `first` method to get rid of duplication.
| * | rename method `find_first_records` to `find_first_with_limit`Dmitry Polushkin2013-06-101-3/+3
| | |
| * | Refactored ActiveRecord `first` method to get rid of duplication.Dmitry Polushkin2013-06-091-11/+10
| | |
* | | Properly namespace DatabaseTasksPiotr Sarnacki2013-06-141-1/+1
| | |
* | | Use DatabaseTasks.env instead of Rails.env in databases.rakePiotr Sarnacki2013-06-141-1/+1
| | |
* | | quoted table name is also cachedAaron Patterson2013-06-131-1/+1
| | |
* | | table name is cached on the class, so stop caching twiceAaron Patterson2013-06-131-1/+1
| | |
* | | calculate types on constructionAaron Patterson2013-06-131-8/+4
| | |
* | | only cache the primary key column in one placeAaron Patterson2013-06-131-1/+1
| | |
* | | these methods are never called, so remove themAaron Patterson2013-06-131-8/+0
| | |
* | | This test does not test anything that happens in the real world. If youAaron Patterson2013-06-132-27/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | recreate the models without mucking with internal caches of the relation objects, then the test fails. For example: class Man < ActiveRecord::Base has_many :interests end class Interest < ActiveRecord::Base belongs_to :man end Then do this test: def test_validate_presence_of_parent_fails_without_inverse_of repair_validations(Interest) do Interest.validates_presence_of(:man) assert_no_difference ['Man.count', 'Interest.count'] do man = Man.create(:name => 'John', :interests_attributes => [{:topic=>'Cars'}, {:topic=>'Sports'}]) assert_not_predicate man.errors[:"interests.man"], :empty? end end end The test will fail. This is a bad test, so I am removing it.
* | | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-06-146-31/+96
|\ \ \ | | | | | | | | | | | | | | | | Conflicts: guides/source/upgrading_ruby_on_rails.md
| * | | copy edits [ci skip]Vijay Dev2013-06-141-19/+15
| | | |
| * | | doc: renaming table name to follow the file's standardsThiago Pinto2013-06-081-2/+2
| | | |
| * | | instructions for variations and alternatives for ActiveRecord#findThiago Pinto2013-06-081-1/+35
| | | |
| * | | explaining ActiveRecord#first in rails 3 and 4Thiago Pinto2013-06-081-0/+13
| | | |
| * | | lists the options for find_each and find_in_batchesThiago Pinto2013-06-071-17/+37
| | | |
| * | | using Model.all.find_each in rails 3 raises an error and should not be ↵Thiago Pinto2013-06-071-2/+2
| | | | | | | | | | | | | | | | recommended
| * | | Consistent use of one space only after punctuationSunny Ripert2013-05-281-2/+2
| | | |
| * | | minor comments cleanupNeeraj Singh2013-05-271-3/+4
| | | |
| * | | enhanced comments for foreign_key_present? methodNeeraj Singh2013-05-231-3/+4
| | | |
| * | | update_counters accepts a hash, not an array of hashesMichael Kozono2013-05-211-1/+1
| | | |
* | | | oops. step away from the keyboard aaron. :cry:Aaron Patterson2013-06-131-1/+1
| | | |
* | | | fix caching of automatic inverse of. :bomb:Aaron Patterson2013-06-131-1/+3
| | | |
* | | | let the object stay in charge of internal cache invalidationAaron Patterson2013-06-132-13/+6
| | | |
* | | | refute the predicate for better failure messagesAaron Patterson2013-06-131-1/+1
| | | |
* | | | reduce automatic_inverse_of caching logicAaron Patterson2013-06-131-30/+16
| | | |
* | | | active_record should always be set. Do or do not, there is no tryAaron Patterson2013-06-131-1/+1
| | | |
* | | | push ambiguous reflection warning down to reflection name calculationAaron Patterson2013-06-131-23/+28
| | | |
* | | | clean up ivar assignmentAaron Patterson2013-06-131-3/+2
| | | |
* | | | Ambiguous reflections are on :through relationships are no longer supported.Aaron Patterson2013-06-134-3/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For example, you need to change this: class Author < ActiveRecord::Base has_many :posts has_many :taggings, :through => :posts end class Post < ActiveRecord::Base has_one :tagging has_many :taggings end class Tagging < ActiveRecord::Base end To this: class Author < ActiveRecord::Base has_many :posts has_many :taggings, :through => :posts, :source => :tagging end class Post < ActiveRecord::Base has_one :tagging has_many :taggings end class Tagging < ActiveRecord::Base end
* | | | Merge pull request #10425 from ↵Rafael Mendonça França2013-06-134-38/+47
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | ranjaykrishna/push_add_column_options_to_schema_creation Push add column options to schema creation
| * | | | Moving add_column_options! up to SchemaCreationjeran2013-06-124-38/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | removed two instances of add_column_options! from abstract_mysql_adapter reworked rename_column_sql to remove add_column_options from schema_statements changed to use new hash syntax.
* | | | | sometimes singularize does not work, so we get a list of two strings. just ↵Aaron Patterson2013-06-121-1/+1
| | | | | | | | | | | | | | | | | | | | uniq them
* | | | | no need to cache hash lookupsAaron Patterson2013-06-121-1/+1
| | | | |
* | | | | split aggregates from association reflections to avoid is_a checks laterAaron Patterson2013-06-121-5/+11
| | | | |
* | | | | remove unnecessary is_a checkAaron Patterson2013-06-121-2/+1
| | | | |
* | | | | we should apply the default scope before queryingAaron Patterson2013-06-121-1/+2
| | | | |
* | | | | Fix typos in AR changelog [ci skip]Prathamesh Sonpatki2013-06-121-2/+2
| | | | |
* | | | | bind values should not be merged between scopesAaron Patterson2013-06-111-1/+1
| | | | |
* | | | | stop adding a new method for touch callbacksAaron Patterson2013-06-111-29/+21
| | | | |
* | | | | push the touch method outside the evalAaron Patterson2013-06-111-13/+34
| | | | |
* | | | | remove unused variableAaron Patterson2013-06-111-1/+0
| | | | |
* | | | | check whether the association is constructible rather than checking constantsAaron Patterson2013-06-111-3/+3
| | | | |
* | | | | use attribute methods for finding key values rather than generating method namesAaron Patterson2013-06-111-3/+3
| | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-08-27 15:23:04 +0000