Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | fixture setup does not rely on `AR::Base.configurations`. | Yves Senn | 2013-06-15 | 3 | -4/+21 |
| | | | | | | | | As you can also configure your database connection using `ENV["DATABASE_URL"]`, the fixture setup can't reply on the `.configurations` Hash. As the fixtures are only loaded when ActiveRecord is actually used (`rails/test_help.rb`) it should be safe to drop the check for an existing configuration. | ||||
* | regression test + mysql2 adapter raises correct error if conn is closed. | Yves Senn | 2013-06-15 | 3 | -3/+36 |
| | |||||
* | cleanup, remove trailing whitespace from AR changelog | Yves Senn | 2013-06-15 | 1 | -4/+4 |
| | |||||
* | Merge pull request #10953 from acapilleri/fix_typos | Yves Senn | 2013-06-15 | 1 | -1/+1 |
|\ | | | | | fix typos | ||||
| * | fix typos | Angelo Capilleri | 2013-06-15 | 1 | -1/+1 |
| | | |||||
* | | Merge pull request #10898 from dmitry/find_first_refactor_duplication | Rafael Mendonça França | 2013-06-14 | 1 | -11/+10 |
|\ \ | | | | | | | Refactored ActiveRecord `first` method to get rid of duplication. | ||||
| * | | rename method `find_first_records` to `find_first_with_limit` | Dmitry Polushkin | 2013-06-10 | 1 | -3/+3 |
| | | | |||||
| * | | Refactored ActiveRecord `first` method to get rid of duplication. | Dmitry Polushkin | 2013-06-09 | 1 | -11/+10 |
| | | | |||||
* | | | Properly namespace DatabaseTasks | Piotr Sarnacki | 2013-06-14 | 1 | -1/+1 |
| | | | |||||
* | | | Use DatabaseTasks.env instead of Rails.env in databases.rake | Piotr Sarnacki | 2013-06-14 | 1 | -1/+1 |
| | | | |||||
* | | | quoted table name is also cached | Aaron Patterson | 2013-06-13 | 1 | -1/+1 |
| | | | |||||
* | | | table name is cached on the class, so stop caching twice | Aaron Patterson | 2013-06-13 | 1 | -1/+1 |
| | | | |||||
* | | | calculate types on construction | Aaron Patterson | 2013-06-13 | 1 | -8/+4 |
| | | | |||||
* | | | only cache the primary key column in one place | Aaron Patterson | 2013-06-13 | 1 | -1/+1 |
| | | | |||||
* | | | these methods are never called, so remove them | Aaron Patterson | 2013-06-13 | 1 | -8/+0 |
| | | | |||||
* | | | This test does not test anything that happens in the real world. If you | Aaron Patterson | 2013-06-13 | 2 | -27/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | recreate the models without mucking with internal caches of the relation objects, then the test fails. For example: class Man < ActiveRecord::Base has_many :interests end class Interest < ActiveRecord::Base belongs_to :man end Then do this test: def test_validate_presence_of_parent_fails_without_inverse_of repair_validations(Interest) do Interest.validates_presence_of(:man) assert_no_difference ['Man.count', 'Interest.count'] do man = Man.create(:name => 'John', :interests_attributes => [{:topic=>'Cars'}, {:topic=>'Sports'}]) assert_not_predicate man.errors[:"interests.man"], :empty? end end end The test will fail. This is a bad test, so I am removing it. | ||||
* | | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-06-14 | 6 | -31/+96 |
|\ \ \ | | | | | | | | | | | | | | | | | Conflicts: guides/source/upgrading_ruby_on_rails.md | ||||
| * | | | copy edits [ci skip] | Vijay Dev | 2013-06-14 | 1 | -19/+15 |
| | | | | |||||
| * | | | doc: renaming table name to follow the file's standards | Thiago Pinto | 2013-06-08 | 1 | -2/+2 |
| | | | | |||||
| * | | | instructions for variations and alternatives for ActiveRecord#find | Thiago Pinto | 2013-06-08 | 1 | -1/+35 |
| | | | | |||||
| * | | | explaining ActiveRecord#first in rails 3 and 4 | Thiago Pinto | 2013-06-08 | 1 | -0/+13 |
| | | | | |||||
| * | | | lists the options for find_each and find_in_batches | Thiago Pinto | 2013-06-07 | 1 | -17/+37 |
| | | | | |||||
| * | | | using Model.all.find_each in rails 3 raises an error and should not be ↵ | Thiago Pinto | 2013-06-07 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | recommended | ||||
| * | | | Consistent use of one space only after punctuation | Sunny Ripert | 2013-05-28 | 1 | -2/+2 |
| | | | | |||||
| * | | | minor comments cleanup | Neeraj Singh | 2013-05-27 | 1 | -3/+4 |
| | | | | |||||
| * | | | enhanced comments for foreign_key_present? method | Neeraj Singh | 2013-05-23 | 1 | -3/+4 |
| | | | | |||||
| * | | | update_counters accepts a hash, not an array of hashes | Michael Kozono | 2013-05-21 | 1 | -1/+1 |
| | | | | |||||
* | | | | oops. step away from the keyboard aaron. :cry: | Aaron Patterson | 2013-06-13 | 1 | -1/+1 |
| | | | | |||||
* | | | | fix caching of automatic inverse of. :bomb: | Aaron Patterson | 2013-06-13 | 1 | -1/+3 |
| | | | | |||||
* | | | | let the object stay in charge of internal cache invalidation | Aaron Patterson | 2013-06-13 | 2 | -13/+6 |
| | | | | |||||
* | | | | refute the predicate for better failure messages | Aaron Patterson | 2013-06-13 | 1 | -1/+1 |
| | | | | |||||
* | | | | reduce automatic_inverse_of caching logic | Aaron Patterson | 2013-06-13 | 1 | -30/+16 |
| | | | | |||||
* | | | | active_record should always be set. Do or do not, there is no try | Aaron Patterson | 2013-06-13 | 1 | -1/+1 |
| | | | | |||||
* | | | | push ambiguous reflection warning down to reflection name calculation | Aaron Patterson | 2013-06-13 | 1 | -23/+28 |
| | | | | |||||
* | | | | clean up ivar assignment | Aaron Patterson | 2013-06-13 | 1 | -3/+2 |
| | | | | |||||
* | | | | Ambiguous reflections are on :through relationships are no longer supported. | Aaron Patterson | 2013-06-13 | 4 | -3/+60 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For example, you need to change this: class Author < ActiveRecord::Base has_many :posts has_many :taggings, :through => :posts end class Post < ActiveRecord::Base has_one :tagging has_many :taggings end class Tagging < ActiveRecord::Base end To this: class Author < ActiveRecord::Base has_many :posts has_many :taggings, :through => :posts, :source => :tagging end class Post < ActiveRecord::Base has_one :tagging has_many :taggings end class Tagging < ActiveRecord::Base end | ||||
* | | | | Merge pull request #10425 from ↵ | Rafael Mendonça França | 2013-06-13 | 4 | -38/+47 |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | ranjaykrishna/push_add_column_options_to_schema_creation Push add column options to schema creation | ||||
| * | | | | Moving add_column_options! up to SchemaCreation | jeran | 2013-06-12 | 4 | -38/+47 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | removed two instances of add_column_options! from abstract_mysql_adapter reworked rename_column_sql to remove add_column_options from schema_statements changed to use new hash syntax. | ||||
* | | | | | sometimes singularize does not work, so we get a list of two strings. just ↵ | Aaron Patterson | 2013-06-12 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | uniq them | ||||
* | | | | | no need to cache hash lookups | Aaron Patterson | 2013-06-12 | 1 | -1/+1 |
| | | | | | |||||
* | | | | | split aggregates from association reflections to avoid is_a checks later | Aaron Patterson | 2013-06-12 | 1 | -5/+11 |
| | | | | | |||||
* | | | | | remove unnecessary is_a check | Aaron Patterson | 2013-06-12 | 1 | -2/+1 |
| | | | | | |||||
* | | | | | we should apply the default scope before querying | Aaron Patterson | 2013-06-12 | 1 | -1/+2 |
| | | | | | |||||
* | | | | | Fix typos in AR changelog [ci skip] | Prathamesh Sonpatki | 2013-06-12 | 1 | -2/+2 |
| | | | | | |||||
* | | | | | bind values should not be merged between scopes | Aaron Patterson | 2013-06-11 | 1 | -1/+1 |
| | | | | | |||||
* | | | | | stop adding a new method for touch callbacks | Aaron Patterson | 2013-06-11 | 1 | -29/+21 |
| | | | | | |||||
* | | | | | push the touch method outside the eval | Aaron Patterson | 2013-06-11 | 1 | -13/+34 |
| | | | | | |||||
* | | | | | remove unused variable | Aaron Patterson | 2013-06-11 | 1 | -1/+0 |
| | | | | | |||||
* | | | | | check whether the association is constructible rather than checking constants | Aaron Patterson | 2013-06-11 | 1 | -3/+3 |
| | | | | | |||||
* | | | | | use attribute methods for finding key values rather than generating method names | Aaron Patterson | 2013-06-11 | 1 | -3/+3 |
| | | | | |