Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Forgot to revert tests from that last commit | Joshua Peek | 2009-12-12 | 1 | -8/+0 |
| | |||||
* | Revert "Fix instance_eval calls to association proxies" | Joshua Peek | 2009-12-12 | 2 | -3/+6 |
| | | | | | | | | | | I think it may of broke the build. Lets see. This reverts commit 49e943c4f0ac3459bd53023167aaa08fc8e46733. Conflicts: activerecord/test/cases/associations/has_many_associations_test.rb | ||||
* | Fix postgresql AR test failure | John Pignata | 2009-12-11 | 1 | -2/+2 |
| | | | | | | | | Due to the ordering of the returning result set, the test fails under the postgresql adapter. Order results by id prior to checking the first item [#3542 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Replace reset_counter_cache with reset_counters that has API inline with ↵ | Gabe da Silveira | 2009-12-03 | 3 | -11/+16 |
| | | | | | | | | existing update_counters method [#1211 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Add support for Mysql column positioning via #add_column and #change_column | Ben Marini | 2009-12-03 | 3 | -0/+64 |
| | | | | | | | | | | | | | | add_column and change_column in the Mysql adapter now accept some additional options: :first => true # Put the column in front of all the columns :after => column_name # Put the colmn after 'column_name' add_column :new_col, :string, :first => true add_column :another_col, :integer, :default => 0, :after => :new_col [#3286 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Reorganize autoloads: | Carlhuda | 2009-12-02 | 1 | -47/+53 |
| | | | | | | | | | | | | | | | | | | | | | * A new module (ActiveSupport::Autoload) is provide that extends autoloading with new behavior. * All autoloads in modules that have extended ActiveSupport::Autoload will be eagerly required in threadsafe environments * Autoloads can optionally leave off the path if the path is the same as full_constant_name.underscore * It is possible to specify that a group of autoloads live under an additional path. For instance, all of ActionDispatch's middlewares are ActionDispatch::MiddlewareName, but they live under "action_dispatch/middlewares/middleware_name" * It is possible to specify that a group of autoloads are all found at the same path. For instance, a number of exceptions might all be declared there. * One consequence of this is that testing-related constants are not autoloaded. To get the testing helpers for a given component, require "component_name/test_case". For instance, "action_controller/test_case". * test_help.rb, which is automatically required by a Rails application's test helper, requires the test_case.rb for all active components, so this change will not be disruptive in existing or new applications. | ||||
* | Fix instance_eval calls to association proxies | Mat Brown | 2009-12-02 | 2 | -6/+10 |
| | | | | | | | | In the current stable, ActiveRecord::Associations::AssociationProxy#method_missing calls yield() if a block is given, causing the block to always be evaluated in its calling context. However, in the case of instance_eval, correct behavior requires that the block be passed directly to the @target, rather than being evaluated inside a different block. Incidentally, this also simplifies the code slightly. [#3412 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Implement ActiveRecord#reset_counter_cache | Mike Breen | 2009-12-02 | 3 | -0/+30 |
| | | | | | | [#1211 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Revert "Revert "Assert primary key does not exist in habtm when the ↵ | Jeremy Kemper | 2009-11-23 | 5 | -31/+14 |
| | | | | | | | | | | | | | association is defined, instead of doing that everytime a record is inserted."" This reverts commit 2b82708b0efb3a3458e8177beab58f0c585788ae. [#3128 state:resolved] Conflicts: activerecord/lib/active_record/associations.rb activerecord/lib/active_record/associations/has_and_belongs_to_many_association.rb | ||||
* | Insert generated association members in the same order they are specified ↵ | Gabe da Silveira | 2009-11-17 | 2 | -2/+25 |
| | | | | | | | | when assigning to a has_many :through using the generated *_ids method [#3491 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Revert "Ensure Model#destroy respects optimistic locking" | Jeremy Kemper | 2009-11-17 | 2 | -52/+0 |
| | | | | | | | | | | [#1966 state:open] This reverts commit 0d922885fb54c19f04680482f024452859218910. Conflicts: activerecord/lib/active_record/locking/optimistic.rb | ||||
* | Ruby 1.9: skip pg locking test for 1.9.1 also | Jeremy Kemper | 2009-11-15 | 1 | -1/+1 |
| | |||||
* | No need to check for generated method, just redispatch | Jeremy Kemper | 2009-11-14 | 1 | -4/+3 |
| | |||||
* | Ruby 1.9.2: use recursive flatten | Jeremy Kemper | 2009-11-14 | 1 | -7/+1 |
| | |||||
* | Skip pg locking test due to connection checkout deadlock detection | Jeremy Kemper | 2009-11-14 | 1 | -5/+8 |
| | |||||
* | Ruby 1.9.2: fix flatten_deeper to preserve nils | Jeremy Kemper | 2009-11-14 | 1 | -1/+1 |
| | |||||
* | Revert "Split arel_table into method to get a relation and another to ↵ | Jeremy Kemper | 2009-11-13 | 5 | -13/+13 |
| | | | | | | memoize the default relation." This reverts commit bd51790895fc75a3b4e19e8dd7aa6dc389d77068. | ||||
* | Split arel_table into method to get a relation and another to memoize the ↵ | Jeremy Kemper | 2009-11-13 | 5 | -13/+13 |
| | | | | default relation. | ||||
* | Missing customers fixture | Jeremy Kemper | 2009-11-13 | 1 | -2/+2 |
| | |||||
* | Ruby 1.9.2: avoid #flatten | Jeremy Kemper | 2009-11-13 | 3 | -18/+38 |
| | |||||
* | Update AR logger subscriber for Notifications subscriber args change | Jeremy Kemper | 2009-11-11 | 1 | -2/+2 |
| | |||||
* | Unify test:isolated across components and run by default at toplevel | Jeremy Kemper | 2009-11-10 | 1 | -5/+7 |
| | |||||
* | Bump AR.gemspec Arel dep too | Jeremy Kemper | 2009-11-10 | 1 | -1/+1 |
| | |||||
* | Ruby 1.9: fix Relation respond_to? and method_missing | Jeremy Kemper | 2009-11-10 | 1 | -6/+4 |
| | |||||
* | Resolve deadlock in pooled connections test | Jeremy Kemper | 2009-11-10 | 1 | -1/+1 |
| | |||||
* | delete correct records for a has_many with :primary_key and :dependent => ↵ | Matt Jones | 2009-11-10 | 4 | -3/+17 |
| | | | | | | :delete_all Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | Avoid adding component lib/ to load path multiple times | Joshua Peek | 2009-11-09 | 1 | -1/+3 |
| | |||||
* | Clarify failed assertion | Jeremy Kemper | 2009-11-09 | 1 | -1/+1 |
| | |||||
* | Integer#even? and Integer#odd? are not needed for Ruby >= 1.8.7 | Xavier Noria | 2009-11-09 | 1 | -2/+0 |
| | |||||
* | Object#tap is not needed for Ruby >= 1.8.7 | Xavier Noria | 2009-11-09 | 1 | -2/+0 |
| | |||||
* | Symbol#to_proc is not needed for Ruby >= 1.8.7 | Xavier Noria | 2009-11-09 | 1 | -1/+0 |
| | |||||
* | Define autosave association callbacks when using accepts_nested_attributes_for. | Eloy Duran | 2009-11-07 | 3 | -2/+4 |
| | | | | | | | This way we don't define all the validation methods for all associations by default, but only when needed. [#3355 state:resolved] | ||||
* | Arel::In -> Arel::Predicates::In | Jeremy Kemper | 2009-11-02 | 3 | -3/+3 |
| | |||||
* | Move validator, human_name and human_attribute_name to ActiveModel, remove ↵ | José Valim | 2009-10-20 | 9 | -1073/+19 |
| | | | | | | deprecated error messages and add i18n_scope and lookup_ancestors. Signed-off-by: Carl Lerche <carllerche@mac.com> | ||||
* | Have all the tests running off a single Gemfile | Yehuda Katz + Carl Lerche | 2009-10-20 | 2 | -15/+6 |
| | |||||
* | Use bundled env for tests only | Jeremy Kemper | 2009-10-19 | 3 | -14/+13 |
| | |||||
* | Bump arel requirement to 0.1.1 | Jeremy Kemper | 2009-10-19 | 1 | -1/+1 |
| | |||||
* | Fixed: #without_typecast should only disable typecasting on the duplicated ↵ | Eric Chapweske | 2009-10-18 | 2 | -2/+10 |
| | | | | | | attributes [#3387 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com> | ||||
* | Refactoring attributes/types [#3348 state:resolved] | Eric Chapweske | 2009-10-17 | 25 | -148/+760 |
| | | | | Signed-off-by: Joshua Peek <josh@joshpeek.com> | ||||
* | Fix Rails root in sqlite adapter | Joshua Peek | 2009-10-16 | 1 | -3/+3 |
| | |||||
* | We won't be publishing tars and zips anymore | Joshua Peek | 2009-10-16 | 1 | -2/+0 |
| | |||||
* | Modify connection pool callbacks to be compatible w/ new style | Nick Sieger | 2009-10-16 | 2 | -8/+27 |
| | | | | Signed-off-by: Yehuda Katz <wycats@gmail.com> | ||||
* | Renamed Orchestra to Notifications once again [#3321 state:resolved] | José Valim | 2009-10-15 | 2 | -3/+3 |
| | |||||
* | Unify benchmark APIs. | José Valim | 2009-10-15 | 2 | -38/+8 |
| | |||||
* | Update Orchestra instrumentations and move part of logging to Orchestra. | José Valim | 2009-10-15 | 3 | -10/+11 |
| | |||||
* | Revert "Rename Orchestra to Notifications [#3321 state:resolved]" | José Valim | 2009-10-15 | 1 | -1/+1 |
| | | | | This reverts commit 8cbf825425dc8ad3770881ea4e100b9023c69ce2. | ||||
* | Merge branch 'arel' | Jeremy Kemper | 2009-10-14 | 34 | -677/+812 |
|\ | |||||
| * | Fix env path | Jeremy Kemper | 2009-10-14 | 1 | -1/+1 |
| | | |||||
| * | Include bundled env in toplevel require, if present | Jeremy Kemper | 2009-10-14 | 2 | -11/+10 |
| | | |||||
| * | No more toplevel arel sibling | Jeremy Kemper | 2009-10-14 | 1 | -4/+2 |
| | |