Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Add tests for Relation#only. | Emilio Tagua | 2010-09-09 | 1 | -0/+11 |
| | |||||
* | No need to go through every option and test it, just don't add skipped ones. | Emilio Tagua | 2010-09-09 | 1 | -4/+4 |
| | |||||
* | return is not needed here | Neeraj Singh | 2010-09-09 | 1 | -2/+2 |
| | |||||
* | remove unnecessary call | Neeraj Singh | 2010-09-09 | 1 | -1/+0 |
| | | | | if operation is count then column_name will never be blank | ||||
* | creating a new array is required. who knew? :-( | Aaron Patterson | 2010-09-09 | 1 | -1/+1 |
| | |||||
* | no need for Array.wrap, also avoid array creation | Aaron Patterson | 2010-09-09 | 1 | -5/+4 |
| | |||||
* | make apply_modules run faster | Neeraj Singh | 2010-09-09 | 1 | -3/+5 |
| | |||||
* | eliminate present? for fewer method calls | Aaron Patterson | 2010-09-08 | 1 | -10/+2 |
| | |||||
* | returning arrays lets us avoid Array.wrap | Aaron Patterson | 2010-09-08 | 1 | -4/+4 |
| | |||||
* | removing unnecessary conditional test | Aaron Patterson | 2010-09-08 | 1 | -4/+4 |
| | |||||
* | switch to blank? to avoid method calls | Aaron Patterson | 2010-09-08 | 1 | -6/+6 |
| | |||||
* | refactor to use faster empty? | Aaron Patterson | 2010-09-08 | 1 | -1/+3 |
| | |||||
* | drying up joins() | Aaron Patterson | 2010-09-08 | 1 | -4/+2 |
| | |||||
* | reduce method calls, use reject + blank? instead of select + present? | Aaron Patterson | 2010-09-08 | 1 | -3/+3 |
| | |||||
* | refactor a couple injects to map + Hash[] | Aaron Patterson | 2010-09-08 | 1 | -5/+2 |
| | |||||
* | avoid an inject in favor of dup | Aaron Patterson | 2010-09-08 | 1 | -3/+3 |
| | |||||
* | attributes should be constructed with table objects | Aaron Patterson | 2010-09-07 | 1 | -1/+1 |
| | |||||
* | attributes should be associated with tables | Aaron Patterson | 2010-09-07 | 1 | -1/+1 |
| | |||||
* | serialized attributes should be serialized before validation [#5525 ↵ | Aaron Patterson | 2010-09-07 | 3 | -3/+12 |
| | | | | state:resolved] | ||||
* | no need to freeze this string | Aaron Patterson | 2010-09-07 | 1 | -1/+1 |
| | |||||
* | fixed some issues with JSON encoding | Jakub Suder | 2010-09-07 | 3 | -2/+11 |
| | | | | | | | | | | | - as_json in ActiveModel should return a hash and handle :only/:except/:methods options - Array and Hash should call as_json on their elements - json methods should not modify options argument [#5374 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | removing useless code, cleaning variable names | Aaron Patterson | 2010-09-07 | 1 | -6/+2 |
| | |||||
* | select should raise error when no block or no parameter is passed | Aaron Patterson | 2010-09-07 | 2 | -3/+7 |
| | |||||
* | select does not need a *args | Aaron Patterson | 2010-09-07 | 1 | -2/+2 |
| | |||||
* | unscoped has nothing so merging with a relation just returns the relation | Santiago Pastorino | 2010-09-07 | 1 | -1/+1 |
| | |||||
* | cleaning up confusing logic | Aaron Patterson | 2010-09-06 | 1 | -3/+6 |
| | |||||
* | Use railties:copy_migrations instead of db:copy_migrations | Piotr Sarnacki | 2010-09-06 | 1 | -1/+5 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Refactor AR validations a bit | Carlos Antonio da Silva | 2010-09-06 | 1 | -5/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Cleanup deprecation warnings in active record | Carlos Antonio da Silva | 2010-09-06 | 7 | -112/+11 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Improved indentation | Pratik Naik | 2010-09-06 | 1 | -7/+3 |
| | |||||
* | Use scoped here to get the scoped where | Santiago Pastorino | 2010-09-05 | 1 | -5/+3 |
| | |||||
* | Make scoped reorder override previous applied orders | Santiago Pastorino | 2010-09-05 | 2 | -3/+15 |
| | | | | [5528 state:committed] | ||||
* | failing test for reorder overriding default_scope | Nick Ragaz | 2010-09-05 | 2 | -1/+7 |
| | | | | | | [5528] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | order should always be concatenated. | Neeraj Singh | 2010-09-05 | 6 | -8/+35 |
| | | | | | | | | | | | | | | | | | | | | | | order that is declared first has highest priority in all cases. Here are some examples. Car.order('name desc').find(:first, :order => 'id').name Car.named_scope_with_order.named_scope_with_another_order Car.order('id DESC').scoping do Car.find(:first, :order => 'id asc') end No special treatment to with_scope or scoping. Also note that if default_scope declares an order then the order declared in default_scope has the highest priority unless with_exclusive_scope is used. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Fix copying migrations to empty directory | Piotr Sarnacki | 2010-09-03 | 3 | -1/+15 |
| | |||||
* | rake db:copy_migrations task, which copies railties migrations into ↵ | Piotr Sarnacki | 2010-09-03 | 1 | -0/+22 |
| | | | | application's db/migrate directory | ||||
* | Implemented ActiveRecord::Migrations#copy based on James Adam's idea | Piotr Sarnacki | 2010-09-03 | 11 | -25/+265 |
| | | | | | | | | | | | | | | | ActiveRecord::Migration#copy allows to copy migrations from one place to another, changing migrations versions and adding scope to filename. For example: ActiveRecord::Migration.copy("db/migrate", :blog_engine => "vendor/gems/blog/db/migrate") will copy all migrations from vendor/gems/blog/db/migrate to db/migrate with such format: Versions of copied migrations will be reversioned to be appended after migrations that already exists in db/migrate | ||||
* | Added Rails.application.config.paths.db.migrate to remove hardcoded ↵ | Piotr Sarnacki | 2010-09-03 | 2 | -10/+13 |
| | | | | db/migrate paths | ||||
* | Merge remote branch 'docrails/master' | Xavier Noria | 2010-09-03 | 5 | -23/+23 |
|\ | |||||
| * | Use new finders syntax in docs. | Emilio Tagua | 2010-09-01 | 5 | -23/+23 |
| | | |||||
* | | A few schema changes for the SQL Server adapter. | Ken Collins | 2010-09-03 | 1 | -3/+3 |
| | | | | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | | Revert "Setup explicit requires for files with exceptions. Removed them from ↵ | José Valim | 2010-09-02 | 4 | -5/+0 |
| | | | | | | | | | | | | | | | | autoloading." Booting a new Rails application does not work after this commit [#5359 state:open] This reverts commit 38a421b34d0b414564e919f67d339fac067a56e6. | ||||
* | | Setup explicit requires for files with exceptions. Removed them from ↵ | Łukasz Strzałkowski | 2010-09-02 | 4 | -0/+5 |
| | | | | | | | | | | | | autoloading. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | remove use of echo [#4410 state:resolved] | Greg Hazel | 2010-09-02 | 1 | -2/+2 |
| | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | Reset default scope in Thread.current when class is unloaded [#5497 ↵ | Andrew White | 2010-09-01 | 2 | -0/+23 |
| | | | | | | | | | | | | state:resolved] Signed-off-by: Xavier Noria <fxn@hashref.com> | ||||
* | | Fix test: this should return 0 not 7, since Arel was ignoring select clause ↵ | Emilio Tagua | 2010-09-01 | 1 | -1/+1 |
| | | | | | | | | | | | | and now it's fixed. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | split out active_record migration logic so others can easily reuse [#5389 ↵ | Jack Dempsey | 2010-09-01 | 2 | -10/+17 |
| | | | | | | | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | nested attributes tests should rely on associated objects to verify results ↵ | Subba Rao Pasupuleti | 2010-09-01 | 1 | -57/+64 |
|/ | | | | | | not on assert_difference [#5206 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Make all the Relation finder methods consistent | Pratik Naik | 2010-08-31 | 1 | -32/+67 |
| | |||||
* | Merge remote branch 'miloops/rails_master_fixes' | Pratik Naik | 2010-08-31 | 1 | -15/+26 |
|\ |