Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Allow nested attributes in associations to update values in it's owner ↵ | Andrew Kaspick | 2011-12-14 | 4 | -2/+22 |
| | | | | object. Fixes a regression from 3.0.x | ||||
* | updating arel and journey dependencies | Aaron Patterson | 2011-12-14 | 1 | -1/+1 |
| | |||||
* | Fix #3672 again (dependent: delete_all perf) | Jon Leighton | 2011-12-14 | 6 | -9/+26 |
| | |||||
* | Remove that there copy/pasted code :bomb: | Jon Leighton | 2011-12-14 | 1 | -5/+0 |
| | |||||
* | Don't try to autosave nested assocs. Fixes #2961. | Jon Leighton | 2011-12-14 | 3 | -1/+19 |
| | |||||
* | Cache column defaults on model. ~30% on Model.new due to avoiding repeatedly ↵ | Jon Leighton | 2011-12-14 | 1 | -2/+2 |
| | | | | fetching connection. | ||||
* | Avoid super; speeds up Model.new by about 12% | Jon Leighton | 2011-12-14 | 1 | -1/+1 |
| | |||||
* | Stop the build asploding on 1.8.7 | Jon Leighton | 2011-12-14 | 2 | -0/+6 |
| | |||||
* | Use a separate module for 'external' attribute methods. | Jon Leighton | 2011-12-14 | 3 | -17/+26 |
| | |||||
* | Add return for 1.8.7 | Jon Leighton | 2011-12-14 | 1 | -1/+1 |
| | |||||
* | Unfluff the CI. | Jon Leighton | 2011-12-14 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | With transactional fixtures enabled, the session records would end up in @_current_transaction_records, and at the end of the transaction, methods would be called on them that would trigger method_missing and trigger attribute methods to be generated. However, at this point the sessions table would not exist, and the columns were not cached, so an exception would be raised because we can't find the columns to generate attribute methods for. Not sure exactly why this didn't crop up before but there have been changes to the schema cache code and perhaps that means that column data that was cached previously at that point is now uncached. | ||||
* | Revert naive O(1) table_exists? implementation. | Jon Leighton | 2011-12-13 | 4 | -12/+16 |
| | | | | | | | | | | It was a bad idea to rescue exceptions here. This can interfere with transaction rollbacks which seems to be the cause of current CI failure. Instead, each adapter should implement its own DB-specific O(1) implementation, and we fall back on the generic, slower, implementation otherwise. | ||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2011-12-14 | 1 | -1/+1 |
|\ | |||||
| * | changed :finder_sql example to select * | clst | 2011-12-12 | 1 | -1/+1 |
| | | | | | | because with select p.* you can no longer use count(). Using count will result in an SQL error message. | ||||
| * | fixed example for :finder_sql | clst | 2011-12-12 | 1 | -1/+1 |
| | | | | | | people.* will not work when the alias is named p | ||||
* | | FileUpdateChecker should be able to handle deleted files. | José Valim | 2011-12-13 | 1 | -2/+1 |
| | | |||||
* | | use the schema cache when asking for the primary key | Aaron Patterson | 2011-12-12 | 1 | -1/+1 |
| | | |||||
* | | Merge pull request #3954 from bdurand/null_store_2 | José Valim | 2011-12-12 | 1 | -0/+4 |
|\ \ | | | | | | | Add ActiveSupport::Cache::NullStore for testing and development | ||||
| * | | Add ActiveSupport::Cache::NullStore to expose caching interface without ↵ | Brian Durand | 2011-12-12 | 1 | -0/+4 |
| | | | | | | | | | | | | actually caching for development and test environments. | ||||
* | | | Speed up development by only reloading classes if dependencies files changed. | José Valim | 2011-12-12 | 1 | -0/+5 |
|/ / | | | | | | | | | | | | | | | This can be turned off by setting `config.reload_classes_only_on_change` to false. Extensions like Active Record should add their respective files like db/schema.rb and db/structure.sql to `config.watchable_files` if they want their changes to affect classes reloading. Thanks to https://github.com/paneq/active_reload and Pastorino for the inspiration. <3 | ||||
* | | ensure @fixture_connections is initialized in case an exception happens ↵ | Aaron Patterson | 2011-12-10 | 1 | -0/+1 |
| | | | | | | | | during setup | ||||
* | | Errno::ENOENT error makes more sense when a file cannot be found | Aaron Patterson | 2011-12-10 | 2 | -11/+1 |
| | | |||||
* | | Allow to run migrations with given scope, with SCOPE=<scope> | Piotr Sarnacki | 2011-12-09 | 2 | -1/+15 |
| | | | | | | | | | | | | | | | | | | | | | | Scope in migrations can be defined by adding suffix in filename, like: 01_a_migration.blog.rb. Such migration have blog scope. Scope is automatically added while copying migrations from engine, so if you want to revert all of the migrations from given engine, you can just run db:migrate with SCOPE, like: rake db:migrate SCOPE=blog | ||||
* | | Allow to filter migrations by passing a block | Piotr Sarnacki | 2011-12-09 | 2 | -9/+31 |
| | | | | | | | | | | | | | | | | | | | | Example: ActiveRecord::Migrator.migrate(path) do |migration| migration.name =~ /User/ end The above example will migrate only migrations with User in the name | ||||
* | | Use `table_exists?` from the schema cache. | Aaron Patterson | 2011-12-09 | 4 | -8/+7 |
| | | |||||
* | | don't need a begin / end. | Aaron Patterson | 2011-12-09 | 1 | -6/+4 |
| | | |||||
* | | squelch table exists? queries. | Aaron Patterson | 2011-12-09 | 1 | -1/+1 |
| | | |||||
* | | Compare migrations for copying only by name and scope | Piotr Sarnacki | 2011-12-09 | 2 | -48/+7 |
| | | |||||
* | | Add suffix for migrations copied from engines | Piotr Sarnacki | 2011-12-09 | 2 | -28/+28 |
| | | |||||
* | | String#to_a is not available in 1.9 | Piotr Sarnacki | 2011-12-09 | 2 | -2/+2 |
| | | |||||
* | | Run also migrations in subdirectories. | Piotr Sarnacki | 2011-12-09 | 5 | -2/+45 |
| | | | | | | | | | | With this commit, ActiveRecord will also look for migrations in db/migrate subdirectories. | ||||
* | | Ignore origin comment when checking for duplicates on Migration.copy | Piotr Sarnacki | 2011-12-09 | 3 | -5/+58 |
| | | | | | | | | | | | | | | 49ebe51 fixed copying migrations, but existing migrations would still trigger warnings. The proper way to compare migrations is to ignore origin lines - if migration is identical it means that we can silently skip it, regardless where it comes from. | ||||
* | | Fix copying migrations from engines | Piotr Sarnacki | 2011-12-09 | 2 | -3/+24 |
| | | | | | | | | | | | | | | | | | | | | There was a bug in ActiveRecord::Migration.copy method, which prevented adding special comment about the origin of migration. Because of that, the check if migration is identical or if it's not and should be skipped was always saying that migration is skipped, which was causing additional useless warnings about skipped migrations. | ||||
* | | Exceptions should read from the spec configu | Aaron Patterson | 2011-12-08 | 1 | -1/+1 |
| | | |||||
* | | Fix #3890. (Calling proxy_association in scope chain.) | Jon Leighton | 2011-12-08 | 3 | -3/+19 |
| | | |||||
* | | fix nodocs | Vijay Dev | 2011-12-09 | 3 | -9/+9 |
| | | |||||
* | | fix comments | Vijay Dev | 2011-12-09 | 1 | -4/+2 |
| | | |||||
* | | Remove NilClass whiners feature. | José Valim | 2011-12-08 | 1 | -2/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Removing this feature causes boost in performance when using Ruby 1.9. Ruby 1.9 started to do implicit conversions using `to_ary` and `to_str` in some STDLIB methods (like Array#join). To do such implicit conversions, Ruby 1.9 always dispatches the method and rescues the NoMethodError exception in case one is raised. Therefore, since the whiners feature defined NilClass#method_missing, such implicit conversions for nil became much, much slower. In fact, just defining NilClass#method_missing (even without the whiners feature) already causes a massive slow down. Here is a snippet that shows such slow down: require "benchmark" Benchmark.realtime { 1_000.times { [nil,nil,nil].join } } class NilClass def method_missing(*args) raise NoMethodError end end Benchmark.realtime { 1_000.times { [nil,nil,nil].join } } | ||||
* | | fixing eval'd line numbers. | Aaron Patterson | 2011-12-08 | 1 | -2/+2 |
| | | |||||
* | | Regexp.union seems to have different results in 1.8 | Aaron Patterson | 2011-12-08 | 1 | -3/+3 |
| | | |||||
* | | Add performance scripts from wycats/rails-simple-benches to actionpack. | José Valim | 2011-12-08 | 1 | -1/+1 |
| | | |||||
* | | Fix broken test_exists_query_logging from the table_exists? change | Jon Leighton | 2011-12-08 | 1 | -0/+1 |
| | | |||||
* | | moving ignored regexp to the instance | Aaron Patterson | 2011-12-07 | 1 | -6/+8 |
| | | |||||
* | | speeding up ignored sql testing | Aaron Patterson | 2011-12-07 | 1 | -1/+4 |
| | | |||||
* | | Use a hash to look up column definitions | Aaron Patterson | 2011-12-07 | 1 | -2/+3 |
| | | |||||
* | | try to normalize the objects passed to column() | Aaron Patterson | 2011-12-07 | 1 | -9/+11 |
| | | |||||
* | | automatically add the column definition to the columns list if creating a ↵ | Aaron Patterson | 2011-12-07 | 1 | -12/+21 |
| | | | | | | | | new one | ||||
* | | stop calling String#to_s so frequently | Aaron Patterson | 2011-12-07 | 1 | -3/+4 |
| | | |||||
* | | the required sqlite3 adapter responds to encoding, so stop checking. | Aaron Patterson | 2011-12-07 | 1 | -5/+1 |
| | | |||||
* | | reversible migration example had missing block parameter | Evgeniy Kelyarsky | 2011-12-07 | 1 | -1/+1 |
| | |