Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Compare migrations for copying only by name and scope | Piotr Sarnacki | 2011-12-09 | 2 | -48/+7 |
| | |||||
* | Add suffix for migrations copied from engines | Piotr Sarnacki | 2011-12-09 | 2 | -28/+28 |
| | |||||
* | String#to_a is not available in 1.9 | Piotr Sarnacki | 2011-12-09 | 2 | -2/+2 |
| | |||||
* | Run also migrations in subdirectories. | Piotr Sarnacki | 2011-12-09 | 5 | -2/+45 |
| | | | | | With this commit, ActiveRecord will also look for migrations in db/migrate subdirectories. | ||||
* | Ignore origin comment when checking for duplicates on Migration.copy | Piotr Sarnacki | 2011-12-09 | 3 | -5/+58 |
| | | | | | | | 49ebe51 fixed copying migrations, but existing migrations would still trigger warnings. The proper way to compare migrations is to ignore origin lines - if migration is identical it means that we can silently skip it, regardless where it comes from. | ||||
* | Fix copying migrations from engines | Piotr Sarnacki | 2011-12-09 | 2 | -3/+24 |
| | | | | | | | | | | There was a bug in ActiveRecord::Migration.copy method, which prevented adding special comment about the origin of migration. Because of that, the check if migration is identical or if it's not and should be skipped was always saying that migration is skipped, which was causing additional useless warnings about skipped migrations. | ||||
* | Exceptions should read from the spec configu | Aaron Patterson | 2011-12-08 | 1 | -1/+1 |
| | |||||
* | Fix #3890. (Calling proxy_association in scope chain.) | Jon Leighton | 2011-12-08 | 3 | -3/+19 |
| | |||||
* | fix nodocs | Vijay Dev | 2011-12-09 | 3 | -9/+9 |
| | |||||
* | fix comments | Vijay Dev | 2011-12-09 | 1 | -4/+2 |
| | |||||
* | Remove NilClass whiners feature. | José Valim | 2011-12-08 | 1 | -2/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | | Removing this feature causes boost in performance when using Ruby 1.9. Ruby 1.9 started to do implicit conversions using `to_ary` and `to_str` in some STDLIB methods (like Array#join). To do such implicit conversions, Ruby 1.9 always dispatches the method and rescues the NoMethodError exception in case one is raised. Therefore, since the whiners feature defined NilClass#method_missing, such implicit conversions for nil became much, much slower. In fact, just defining NilClass#method_missing (even without the whiners feature) already causes a massive slow down. Here is a snippet that shows such slow down: require "benchmark" Benchmark.realtime { 1_000.times { [nil,nil,nil].join } } class NilClass def method_missing(*args) raise NoMethodError end end Benchmark.realtime { 1_000.times { [nil,nil,nil].join } } | ||||
* | fixing eval'd line numbers. | Aaron Patterson | 2011-12-08 | 1 | -2/+2 |
| | |||||
* | Regexp.union seems to have different results in 1.8 | Aaron Patterson | 2011-12-08 | 1 | -3/+3 |
| | |||||
* | Add performance scripts from wycats/rails-simple-benches to actionpack. | José Valim | 2011-12-08 | 1 | -1/+1 |
| | |||||
* | Fix broken test_exists_query_logging from the table_exists? change | Jon Leighton | 2011-12-08 | 1 | -0/+1 |
| | |||||
* | moving ignored regexp to the instance | Aaron Patterson | 2011-12-07 | 1 | -6/+8 |
| | |||||
* | speeding up ignored sql testing | Aaron Patterson | 2011-12-07 | 1 | -1/+4 |
| | |||||
* | Use a hash to look up column definitions | Aaron Patterson | 2011-12-07 | 1 | -2/+3 |
| | |||||
* | try to normalize the objects passed to column() | Aaron Patterson | 2011-12-07 | 1 | -9/+11 |
| | |||||
* | automatically add the column definition to the columns list if creating a ↵ | Aaron Patterson | 2011-12-07 | 1 | -12/+21 |
| | | | | new one | ||||
* | stop calling String#to_s so frequently | Aaron Patterson | 2011-12-07 | 1 | -3/+4 |
| | |||||
* | the required sqlite3 adapter responds to encoding, so stop checking. | Aaron Patterson | 2011-12-07 | 1 | -5/+1 |
| | |||||
* | reversible migration example had missing block parameter | Evgeniy Kelyarsky | 2011-12-07 | 1 | -1/+1 |
| | |||||
* | avoid deprecated methods | Aaron Patterson | 2011-12-06 | 1 | -1/+1 |
| | |||||
* | add prefix and suffix to renamed tables, closes #1510 | Vasiliy Ermolovich | 2011-12-06 | 4 | -0/+52 |
| | |||||
* | Quitoting the table name before querying. | Aaron Patterson | 2011-12-05 | 1 | -1/+1 |
| | |||||
* | Speed up table_exists? for databases with a large number of tables | Jade Rubick | 2011-12-05 | 1 | -1/+6 |
| | | | | | | At New Relic, we have hundreds of thousands of tables, and our migrations took 30 minutes without this similar patch. This cuts it down to a more reasonable amount of time. The rescue false part is ugly, but necessary as far as I can tell. I don't know of a cross-database statement you can make that will work without trapping errors. | ||||
* | Merge pull request #3854 from exviva/validates_associated_marked_for_destruction | José Valim | 2011-12-04 | 2 | -2/+13 |
|\ | | | | | Do not validate associated records marked for destruction | ||||
| * | Do not validate associated records marked for destruction | Olek Janiszewski | 2011-12-05 | 2 | -2/+13 |
| | | | | | | | | | | | | The main reason for this change is to fix a bug where `validates_associated` would prevent `accepts_nested_attributes_for` with `allow_destroy: true` from destroying invalid associated records. | ||||
* | | Merge pull request #3851 from ebeigarts/fix_sequence_name | Jon Leighton | 2011-12-04 | 2 | -2/+12 |
|\ \ | |/ |/| | Fix sequence name with abstract classes. | ||||
| * | Fix sequence name with abstract classes. | Edgars Beigarts | 2011-12-04 | 2 | -2/+12 |
| | | |||||
* | | moves some auto explain logic to the subscriber [José Valim & Xavier Noria] | Xavier Noria | 2011-12-04 | 2 | -19/+12 |
| | | |||||
* | | simplifies ActiveRecord::ExplainSubscriber [José Valim & Xavier Noria] | Xavier Noria | 2011-12-04 | 1 | -8/+6 |
| | | |||||
* | | Merge branch 'explain' | Xavier Noria | 2011-12-04 | 6 | -84/+93 |
|\ \ | |/ |/| | |||||
| * | implements a much faster auto EXPLAIN, closes #3843 [José Valim & Xavier Noria] | Xavier Noria | 2011-12-04 | 6 | -84/+93 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit vastly reduces the impact of auto explain logging when enabled, while keeping a negligible cost when disabled. The first implementation was based on the idea of subscribing to "sql.active_record" when needed, and unsubscribing once done. This is the idea behind AR::Relation#explain. Subscribe, collect, unsubscribe. But with the current implementation of notifications unsubscribing is costly, because it wipes an internal cache and that puts a penalty on the next event. So we are switching to an approach where a long-running subscriber is listening. Instead of collecting the queries with a closure in a dedicated subscriber, now we setup a thread local. If the feature is disabled by setting the threshold to nil, the subscriber will call a method that does nothing. That's totally cheap. | ||||
* | | Refactor readonly attributes conditional | Carlos Antonio da Silva | 2011-12-04 | 1 | -1/+2 |
|/ | |||||
* | SQlite3 Bump | Arun Agrawal | 2011-12-04 | 1 | -1/+1 |
| | |||||
* | Add missing require | Jon Leighton | 2011-12-03 | 1 | -0/+2 |
| | |||||
* | Avoid postgres 9.X syntax | Jon Leighton | 2011-12-03 | 1 | -1/+5 |
| | |||||
* | Fix #3837. | Jon Leighton | 2011-12-03 | 2 | -11/+17 |
| | | | | | We also need to time zone convert time zone aware attributes when accessed via read_attribute, not only when via direct access. | ||||
* | removes the convenience instance version of AR::Base.silence_auto_explain | Xavier Noria | 2011-12-03 | 4 | -96/+83 |
| | | | | | | | Rationale: As discussed with José and Jon, this convenience shortcut is not clearly justified and it could let the user thing the disabled EXPLAINs are related to the model instance rather than being globally disabled. | ||||
* | Merge pull request #3820 from jaylevitt/nested_loading_through_assoc | Jon Leighton | 2011-12-03 | 2 | -1/+36 |
|\ | | | | | reintroduce patch from #726 to handle nested eager loading via associations | ||||
| * | reintroduce patch from #726 to handle nested eager loading via associations | Jay Levitt | 2011-11-30 | 2 | -1/+36 |
| | | |||||
* | | Merge pull request #3833 from kennyj/fix_3678-3 | Jon Leighton | 2011-12-03 | 1 | -3/+8 |
|\ \ | | | | | | | Use show create table (fix 3678: third time). | ||||
| * | | Use show create table. | kennyj | 2011-12-03 | 1 | -3/+8 |
| | | | |||||
* | | | yield > block.call | Xavier Noria | 2011-12-02 | 1 | -3/+3 |
| | | | |||||
* | | | two small details from the previous patch | Xavier Noria | 2011-12-02 | 1 | -1/+1 |
| | | | |||||
* | | | implements AR::Base(.|#)silence_auto_explain | Xavier Noria | 2011-12-02 | 4 | -61/+105 |
| | | | |||||
* | | | indentation fix warning | Arun Agrawal | 2011-12-02 | 1 | -1/+1 |
|/ / | |||||
* | | revises some details in the previous explain patch | Xavier Noria | 2011-12-02 | 2 | -3/+3 |
| | |