Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Return nil from read_attribute(:foo) if 'foo' is not present in the ↵ | Jon Leighton | 2011-04-15 | 2 | -2/+3 |
| | | | | @attributes hash, but the _foo method has been defined. This brings the behaviour into line with the 3-0-stable branch and the master branch before 93641ed6c8c684f6b4db02b6c8a22fa9bc7f0eaf (there were previously no assertions about this which is why the change slipped through). Note that actually calling the 'foo' method will still raise an error if the attribute is not present. | ||||
* | Undo performances regressions I introduced in ↵ | Jon Leighton | 2011-04-15 | 2 | -5/+34 |
| | | | | bbe0a507f287c20ab4ae8a244fbfc810665deda5 and add test for an edge case. Add comments to explain the intent of the code. | ||||
* | Refactor test to avoid hackery | Jon Leighton | 2011-04-15 | 1 | -4/+4 |
| | |||||
* | Remove unnecessary code from define_read_method and add assertion to make ↵ | Jon Leighton | 2011-04-15 | 2 | -7/+5 |
| | | | | sure the underscored version is actually generated | ||||
* | sort insert columns for better cache hits | Aaron Patterson | 2011-04-14 | 1 | -1/+1 |
| | |||||
* | refactoring inserts to use the same method on the connection | Aaron Patterson | 2011-04-14 | 1 | -21/+16 |
| | |||||
* | mimic prepared statements in the exec_insert for mysql2 | Aaron Patterson | 2011-04-14 | 1 | -0/+11 |
| | |||||
* | mysql type cast should return integers when typecasting true / false | Aaron Patterson | 2011-04-14 | 3 | -0/+57 |
| | |||||
* | using the database adapter to typecast before executing prepared statement | Aaron Patterson | 2011-04-14 | 4 | -2/+34 |
| | |||||
* | inserting big decimals as strings works consistently among dbs, so use ↵ | Aaron Patterson | 2011-04-14 | 2 | -2/+2 |
| | | | | string form | ||||
* | insert statements are prepared, but values are not escaped properly | Aaron Patterson | 2011-04-14 | 5 | -8/+64 |
| | |||||
* | adding a type cast method for prepared statements | Aaron Patterson | 2011-04-14 | 3 | -1/+130 |
| | |||||
* | Extract the constraint-building for joins in JoinAssociation into a separate ↵ | Jon Leighton | 2011-04-14 | 1 | -8/+14 |
| | | | | method to make it easy to change/override (requested by Ernie Miller so that MetaWhere can add to it easily) | ||||
* | Fixes performance issue introduced in 3.0.6 (issue #6695) | Stian Grytøyr | 2011-04-14 | 1 | -3/+5 |
| | |||||
* | do not depend on to_yaml being called, but rather depend on YAML being dumped | Aaron Patterson | 2011-04-13 | 2 | -7/+8 |
| | |||||
* | use index based substitution for bind parameters | Aaron Patterson | 2011-04-13 | 7 | -10/+10 |
| | |||||
* | Remove `#among?` from Active Support | Prem Sichanugrist | 2011-04-13 | 11 | -11/+11 |
| | | | | | | After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now. It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`. | ||||
* | common @jonleighton :bomb: | Aaron Patterson | 2011-04-12 | 1 | -2/+1 |
| | |||||
* | Deprecate defining scopes with a callable (lambda, proc, etc) via the scope ↵ | Jon Leighton | 2011-04-12 | 6 | -23/+116 |
| | | | | class method. Just define a class method yourself instead. | ||||
* | ActiveRecord::Base.scopes hash is not needed | Jon Leighton | 2011-04-12 | 3 | -29/+4 |
| | |||||
* | Evaluate default scopes at the last possible moment in order to avoid ↵ | Jon Leighton | 2011-04-12 | 10 | -33/+67 |
| | | | | problems with default scopes getting included into other scopes and then being unable to remove the default part via unscoped. | ||||
* | Deprecated support for passing hashes and relations to default_scope, in ↵ | Jon Leighton | 2011-04-12 | 17 | -172/+410 |
| | | | | favour of defining a 'default_scope' class method in the model. See the CHANGELOG for more details. | ||||
* | Removing the scope-caching which happens on association proxies, because the ↵ | Jon Leighton | 2011-04-12 | 3 | -24/+15 |
| | | | | query is already cached by the query cacher. For formalised proof see http://www.youtube.com/watch?v=wDefXLb-FDs | ||||
* | stop using deprecated methods in arel | Aaron Patterson | 2011-04-11 | 1 | -2/+2 |
| | |||||
* | Change Object#either? to Object#among? -- thanks to @jamesarosen for the ↵ | David Heinemeier Hansson | 2011-04-12 | 11 | -11/+11 |
| | | | | suggestion! | ||||
* | remove so many nested if statements | Aaron Patterson | 2011-04-11 | 1 | -9/+11 |
| | |||||
* | wrap the pg_get_serial_sequence function and reuse it for the default ↵ | Aaron Patterson | 2011-04-11 | 2 | -2/+35 |
| | | | | sequence name | ||||
* | cache table exists queries in prepared statement cache | Aaron Patterson | 2011-04-11 | 1 | -3/+6 |
| | |||||
* | only use the primary_key method, refactor schema and table name parsing | Aaron Patterson | 2011-04-11 | 1 | -13/+15 |
| | |||||
* | use prepared statements for primary key queries | Aaron Patterson | 2011-04-11 | 1 | -2/+15 |
| | |||||
* | last insert id can never be called, so remove that code path | Aaron Patterson | 2011-04-11 | 1 | -11/+3 |
| | |||||
* | we know the table and pk, so we can calculate a default sequence name | Aaron Patterson | 2011-04-11 | 1 | -3/+4 |
| | |||||
* | always look up pk and sequence unless both are provided | Aaron Patterson | 2011-04-11 | 1 | -6/+5 |
| | |||||
* | pg does not know the insert_id in advance, so super will never return true | Aaron Patterson | 2011-04-11 | 1 | -13/+10 |
| | |||||
* | updating the docco for ActiveRecord::Result | Aaron Patterson | 2011-04-11 | 1 | -2/+2 |
| | |||||
* | implement exec_query on mysql2 adapter | Aaron Patterson | 2011-04-11 | 1 | -2/+20 |
| | |||||
* | make sqlite insert_sql more consistent with other adapters | Aaron Patterson | 2011-04-11 | 1 | -1/+2 |
| | |||||
* | adding exec_insert for postgresql | Aaron Patterson | 2011-04-11 | 3 | -1/+43 |
| | |||||
* | fixing variable name in mysql test | Aaron Patterson | 2011-04-11 | 1 | -1/+1 |
| | |||||
* | properly name schema queries for the logger | Aaron Patterson | 2011-04-11 | 1 | -10/+10 |
| | |||||
* | adding mysql adapter test case | Aaron Patterson | 2011-04-11 | 1 | -0/+69 |
| | |||||
* | adding client_encoding method for discovering the encoding set for this ↵ | Aaron Patterson | 2011-04-11 | 1 | -0/+62 |
| | | | | client, testing exec_insert on a string | ||||
* | properly name schema queries for logging | Aaron Patterson | 2011-04-11 | 1 | -3/+3 |
| | |||||
* | adding exec_insert to sqlite3 | Aaron Patterson | 2011-04-11 | 2 | -0/+16 |
| | |||||
* | adding a case_sensitive_modifier for forcing comparisons to be case sensitive | Aaron Patterson | 2011-04-11 | 4 | -0/+15 |
| | |||||
* | only support pg >= 8.2, so no need to check | Aaron Patterson | 2011-04-11 | 1 | -7/+4 |
| | |||||
* | pg should define insert_sql so that query cache actually works for inserts | Aaron Patterson | 2011-04-10 | 1 | -2/+1 |
| | |||||
* | adding pg support notes to the changelog | Aaron Patterson | 2011-04-10 | 1 | -0/+2 |
| | |||||
* | community support for pg < 8.2 has ended, so we can drop support for those ↵ | Aaron Patterson | 2011-04-10 | 1 | -62/+12 |
| | | | | versions | ||||
* | Refactored uniqueness validator to use Arel instead of hardcoded SQL | Brian Cardarella | 2011-04-10 | 1 | -26/+11 |
| |