Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | First bit of support for habtm in through assocs - ↵ | Jon Leighton | 2010-10-13 | 6 | -30/+84 |
| | | | | test_has_many_through_has_many_with_has_and_belongs_to_many_source_reflection now passes | ||||
* | Hook ThroughAssociationScope up to use the AliasTracker class | Jon Leighton | 2010-10-13 | 1 | -9/+30 |
| | |||||
* | Some small tweaks on the last commit | Jon Leighton | 2010-10-12 | 2 | -19/+12 |
| | |||||
* | Extract aliasing code from JoinDependency and JoinAssociation into a ↵ | Jon Leighton | 2010-10-12 | 2 | -41/+83 |
| | | | | separate AliasTracker class. This can then be used by ThroughAssociationScope as well. | ||||
* | Add a commented, failing test for using a habtm in a has many through ↵ | Jon Leighton | 2010-10-12 | 5 | -55/+74 |
| | | | | association. I want to refactor how aliasing works first. | ||||
* | Add test_has_many_through_has_one_through_with_has_many_source_reflection | Jon Leighton | 2010-10-12 | 2 | -1/+19 |
| | |||||
* | Adding test_has_many_through_has_one_with_has_many_through_source_reflection ↵ | Jon Leighton | 2010-10-12 | 5 | -3/+29 |
| | | | | and modifying ThroughAssociationScope to make it work correctly. | ||||
* | Rename some tests for consistency | Jon Leighton | 2010-10-12 | 1 | -3/+3 |
| | |||||
* | Add test_has_many_through_has_one_through | Jon Leighton | 2010-10-12 | 2 | -2/+17 |
| | |||||
* | Support has_one through assocs as the source association | Jon Leighton | 2010-10-12 | 7 | -20/+71 |
| | |||||
* | A load of tests that need to be written | Jon Leighton | 2010-10-12 | 1 | -0/+63 |
| | |||||
* | Refactoring to remove duplication introduced by the last commit | Jon Leighton | 2010-10-10 | 1 | -160/+145 |
| | |||||
* | Add support for nested through associations in JoinAssociation. Hence ↵ | Jon Leighton | 2010-10-09 | 11 | -94/+175 |
| | | | | Foo.joins(:bar) will work for through associations. There is some duplicated code now, which will be refactored. | ||||
* | Merge branch 'master' into nested_has_many_through | Jon Leighton | 2010-10-06 | 15 | -67/+147 |
|\ | |||||
| * | create fewer objects, call fewer methods in extract_pg_identifier_from_name | Aaron Patterson | 2010-10-04 | 1 | -3/+3 |
| | | |||||
| * | * + flatten is not required in >= Ruby 1.8.7 | Aaron Patterson | 2010-10-04 | 1 | -1/+1 |
| | | |||||
| * | converting inject([]) to map | Aaron Patterson | 2010-10-03 | 1 | -4/+3 |
| | | |||||
| * | speed up duplicate migration detection | Aaron Patterson | 2010-10-03 | 1 | -6/+5 |
| | | |||||
| * | reduce the number of calls to camelize | Aaron Patterson | 2010-10-03 | 1 | -3/+4 |
| | | |||||
| * | convertion MigrationProxy to a Struct, initialize instance variables | Aaron Patterson | 2010-10-03 | 1 | -7/+6 |
| | | |||||
| * | dry up some migration logic | Aaron Patterson | 2010-10-03 | 1 | -2/+4 |
| | | |||||
| * | no need to differentiate between nil and false in this case | Aaron Patterson | 2010-10-03 | 1 | -2/+2 |
| | | |||||
| * | lengths will be nil or an array | Aaron Patterson | 2010-10-03 | 1 | -2/+2 |
| | | |||||
| * | remove a few function calls | Aaron Patterson | 2010-10-03 | 1 | -3/+5 |
| | | |||||
| * | be kind to the garbage collector and reuse our visitor object | Aaron Patterson | 2010-10-03 | 1 | -1/+4 |
| | | |||||
| * | avoid creating objects when we can | Aaron Patterson | 2010-10-03 | 3 | -14/+7 |
| | | |||||
| * | Rely on Rack::Session stores API for more compatibility across the Ruby world. | José Valim | 2010-10-03 | 1 | -2/+5 |
| | | |||||
| * | Refactor AssociationCollection#include? with objects in memory | Carlos Antonio da Silva | 2010-10-02 | 1 | -4/+3 |
| | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | Arel::Sql::Engine.new does not do anything anymore | Aaron Patterson | 2010-09-30 | 2 | -2/+2 |
| | | |||||
| * | type_name should check for blank because people may have messed up databases | Aaron Patterson | 2010-09-30 | 2 | -1/+15 |
| | | |||||
| * | build_where should be private | Aaron Patterson | 2010-09-30 | 1 | -2/+2 |
| | | |||||
| * | type_name is never a blank string, so use faster .nil? call | Aaron Patterson | 2010-09-30 | 1 | -1/+1 |
| | | |||||
| * | AssociationCollection#include? working properly for objects added with build ↵ | Marcelo Giorgi | 2010-09-30 | 4 | -0/+39 |
| | | | | | | | | method [#3472 state:resolved] | ||||
| * | speeding up object instantiation by eliminating instance_eval | Aaron Patterson | 2010-09-30 | 1 | -7/+21 |
| | | |||||
| * | [#5441 state:resolved] refactoring code to determine aggregate column | Aaron Patterson | 2010-09-30 | 1 | -11/+14 |
| | | |||||
| * | group clause must be more specific | Aaron Patterson | 2010-09-30 | 1 | -1/+1 |
| | | |||||
| * | Tests proving #5441 | oleg dashevskii | 2010-09-30 | 1 | -1/+11 |
| | | |||||
* | | Refactoring JoinDependency and friends. This improves the code (IMO) ↵ | Jon Leighton | 2010-10-06 | 10 | -209/+356 |
| | | | | | | | | including adding some explanatory comments, but more importantly structures it in such a way as to allow a JoinAssociation to produce an arbitrary number of actual joins, which will be necessary for nested has many through support. Also added 3 tests covering functionality which existed but was not previously covered. | ||||
* | | A failing test for a nested has many through association loaded via ↵ | Jon Leighton | 2010-10-05 | 1 | -0/+6 |
| | | | | | | | | Foo.joins(:bar) | ||||
* | | Fix the tests (I have actually verified that these are also the 'right' ↵ | Jon Leighton | 2010-10-03 | 6 | -24/+24 |
| | | | | | | | | fixes, rather than just making the tests pass again) | ||||
* | | Add support for table aliasing, with a test that needs aliasing in order to ↵ | Jon Leighton | 2010-10-02 | 7 | -15/+75 |
| | | | | | | | | work correctly. This test incidentally provides a more complicated test case (4 inner joins, 2 using polymorphism). | ||||
* | | Integrate nested support into ThroughAssociationScope, using my concept of ↵ | Jon Leighton | 2010-10-02 | 5 | -59/+107 |
| | | | | | | | | generating a 'chain' of reflections to be joined. It seems to work at the moment, all existing tests are passing. There may be further complications as we add more test cases for nested associations, though. | ||||
* | | Started implementing nested :through associations by using the existing ↵ | Jon Leighton | 2010-10-01 | 4 | -32/+60 |
| | | | | | | | | structure of ThroughAssociationScope rather than layering a module over the top | ||||
* | | Prevent ↵ | Jon Leighton | 2010-09-30 | 1 | -2/+2 |
| | | | | | | | | test_has_many_through_a_has_many_through_association_on_through_reflection failing for me due to ordering of the results | ||||
* | | Merge branch 'master' into nested_has_many_through_2 | Jon Leighton | 2010-09-30 | 33 | -224/+350 |
|\| | |||||
| * | Fix 'rake db:create' is ignore encoding when using postgres [#5717 ↵ | yalab | 2010-09-30 | 1 | -1/+1 |
| | | | | | | | | | | | | state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
| * | Added config.app_generators to allow configuring application's generators ↵ | Piotr Sarnacki | 2010-09-30 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | from railties. With config.generators becomes a way to configure generators for current instance only. For example: module Blog class Engine < Rails::Engine config.generators do |g| g.orm :active_record end config.app_generators do |g| g.test_framework :rspec end end end such definition sets :active_record as orm for engine and :rspec as test_framework for application. The values set with app_generators can be overwritten in application using config.generators as you would normally do: module MyApp class Application < Rails::Application config.generators do |g| g.test_framework :test_unit end end end | ||||
| * | double negative is not good | Neeraj Singh | 2010-09-30 | 1 | -1/+1 |
| | | |||||
| * | no need of nil check | Neeraj Singh | 2010-09-29 | 1 | -1/+1 |
| | | |||||
| * | Use detect instead select to avoid "sh: [mysqldump]: command not found". | Emilio Tagua | 2010-09-29 | 1 | -1/+1 |
| | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> |