Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | reducing funcalls, cleaning up primary key methods for sqlite adapter | Aaron Patterson | 2010-07-10 | 1 | -6/+11 |
| | |||||
* | primary key behavioral tests | Aaron Patterson | 2010-07-10 | 1 | -0/+17 |
| | |||||
* | behavioral tests for sqlite adapter | Aaron Patterson | 2010-07-10 | 1 | -4/+77 |
| | |||||
* | adding more behavioral tests for the sqlite adapter | Aaron Patterson | 2010-07-09 | 1 | -0/+20 |
| | |||||
* | Merge remote branch 'docrails/master' | Xavier Noria | 2010-07-09 | 1 | -2/+7 |
|\ | |||||
| * | copy-edits some docs | Xavier Noria | 2010-07-08 | 1 | -6/+5 |
| | | |||||
| * | Merge branch 'master' of github.com:lifo/docrails | Neeraj Singh | 2010-07-08 | 7 | -15/+34 |
| |\ | |||||
| * | | clarifying how to create non standard primary key | Neeraj Singh | 2010-07-08 | 1 | -1/+7 |
| | | | |||||
* | | | Refactor previous commits a bit. | José Valim | 2010-07-08 | 1 | -7/+10 |
| | | | |||||
* | | | Return from ActiveRecord::Base#attributes= unless value is a hash [#4070 ↵ | David Trasbo | 2010-07-08 | 2 | -1/+8 |
| | | | | | | | | | | | | | | | | | | state:committed] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | | reset_counter should work with non-traditional belongs_to and polymorphic ↵ | Neeraj Singh | 2010-07-08 | 7 | -6/+52 |
| | | | | | | | | | | | | | | | | | | | | | | | | belongs_to [#4984 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | | Improve a bit the code in latest commits. | José Valim | 2010-07-08 | 2 | -20/+16 |
| | | | |||||
* | | | This patch changes update_attribute implementatino so: | Neeraj Singh | 2010-07-08 | 5 | -20/+74 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - it will only save the attribute it has been asked to save and not all dirty attributes - it does not invoke callbacks - it does change updated_at/on Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | | consolidating updated_at and updated_on | Neeraj Singh | 2010-07-08 | 1 | -9/+16 |
| | | | | | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | | Eager loading :through associations will join the :source model if there are ↵ | Grant Ammons | 2010-07-08 | 3 | -1/+13 |
| | | | | | | | | | | | | | | | | | | :conditions. [#2362 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | | Fix the #using_limitable_reflections? helper to work correctly by not ↵ | Ken Collins | 2010-07-08 | 2 | -1/+11 |
| | | | | | | | | | | | | | | | | | | examining the length of an array which contains false/true, hence always passing. [#4869 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | | Tests to specify the behaviour of ActiveRecord::Migrator.get_all_versions() ↵ | Thiago Pradi | 2010-07-08 | 1 | -0/+14 |
| | | | | | | | | | | | | | | | | | | [#5066 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | | removed an old unused method in AR which removed readonly attributes | Josh Kalderimis | 2010-07-08 | 1 | -9/+0 |
| | | | | | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | | removing unused method | Neeraj Singh | 2010-07-08 | 1 | -5/+0 |
| | | | | | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | | moving parse_sqlite_config to the sqlite3_connection method (where it ↵ | Aaron Patterson | 2010-07-08 | 2 | -20/+11 |
| | | | | | | | | | | | | | | | | | | belongs) [#5071 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | | | removing useless code. [#5070 state:resolved] | Aaron Patterson | 2010-07-08 | 1 | -2/+1 |
| | | | | | | | | | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | | | fix ActiveRecord `destroy_all` so it returns destroyed records | Mislav Marohnić | 2010-07-08 | 4 | -13/+24 |
| | | | | | | | | | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | | | mass_assignment_security moved from AR to AMo, and minor test cleanup | Josh Kalderimis | 2010-07-08 | 12 | -408/+12 |
| | | | | | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | | minor changes to mass assignment security patch to bring it in line with ↵ | Josh Kalderimis | 2010-07-08 | 8 | -249/+234 |
| | | | | | | | | | | | | | | | | | | rails standards Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | | Mass assignment security refactoring | Eric Chapweske | 2010-07-08 | 10 | -146/+378 |
| | | | | | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | | This test never runs and it has never run. Since the day this file | Neeraj Singh | 2010-07-08 | 1 | -4/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | was created this test has name not beginning with test_. Also this test is trying to use has_many on another has_many which is not supported. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | | Fixed gruoped_by_title spelling [#5063 state:committed] | Ben Somers | 2010-07-08 | 2 | -3/+3 |
| | | | | | | | | | | | | Signed-off-by: Xavier Noria <fxn@hashref.com> | ||||
* | | | adding some behavioral tests for the sqlite adapter. [#5065 state:resolved] | Aaron Patterson | 2010-07-07 | 1 | -0/+100 |
| |/ |/| | | | | | Signed-off-by: wycats <wycats@gmail.com> | ||||
* | | Merge remote branch 'docrails/master' | Xavier Noria | 2010-07-07 | 2 | -2/+8 |
|\| | |||||
| * | added more info about << operation in associations | Neeraj Singh | 2010-07-06 | 1 | -0/+4 |
| | | |||||
| * | clarifying the comments regarding base_class declaration | Neeraj Singh | 2010-07-01 | 1 | -2/+4 |
| | | |||||
* | | documents automatic management of join models in hmt associations, in ↵ | Xavier Noria | 2010-07-06 | 1 | -4/+11 |
| | | | | | | | | particular the gotcha that deletion is direct | ||||
* | | Define a convention for descendants and subclasses. | José Valim | 2010-07-05 | 1 | -3/+3 |
| | | | | | | | | | | | | The former should be symmetric with ancestors and include all children. However, it should not include self since ancestors + descendants should not have duplicated. The latter is symmetric to superclass in the sense it only includes direct children. By adopting a convention, we expect to have less conflict with other frameworks, as Datamapper. For this moment, to ensure ActiveModel::Validations can be used with Datamapper, we should always call ActiveSupport::DescendantsTracker.descendants(self) internally instead of self.descendants avoiding conflicts. | ||||
* | | Avoid calls to Rails::Application since this is not the official API. | José Valim | 2010-07-01 | 1 | -1/+1 |
| | | | | | | | | Your application should *always* reference your application const (as Blog::Application) and Rails.application should be used just internally. | ||||
* | | Don't remove scheduled destroys when loading an association. [#4642 ↵ | James Le Cuirot | 2010-07-01 | 2 | -1/+12 |
| | | | | | | | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | Make relation a private method. | José Valim | 2010-07-01 | 2 | -6/+7 |
|/ | |||||
* | Merge remote branch 'rails/master' | Xavier Noria | 2010-06-30 | 26 | -302/+681 |
|\ | |||||
| * | Support any mysql-like adapter | Jeremy Kemper | 2010-06-30 | 1 | -7/+7 |
| | | |||||
| * | Add missing CHANGELOG items. | José Valim | 2010-06-30 | 1 | -0/+2 |
| | | |||||
| * | AssociationCollection#create_by_*, find_or_create_by_* work properly now. ↵ | Aaron Patterson | 2010-06-29 | 2 | -0/+73 |
| | | | | | | | | | | | | [#1108 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
| * | migrations.rb requires active_support/core_ext/module/aliasing [#5008 ↵ | Tekin | 2010-06-30 | 1 | -0/+1 |
| | | | | | | | | | | | | state:committed] Signed-off-by: Xavier Noria <fxn@hashref.com> | ||||
| * | Test that adding an index also doesn't raise an exception. | J. Pablo Fernández | 2010-06-29 | 1 | -1/+1 |
| | | | | | | | | | | | | [#4809 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | Replaced statement in comment with an assertion | Paul Barry | 2010-06-29 | 1 | -2/+3 |
| | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | Fixed error when removing an index from a table name values, which is a ↵ | J. Pablo Fernández | 2010-06-29 | 2 | -1/+17 |
| | | | | | | | | | | | | reserved word, with test. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | No need to check if the attribute exists (this is the same behavior as in ↵ | José Valim | 2010-06-29 | 1 | -3/+1 |
| | | | | | | | | 2.3) [#4994 state:resolved] and [#5003 state:resolved] | ||||
| * | Push a failing test for issues [#4994] and [#5003]. | José Valim | 2010-06-29 | 2 | -0/+9 |
| | | |||||
| * | array subtraction should be faster than iterating over all the elements | Neeraj Singh | 2010-06-29 | 1 | -1/+1 |
| | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | splitting a really long line into multiple lines which is easy on eyes | Neeraj Singh | 2010-06-29 | 1 | -1/+5 |
| | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | Remove ActiveRecord::Base#class_name [#379 state:committed] | David Trasbo | 2010-06-29 | 2 | -27/+0 |
| | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | Tidy up deprecation message for with_exclusive_scope. | José Valim | 2010-06-29 | 2 | -11/+12 |
| | |