aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Use broken YAML that will fail with Syck as well as Psych. Fixes ↵Jon Leighton2011-10-091-2/+2
| | | | | | | | | | | | | | | | | | test_broken_yaml_exception in fixtures_test.rb on Ruby 1.8.7. Cherry-pick from 3-1-stable: b8d46924e70e0847e92e1d2dbaaec8c11381072c
* | | Remove stray whitespaceJeremy Kemper2011-10-091-4/+1
| | |
* | | Only use LOWER for mysql case insensitive uniqueness check when column has a ↵Joseph Palermo2011-10-0910-12/+139
| | | | | | | | | | | | case sensitive collation.
* | | Merge pull request #500 from cyril/patch-1Jeremy Kemper2011-10-081-2/+2
|\ \ \ | | | | | | | | Use quotes for command substitution
| * | | Use quotes for command substitutionCyril Wack2011-05-101-2/+2
| | | |
* | | | Fixed BodyProxy.new for tests! for wrong argumentArun Agrawal2011-10-081-1/+1
| | | |
* | | | use thread locals and an instance variable within QueryCache#BodyProxy to ↵Mark J. Titorenko2011-10-073-3/+13
| | | | | | | | | | | | | | | | maintain appropriate linkage with AR database connection across threads
* | | | Merge pull request #3232 from Juanmcuello/pg_prepared_statementsAaron Patterson2011-10-062-3/+23
|\ \ \ \ | | | | | | | | | | Use the schema_search_path in prepared statements.
| * | | | refs #3232. Prepared statements and postgreSQL schemas.Juan M. Cuello2011-10-051-0/+19
| | | | | | | | | | | | | | | | | | | | | | | | | Add tests for prepared statements with multiple schemas in postgreSQL.
| * | | | Use the schema_search_path in prepared statements.Juan M. Cuello2011-10-051-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | To allow the use of prepared statements when changing schemas in postgres, the schema search path is added to the sql key.
* | | | | Merge pull request #3203 from jrmehle/fix_clone_structureVijay Dev2011-10-061-2/+2
|\ \ \ \ \ | | | | | | | | | | | | db:test:clone_structure if path to .sql file contains spaces or dashes
| * | | | | Quoted path to <Rails.env>_structure.sql file in db:test:clone_structure task.Jared Mehle2011-10-031-2/+2
| | | | | | | | | | | | | | | | | | Leaving the path unquoted causes errors in paths containing spaces or dashes.
* | | | | | Transactional fixtures enlist all active database connections.Jeremy Kemper2011-10-057-10/+61
| | | | | | | | | | | | | | | | | | | | | | | | You can use multiple databases in your tests without disabling transactional fixtures.
* | | | | | Raise an exception on unknown primary key inside AssociationReflection.Jon Leighton2011-10-053-4/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | An association between two models cannot be made if a relevant key is unknown, so fail fast rather than generating invalid SQL. Fixes #3207.
* | | | | | Revert "Raise error on unknown primary key."Jon Leighton2011-10-0512-54/+18
| |/ / / / |/| | | | | | | | | | | | | | This reverts commit ee2be435b1e5c0e94a4ee93a1a310e0471a77d07.
* | | | | Raise error on unknown primary key.Jon Leighton2011-10-0512-18/+54
| | | | | | | | | | | | | | | | | | | | | | | | | If we don't have a primary key when we ask for it, it's better to fail fast. Fixes GH #2307.
* | | | | Changing rake db:schema:dump to run :environment as well as :load_config, as ↵Ben Woosley2011-10-041-1/+1
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | running :load_config alone will lead to the dumper being run without including extensions such as those included in foreigner and spatial_adapter. This reverses a change made here: https://github.com/rails/rails/commit/5df72a238e9fcb18daf6ab6e6dc9051c9106d7bb#L0L324 I'm assuming here that :load_config needs to be invoked separately from :environment, as it is elsewhere in the file for db operations, if not the alternative is to go back to "task :dump => :environment do". Signed-off-by: José Valim <jose.valim@gmail.com>
* | | | To support ActiveRecord unit tests for IBM DB2Yasuo Honda2011-10-021-0/+2
| | | |
* | | | Add CHANGELOG entriesSantiago Pastorino2011-09-291-1/+25
| | | |
* | | | Don't call self.class unless necessary. Closes #3171.Jon Leighton2011-09-292-2/+3
| |/ / |/| |
* | | Fixed failed test under 1.8.7 as map.keys order in indeterminableRocky Jaiswal2011-09-282-2/+2
| | |
* | | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2011-09-281-1/+1
|\ \ \
| * | | fixing docs for delete_sql where quotes should be used in this example.Diego Plentz2011-09-261-1/+1
| | | |
* | | | Don't require a DB connection when setting primary key.Jon Leighton2011-09-263-1/+20
| | | | | | | | | | | | | | | | Closes #2807.
* | | | Merge pull request #3030 from htanata/fix_habtm_select_query_methodJon Leighton2011-09-263-4/+16
| | | | | | | | | | | | | | | | Fix: habtm doesn't respect select query method
* | | | Fix belongs_to polymorphic with custom primary key on target.Jon Leighton2011-09-265-18/+30
| | | | | | | | | | | | | | | | Closes #3104.
* | | | CollectionProxy#replace should change the DB records rather than just ↵Jon Leighton2011-09-262-1/+12
|/ / / | | | | | | | | | mutating the array. Fixes #3020.
* | | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2011-09-211-0/+29
|\ \ \
| * | | copy edits 908f2616Vijay Dev2011-09-201-4/+4
| | | |
| * | | Document ActiveRecord::QueryMethods#selectRyan Bigg2011-09-171-0/+29
| | | |
* | | | fix test error when running with postgresql.Arun Agrawal2011-09-181-2/+4
| | | | | | | | | | | | | | | | | | | | This Sqlite3 should be in if block. Was giving error because sqlite3 is not loaded
* | | | to_xml should also rely on serializable hash.José Valim2011-09-181-1/+1
| | | |
* | | | Fixed test for JRuby. Arun Agrawal2011-09-181-1/+2
|/ / / | | | | | | for Sqlite3 in AR-JDBC.It's Jdbc::SQLite3::VERSION
* | | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2011-09-152-1/+37
|\ \ \
| * | | minor editVijay Dev2011-09-141-1/+1
| | | |
| * | | Add documentation for the extending method in ActiveRecord:QueryMethodsRyan Bigg2011-09-141-0/+36
| | | |
| * | | [:class_name] option in belongs_to should mention belongs_to and not has_oneErik Behrends2011-09-131-1/+1
| | | |
* | | | update 3.1 release date in changelogsVijay Dev2011-09-141-1/+1
| | | |
* | | | Stop trying to be clever about when to define attribute methods.Jon Leighton2011-09-142-34/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There is no meaningful performance penalty in defining attribute methods, since it only happens once. There is also no reason *not* to define them, since they get thrown in an included module, so they will not 'overwrite' anything. In fact, this is desirable, since it allows us to call super.
* | | | We don't need to build a set for DangerousAttributeError.Jon Leighton2011-09-141-7/+13
| | | | | | | | | | | | | | | | We can just use method_defined? and private_method_defined?
* | | | Rename first_or_new to first_or_initialize.Jon Leighton2011-09-135-28/+15
|/ / / | | | | | | | | | | | | For consistency with find_or_initialize_by. Also remove first_or_build alias.
* | | Deprecate using method_missing for attributes that are columns.Jon Leighton2011-09-132-0/+30
| | | | | | | | | | | | | | | | | | This shouldn't ever happen unless people are doing something particularly weird, but adding a deprecation in case there are bugs not caught by our tests.
* | | Let Ruby deal with method visibility.Jon Leighton2011-09-132-10/+13
| | | | | | | | | | | | | | | | | | Check respond_to_without_attributes? in method_missing. If there is any method that responds (even private), let super handle it and raise NoMethodError if necessary.
* | | Reset column info when messing with columns.Jon Leighton2011-09-131-0/+2
| | | | | | | | | | | | | | | | | | | | | We are subclassing Session here, but messing with the columns will affect the attribute methods defined on the Session superclass, and therefore other tests, unless we properly isolate it by resetting column info before and after the test run.
* | | Always generate attribute methods on the base class.Jon Leighton2011-09-134-6/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes a situation I encountered where a subclass would cache the name of a generated attribute method in @_defined_class_methods. Then, when the superclass has it's attribute methods undefined, the subclass would always have to dispatch through method_missing, because the presence of the attribute in @_defined_class_methods would mean that it is never generated again, even if undefine_attribute_methods is called on the subclass. There various other confusing edge cases like this. STI classes share columns, so let's just keep all the attribute method generation state isolated to the base class.
* | | Raise error when using write_attribute with a non-existent attribute.Jon Leighton2011-09-138-25/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | Previously we would just silently write the attribute. This can lead to subtle bugs (for example, see the change in AutosaveAssociation where a through association would wrongly gain an attribute. Also, ensuring that we never gain any new attributes after initialization will allow me to reduce our dependence on method_missing.
* | | Make protected method public so we avoid method_missing.Jon Leighton2011-09-131-4/+5
| | |
* | | Fix warnings.Jon Leighton2011-09-131-1/+1
| | | | | | | | | | | | Make sure we don't redefine an already-defined attribute method.
* | | Add deprecation for doing `attribute_method_suffix ''`Jon Leighton2011-09-131-2/+0
| | |
* | | Alias id= if necessary, rather than relying on method_missingJon Leighton2011-09-131-0/+4
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-16 17:40:11 +0000