Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | type_name should check for blank because people may have messed up databases | Aaron Patterson | 2010-09-30 | 2 | -1/+15 |
| | |||||
* | build_where should be private | Aaron Patterson | 2010-09-30 | 1 | -2/+2 |
| | |||||
* | type_name is never a blank string, so use faster .nil? call | Aaron Patterson | 2010-09-30 | 1 | -1/+1 |
| | |||||
* | AssociationCollection#include? working properly for objects added with build ↵ | Marcelo Giorgi | 2010-09-30 | 4 | -0/+39 |
| | | | | method [#3472 state:resolved] | ||||
* | speeding up object instantiation by eliminating instance_eval | Aaron Patterson | 2010-09-30 | 1 | -7/+21 |
| | |||||
* | [#5441 state:resolved] refactoring code to determine aggregate column | Aaron Patterson | 2010-09-30 | 1 | -11/+14 |
| | |||||
* | group clause must be more specific | Aaron Patterson | 2010-09-30 | 1 | -1/+1 |
| | |||||
* | Tests proving #5441 | oleg dashevskii | 2010-09-30 | 1 | -1/+11 |
| | |||||
* | Fix 'rake db:create' is ignore encoding when using postgres [#5717 ↵ | yalab | 2010-09-30 | 1 | -1/+1 |
| | | | | | | state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Added config.app_generators to allow configuring application's generators ↵ | Piotr Sarnacki | 2010-09-30 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | from railties. With config.generators becomes a way to configure generators for current instance only. For example: module Blog class Engine < Rails::Engine config.generators do |g| g.orm :active_record end config.app_generators do |g| g.test_framework :rspec end end end such definition sets :active_record as orm for engine and :rspec as test_framework for application. The values set with app_generators can be overwritten in application using config.generators as you would normally do: module MyApp class Application < Rails::Application config.generators do |g| g.test_framework :test_unit end end end | ||||
* | double negative is not good | Neeraj Singh | 2010-09-30 | 1 | -1/+1 |
| | |||||
* | no need of nil check | Neeraj Singh | 2010-09-29 | 1 | -1/+1 |
| | |||||
* | Use detect instead select to avoid "sh: [mysqldump]: command not found". | Emilio Tagua | 2010-09-29 | 1 | -1/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | eliminating method_missing on TableDefinition | Aaron Patterson | 2010-09-29 | 2 | -16/+18 |
| | |||||
* | DRY up postgresql quote logic | Aaron Patterson | 2010-09-29 | 1 | -11/+14 |
| | |||||
* | fixing where clause indentation | Aaron Patterson | 2010-09-29 | 1 | -4/+4 |
| | |||||
* | use consistent method calls for column inspection | Aaron Patterson | 2010-09-29 | 1 | -1/+1 |
| | |||||
* | require pg when this adapter is loaded | Aaron Patterson | 2010-09-29 | 1 | -5/+4 |
| | |||||
* | only reopen ConnectionAdapters once | Aaron Patterson | 2010-09-29 | 1 | -2/+0 |
| | |||||
* | use inheritence to deal with custom methods | Aaron Patterson | 2010-09-29 | 2 | -10/+20 |
| | |||||
* | fisting test organization | Aaron Patterson | 2010-09-29 | 2 | -52/+50 |
| | |||||
* | just use if rather than nil? | Aaron Patterson | 2010-09-29 | 1 | -1/+1 |
| | |||||
* | just require sqlite3 when the database adapter is required | Aaron Patterson | 2010-09-29 | 1 | -4/+1 |
| | |||||
* | removing more useless code! yay! | Aaron Patterson | 2010-09-28 | 1 | -6/+2 |
| | |||||
* | SqlLiteral is a string, so we can dry up these conditionals | Aaron Patterson | 2010-09-28 | 1 | -4/+3 |
| | |||||
* | shorten up or sql literal creation statements | Aaron Patterson | 2010-09-28 | 1 | -4/+2 |
| | |||||
* | we only care about arrays and strings | Aaron Patterson | 2010-09-28 | 1 | -1/+1 |
| | |||||
* | dry up calls to arel.join() | Aaron Patterson | 2010-09-28 | 1 | -5/+4 |
| | |||||
* | removing unused lasgns | Aaron Patterson | 2010-09-28 | 1 | -4/+4 |
| | |||||
* | refactoring to remove crazy logic | Aaron Patterson | 2010-09-28 | 2 | -9/+6 |
| | |||||
* | where_values_hash always returns a hash | Aaron Patterson | 2010-09-28 | 1 | -1/+1 |
| | |||||
* | performance improvement based on discussion at ↵ | Neeraj Singh | 2010-09-28 | 1 | -9/+3 |
| | | | | | | http://github.com/rails/rails/commit/fbd1d306b95cc2efb6422e12d26d5818a3a42343 Credit goes to all the participants in the discussion | ||||
* | Revert "porting 515917f5d8678af6c57842ca5dfd7c18e67ff1fe to master" | Aaron Patterson | 2010-09-28 | 1 | -6/+0 |
| | | | | This reverts commit bee447a5b9fe1d683c6cc69aefb7fc22c2a9d9af. | ||||
* | Revert "porting 066518295032a8e3f3468737337b8c8299442867 to master. Thanks ↵ | Aaron Patterson | 2010-09-28 | 1 | -1/+1 |
| | | | | | | Marcelo Giorgi" This reverts commit 9eca11a4a564f44675cca951216e917b8f610eab. | ||||
* | removing a conditional that is not used | Aaron Patterson | 2010-09-28 | 1 | -2/+0 |
| | |||||
* | fisting the postgresql tests | Aaron Patterson | 2010-09-28 | 1 | -1/+2 |
| | |||||
* | Set attributes properly for model built from association with conditions ↵ | Marcelo Giorgi | 2010-09-28 | 8 | -10/+61 |
| | | | | | | [#5562 state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | each works well too | Aaron Patterson | 2010-09-28 | 1 | -1/+1 |
| | |||||
* | no need for splat and flatten | Aaron Patterson | 2010-09-28 | 1 | -1/+1 |
| | |||||
* | avoid calling to_sql when we can | Aaron Patterson | 2010-09-28 | 2 | -4/+4 |
| | |||||
* | removing an inject + merge in favor of Hash#[] | Aaron Patterson | 2010-09-28 | 1 | -1/+1 |
| | |||||
* | fixing indentation warning | Aaron Patterson | 2010-09-28 | 1 | -1/+1 |
| | |||||
* | Test add_index and remove_index with a symbol name #4891 | Étienne Barrié | 2010-09-28 | 2 | -4/+10 |
| | |||||
* | porting 066518295032a8e3f3468737337b8c8299442867 to master. Thanks Marcelo ↵ | Aaron Patterson | 2010-09-28 | 1 | -1/+1 |
| | | | | Giorgi | ||||
* | porting 515917f5d8678af6c57842ca5dfd7c18e67ff1fe to master | Aaron Patterson | 2010-09-28 | 1 | -0/+6 |
| | |||||
* | use new skool Ruby instead of Ruby Classic™ | Aaron Patterson | 2010-09-27 | 1 | -5/+3 |
| | |||||
* | be kind to the garbage collector: only instantiate objects when absolutely ↵ | Aaron Patterson | 2010-09-27 | 1 | -14/+17 |
| | | | | necessary | ||||
* | adding test cases for the dynamic finder matcher match method | Aaron Patterson | 2010-09-27 | 1 | -0/+49 |
| | |||||
* | constructor should not do so much work; avoid allocating object if possible | Aaron Patterson | 2010-09-27 | 1 | -10/+5 |
| | |||||
* | @klass also uses DynamicFinderMatch, so no need for it on the relation | Aaron Patterson | 2010-09-27 | 2 | -9/+5 |
| |