aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
* fix #create_fixtures when equal table names in different databasesJulia Lopez2016-12-215-0/+25
|
* Merge pull request #27400 from kamipo/remove_useless_test_supports_primary_keyEileen M. Uchitelle2016-12-191-6/+0
|\ | | | | Remove useless `test_supports_primary_key`
| * Remove useless `test_supports_primary_key`Ryuta Kamizono2016-12-191-6/+0
| | | | | | | | | | `supports_primary_key?` method is defined in `AbstractAdapter` so does not raise any errors.
* | Consolidate duplicated elsif branchRyuta Kamizono2016-12-191-6/+1
|/
* Merge pull request #27329 from kamipo/simplify_unsigned_regexEileen M. Uchitelle2016-12-171-1/+1
|\ | | | | Simplify the regex for `unsigned?` method
| * Simplify the regex for `unsigned?` methodRyuta Kamizono2016-12-111-1/+1
| | | | | | | | | | It is enough to distinguish only the trailing `unsigned` and `unsigned zerofill`.
* | Merge pull request #27375 from kirs/fixture-error-messageRafael França2016-12-162-2/+15
|\ \ | | | | | | Throw friendly error message when fixture is not a hash
| * | Throw friendly error message when fixture is not a hashKir Shatrov2016-12-152-2/+15
| | | | | | | | | | | | | | | | | | Right now, when fixture is not a Hash we throw an error message saying "fixture is not a hash". This is not very user friendly because it's not saying which fixture is invalid.
* | | fix QueryCache nil dupRichard Monette2016-12-152-2/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | make sql statements frozen dup if arel is not our string expect runtime error dont wrap runtime error in invalid log errors will now be treated as runtime errors update changelog
* | | fix new warning in ruby 2.4yuuji.yaginuma2016-12-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes the following warning. ``` test/caching_test.rb:986: warning: parentheses after method name is interpreted as test/caching_test.rb:986: warning: an argument list, not a decomposed argument test/cases/adapters/mysql2/reserved_word_test.rb:146: warning: parentheses after method name is interpreted as test/cases/adapters/mysql2/reserved_word_test.rb:146: warning: an argument list, not a decomposed argument ``` Ref: https://github.com/ruby/ruby/commit/65e27c8b138d6959608658ffce2fa761842b8d24
* | | Merge pull request #27042 from kirs/yaml-schema-cacheRafael França2016-12-132-4/+384
|\ \ \ | | | | | | | | Schema cache in YAML
| * | | Use YAML to serialize schema cacheKir Shatrov2016-11-272-4/+384
| | | |
* | | | Remove duplicated lineRyuta Kamizono2016-12-111-1/+0
| |_|/ |/| |
* | | Fix CI failure caused by #25227 and #25280 were merged at the same timeRyuta Kamizono2016-12-101-1/+1
| |/ |/|
* | Merge pull request #25280 from ↵Sean Griffin2016-12-101-0/+14
|\ \ | | | | | | | | | | | | kamipo/prevent_range_error_for_belongs_to_associations Prevent `RangeError` for `belongs_to` associations
| * | Prevent `RangeError` for `belongs_to` associationsRyuta Kamizono2016-10-101-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | Currently to access `belongs_to` associations raises a `RangeError` if foreign key attribute has out of range value. It should return a nil value rather than raising a `RangeError`. Fixes #20140.
* | | Merge pull request #25227 from kamipo/numeric_value_out_of_rangeSean Griffin2016-12-102-2/+10
|\ \ \ | | | | | | | | Translate numeric value out of range to the specific exception
| * | | Translate numeric value out of range to the specific exceptionRyuta Kamizono2016-12-062-2/+10
| | | | | | | | | | | | | | | | Raise `ActiveRecord::RangeError` when values that executed are out of range.
* | | | Emulate db trigger behaviour for after_commit :destroy, :updateStefan Budeanu2016-12-091-0/+45
| | | | | | | | | | | | | | | | | | | | | | | | Race conditions can occur when an ActiveRecord is destroyed twice or destroyed and updated. The callbacks should only be triggered once, similar to a SQL database trigger.
* | | | Resolve association class correctly when assigning ids on a through associationMatthew Draper2016-12-091-0/+7
| | | |
* | | | Merge pull request #26696 from iainbeeston/only-ruby-types-in-activemodelSean Griffin2016-12-081-0/+17
|\ \ \ \ | | | | | | | | | | | | | | | Moved database-specific ActiveModel types into ActiveRecord
| * | | | Moved database-specific ActiveModel types into ActiveRecordIain Beeston2016-10-141-0/+17
| | | | | | | | | | | | | | | | | | | | ie. DecimalWithoutScale, Text and UnsignedInteger
* | | | | Check whether the current attribute being write is aliased or not before writingPrathamesh Sonpatki2016-12-091-0/+7
| | | | | | | | | | | | | | | | | | | | - If aliased, then use the aliased attribute name.
* | | | | Check whether the current attribute being read is aliased or not before readingPrathamesh Sonpatki2016-12-081-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | - If aliased, then use the aliased attribute name. - Fixes #26417.
* | | | | Merge pull request #27251 from ebeigarts/fix-autosaveSean Griffin2016-12-061-0/+24
|\ \ \ \ \ | |_|/ / / |/| | | | Fix association scope inside autosaved association callbacks
| * | | | Improve test without using anonymous classesEdgars Beigarts2016-12-061-27/+24
| | | | |
| * | | | Reload association scope inside autosaved associationsEdgars Beigarts2016-12-021-0/+27
| | | | |
* | | | | Translate NOT NULL violation to the specific exceptionRyuta Kamizono2016-12-063-8/+20
| | | | | | | | | | | | | | | | | | | | | | | | | Raise `ActiveRecord::NotNullViolation` when a record cannot be inserted or updated because it would violate a not null constraint.
* | | | | Merge pull request #26687 from kamipo/fix_add_index_to_normalize_optionsMatthew Draper2016-12-062-0/+7
|\ \ \ \ \ | | | | | | | | | | | | Fix `add_index` to normalize column names and options
| * | | | | Fix `add_index` to normalize column names and optionsRyuta Kamizono2016-10-032-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently does not work the following code. ```ruby add_index(:people, ["last_name", "first_name"], order: { last_name: :desc, first_name: :asc }) ``` Normalize column names and options to fix the issue.
* | | | | | Merge pull request #27274 from kamipo/primary_key_with_auto_increment_and_bigintMatthew Draper2016-12-061-8/+18
|\ \ \ \ \ \ | | | | | | | | | | | | | | Make `:auto_increment` option works on `:bigint`
| * | | | | | Make `:auto_increment` option works on `:bigint`Ryuta Kamizono2016-12-061-8/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow up to #27272.
* | | | | | | Make pg adapter use bigserial for pk by defaultPavel Pravosud2016-12-056-0/+196
| | | | | | |
* | | | | | | Change MySQL and Postgresql to use Bigint primary keysJon McCartie2016-12-056-64/+46
|/ / / / / /
* | | | | | Make `:auto_increment` to internal primary key optionRyuta Kamizono2016-12-061-0/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using `:auto_increment` option for abstracting the DB-specific auto incremental types. It is worth to ease to implement the compatibility layer.
* | | | | | Fix that `change_column` lose a commentRyuta Kamizono2016-12-051-2/+1
| |/ / / / |/| | | |
* | | | | Make the second argument to `attribute` optionalSean Griffin2016-11-301-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | While working on updating Paper Trail for 5.1 compatibility, I noticed that I was required to pass a second argument to `attribute`. I didn't intend for this to be the case, as `attribute :foo` is totally reasonable shorthand for "I want `attr_accessor :foo`, but also have it work with things like `.attributes` and `ActiveRecord::Dirty`"
* | | | | Merge pull request #27126 from kamipo/fix_unsigned_with_zerofillRafael França2016-11-291-0/+1
|\ \ \ \ \ | | | | | | | | | | | | Fix that unsigned with zerofill is treated as signed
| * | | | | Fix that unsigned with zerofill is treated as signedRyuta Kamizono2016-11-271-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | Fixes #27125.
* | | | | | Merge pull request #27195 from y-yagi/use_public_module_includeSantiago Pastorino2016-11-271-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | use public Module#include instead of send :include
| * | | | | | use public Module#include instead of send :includeyuuji.yaginuma2016-11-271-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow up to #18767
* | | | | | | fixing update_all and delete_all when chained with left_joins. fixes #27192Diego Plentz2016-11-271-0/+22
| |/ / / / / |/| | | | |
* | | | | | Merge pull request #26865 from ↵Matthew Draper2016-11-271-0/+16
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | sergey-alekseev/uniqueness-validation-scope-with-polymorphic-association fix the uniqueness validation scope with a polymorphic association
| * | | | | | fix the uniqueness validation scope with a polymorphic associationSergey Alekseev2016-11-261-0/+16
| |/ / / / / | | | | | | | | | | | | | | | | | | https://gist.github.com/sergey-alekseev/946657ebdb5e58d1bee115714056ec96
* | | | | | abort_on_exception can't be disabled for a single threadMatthew Draper2016-11-272-6/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If it's enabled globally, it's on regardless of how individual threads are set.
* | | | | | We expect exceptions; abort will just raise in the wrong placeMatthew Draper2016-11-272-9/+17
|/ / / / /
* | | | | Make the test that seems to be getting stuck noisierMatthew Draper2016-11-261-35/+55
| | | | | | | | | | | | | | | | | | | | | | | | | I assume it's upset because of the change in d314646c965b045724e6bdb9d61dcecfabc0ba8f, but I don't yet understand why.
* | | | | Should test `test_change_column_default` in `PostgresqlUUIDTest`Ryuta Kamizono2016-11-251-13/+13
| | | | | | | | | | | | | | | | | | | | Follow up to #25395.
* | | | | Merge pull request #27171 from kamipo/suppress_migration_messageMatthew Draper2016-11-251-0/+4
|\ \ \ \ \ | | | | | | | | | | | | Suppress migration message in the test
| * | | | | Suppress migration message in the testRyuta Kamizono2016-11-251-0/+4
| | | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 09:21:13 +0000