aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
* this fixes a brittle test in fixtures_test.rb which fails when you are in a ↵Josh Kalderimis2011-07-201-2/+2
| | | | timezone which is ahead of UTC but UTC is in the previous day still.
* ActiveRecord: Fix eager loading so that giving a blank order clause ↵Elliot Winkler2011-07-181-0/+12
| | | | generates valid SQL
* Merge pull request #195 from bigfix/active_model_include_serializationJosé Valim2011-07-182-143/+133
|\ | | | | ActiveModel support for the :include serialization option
| * Move to_xml tests to xml_serialization_test.rbJohn Firebaugh2011-07-172-143/+133
| | | | | | | | | | One duplicate was eliminated: test_to_xml_including_methods/ test_methods_are_called_on_object.
* | Refactor test case to use anonymous class - Thank you @tenderlovePrem Sichanugrist2011-07-181-13/+8
| |
* | Raise an ArgumentError if user passing less number of argument in the ↵Prem Sichanugrist2011-07-172-0/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | dynamic finder The previous behavior was unintentional, and some people was relying on it. Now the dynamic finder will always expecting the number of arguments to be equal or greater (so you can still pass the options to it.) So if you were doing this and expecting the second argument to be nil: User.find_by_username_and_group("sikachu") You'll now get `ArgumentError: wrong number of arguments (1 for 2).` You'll then have to do this: User.find_by_username_and_group("sikachu", nil)
* | Revert "Fix failure in test_preserves_existing_fixture_data from ↵Jon Leighton2011-07-171-2/+2
|/ | | | | | test/cases/fixtures_test.rb when UTC and local time occur on different dates." I am pretty sure this was an incorrect fix, and it still failed in certain circumstances anyway. I am now unable to reproduce the original failure I was experiencing so will leave it for now and see if this pops up again. This reverts commit e4479b2f1bc54edf155408d51dd3236955150ce1.
* Merge pull request #2063 from elight/masterSantiago Pastorino2011-07-141-2/+27
|\ | | | | Patch for https://github.com/rails/rails/issues/2059
| * Fix and unit test for https://github.com/rails/rails/issues/2059Evan Light2011-07-141-2/+27
| | | | | | | | | | | | | | | | | | | | | | | | Cache key was incorrectly using timezone-dependent record#updated_at when it should be using a timezone-independent value to generate the cache key Minor refactoring to cache_key timezone test Closes #2059 Adds a test to validate the format of the cache_key for nil and present updated_at values Correctly handles updated_at == nil
* | Merge pull request #1807 from caius/find_in_batches_id_bugSantiago Pastorino2011-07-141-0/+16
|\ \ | |/ |/| Bugfix by stopping find_in_batches using the records after yielding.
| * Stop find_in_batches using the records after yielding.Caius Durling2011-06-211-0/+16
| | | | | | | | | | | | Currently if the code that calls .find_in_batches modifies the yielded array in place then .find_in_batches can enter an infinite loop searching with ruby object ids in the database instead of the primary key of records in the database. This happens because it naively assumes the yielded array hasn't been modified before calling #id on the last object in the array. And ruby (1.8 at least) alias' #id to #object_id so an integer is still returned no matter what the last object is. By moving finding the #id of the last object before yielding the array it means the calling code can do whatever it wants to the array in terms of modifying it in place, and .find_in_batches doesn't care.
* | Fix failure in test_preserves_existing_fixture_data from ↵Jon Leighton2011-07-121-2/+2
| | | | | | | | test/cases/fixtures_test.rb when UTC and local time occur on different dates.
* | Fix exception if old and new targets are both nil. Fixes #1471.Jon Leighton2011-07-123-1/+14
| |
* | Merge pull request #1929 from sobrinho/masterSantiago Pastorino2011-07-111-0/+14
|\ \ | | | | | | Create a test case for disable_referential_integrity
| * | Create a test case for disable_referential_integrityGabriel Sobrinho2011-07-011-0/+14
| | |
* | | Merge pull request #1823 from gnarg/masterSantiago Pastorino2011-07-101-0/+8
|\ \ \ | | | | | | | | Log instrumentation name for exists? queries
| * | | Log instrumentation name for exists? queriesJon Guymon2011-06-221-0/+8
| | | |
* | | | to_key on a destroyed model should return nilSantiago Pastorino2011-07-091-1/+1
| | | |
* | | | formatsAkira Matsuda2011-07-091-5/+5
| | | |
* | | | fix AR having() not to raise NoMethodError when the given argument does not ↵Akira Matsuda2011-07-091-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | respond to empty? having raises NoMethodError: undefined method `empty?' when a Fixnum or Date/Time were passed via varargs
* | | | Foo.joins(:bar).includes(:bar) should result in a single query with :bar as ↵Jon Leighton2011-07-091-0/+8
| | | | | | | | | | | | | | | | a join. Related: #1873.
* | | | Merge pull request #2017 from Casecommons/active_record_lintJosé Valim2011-07-082-0/+12
|\ \ \ \ | | | | | | | | | | ActiveRecord::Base subclasses should pass ActiveModel::Lint.
| * | | | ActiveRecord::Base should pass ActiveModel::Lint.Grant Hutchins & Peter Jaros2011-07-082-0/+12
| | | | |
* | | | | Destroy association habtm record before destroying the record itself. Fixes ↵Tomas D'Stefano2011-07-082-0/+12
| | | | | | | | | | | | | | | | | | | | issue #402.
* | | | | Ensure that the foreign key gets set when doing record.create_association or ↵Jon Leighton2011-07-081-0/+14
| | | | | | | | | | | | | | | | | | | | record.create_association. Fixes #1960.
* | | | | Refactor PostgreSQLAdapter a bitDaniel Schierbeck2011-07-081-2/+2
|/ / / / | | | | | | | | | | | | | | | | Move the private method #extract_schema_and_table into a separate Utils module so that it can be tested without resorting to #send.
* | | | Use Enumerable#with_index. We're on Ruby > 1.8.7 (part II)Akira Matsuda2011-07-081-3/+1
| | | |
* | | | Make `ActiveRecord::Batches#find_each` to not return `self`.knapo2011-07-071-0/+7
| | | | | | | | | | | | | | | | This caused that `find_each` was producing extra db call taking all the records from db, and was less efficient than `ActiveRecord::Base#all`.
* | | | Fix bug in collection_singular_ids on has many through association with ↵Anatoliy Lysenko2011-07-061-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | conditions and includes, when condtions references tables from includes. Test fail because of invalid sql: ActiveRecord::StatementInvalid: SQLite3::SQLException: no such column: comments.id: SELECT "posts".id FROM "posts" INNER JOIN "readers" ON "posts"."id" = "readers"."post_id" WHERE "readers"."person_id" = 1 AND (comments.id is null) Bug described in github#925 This commit will revert fix from https://github.com/rails/rails/commit/3436fdfc12d58925e3d981e0afa61084ea34736c , but tests is ok. Bug described in #6569 ticket.
* | | | Merge pull request #1273 from jeremyf/feature-association-proxy-sendSantiago Pastorino2011-07-061-0/+9
|\ \ \ \ | | | | | | | | | | Addresses an inconsistency in the ActiveRecord::Base.method_missing handl
| * | | | Addresses an inconsistency in the ActiveRecord::Base.method_missing handling ↵Jeremy Friesen2011-05-241-0/+9
| | | | | | | | | | | | | | | | | | | | of dynamic finder methods and the passing of the &block parameter for :find_by_attributes.
* | | | | Merge pull request #1494 from anildigital/masterSantiago Pastorino2011-07-061-2/+2
|\ \ \ \ \ | | | | | | | | | | | | Fix failing test because of Timezone difference.
| * | | | | Fix failing test because of Timezone difference.Anil Wadghule2011-06-051-2/+2
| | | | | |
* | | | | | Merge pull request #1979 from bogdan/association_sum_array_compatibilityJon Leighton2011-07-061-0/+4
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fixed AR::Relation#sum compatibility with Array#sum
| * | | | | | Fixed AR::Relation#sum compatibility with Array#sumBogdan Gusiev2011-07-051-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In order make Relation behavior closer to Array Made Relation#sum to accept block and delegate it to Array#sum
* | | | | | | Merge pull request #1968 from bogdan/associations_find_array_compatibility2Santiago Pastorino2011-07-051-0/+4
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | Fixed CollectionAssociation#find to be compatible with Array#find
| * | | | | | Fixed CollectionAssociation#find to be compatible with Array#findBogdan Gusiev2011-07-051-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In order to make CollectionAssociation behave closer to Array Add the ability to pass block to #find method just like Array#find does.
* | | | | | | Only call set_owner_attributes for has_one association if target exists.Dieter Komendera2011-07-041-0/+11
|/ / / / / /
* | | | / / Reversing the changes done in c278a2c while still resolving #1857.Vijay Dev2011-07-021-5/+3
| |_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The changes broke bulk migration tests and were fixed in 4d256bc6; however that brought back the issue of #1857 and so this commit goes back to the original scenario and just adds change_table to the list of methods which are to be recorded in the CommandRecorder. The method_missing now delegates all calls to the underlying connection as before.
* | | | | Assign the association attributes to the associated record before the ↵Jon Leighton2011-06-303-2/+21
| | | | | | | | | | | | | | | | | | | | before_initialize callback of the record runs. Fixes #1842.
* | | | | cache the plural name on the reflection so we do not pay pluralize costs on ↵Aaron Patterson2011-06-301-1/+1
| | | | | | | | | | | | | | | | | | | | joins
* | | | | CommandRecorder should delegate in method_missing where possible. Fixes some ↵Jon Leighton2011-06-301-1/+6
| | | | | | | | | | | | | | | | | | | | tests in migration_test.rb under mysql. The problem was introduced in c278a2c5e109204ec8a47fcbfdfc327aad7996ce.
* | | | | Merge pull request #1574 from ↵Aaron Patterson2011-06-281-0/+12
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | oriolgual/1571_ar_relation_order_no_longer_works_with_arel_nodes Fix #1571 ActiveRecord::Relation#order no longer works with arel ordering nodes
| * | | | | Add more test casesOriol Gual2011-06-281-0/+8
| | | | | |
| * | | | | Add failing testOriol Gual2011-06-281-0/+4
| | | | | |
* | | | | | Fix test_finding_with_cross_table_order_and_limit for OracleRaimonds Simanovskis2011-06-281-3/+3
|/ / / / / | | | | | | | | | | Use latest Arel syntax and pass each order by expression as separate argument to order method as otherwise invalid Oracle SQL is generated.
* | | | | Merge pull request #1857 from vijaydev/irreversible-migrationAaron Patterson2011-06-281-3/+5
|\ \ \ \ \ | | | | | | | | | | | | IrreversibleMigration is not raised when a method not supported by reversible migrations is called in the change method of a migration
| * | | | | record unsupported methods in CommandRecorder instead of letting the ↵Vijay Dev2011-06-251-3/+5
| | | | | | | | | | | | | | | | | | | | | | | | unsupported methods go through to the underlying db causing errors like duplicate columns to occur when rolling back migrations
* | | | | | Merge pull request #1860 from dmathieu/comparisonAaron Patterson2011-06-281-0/+13
|\ \ \ \ \ \ | | | | | | | | | | | | | | Allow comparison on model objects - Closes #1858
| * | | | | | comparing different classes returns nilDamien Mathieu2011-06-261-0/+6
| | | | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-06 01:00:00 +0000