aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
* Remove migration constants to avoid method redefined warningsAndrew White2016-11-031-0/+4
|
* Remove unused local variableAndrew White2016-11-031-1/+0
|
* Fix indentingAndrew White2016-11-021-6/+6
|
* Fix File.exists? deprecation warnings in Active RecordAndrew White2016-11-022-19/+19
|
* Fix warning about unset I18n.enforce_available_localesAndrew White2016-11-021-0/+3
|
* Use Ruby 1.8 compat syntax in test of security fix in ↵Josef Šimánek2016-01-261-4/+4
| | | | activerecord/test/cases/nested_attributes_test.rb.
* Don't short-circuit reject_if procAndrew White2016-01-221-0/+13
| | | | | | | | | | | | | When updating an associated record via nested attribute hashes the reject_if proc could be bypassed if the _destroy flag was set in the attribute hash and allow_destroy was set to false. The fix is to only short-circuit if the _destroy flag is set and the option allow_destroy is set to true. It also fixes an issue where a new record wasn't created if _destroy was set and the option allow_destroy was set to false. CVE-2015-7577
* Check against bit string values using multiline regexpRafael Mendonça França2014-07-021-0/+5
| | | | Fix CVE-2014-3482.
* Revert "Merge pull request #12413 from arthurnn/inverse_of_on_build"Rafael Mendonça França2013-10-101-3/+1
| | | | | | | | | This reverts commit ccd11d58910059f07b28cc518dbdad42cbc8ea0c, reversing changes made to 54c05acdba138f3a7a3d44dfc922b0fe4e4cf554. Reason: This caused a regression when the associated record is created in a before_create callback. See https://github.com/rails/rails/pull/12413#issuecomment-25848163
* Revert "Merge pull request #12443 from arthurnn/add_inverse_of_add_target"Rafael Mendonça França2013-10-101-13/+0
| | | | | | | | | | This reverts commit 7ed5bdc834479c39e3b0ad5a38bcffe27983c10d, reversing changes made to 31c79e291f42b1d862df06c552fe002864aae705. Reason: this caused a regression when the associated record is creted in a before_create callback. See https://github.com/rails/rails/pull/12413#issuecomment-25848163
* add regression test for set_inverse_instance on add_to_targetArthur Neves2013-10-041-0/+13
|
* Merge pull request #12084 from Ben-M/3-2-stableAaron Patterson2013-10-032-0/+10
|\ | | | | Fix STI scopes using benolee's suggestion. Fixes #11939
| * Fix STI scopes using benolee's suggestion. Fixes #11939Ben Maraney2013-08-302-0/+10
| |
* | Move set_inverse_instance to association.build_recordArthur Neves2013-09-301-1/+3
| | | | | | | | [fixes #10371]
* | fix inverse_of when find_or_initialize_by_*Arthur Neves2013-09-261-0/+11
| | | | | | | | | | inverse_of relation was not being set when calling find_or_initialize_by_ and the entry was found on the db.
* | on tests: dont always touch firm on validateArthur Neves2013-09-252-2/+5
| |
* | Merge pull request #12359 from arthurnn/inverse_on_callbacksRafael Mendonça França2013-09-252-1/+12
| | | | | | | | | | | | | | Make sure inverse_of is visible on the has_many callbacks Conflicts: activerecord/CHANGELOG.md activerecord/test/models/company.rb
* | Fix FinderMethods#last unscoped primary keyEugene Kalenkovich2013-09-121-0/+14
|/ | | | | | | | Fixes table.joins(:relation).last(N) breaking on sqlite Conflicts: activerecord/CHANGELOG.md activerecord/test/cases/finder_test.rb
* Load fixtures from linked foldersKassio Borges2013-08-052-1/+2
|
* Fix broken testRafael Mendonça França2013-07-241-1/+1
| | | | quote_value is called on the object not the class
* Tidy up the "Specified column type for quote_value" changesBen Woosley2013-07-241-1/+0
| | | | | | | | | | This includes fixing typos in changelog, removing a deprecated mocha/setup test require, and preferring the `column_for_attribute` accessor over direct access to the columns_hash in the new code. Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/locking/optimistic.rb
* Specified column type for quote_valueAlfred Wong2013-07-241-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | When calling quote_value the underlying connection sometimes requires more information about the column to properly return the correct quoted value. I ran into this issue when using optimistic locking in JRuby and the activerecord-jdbcmssql-adapter. In SQLSever 2000, we aren't allowed to insert a integer into a NVARCHAR column type so we need to format it as N'3' if we want to insert into the NVARCHAR type. Unfortuantely, without the column type being passed the connection adapter cannot properly return the correct quote value because it doesn't know to return N'3' or '3'. This patch is fairly straight forward where it just passes in the column type into the quote_value, as it already has the ability to take in the column, so it can properly handle at the connection level. I've added the tests required to make sure that the quote_value method is being passed the column type so that the underlying connection can determine how to quote the value. Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/locking/optimistic.rb
* Fix merge error when Equality LHS is non-attribute.90yukke2013-07-231-0/+15
| | | | This is reworking of rails/rails/pull/7380 made for rails 3.
* Use Ruby 1.8 syntaxRafael Mendonça França2013-07-151-1/+1
|
* Merge pull request #11451 from ↵Yves Senn2013-07-151-0/+7
| | | | | | | | | | | jetthoughts/11450_do_not_resave_destroyed_association Do not re-save destroyed association on saving parent object Conflicts: activerecord/lib/active_record/autosave_association.rb Conflicts: activerecord/CHANGELOG.md
* Skip connection url test when the machine is using socket configuration.Rafael Mendonça França2013-07-061-0/+3
| | | | The connection url parssing don't accept the socket option
* Merge pull request #11019 from tkhr/test_case_for_issue_10393Yves Senn2013-06-251-0/+23
|\ | | | | Add test case for issue #10393 and fix warning message
| * Allow global override of default STI inheritance columnchapmajs2013-06-261-0/+23
| | | | | | | | | | | | This change fixes a bug by which 3.2-STABLE users can't globally override the default STI inheritance column with `ActiveRecord::Base.inheritance_column = 'some_column'`. 3.2-STABLE users are forced to use a deprecated method or monkey patch it otherwise. Test case written by tkhr <takehiro0740@gmail.com>.
* | build fix, fall back to old hash syntaxYves Senn2013-06-261-3/+3
|/
* Merge pull request #9893 from ↵Yves Senn2013-06-251-0/+13
|\ | | | | | | | | JonRowe/add_test_to_assert_association_doesnt_overwrite Add a test to assert autosaving associations doesn't overwrite id accessor methods
| * test case to assert that associations do not overwrite after create, fixes #9310Jon Rowe2013-03-241-0/+13
| |
* | Merge pull request #10373 from janko-m/fix-store-accessorCarlos Antonio da Silva2013-06-251-0/+7
|\ \ | | | | | | | | | Fix a bug in ActiveRecord::Store accessors
| * | Fix ActiveRecord::Store not tracking changesJanko Marohnić2013-04-291-0/+7
| | |
* | | Revert "Revert "Merge pull request #10901 from ↵Yves Senn2013-06-251-0/+27
| | | | | | | | | | | | | | | | | | | | | | | | armstrjare/fix_query_null_foreign_key_on_new_record_collection_ids_reader"" This reverts commit 5009b078875e596a2fba7827336f7548aa6e35ac. Also updated the CHANGELOG and adjusted the test-case to match the one on master.
* | | Revert "Merge pull request #10901 from ↵Yves Senn2013-06-221-27/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | armstrjare/fix_query_null_foreign_key_on_new_record_collection_ids_reader" This reverts commit 6675d713186c270de1c4684bc1e56742ea2e19e1, reversing changes made to 919d1a19d5e7871d50c1531351fc3f736bad5d07. I missed to check the target branch and wrongly merged it into 3-2-stable directly.
* | | Merge pull request #10901 from ↵Yves Senn2013-06-221-0/+27
|\ \ \ | | | | | | | | | | | | | | | | armstrjare/fix_query_null_foreign_key_on_new_record_collection_ids_reader Fixes CollectionAssociation#ids_reader returning incorrect ids for new records
| * | | Fixes CollectionAssociation#ids_reader returning incorrect ids for new recordsJared Armstrong2013-06-211-0/+27
| | | |
* | | | Merge pull request #10925 from senny/10917_test_to_prevent_regressionYves Senn2013-06-151-0/+26
|/ / / | | | | | | | | | | | | | | | | | | regression test + mysql2 adapter raises correct error if conn is closed. Conflicts: activerecord/CHANGELOG.md
* | | adding a test for #10830Aaron Patterson2013-06-051-0/+46
| | |
* | | Using 1.8.7 syntax for 3-2-stableArun Agrawal2013-05-243-6/+6
| | |
* | | Merge pull request #10713 from senny/10693_fix_primary_key_option_on_has_manyRafael Mendonça França2013-05-232-0/+9
| | | | | | | | | | | | | | | | | | | | | Fix the `:primary_key` option for `has_many` associations. Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/associations/has_many_association.rb
* | | destroys association records before saving/inserting new association recordsJohnny Holton2013-05-181-3/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a backport of #10417 fixes bug introduced by #3329 These are the conditions necessary to reproduce the bug: - For an association, autosave => true. - An association record is being destroyed - A new association record is being created. - There is a unique index one of the association's fields. - The record being created has the same value as the record being destroyed on the indexed field. Before, the deletion of records was postponed until after all insertions/saves. Therefore the new record with the identical value in the indexed field caused a non-unique value error to be thrown at the database level. With this fix, the deletions happen first, before the insertions/saves. Therefore the record with the duplicate value is gone from the database before the new record is created, thereby avoiding the non-uniuqe value error.
* | | Backport a super-simplified version of #6792, fixingBen Woosley2013-05-141-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | that #exists? and others can produce invalid SQL: "SELECT DISTINCT DISTINCT" The combination of a :uniq => true association and the #distinct call in #construct_limited_ids_condition combine to create invalid SQL, because we're explicitly selecting DISTINCT, and also sending #distinct on to AREL, via the relation#distinct_value. Where #6792 was the forever fix, this is the minimal fix. Instead of properly indicating the distinctness of the query through #uniq_value alone, we use a literal select statement and set #uniq_value to always be falsey
* | | Preserve context for joins while merging relationsAndrew Horner2013-05-111-1/+8
| | | | | | | | | | | | | | | | | | This is a backport of #10164, already merged into master. The issue is described in lengthy detail in issues #3002 and #5494.
* | | Don't try to EXPLAIN select_db callsDaniel Schierbeck2013-05-121-0/+7
| | | | | | | | | | | | Now with a non-broken test.
* | | Revert "Don't try to EXPLAIN select_db calls"Xavier Noria2013-05-111-7/+0
| | | | | | | | | | | | | | | | | | Reason: This was backported, but the test does not pass as is. This reverts commit a33d320cf4b57fabd9c299b09c217ee3955ecc77.
* | | Merge pull request #10555 from dasch/dasch/3-2-stableXavier Noria2013-05-101-0/+7
|\ \ \ | | | | | | | | Don't try to EXPLAIN select_db calls
| * | | Don't try to EXPLAIN select_db callsDaniel Schierbeck2013-05-101-0/+7
| |/ /
* | | Fixed pluck to be working with selects.Arun Agrawal2013-05-101-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See #9777 for details. Previously pluck is not returning what we wanted to Added a test also to make sure it's working fine. This will also fix the build for 1.8.7 as we were doing some sort on hash. Thanks @pixeltrix for helping me out. Thanks @linduxed for pairing with me.
* | | Revert "Merge pull request #8209 from senny/backport_8176"Rafael Mendonça França2013-05-081-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 724020278480855bddfe749c91f1074d4f50f3c6, reversing changes made to e4e2bcce75b85fb8c1c49509a17bd5dfe6034c32. Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/relation/calculations.rb activerecord/test/cases/calculations_test.rb Reason: This caused a regression since it changed the behavior in a stable release. Fixes #9777
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-28 21:34:36 +0000