aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
...
* | | ActiveRecord::Base.all returns a Relation.Jon Leighton2012-07-2728-305/+313
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously it returned an Array. If you want an array, call e.g. `Post.to_a` rather than `Post.all`. This is more explicit. In most cases this should not break existing code, since Relations use method_missing to delegate unknown methods to #to_a anyway.
* | | Modify the preference attribute from `:null => false` to `:null => true`Yasuo Honda2012-07-271-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | to address ORA-01400 errors with Oracle enhanced adapter. Issue #4856 had been fixed and tested with the attribute `:null => false, :default => ""`. Now `:null => false` attribute is not necessary to test this issue.
* | | Refactor ActiveRecord::Inheritance.base_class logicbeerlington2012-07-262-12/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | Moved logic from class_of_active_record_descendant(class) to the base_class method. This method was confusing because it required an argument, but that argument was 'self'. Moved base_class tests to inheritance_test.rb and added some test coverage for some untested cases.
* | | Merge pull request #6654 from stevecj/postgresql-auto-reconnect-2Aaron Patterson2012-07-252-0/+74
|\ \ \ | | | | | | | | Postgresql auto reconnect 2
| * | | Stop being silly with formatting of method aliasing.Steve Jorgensen2012-07-161-3/+3
| | | |
| * | | Simulated & actual (manual/skipped) PostgreSQL auto-reconnection tests.Steve Jorgensen2012-07-162-0/+74
| | | |
* | | | Use string datatype for the setting attributeYasuo Honda2012-07-261-1/+1
| | | | | | | | | | | | | | | | to make store works all database adapters.
* | | | Deprecate update_column in favor of update_columns.Rafael Mendonça França2012-07-2412-43/+64
| | | | | | | | | | | | | | | | Closes #1190
* | | | Use update_columns to implemente the update_columnRafael Mendonça França2012-07-241-2/+36
| | | |
* | | | New #update_columns method.Sebastian Martinez2012-07-241-0/+57
| | | |
* | | | This pull requests addresses ORA-01400 errors and also supports #6115 issue ↵Yasuo Honda2012-07-251-1/+1
| |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | tested. Issue #6115 has been fixed and tested with the attribute `:null => false, :default => ""` However `:null => false` attribute is not necessary to test this issue, which causes many ORA-01400 errors with Oracle enhanced adapter.
* | | Restore connection_id on error.kennyj2012-07-231-0/+12
| | |
* | | rm unnecessary testJon Leighton2012-07-203-12/+0
| | | | | | | | | | | | | | | interpolation is no longer a thing separate from "normal" assoc conditions.
* | | rm redundant testJon Leighton2012-07-202-9/+0
| | | | | | | | | | | | now everything is converted to the new style, this is not needed
* | | Remove :finder_sql, :counter_sql, :insert_sql, :delete_sql.Jon Leighton2012-07-206-197/+3
| | |
* | | Convert association macros to the new syntaxJon Leighton2012-07-2015-134/+135
| | |
* | | Merge pull request #7078 from kennyj/logging_query_planRafael Mendonça França2012-07-191-0/+10
|\ \ \ | | | | | | | | Log query plan when we use count_by_sql method.
| * | | Log query plan when we use count_by_sql method.kennyj2012-07-181-0/+10
| | | |
* | | | revert Default timestamps to non-nullDave Kroondyk2012-07-182-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit 3dbedd2 added NOT NULL constraints to timestamps. Commit fcef728 started to revert this, but was incomplete. With this commit, 3dbedd2 should be fully reverted and timestamps will no longer default to NOT NULL.
* | | | Merge pull request #7028 from lexmag/join_table_indexesJosé Valim2012-07-181-3/+17
|\ \ \ \ | | | | | | | | | | Add indexes to create_join_table method
| * | | | Add join table migration generatorAleksey Magusev2012-07-181-3/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For instance, running rails g migration CreateMediaJoinTable artists musics:uniq will create a migration with create_join_table :artists, :musics do |t| # t.index [:artist_id, :music_id] t.index [:music_id, :artist_id], unique: true end
* | | | | AR::Integration must be included after AM::ConversionJohn Firebaugh2012-07-171-0/+6
| |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | Integration's definition of #to_param must override Conversion's. Otherwise, there is a regression from 3.1 in the behavior of a non-persisted AR::Base instance which nevertheless has an id.
* | | | Merge pull request #7076 from kennyj/fix_class_evalAaron Patterson2012-07-172-3/+3
|\ \ \ \ | | | | | | | | | | Fix class_eval without __FILE__ and __LINE__.
| * | | | Fix class_eval without __FILE__ and __LINE__.kennyj2012-07-182-3/+3
| | |/ / | |/| |
* / | | Fixes "Cannot visit ..." with validates_uniqueness_ofbeerlington2012-07-171-0/+16
|/ / / | | | | | | | | | | | | | | | Fixes issue with overrding ActiveRecord reader methods with a composed object and using that attribute as the scope of a validates_uniqueness_of validation.
* | | Fix SqlBypass.data_column= problem. SqlBypass.find_by_session_id method ↵kennyj2012-07-151-0/+14
| | | | | | | | | | | | didn't use this assignment.
* | | teaching the mysql adapter how to typecast strings returned from the databaseAaron Patterson2012-07-131-2/+2
| | |
* | | fixing tests to deal with data differences between prepared statements and ↵Aaron Patterson2012-07-133-3/+8
| | | | | | | | | | | | | | | | | | | | | non-prepared statements Conflicts: activerecord/test/cases/query_cache_test.rb
* | | fix association :extend optionJon Leighton2012-07-132-3/+6
| | |
* | | stop using class_attribute where methods/inheritance will suffice.Jon Leighton2012-07-131-16/+0
| | |
* | | Represent association scope options as AR::Relations insternally.Jon Leighton2012-07-132-19/+38
| | |
* | | fix assertion arguments orderJon Leighton2012-07-131-2/+2
| | |
* | | Allow associations to take a lambda which builds the scopeJon Leighton2012-07-134-23/+32
| | |
* | | support relations created with a table aliasJon Leighton2012-07-131-0/+10
| | |
* | | Add teardown method to AR::Mig::RenameTableTestRobb Kidd2012-07-101-18/+13
| | | | | | | | | | | | | | | | | | | | | Dry up reseting the renamed table after each test. Also made use of the AR::Base.connection object already available from AR::MigrationTest#connection.
* | | Merge pull request #6874 from robbkidd/rename_sequences_tooAaron Patterson2012-07-101-0/+13
|\ \ \ | |/ / |/| | Rename default sequence when table is renamed? [AR:postgres]
| * | Update psql adapter to rename a default pkey sequence when renaming a table.Robb Kidd2012-06-271-0/+13
| | |
* | | Merge pull request #6838 from kennyj/added_registration_taskCarlos Antonio da Silva2012-07-071-0/+16
|\ \ \ | | | | | | | | Allow to register database tasks from different adapters
| * | | Added a feature to add a database task. e.g. OracleDatabaseTaskskennyj2012-06-241-0/+16
| | | |
* | | | Relation#inspect handles doesn't perform a new query on an already-loaded ↵Jon Leighton2012-07-071-1/+12
| | | | | | | | | | | | | | | | relation
* | | | Merge pull request #6997 from kennyj/fix_stored_attributesJosé Valim2012-07-072-0/+14
|\ \ \ \ | | | | | | | | | | Added *instance_writer: false* to stored/serialized attributes.
| * | | | Added *instance_writer: false* for stored/serialized attributes.kennyj2012-07-072-0/+14
| | | | |
* | | | | Limit the number of records in Relation#inspectDamien Mathieu2012-07-061-0/+5
|/ / / / | | | | | | | | | | | | While it's interesting to have the results array, it can make a console or a webpage freeze if there are a lot of them. So this limits the number of records displayed in #inspect to 10 and tells how much were effectively found.
* | | | Merge pull request #6985 from sidonath/disable-query-cache-for-locksRafael Mendonça França2012-07-061-0/+8
|\ \ \ \ | | | | | | | | | | Disable query cache for lock queries
| * | | | Disable query cache for lock queriesDamir Zekic2012-07-061-0/+8
| | | | | | | | | | | | | | | | | | | | Fixes #867
* | | | | Show the records in Relation#inspectJon Leighton2012-07-061-0/+5
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The reason for removing the previous implementation of `#inspect` was that it hid from you that you were dealing with a `Relation` rather than an `Array`. But it is still useful to be able to see the records, particularly if you're writing something like the following in tests: assert_equal [foo], Post.where(:bar) If the assertion fails, you want to see what records were actually loaded. So this implementation makes it clear that you've got a `Relation`, but also shows your records.
* | | | Merge pull request #6927 from parndt/patch-3Carlos Antonio da Silva2012-07-051-1/+1
|\ \ \ \ | | | | | | | | | | Make ArgumentError message more consistent in nested attributes
| * | | | Made ArgumentError messages consistent.Philip Arndt2012-07-061-1/+1
| | |_|/ | |/| |
* | | | fix quoting for ActiveSupport::Duration instancesFrancesco Rodriguez2012-07-042-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch fixes quoting for ActiveSupport::Duration instances: # before >> ActiveRecord::Base.connection.quote 30.minutes => "'--- 1800\n...\n'" # after >> ActiveRecord::Base.connection.quote 30.minutes => "1800" Also, adds a test for type casting ActiveSupport::Duration instances. Related to #1119.
* | | | remove duplicate requires of mocha.Aaron Patterson2012-07-031-1/+0
| | | | | | | | | | | | | | | | | | | | Mocha is already required by AS::TestCase, so remove the duplicate requires.