| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Previously it returned an Array.
If you want an array, call e.g. `Post.to_a` rather than `Post.all`. This
is more explicit.
In most cases this should not break existing code, since
Relations use method_missing to delegate unknown methods to #to_a
anyway.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
to address ORA-01400 errors with Oracle enhanced adapter.
Issue #4856 had been fixed and tested with
the attribute `:null => false, :default => ""`.
Now `:null => false` attribute is not necessary to test this issue.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Moved logic from class_of_active_record_descendant(class) to the
base_class method. This method was confusing because it required
an argument, but that argument was 'self'.
Moved base_class tests to inheritance_test.rb and added some test
coverage for some untested cases.
|
|\ \ \
| | | |
| | | | |
Postgresql auto reconnect 2
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
to make store works all database adapters.
|
| | | |
| | | |
| | | |
| | | | |
Closes #1190
|
| | | | |
|
| | | | |
|
| |_|/
|/| |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
tested.
Issue #6115 has been fixed and tested with
the attribute `:null => false, :default => ""`
However `:null => false` attribute is not necessary to test this issue,
which causes many ORA-01400 errors with Oracle enhanced adapter.
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
interpolation is no longer a thing separate from "normal" assoc
conditions.
|
| | |
| | |
| | |
| | | |
now everything is converted to the new style, this is not needed
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
Log query plan when we use count_by_sql method.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Commit 3dbedd2 added NOT NULL constraints to timestamps.
Commit fcef728 started to revert this, but was incomplete.
With this commit, 3dbedd2 should be fully reverted and
timestamps will no longer default to NOT NULL.
|
|\ \ \ \
| | | | |
| | | | | |
Add indexes to create_join_table method
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
For instance, running
rails g migration CreateMediaJoinTable artists musics:uniq
will create a migration with
create_join_table :artists, :musics do |t|
# t.index [:artist_id, :music_id]
t.index [:music_id, :artist_id], unique: true
end
|
| |/ / /
|/| | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Integration's definition of #to_param must override
Conversion's. Otherwise, there is a regression from
3.1 in the behavior of a non-persisted AR::Base instance
which nevertheless has an id.
|
|\ \ \ \
| | | | |
| | | | | |
Fix class_eval without __FILE__ and __LINE__.
|
| | |/ /
| |/| | |
|
|/ / /
| | |
| | |
| | |
| | |
| | | |
Fixes issue with overrding ActiveRecord reader methods with a
composed object and using that attribute as the scope of a
validates_uniqueness_of validation.
|
| | |
| | |
| | |
| | | |
didn't use this assignment.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
non-prepared statements
Conflicts:
activerecord/test/cases/query_cache_test.rb
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Dry up reseting the renamed table after each test.
Also made use of the AR::Base.connection object already
available from AR::MigrationTest#connection.
|
|\ \ \
| |/ /
|/| | |
Rename default sequence when table is renamed? [AR:postgres]
|
| | | |
|
|\ \ \
| | | |
| | | | |
Allow to register database tasks from different adapters
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
relation
|
|\ \ \ \
| | | | |
| | | | | |
Added *instance_writer: false* to stored/serialized attributes.
|
| | | | | |
|
|/ / / /
| | | |
| | | |
| | | | |
While it's interesting to have the results array, it can make a console or a webpage freeze if there are a lot of them.
So this limits the number of records displayed in #inspect to 10 and tells how much were effectively found.
|
|\ \ \ \
| | | | |
| | | | | |
Disable query cache for lock queries
|
| | | | |
| | | | |
| | | | |
| | | | | |
Fixes #867
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The reason for removing the previous implementation of `#inspect` was
that it hid from you that you were dealing with a `Relation` rather than
an `Array`.
But it is still useful to be able to see the records, particularly if you're
writing something like the following in tests:
assert_equal [foo], Post.where(:bar)
If the assertion fails, you want to see what records were actually
loaded.
So this implementation makes it clear that you've got a `Relation`, but
also shows your records.
|
|\ \ \ \
| | | | |
| | | | | |
Make ArgumentError message more consistent in nested attributes
|
| | |_|/
| |/| | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This patch fixes quoting for ActiveSupport::Duration instances:
# before
>> ActiveRecord::Base.connection.quote 30.minutes
=> "'--- 1800\n...\n'"
# after
>> ActiveRecord::Base.connection.quote 30.minutes
=> "1800"
Also, adds a test for type casting ActiveSupport::Duration instances.
Related to #1119.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Mocha is already required by AS::TestCase, so remove the duplicate
requires.
|