aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
* Save has_one associations only if record has changesAlan Kennedy2013-10-311-0/+15
| | | | | | Prevents save related callbacks such as `after_commit` being triggered when `has_one` objects are already persisted and have no changes.
* :cut: whitespaceAaron Patterson2013-10-301-2/+2
|
* fix code typo in `MysqlAdapter` .Closes #12647.Yves Senn2013-10-301-0/+15
|
* short arrays in inspectJan Bernacki2013-10-301-0/+5
|
* Fix broken delete_all test, which will now be failing since #delete_all is ↵David Heinemeier Hansson2013-10-281-4/+4
| | | | broken
* Add failing test for preloading with a polymorphic association and using the ↵David Heinemeier Hansson2013-10-281-1/+10
| | | | existential predicate
* Merge pull request #12578 from ↵Rafael Mendonça França2013-10-271-1/+10
|\ | | | | | | | | | | | | | | | | jeradphelps/configurable_schema_migrations_table_name Configurable name for schema_migrations table Conflicts: activerecord/CHANGELOG.md
| * added schema_migrations_table_name to ActiveRecord::Base in order that the ↵Jerad Phelps2013-10-271-1/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | name of the schema migrations table can be configured. consolidated test_schema_migrations_table_name tests Added changelog entry edited changelog removed commented lines removed reader ensure the schema migrations table is reset at end of test added entry to configuration guide guides typo and changelog order
* | Assert the return value in the testRafael Mendonça França2013-10-271-1/+1
| |
* | Skip `include_values` from through associations chains for building target scopePaul Nikitochkin2013-10-272-0/+7
| | | | | | | | Fixes: #12242, #9517, #10240
* | Merge pull request #12643 from severin/pg_cast_json_on_writeYves Senn2013-10-251-0/+7
|\ \ | | | | | | cast json values on write to be consistent with reading from the db.
| * | cast json values on write to be consistent with reading from the db.Severin Schoepke2013-10-251-0/+7
| | | | | | | | | | | | See also commit 5ac2341fab689344991b2a4817bd2bc8b3edac9d
* | | prevent `time_zone_aware_attributes` test leak. follow-up to #12633.Yves Senn2013-10-251-21/+21
| | |
* | | only warn on leaked time zone state instead of rasing an error.Yves Senn2013-10-251-3/+6
| | | | | | | | | | | | | | | | | | Raising `RuntimeErrors` skips important cleanup code and leads to a lot of subsequent errors. This clutters the test output with a lot of noise.
* | | Merge pull request #12633 from senny/no_more_time_zone_leaksYves Senn2013-10-2512-214/+223
|\ \ \ | |/ / |/| | prevent global timezone state from leaking out of test cases.
| * | prevent global timezone state from leaking out of test cases.Yves Senn2013-10-2512-214/+223
| | |
* | | `ActiveRecord::Store` works together with PG `hstore` columns.Yves Senn2013-10-251-0/+21
| | | | | | | | | | | | | | | | | | This is necessary because as of 5ac2341 `hstore` columns are always stored as `Hash` with `String` keys. `ActiveRecord::Store` expected the attribute to be an instance of `HashWithIndifferentAccess`, which led to the bug.
* | | `stored_attributes` need to be specific to a subclass.Yves Senn2013-10-251-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently they are all stored globally in the same `Hash`. This commit forces the creation of a per-class variable if necessary. The behavior was exposed through the following test-case: ``` 1) Failure: StoreTest#test_all_stored_attributes_are_returned [/Users/senny/Projects/rails/activerecord/test/cases/store_test.rb:151]: --- expected +++ actual @@ -1 +1 @@ -[:color, :homepage, :favorite_food] +[:resolution, :color, :homepage, :favorite_food] ```
* | | test to verify the `ActiveRecord::Store` behavior with PG's json typeYves Senn2013-10-251-0/+18
| | |
* | | Merge pull request #12621 from ↵Rafael Mendonça França2013-10-241-0/+11
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | laurocaetano/fix_has_one_association_with_primary_key_set Save association when primary key is manually set Conflicts: activerecord/CHANGELOG.md
| * | Save association when primary key is manually setlaurocaetano2013-10-241-0/+11
| | |
* | | Fix order dependent testsRafael Mendonça França2013-10-221-4/+4
| | |
* | | Merge branch 'master' into joindepAaron Patterson2013-10-217-10/+80
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (23 commits) Escape the parentheses in the default function regexp Update docs on Tilt::Template in Asset Pipeline guide Fix loading a sql structure file on postgres when the file's path has whitespace in it remove trailing whitespace added with b057765 [ci skip]. Allow unscope to work with `where.not` Raise an exception when model without primary key calls .find_with_ids Process sub-query relation's binding values Instrument the generation of Action Mailer messages Remove extra variable creation and merge. In Relation#empty? use #exists? instead of #count. [ci skip] avoid deprecation warning in sample code Convert Fixnum into String the port number in MySQL Fix some indentation on autosave association Make define_non_cyclic_method simpler Add Sass gobbling info to asset pipeline docs Ensure the state is clean after one failure Fix typo in form_helper.rb add a new local variable to track if digests are being stored, to ensure the cleanup works correctly [ci skip] Fix number of methods added by association. update digestor code based on review ...
| * \ \ Merge pull request #12588 from jetthoughts/12586_subquery_with_unprepared_sqlRafael Mendonça França2013-10-212-4/+38
| |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Inline bind values for sub-queries generated for Relation in where Conflicts: activerecord/CHANGELOG.md
| | * | | Process sub-query relation's binding valuesPaul Nikitochkin2013-10-202-4/+38
| | |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Generated sub-query for Relation as array condition for `where` method did not take in account its bind values, in result generates invalid SQL query. Fixed by adding sub-query relation's binding values to base relation Closes: #12586
| * | | Escape the parentheses in the default function regexpRafael Mendonça França2013-10-211-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This is causing every default value in PostreSQL database to being handled as default function. Fixes #12581
| * | | Fix loading a sql structure file on postgres when the file's path has ↵Kevin Mook2013-10-211-0/+7
| | | | | | | | | | | | | | | | whitespace in it
| * | | remove trailing whitespace added with b057765 [ci skip].Yves Senn2013-10-211-2/+2
| | | |
| * | | Allow unscope to work with `where.not`Eric Hankins2013-10-211-6/+14
| | | | | | | | | | | | | | | | | | | | | | | | Allows you to call #unscope on a relation with negative equality operators, i.e. Arel::Nodes::NotIn and Arel::Nodes::NotEqual that have been generated through the use of where.not.
| * | | Raise an exception when model without primary key calls .find_with_idsShimpei Makimoto2013-10-211-0/+7
| |/ /
| * / Convert Fixnum into String the port number in MySQLKenta Okamoto2013-10-181-0/+9
| |/
* | Merge branch 'master' into joindepAaron Patterson2013-10-151-1/+1
|\| | | | | | | | | | | | | | | | | | | | | * master: use the cached arel table Fix typo in the changelog entry Don't remove the select values to add they back again Pluck on NullRelation accepts a list of columns Conflicts: activerecord/lib/active_record/relation/finder_methods.rb
| * Pluck on NullRelation accepts a list of columnsDerek Prior2013-10-151-1/+1
| | | | | | | | | | | | `pluck` was updated to accept a list of columns, but the `NullRelation` was never updated to match that signature. As a result, calling `pluck` on a `NullRelation` results in an `ArgumentError`.
* | Merge branch 'master' into joindepAaron Patterson2013-10-1516-14/+99
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (44 commits) grammar fix (reverted in e9a1ecd) Revert "fixed a doc bug in the CHANGELOG.md s/does no longer depend on/no longer depends on/" Add missed require making `enable_warnings` available Prepare generated Gemfile for Capistrano 3 Added --model-name option scaffold_controller_generator. read the association instead of sending we should have unique sponsorable ids in the fixtures at least simplify populating the ordering hash the preloader for the RHS has all the preloaded records, so ask it only calculate offset index once. #12537 Remove size alias for length validation Fix `singleton_class?` Minor Refactoring to `NumberHelper#number_to_human` `$SAFE = 4;` has been removed with Ruby 2.1 scope_chain should not be mutated for other reflections Remove `default_primary_key_type` and extract contains of `native_database_types` to a constant since they aren't conditional now in SQLite3Adapter. Makes it more like other adapters. cleanup changelog entry format. [ci skip] Extract a function to determine if the default value is a function Push default_function to superclass to avoid method check Dump the default function when the primary key is uuid ... Conflicts: activerecord/lib/active_record/relation/finder_methods.rb
| * we should have unique sponsorable ids in the fixtures at leastAaron Patterson2013-10-141-1/+1
| |
| * scope_chain should not be mutated for other reflectionsNeeraj Singh2013-10-147-0/+51
| | | | | | | | | | | | | | | | | | | | | | Currently `scope_chain` uses same array for building different `scope_chain` for different associations. During processing these arrays are sometimes mutated and because of in-place mutation the changed `scope_chain` impacts other reflections. Fix is to dup the value before adding to the `scope_chain`. Fixes #3882.
| * Merge pull request #9499 from ↵Rafael Mendonça França2013-10-141-0/+12
| |\ | | | | | | | | | | | | | | | | | | | | | | | | dmitry/inverse_instance_should_not_be_reloaded_after_stale_state_change Inversed instance should not be reloaded after stale state was changed Conflicts: activerecord/CHANGELOG.md
| | * inversed instance should not be reloaded after stale state was changedDmitry Polushkin2013-10-131-0/+12
| | | | | | | | | check at association reader that record is inverted and should not be reloaded because of stale was changed at target record
| * | Merge pull request #11833 from vipulnsward/remove_autoincrementRafael Mendonça França2013-10-141-5/+2
| |\ \ | | | | | | | | Remove sqlite specific`supports_autoincrement?` which defaults to true
| | * | Remove sqlite specific`supports_autoincrement?` which always defaults to trueVipul A M2013-08-101-5/+2
| | | |
| * | | Dump the default function when the primary key is uuidRafael Mendonça França2013-10-141-2/+2
| | |/ | |/| | | | | | | Fixes #12489
| * | Merge pull request #12518 from vipulnsward/remove_count_optionsRafael Mendonça França2013-10-131-1/+1
| |\ \ | | | | | | | | `Relation#count` doesn't use options anymore.
| | * | Stop accepting `options` for `Relation#average`, `Relation#minimum`, ↵Vipul A M2013-10-141-1/+1
| | | | | | | | | | | | | | | | `Relation#maximum`, `Relation#calculate`, `perform_calculation`, `NullRelation#calculate` as they isn't used anymore.
| * | | Merge pull request #12508 from ↵Rafael Mendonça França2013-10-132-0/+11
| |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | jetthoughts/12415_generate_subqueries_for_relation_from_binding_params Generate subquery for Relation passed as array condition for where Conflicts: activerecord/CHANGELOG.md
| | * | | Generate subquery for Relation passed as array condition for wherePaul Nikitochkin2013-10-132-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of executing 2 queries for fetching records filtered by array condition with Relation, added generation of subquery to current query. This behaviour will be consistent when passes Relation as hash condition to where Closes: #12415
| * | | | Merge pull request #12456 from razielgn/ar-test-fixesRafael Mendonça França2013-10-133-5/+11
| |\ \ \ \ | | |_|/ / | |/| | | Fixed MRI dependent stuff in AR tests
| | * | | Allow methods arity below -1 in assert_responds.Federico Ravasio2013-10-081-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Every method from MRI's core classes is written in C. This means Method#arity always returns -1 for methods with a variable number of arguments. This is not the case with Rubinius, where, for example Array#slice! is implemented in Ruby and has arity -2, since is defined as def slice!(start, length = undefined)
| | * | | Assert presence of "frozen" in error message, not the full MRI message.Federico Ravasio2013-10-081-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Related to all the other issues regarding message independent assertions to make Rails compatible with other Ruby implementations other than MRI. The best way here would be to have a specific error raised when modifying frozen objects, like FrozenObjectError or something. But since Ruby doesn't provide such a thing, we must limit the assertion to the lowest common denominator, which is word "frozen".
| | * | | Just change ENV and restore it afterwards.Federico Ravasio2013-10-071-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Stubbing ENV[] is not safe outside MRI. At some point after the stubbing has occurred a backtrace is printed to the ActiveSupport warning log: there Rubinius accesses ENV['RBX_NOCOLOR'] to determine if it should print the backtrace with colors or not, causing the stub to fail. Other implementations might access ENV in a different way too, we just can't predict it. The only thing we can do here is to actually set the ENV with what we want and restore it afterwards.
| * | | | Merge pull request #11791 from versioncontrol/includes_with_persistent_selectRafael Mendonça França2013-10-121-0/+8
| |\ \ \ \ | | |_|/ / | |/| | | Includes with persistent select, fixes #11773
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-04 19:22:15 +0000