aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | | Revert "test pg, we don't care about the internal state of `column#default`."Yves Senn2014-06-037-0/+23
| |_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Revert "test pg, remove unused column assignments. Follow up to 254cdf47" Related to #15492 This reverts commit 254cdf4728291277f3fbaa854f34495030e476b4. This reverts commit 4bcf9029452e0c760af04faab6b549710401e8cf. There are public methods that assume `Column#default` is type casted. The return value of `Column#default` is publicly relevant and should not change. /cc @sgrif
* | | | | | test pg, remove unused column assignments. Follow up to 254cdf47Yves Senn2014-06-035-12/+0
| | | | | |
* | | | | | pg, preserve money type when dumping schema and extract money default.Yves Senn2014-06-033-17/+26
| | | | | |
* | | | | | test pg, rm unused requires.Yves Senn2014-06-0311-27/+0
| |_|/ / / |/| | | |
* | | | | Respect limit for PG bit stringsSean Griffin2014-06-031-8/+8
| | | | |
* | | | | pg, preserve type when schema dumping bit and bit varying columns.Yves Senn2014-06-031-8/+8
| | | | |
* | | | | test pg, move bit string type tests into `bit_string_test.rb`.Yves Senn2014-06-033-42/+80
| | | | |
* | | | | test pg, we don't care about the internal state of `column#default`.Yves Senn2014-06-035-9/+0
|/ / / / | | | | | | | | | | | | | | | | That data is internal to Active Record. What we care about is that new records have the right default value.
* | | | pg, preserve point type when schema dumping.Yves Senn2014-06-032-9/+9
| | | |
* | | | pg test, examples for default values and schema dumping of point types.Yves Senn2014-06-032-0/+32
| | | | | | | | | | | | | | | | /cc @sgrif
* | | | just use `assert`Aaron Patterson2014-06-021-1/+1
| | | |
* | | | test pg, add basic test cases for point datatype.Yves Senn2014-06-021-0/+45
| | | |
* | | | New records should remain new after yaml serializationSean Griffin2014-06-011-0/+17
| | | |
* | | | Remove most code related to serialized propertiesSean Griffin2014-06-013-5/+9
| |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Nearly completely implemented in terms of custom properties. `_before_type_cast` now stores the raw serialized string consistently, which removes the need to keep track of "state". The following is now consistently true: - `model.serialized == model.reload.serialized` - A model can be dumped and loaded infinitely without changing - A model can be saved and reloaded infinitely without changing
* | | Don't change values in `@raw_attributes` during serializationSean Griffin2014-06-012-21/+12
| | | | | | | | | | | | | | | | | | During `init_with`, the attributes given to the coder will be placed into `@raw_attributes`. As such, we should read from `@raw_attributes` when encoding, rather than `@attributes`, which has been type cast.
* | | Merge pull request #15434 from sgrif/sg-clear-cachesYves Senn2014-05-311-0/+20
|\ \ \ | | | | | | | | Clear all caches calculated based on `@columns` when `@columns` changes
| * | | Clear all caches calculated based on `@columns` when `@columns` changesSean Griffin2014-05-311-0/+20
| | | |
* | | | Add missing test case for writing unknown attributesSean Griffin2014-05-301-0/+2
|/ / /
* | | Update some bad test cases for serialized columnsSean Griffin2014-05-301-53/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The first case was not testing what the issue mentioned actually was (A subclass of a class with serialized attributes does not serialize when they come from the database). The second case was a bad coder. It would fail if the model was `dup`ed, or if the the model was loaded from the database and then saved again. The third case wasn't testing anything that wasn't covered by the second (and was also a bad coder for the same reasons as the second).
* | | Merge pull request #15427 from sgrif/sg-rename-attribute-ivarsRafael Mendonça França2014-05-301-1/+1
|\ \ \ | | | | | | | | Rename attribute related instance variables to better express intent
| * | | Rename attribute related instance variables to better express intentSean Griffin2014-05-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `@attributes` was actually used for `_before_type_cast` and friends, while `@attributes_cache` is the type cast version (and caching is the wrong word there, but I'm working on removing the conditionals around that). I opted for `@raw_attributes`, because `_before_type_cast` is also semantically misleading. The values in said hash are in the state given by the form builder or database, so raw seemed to be a good word.
* | | | Allow specifying a default value in overloaded propertiesSean Griffin2014-05-302-4/+6
|/ / /
* | | pg, support default values for enum types. Closes #7814.Yves Senn2014-05-301-0/+11
| | | | | | | | | | | | | | | This is an intermediate solution. It is related to the refactoring @sgrif is making and will change in the future.
* | | pg, `default_sequence_name` respects schema. Closes #7516.Yves Senn2014-05-301-8/+6
| | |
* | | Merge pull request #11896 from nkondratyev/fix_pg_columns_for_distinctYves Senn2014-05-301-0/+11
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Fixed #columns_for_distinct of postgresql adapter Conflicts: activerecord/CHANGELOG.md
| * | | Fixed `columns_for_distinct` of postgresql adapterNikolay Kondratyev2013-08-151-0/+11
| | | |
* | | | pg, `reset_pk_sequence!` respects schemas. Closes #14719.Yves Senn2014-05-303-6/+17
| | | |
* | | | pg, `PostgreSQL::Name` to hold schema qualified names.Yves Senn2014-05-301-2/+43
| | | |
* | | | Move `type_cast_for_write` behavior over to the serialized type objectSean Griffin2014-05-291-29/+0
| | | |
* | | | Refactor serialized types to be partially defined as custom propertiesSean Griffin2014-05-292-12/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Many of the methods defined in `AttributeMethods::Serialization` can be refactored onto this type as well, but this is a reasonable small step. Removes the `Type` class, and the need for `decorate_columns` to handle serialized types.
* | | | Result sets never override a model's column typeSean Griffin2014-05-292-0/+50
| |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | MySQL and PostgreSQL provide a column type override in order to properly type cast computed columns included in a result set. This should never override the known types of full fledged columns. In addition to messing up computed properties, this would have led to inconsistent behavior between a record created with `new`, and a record created with `last` on the mysql adapter in the following cases: - `tinyint(1)` with `emulate_booleans` set to `false` - `text`, `string`, `binary`, and `decimal` columns
* | | Maintain column order when overriding existing columnsSean Griffin2014-05-281-0/+5
| | | | | | | | | | | | | | | | | | Working towards re-implementing serialized attributes to use the properties API exposed the need for this, as serializing a column shouldn't change the order of the columns.
* | | Merge pull request #15389 from sgrif/sg-property-inheritanceRafael Mendonça França2014-05-281-0/+19
|\ \ \ | | | | | | | | Ensure custom properties work correctly with inheritance
| * | | Ensure custom properties work correctly with inheritanceSean Griffin2014-05-281-0/+19
| | | |
* | | | Merge pull request #15370 from sgrif/sg-type-namespaceRafael Mendonça França2014-05-283-143/+131
|\ \ \ \ | |/ / / |/| | | Move types to the top level `ActiveRecord` namespace
| * | | Move types to the top level `ActiveRecord` namespaceSean Griffin2014-05-273-143/+131
| | | | | | | | | | | | | | | | | | | | `ActiveRecord::ConnectionAdapters::Type::Value` => `ActiveRecord::Type::Value`
* | | | Merge pull request #15387 from sgrif/sg-remove-column-coderSantiago Pastorino2014-05-281-20/+0
|\ \ \ \ | | | | | | | | | | Remove unused `Column#coder`
| * | | | Remove unused `Column#coder`Sean Griffin2014-05-281-20/+0
| |/ / / | | | | | | | | | | | | | | | | It appears this property was added, but never actually used. It would be broken if it were, as it only type casts one way.
* / / / pg, keep `hstore` and `json` attributes as `Hash` in @attributes.Yves Senn2014-05-282-0/+18
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The solution presented in this patch is not efficient. We should replace it in the near future. The following needs to be worked out: * Is `@attributes` storing the Ruby or SQL representation? * `cacheable_column?` is broken but `hstore` and `json` rely on that behavior Refs #15369. /cc @sgrif @rafaelfranca
* | | Add test case for clear mappingsAkshay Vishnoi2014-05-281-0/+10
| | |
* | | Test Case - Change method nameAkshay Vishnoi2014-05-281-1/+1
| | |
* | | Merge pull request #15371 from sgrif/sg-silence-deprecation-warningRafael Mendonça França2014-05-271-0/+3
|\ \ \ | | | | | | | | Silence deprecation warning in test
| * | | Silence deprecation warning in testSean Griffin2014-05-271-0/+3
| | | | | | | | | | | | | | | | Missed a case that only occured for mysql/mysql2
* | | | Merge pull request #14834 from al2o3cr/issue14155Aaron Patterson2014-05-271-0/+10
|\ \ \ \ | |/ / / |/| | | Correctly alias table names when joining more than once
| * | | WIP: pass existing joins to construct_join_dependencyMatt Jones2014-05-161-0/+10
| | | |
* | | | Merge pull request #15295 from sgrif/sg-deprecate-decimalsRafael Mendonça França2014-05-274-1/+13
|\ \ \ \ | | | | | | | | | | Deprecate decimal columns being automatically treated as integers
| * | | | Deprecate decimal columns being automatically treated as integersSean Griffin2014-05-274-1/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With ActiveRecord::Properties, we now have a reasonable path for users to continue to keep this behavior if they want it. This is an edge case that has added a lot of complexity to the code base.
* | | | | Fix redefine a has_and_belongs_to_many inside inherited classArthur Neves2014-05-271-1/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | After ad7b5efb55bcc2e0ccd3e7f22a81e984df8676d1, which changed how has_an_belongs_to_many used to work, we start raising an error when redefining the same has_an_belongs_to_many association. This commits fix that regression. [Fixes #14983]
* | | | | Fix syntax error from 5eae77cZachary Scott2014-05-261-1/+1
| | | | |
* | | | | Move test to the proper fileRafael Mendonça França2014-05-262-7/+7
| | | | | | | | | | | | | | | | | | | | All preload tests are in the eager_test file
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-05 10:14:44 +0000