aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #29248 from yawboakye/rename-should-rename-table-pkeyGuillermo Iguaran2017-05-291-0/+23
|\ | | | | `rename_table` should rename primary key index name
| * `rename_table` renames primary key index nameYaw Boakye2017-05-291-0/+23
| | | | | | | | | | | | | | | | | | | | Formerly, `rename_table` only renamed primary key index name if the column's data type was sequential (serial, etc in PostgreSQL). The problem with that is tables whose primary keys had other data types (e.g. UUID) maintained the old primary key name. So for example, if the `cats` table has a UUID primary key, and the table is renamed to `felines`, the primary key index will still be called `cats_pkey` instead of `felines_pkey`. This PR corrects it.
* | Remove a redundant test assertionKoichi ITO2017-05-291-6/+0
|/
* Merge pull request #29208 from ↵Guillermo Iguaran2017-05-281-0/+11
|\ | | | | | | | | kamipo/default_env_fall_back_to_default_env_when_rails_env_or_rack_env_is_empty_string `DEFAULT_ENV` falls back to `default_env` when `RAILS_ENV` or `RACK_ENV` is an empty string
| * `DEFAULT_ENV` falls back to `default_env` when `RAILS_ENV` or `RACK_ENV` is ↵Ryuta Kamizono2017-05-251-0/+11
| | | | | | | | | | | | an empty string Follow up of #27399.
* | Deprecate passing arguments and block at the same time to `count` and `sum` ↵Ryuta Kamizono2017-05-291-0/+12
| | | | | | | | | | | | | | | | in `ActiveRecord::Calculations` `select`, `count`, and `sum` in `Relation` are also `Enumerable` method that can be passed block. `select` with block already doesn't take arguments since 4fc3366. This is follow up of that.
* | Merge pull request #29258 from koic/remove_redundant_command_recorder_testMatthew Draper2017-05-291-5/+0
|\ \ | | | | | | Remove a redundant test case of command_recorder_test
| * | Remove a redundant test case of command_recorder_testKoichi ITO2017-05-291-5/+0
| | |
* | | Merge pull request #29253 from kamipo/prevent_extra_queryMatthew Draper2017-05-291-3/+9
|\ \ \ | | | | | | | | Prevent extra `current_database` query for `encoding`/`collation`/`ctype`
| * | | Prevent extra `current_database` query for `encoding`/`collation`/`ctype`Ryuta Kamizono2017-05-281-3/+9
| | | |
* | | | Merge pull request #28969 from ↵Matthew Draper2017-05-283-3/+4
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | kamipo/refactor_enum_to_use_value_instead_of_label Refactor enum to use `value` instead of `label` in the scope
| * | | | Refactor enum to use `value` instead of `label` in the scopeRyuta Kamizono2017-05-073-3/+4
| | | | |
* | | | | Merge pull request #29003 from kamipo/delegate_ast_and_locked_to_arel_explicitlyMatthew Draper2017-05-282-1/+10
|\ \ \ \ \ | |_|/ / / |/| | | | Delegate `ast` and `locked` to `arel` explicitly
| * | | | Delegate `ast` and `locked` to `arel` explicitlyRyuta Kamizono2017-05-062-1/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently `ast` and `locked` are used in the internal but delegating to `arel` is depend on `method_missing`. If a model class is defined these methods, `select_all` will be broken. It should be delegated to `arel` explicitly.
* | | | | Merge pull request #29197 from kamipo/enable_extending_even_if_scope_returns_nilMatthew Draper2017-05-281-1/+1
|\ \ \ \ \ | | | | | | | | | | | | Enable extending even if scope returns nil
| * | | | | Enable extending even if scope returns nilRyuta Kamizono2017-05-241-1/+1
| | | | | |
* | | | | | Fix regression in Numericality validator where extra decimal places on Bradley Priest2017-05-271-0/+14
| |_|_|/ / |/| | | | | | | | | a user input for a decimal column were ignored by numerically validations
* | | | | Remove a redundant test assertionKoichi ITO2017-05-271-1/+0
| | | | |
* | | | | Merge pull request #29176 from bogdanvlviv/define-path-with__dir__Matthew Draper2017-05-266-7/+7
|\ \ \ \ \ | | | | | | | | | | | | Define path with __dir__
| * | | | | Define path with __dir__bogdanvlviv2017-05-236-7/+7
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | ".. with __dir__ we can restore order in the Universe." - by @fxn Related to 5b8738c2df003a96f0e490c43559747618d10f5f
* | | | | Merge pull request #29221 from koic/remove_duplicate_migration_testMatthew Draper2017-05-261-27/+0
|\ \ \ \ \ | | | | | | | | | | | | Remove a duplicate test of migration_test in AR
| * | | | | Remove a duplicate test of migration_test in ARKoichi ITO2017-05-251-27/+0
| | | | | |
* | | | | | Merge pull request #29230 from koic/remove_duplicate_schema_authorization_testMatthew Draper2017-05-261-11/+0
|\ \ \ \ \ \ | | | | | | | | | | | | | | Remove a duplicate test of schema_authorization_test in AR
| * | | | | | Remove a duplicate test of schema_authorization_test in ARKoichi ITO2017-05-251-11/+0
| | | | | | |
* | | | | | | Merge pull request #29226 from koic/remove_duplicate_mysql_rake_testMatthew Draper2017-05-261-7/+0
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Remove a duplicate test of mysql_rake_test
| * | | | | | | Remove a duplicate test of mysql_rake_testKoichi ITO2017-05-261-7/+0
| |/ / / / / /
* | | | | | | Merge pull request #29216 from matthewd/threadsafe-load-schemaMatthew Draper2017-05-261-0/+28
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | Add a Monitor to ModelSchema#load_schema
| * | | | | | Add a Monitor to ModelSchema#load_schemaMatthew Draper2017-05-251-0/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | [Vikrant Chaudhary, David Abdemoulaie, Matthew Draper]
* | | | | | | Merge pull request #29175 from kamipo/extract_json_shared_testsMatthew Draper2017-05-253-351/+184
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | Extract `JSONSharedTestCases`
| * | | | | | Extract `JSONSharedTestCases`Ryuta Kamizono2017-05-223-351/+184
| | |/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | Both `mysql2/json_test.rb` and `postgresql/json_test.rb` have same test cases.
* | | | | | Merge pull request #29181 from kamipo/fix_circular_left_joins_with_scopingMatthew Draper2017-05-251-2/+9
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | Fix crashing on circular left join references with scoping
| * | | | | Fix crashing on circular left join references with scopingRyuta Kamizono2017-05-241-2/+9
| | |_|_|/ | |/| | | | | | | | | | | | | Follow up of #25702.
* / | | | Fix a RuboCop offences using `rubocop -a`Koichi ITO2017-05-241-1/+1
|/ / / /
* | | | Merge pull request #29141 from kamipo/make_helper_methods_to_privateMatthew Draper2017-05-241-18/+19
|\ \ \ \ | | | | | | | | | | Make helper methods in tests to private
| * | | | Make helper methods in tests to privateRyuta Kamizono2017-05-191-18/+19
| | | | | | | | | | | | | | | | | | | | | | | | | `make_model` and `make_no_pk_hm_t` in `HasManyThroughAssociationsTest` are not a test case. it should be private.
* | | | | Merge pull request #29145 from kamipo/reference_type_should_be_not_nullMatthew Draper2017-05-241-0/+8
|\ \ \ \ \ | | | | | | | | | | | | Both reference id and type should be `NOT NULL` if `null: false` is specified
| * | | | | Both reference id and type should be `NOT NULL` if `null: false` is specifiedRyuta Kamizono2017-05-191-0/+8
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | This is a regression due to #28282. Fixes #29136.
* | | | | Merge pull request #29167 from koic/remove_duplicate_inverse_associations_testMatthew Draper2017-05-241-14/+0
|\ \ \ \ \ | | | | | | | | | | | | Remove a duplicate test of inverse_associations_test in AR
| * | | | | Remove a duplicate test of inverse_associations_test in ARKoichi ITO2017-05-211-14/+0
| | |/ / / | |/| | |
* | | | | Merge pull request #29182 from kamipo/remove_unused_left_joins_values_generationMatthew Draper2017-05-241-1/+1
|\ \ \ \ \ | | | | | | | | | | | | Remove unused `left_joins_values` generation
| * | | | | Remove unused `left_joins_values` generationRyuta Kamizono2017-05-231-1/+1
| |/ / / / | | | | | | | | | | | | | | | This was added at #22125 but `left_joins_values` is never used.
* / / / / More friendly exception in nested attributesKir Shatrov2017-05-221-1/+1
|/ / / /
* / / / Add cache_key_with_version and use it in ActiveSupport::Cache.expand_cache_keyDavid Heinemeier Hansson2017-05-192-7/+19
|/ / / | | | | | | | | | | | | | | | This retains the existing behavior of ActiveSupport::Cache.expand_cache_key (as used by etaging) where the cache key includes the version.
* | | Use recyclable cache keys (#29092)David Heinemeier Hansson2017-05-182-2/+68
| | |
* | | Set non 0 value to logger not to be affected by Ruby versionsYasuo Honda2017-05-171-23/+23
| | | | | | | | | | | | Addresses #29021
* | | Respect 'ignore_tables' in SQLite structure dumpGuillermo Iguaran2017-05-151-0/+20
| | |
* | | Respect 'ignore_tables' in MySQL structure dumpGuillermo Iguaran2017-05-151-0/+16
| | |
* | | Respect `ignore_tables` in Postgres structure dumpRusty Geldmacher2017-05-151-0/+8
| | | | | | | | | | | | | | | | | | When using `sql` as the schema format, or even just doing `rake db:structure:dump`, it would be good to respect the list of ignored tables that has been configured.
* | | Don't eager loading if unneeded for `FinderMethods#exists?`Ryuta Kamizono2017-05-111-0/+1
| | | | | | | | | | | | Fixes #29025.
* | | Should escape meta characters in regexpRyuta Kamizono2017-05-0710-26/+26
| |/ |/|
generated by cgit v1.2.3 (git 2.25.1) at 2025-04-07 07:40:48 +0000