Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | Merge pull request #3521 from ↵ | Aaron Patterson | 2011-11-06 | 1 | -0/+4 | |
| | | | | | | | | | | | | nulogy/fix_postgres_adapter_to_handle_spaces_between_schemas Fix postgres adapter to handle spaces between schemas | |||||
* | | Update ActiveRecord#attribute_present? to work as documented | Justin Mazzi | 2011-11-05 | 1 | -0/+18 | |
| | | | | | | | | | | | | | | "Returns true if the specified attribute has been set by the user or by a database load and is neither nil nor empty?" Fixes #1613 | |||||
* | | implements AR::Relation#explain | Xavier Noria | 2011-11-05 | 3 | -0/+71 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a first implementation, EXPLAIN is highly dependent on the database and I have made some compromises. On one hand, the method allows you to run the most common EXPLAIN and that's it. If you want EXPLAIN ANALYZE in PostgreSQL you need to do it by hand. On the other hand, I've tried to construct a string as close as possible to the ones built by the respective shells. The rationale is that IMO the user should feel at home with the output and recognize it at first sight. Per database. I don't know whether this implementation is going to work well. Let's see whether people like it. | |||||
* | | Merge pull request #3525 from kennyj/fix_3440-1 | Jon Leighton | 2011-11-05 | 1 | -0/+5 | |
|\ \ | | | | | | | Fixed an issue id false option is ignored on mysql/mysql2 (fix #3440) | |||||
| * | | Fixed an issue id false option is ignored on mysql/mysql2 (fix #3440) | kennyj | 2011-11-06 | 1 | -0/+5 | |
| | | | ||||||
* | | | Add ActiveRecord::Relation#uniq for toggling DISTINCT in the SQL query | Jon Leighton | 2011-11-05 | 3 | -1/+23 | |
| | | | ||||||
* | | | AR changes to support creating ordered (asc, desc) indexes | Vlad Jebelev | 2011-11-04 | 2 | -4/+24 | |
|/ / | ||||||
* | | Fix test as one more has_many added | Arun Agrawal | 2011-11-04 | 1 | -1/+1 | |
| | | ||||||
* | | Allow the :class_name option for associations to take a symbol. | Jon Leighton | 2011-11-04 | 2 | -1/+6 | |
| | | | | | | | | | | This is to avoid confusing newbies, and to be consistent with the fact that other options like :foreign_key already allow a symbol or a string. | |||||
* | | Merge pull request #1163 from amatsuda/sexier_migration_31 | Aaron Patterson | 2011-11-04 | 1 | -0/+20 | |
|\ \ | | | | | | | Sexier migrations | |||||
| * | | Tests for new create_table DSL | Akira Matsuda | 2011-05-20 | 1 | -0/+20 | |
| | | | ||||||
* | | | Merge pull request #3507 from jmazzi/issue-3503 | Jeremy Kemper | 2011-11-03 | 1 | -0/+15 | |
| | | | | | | | | | | | | Preserve SELECT columns on the COUNT for finder_sql when possible | |||||
* | | | Fix #3271. | Jon Leighton | 2011-11-03 | 1 | -0/+6 | |
| | | | | | | | | | | | | | | | | | | | | | | | | Building the conditions of a nested through association could potentially modify the conditions of the through and/or source association. This is a Bad Thing. | |||||
* | | | Remove all revelant through records. | Jon Leighton | 2011-11-03 | 1 | -0/+15 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | If a record is removed from a has_many :through, all of the join records relating to that record should also be removed from the through association's target. (Previously the records were removed in the database, but only one was removed from the in-memory target array.) | |||||
* | | | Fix adding multiple instances of the same record to a has_many :through. | Jon Leighton | 2011-11-03 | 1 | -0/+10 | |
| | | | | | | | | | | | | Fixes #3425. | |||||
* | | | Fix #3247. | Jon Leighton | 2011-11-03 | 1 | -0/+5 | |
| | | | | | | | | | | | | | | | Fixes creating records in a through association with a polymorphic source type. | |||||
* | | | assert_match takes a regexp and a string in that order | Vijay Dev | 2011-10-31 | 1 | -1/+1 | |
| | | | ||||||
* | | | dump_schema_information: explicitly order inserts into schema_migrations table | Laust Rud Jacobsen | 2011-10-31 | 1 | -0/+9 | |
| | | | | | | | | | | | | | | | | | | | | | This change reduces churn in the db/development_structure.sql file when using :sql as active_record.schema_format, and makes comparing diffs much easier. Test ensures the output SQL-statements are lexically ordered by version. | |||||
* | | | Added failing test case for changing schema in migration not clearing the ↵ | Joe Van Dyk | 2011-10-27 | 1 | -0/+12 | |
| | | | | | | | | | | | | prepared statement cache | |||||
* | | | More checks for instance writers. | Arun Agrawal | 2011-10-27 | 1 | -1/+2 | |
| | | | ||||||
* | | | Adding more checks for instance_writer false | Arun Agrawal | 2011-10-27 | 1 | -1/+2 | |
| | | | ||||||
* | | | Test fix Allow instances to disable record_timestamps | Arun Agrawal | 2011-10-27 | 1 | -1/+1 | |
| | | | | | | | | | | | | Removed here 0d0176c4ffe5c58fd1002efbd8f7bd45a8872e33 | |||||
* | | | Allow instances to disable record_timestamps | Pratik Naik | 2011-10-26 | 1 | -0/+10 | |
| | | | ||||||
* | | | Merge branch 'master' of github.com:rails/rails | David Heinemeier Hansson | 2011-10-25 | 8 | -13/+100 | |
|\ \ \ | ||||||
| * | | | preserve decimal column attributes after migration | Greg Reinacker | 2011-10-21 | 1 | -0/+36 | |
| | | | | ||||||
| * | | | Merge pull request #3258 from ileitch/3-1-stable | Aaron Patterson | 2011-10-20 | 1 | -0/+16 | |
| | |/ | |/| | | | | | | | Postgres: Do not attempt to deallocate a statement if the connection is no longer active. | |||||
| * | | only use now() on pg! | Aaron Patterson | 2011-10-18 | 1 | -1/+3 | |
| | | | ||||||
| * | | reset prepared statement when schema changes imapact statement results. ↵ | Aaron Patterson | 2011-10-18 | 1 | -0/+8 | |
| | | | | | | | | | | | | fixes #3335 | |||||
| * | | use now() for dates in pg | Aaron Patterson | 2011-10-18 | 1 | -1/+1 | |
| | | | ||||||
| * | | Merge pull request #3340 from surfacedamage/exclude_destroy_in_all_blank_check | José Valim | 2011-10-17 | 1 | -0/+8 | |
| |\ \ | | | | | | | | | Exclude _destroy parameter in :all_blank check (issue #2937) | |||||
| | * | | Exclude _destroy parameter in :all_blank check (issue #2937) | Aaron Christy | 2011-10-17 | 1 | -0/+8 | |
| | | | | ||||||
| * | | | Merge pull request #3334 from mperham/master | Aaron Patterson | 2011-10-16 | 1 | -5/+5 | |
| |\ \ \ | | | | | | | | | | | Default timestamps to non-null | |||||
| | * | | | Default timestamps to non-null | Mike Perham | 2011-10-14 | 1 | -5/+5 | |
| | |/ / | ||||||
| * / / | fix to remove warning in test cases | Vishnu Atrai | 2011-10-16 | 1 | -2/+2 | |
| |/ / | ||||||
| * | | Includes stale record in StaleObjectError | Christian Bäuerlein | 2011-10-14 | 1 | -1/+18 | |
| | | | ||||||
| * | | Rails 4 is just around the corner. Stuck with 1.8 until then. | Jeremy Kemper | 2011-10-13 | 1 | -3/+3 | |
| | | | ||||||
| * | | Tests gotta run in 1.8 too | Jeremy Kemper | 2011-10-13 | 1 | -2/+2 | |
| | | | ||||||
* | | | Fix that changing a store should mark the store attribute as changed | David Heinemeier Hansson | 2011-10-25 | 1 | -0/+5 | |
|/ / | ||||||
* | | Added ActiveRecord::Base.store for declaring simple single-column key/value ↵ | David Heinemeier Hansson | 2011-10-13 | 3 | -0/+31 | |
| | | | | | | | | stores [DHH] | |||||
* | | ambiguous first argument; put parentheses or even spaces Warning removed! | Arun Agrawal | 2011-10-10 | 1 | -2/+2 | |
| | | ||||||
* | | Use broken YAML that will fail with Syck as well as Psych. Fixes ↵ | Jon Leighton | 2011-10-09 | 1 | -2/+2 | |
| | | | | | | | | | | | | test_broken_yaml_exception in fixtures_test.rb on Ruby 1.8.7. Cherry-pick from 3-1-stable: b8d46924e70e0847e92e1d2dbaaec8c11381072c | |||||
* | | Remove stray whitespace | Jeremy Kemper | 2011-10-09 | 1 | -4/+1 | |
| | | ||||||
* | | Only use LOWER for mysql case insensitive uniqueness check when column has a ↵ | Joseph Palermo | 2011-10-09 | 4 | -1/+96 | |
| | | | | | | | | case sensitive collation. | |||||
* | | Fixed BodyProxy.new for tests! for wrong argument | Arun Agrawal | 2011-10-08 | 1 | -1/+1 | |
| | | ||||||
* | | Merge pull request #3232 from Juanmcuello/pg_prepared_statements | Aaron Patterson | 2011-10-06 | 1 | -0/+19 | |
|\ \ | | | | | | | Use the schema_search_path in prepared statements. | |||||
| * | | refs #3232. Prepared statements and postgreSQL schemas. | Juan M. Cuello | 2011-10-05 | 1 | -0/+19 | |
| | | | | | | | | | | | | | | | Add tests for prepared statements with multiple schemas in postgreSQL. | |||||
* | | | Transactional fixtures enlist all active database connections. | Jeremy Kemper | 2011-10-05 | 5 | -4/+38 | |
| | | | | | | | | | | | | You can use multiple databases in your tests without disabling transactional fixtures. | |||||
* | | | Raise an exception on unknown primary key inside AssociationReflection. | Jon Leighton | 2011-10-05 | 1 | -0/+15 | |
| | | | | | | | | | | | | | | | An association between two models cannot be made if a relevant key is unknown, so fail fast rather than generating invalid SQL. Fixes #3207. | |||||
* | | | Revert "Raise error on unknown primary key." | Jon Leighton | 2011-10-05 | 3 | -18/+4 | |
|/ / | | | | | | | This reverts commit ee2be435b1e5c0e94a4ee93a1a310e0471a77d07. | |||||
* | | Raise error on unknown primary key. | Jon Leighton | 2011-10-05 | 3 | -4/+18 | |
| | | | | | | | | | | If we don't have a primary key when we ask for it, it's better to fail fast. Fixes GH #2307. |