Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | Revert "Merge pull request #11120 from awilliams/ar_mysql2_boolean_quoting" | Yves Senn | 2013-07-17 | 1 | -25/+0 | |
| | | | | | | | | | | This reverts commit cb1d07e43926bcec95cb8b4a663ca9889173395a, reversing changes made to 754a373e301d2df0b12a11083405252722bc8366. | |||||
* | | removes the obsolete private method column_methods_hash [Closes #11406] | Xavier Noria | 2013-07-16 | 3 | -30/+28 | |
| | | ||||||
* | | Unifies mysql and mysql2 casting of booleans | awilliams | 2013-07-16 | 1 | -0/+25 | |
| | | | | | | | | | | Using the mysql2 adapter, boolean values were sometimes being incorrectly cast to 't' or 'f'. This changes the cast to match the mysql adapter behavior, ie 1 and 0. | |||||
* | | `change_column` for PG adapter respects `:array` option. | Yves Senn | 2013-07-16 | 1 | -0/+12 | |
|/ | ||||||
* | reorder bind parameters when merging relations | Aaron Patterson | 2013-07-15 | 2 | -1/+25 | |
| | ||||||
* | use arel rather than slapping together SQL strings | Aaron Patterson | 2013-07-15 | 1 | -3/+6 | |
| | ||||||
* | Merge pull request #11451 from ↵ | Yves Senn | 2013-07-15 | 1 | -0/+7 | |
|\ | | | | | | | | | jetthoughts/11450_do_not_resave_destroyed_association Do not re-save destroyed association on saving parent object | |||||
| * | Do not re-save destroyed association on saving parent object | Paul Nikitochkin | 2013-07-15 | 1 | -0/+7 | |
| | | | | | | | | Closes #11450 | |||||
* | | Remove deprecation warning from attribute_missing | Arun Agrawal | 2013-07-15 | 1 | -15/+0 | |
|/ | | | for attributes that are columns. | |||||
* | Merge pull request #11434 from jetthoughts/new_save_transaction_bugfix | Santiago Pastorino | 2013-07-14 | 1 | -0/+14 | |
|\ | | | | | Remove extra decrement of transaction level | |||||
| * | #4566: Remove extra decrement of transaction level | Paul Nikitochkin | 2013-07-14 | 1 | -0/+14 | |
| | | | | | | | | | | | | | | | | | | | | | | | | `rollback_active_record_state!` tries to restore model state on `Exception` by invoking `restore_transaction_record_state` it decrement deep level by `1`. After restoring it ensure that states to be cleared and level decremented by invoking `clear_transaction_record_state`, which cause the bug: because state already reduced in `restore_transaction_record_state`. Removed double derement of transaction level and removed duplicated code which clear transaction state for top level. | |||||
* | | Blacklist->whitelist for reference scans in order! | Ernie Miller | 2013-07-14 | 1 | -0/+7 | |
|/ | | | | | | Stop special-casing Arel::Nodes as exempt from reference scanning in order. Instead, only scan order values that are strings for a table reference. | |||||
* | Reset @column_defaults when assigning . | kennyj | 2013-07-14 | 1 | -0/+1 | |
| | ||||||
* | Make sure that a joins Relation can be merged with has_many :through + ↵ | Akira Matsuda | 2013-07-10 | 2 | -1/+11 | |
| | | | | | | association proxy Closes #11248. | |||||
* | Fix: attribute_for_inspect truncate upto (51 => 50) characters. | namusyaka | 2013-07-09 | 1 | -1/+1 | |
| | ||||||
* | Remove redundant test about `push_with_attributes` removal. | Vipul A M | 2013-07-09 | 1 | -7/+0 | |
| | ||||||
* | close our connection when we are done | Aaron Patterson | 2013-07-08 | 2 | -14/+17 | |
| | ||||||
* | remove dead code | Aaron Patterson | 2013-07-08 | 1 | -16/+0 | |
| | ||||||
* | if we remove the connection from the pool, we should close it | Aaron Patterson | 2013-07-08 | 1 | -0/+1 | |
| | ||||||
* | use latches rather than mucking with the scheduler | Aaron Patterson | 2013-07-08 | 1 | -7/+7 | |
| | ||||||
* | Merge pull request #11274 from arunagw/deprecation-removed-build-fixed | Rafael Mendonça França | 2013-07-07 | 1 | -20/+0 | |
|\ | | | | | Deprecation removed build fixed | |||||
| * | Removed unused test for DateTime.local_offset | Arun Agrawal | 2013-07-07 | 1 | -20/+0 | |
| | | | | | | | | see discussion here #11274 | |||||
* | | Merge pull request #11306 from ↵ | Rafael Mendonça França | 2013-07-06 | 1 | -1/+42 | |
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | jetthoughts/11288_remove_extra_queries_for_belongs_to_with_touch #11288: Removed duplicated touching Conflicts: activerecord/CHANGELOG.md | |||||
| * | | #11288: Removed duplicated touching | Paul Nikitochkin | 2013-07-05 | 1 | -1/+42 | |
| | | | | | | | | | | | | | | | | | | if belongs to model with touch option on touch Closes #11288 | |||||
* | | | Revert "Merge pull request #11299 from ↵ | Yves Senn | 2013-07-05 | 1 | -0/+6 | |
|/ / | | | | | | | | | | | | | | | | | | | arunagw/disable_implicit_join_references_removed" `disable_implicit_join_references=` was only deprecated on `master`, not with rails 4.0. We can remove it after 4.1 This reverts commit 3c719ead414ffd29e71efce185698af979052abb, reversing changes made to d5c3bf9722abd5733a769c8d789de3f74dbfb92d. | |||||
* | | Cleanup belongs to tests | Paul Nikitochkin | 2013-07-05 | 1 | -2/+1 | |
| | | | | | | | | simplified logic to calculate number of queries by using assert_queries | |||||
* | | Remove deprecated `ActiveRecord::Base.disable_implicit_join_references=`. | Arun Agrawal | 2013-07-04 | 1 | -6/+0 | |
| | | ||||||
* | | Remove deprecated String constructor from `ActiveRecord::Migrator`. | Yves Senn | 2013-07-04 | 1 | -6/+0 | |
| | | ||||||
* | | Remove deprecated `scope` use without passing a callable object. | Arun Agrawal | 2013-07-03 | 1 | -10/+0 | |
| | | | | | | | | Removed tests from deprecated code. | |||||
* | | Remove deprecated `transaction_joinable=` | Arun Agrawal | 2013-07-03 | 1 | -9/+0 | |
|/ | | | | | in favor of `begin_transaction` with `:joinable` option. | |||||
* | remove deprecated `PostgreSQLAdapter#outside_transaction?` method. | Yves Senn | 2013-07-03 | 1 | -10/+0 | |
| | ||||||
* | Merge pull request #11258 from frodsan/remove_deprecated_distinct | Carlos Antonio da Silva | 2013-07-02 | 1 | -46/+0 | |
|\ | | | | | Remove deprecated SchemaStatements#distinct | |||||
| * | Remove deprecated SchemaStatements#distinct | Francesco Rodriguez | 2013-07-02 | 1 | -46/+0 | |
| | | ||||||
* | | initialize generated modules on inclusion and on inheritence | Aaron Patterson | 2013-07-02 | 1 | -7/+0 | |
| | | ||||||
* | | fix to_sql output on eager loaded relations | Aaron Patterson | 2013-07-02 | 1 | -0/+8 | |
| | | ||||||
* | | remove private attribute reader | Aaron Patterson | 2013-07-02 | 1 | -2/+2 | |
|/ | ||||||
* | remove unused `ActiveRecord::TestCase#sqlite3` method. | Yves Senn | 2013-07-02 | 1 | -6/+0 | |
| | ||||||
* | deprecated `ActiveRecord::TestCase` is no longer public. | Yves Senn | 2013-07-02 | 1 | -2/+94 | |
| | | | | /cc @tenderlove | |||||
* | Dropped deprecated option `:restrict` for `:dependent` in associations | Neeraj Singh | 2013-07-03 | 3 | -38/+0 | |
| | ||||||
* | Removed support for deprecated `delete_sql` in associations. | Neeraj Singh | 2013-07-03 | 2 | -30/+0 | |
| | ||||||
* | Removed support for deprecated `finder_sql` in associations. | Neeraj Singh | 2013-07-02 | 5 | -156/+0 | |
| | ||||||
* | Add CHANGELOG enty for #11235 | Rafael Mendonça França | 2013-07-02 | 1 | -1/+0 | |
| | ||||||
* | Removed support for deprecated `counter_sql` | Neeraj Singh | 2013-07-02 | 3 | -61/+1 | |
| | ||||||
* | Removing not useful test related to reflect_on_all_associations | Neeraj Singh | 2013-07-02 | 1 | -8/+0 | |
| | | | | | | | | | | | | | | | | The comment in the test pretty much summarizes the issue. `FIXME these assertions bust a lot` Adding any type of association in class `Firm` will break this test. I removed some deprecated stuff and this test failed. I do not think this test provides any useful value. First of all who counted last that 39 is the right number of associations. Secondly there are a large number of tests which depend on reflection returning right information about associations. Those tests will start failing if there is a bug in the code. | |||||
* | Merge pull request #10604 from ↵ | Rafael Mendonça França | 2013-07-01 | 6 | -2/+73 | |
|\ | | | | | | | | | | | | | | | | | neerajdotname/delete_all_should_not_call_callbacks Do not invoke callbacks when delete_all is called Conflicts: activerecord/CHANGELOG.md | |||||
| * | Do not invoke callbacks when delete_all is called | Neeraj Singh | 2013-06-30 | 6 | -2/+73 | |
| | | | | | | | | | | | | | | | | | | | | | | Method `delete_all` should not be invoking callbacks and this feature was deprecated in Rails 4.0. This is being removed. `delete_all` will continue to honor the `:dependent` option. However if `:dependent` value is `:destroy` then the default deletion strategy for that collection will be applied. User can also force a deletion strategy by passing parameter to `delete_all`. For example you can do `@post.comments.delete_all(:nullify)` | |||||
* | | calling default_scope without a proc will raise ArgumentError | Neeraj Singh | 2013-07-02 | 1 | -3/+2 | |
| | | | | | | | | Calling default_scope without a proc will now raise `ArgumentError`. | |||||
* | | Removed deprecated options for assocations | Neeraj Singh | 2013-07-02 | 2 | -22/+0 | |
| | | | | | | | | | | Deprecated options `delete_sql`, `insert_sql`, `finder_sql` and `counter_sql` have been deleted. | |||||
* | | remove deprecated `ActiveRecord::Base#connection` method. | Yves Senn | 2013-07-01 | 1 | -4/+0 | |
| | | ||||||
* | | Remove deprecated `:distinct` option from `Relation#count`. | Yves Senn | 2013-07-01 | 1 | -10/+0 | |
| | |