| Commit message (Collapse) | Author | Age | Files | Lines | |
|---|---|---|---|---|---|
| * | used flat_map instead of map.flatten | Karunakar (Ruby) | 2013-07-25 | 1 | -1/+1 |
| | | |||||
| * | :scissors: [ci skip] | Carlos Antonio da Silva | 2013-07-25 | 1 | -1/+1 |
| | | |||||
| * | change function def self.table_name to self.table_name | Rajarshi Das | 2013-07-25 | 2 | -5/+3 |
| | | | | | | | change def self.primary_key to self.primary_key change def self.primary_key to self.primary_key | ||||
| * | More unused associations in AR test models | Akira Matsuda | 2013-07-25 | 8 | -13/+0 |
| | | |||||
| * | Clean up unused associations in AR test model | Akira Matsuda | 2013-07-25 | 1 | -3/+0 |
| | | |||||
| * | acually get the actual source reflection :cry::gun: | Aaron Patterson | 2013-07-23 | 1 | -2/+3 |
| | | |||||
| * | stop relying on side effects of const_missing | Aaron Patterson | 2013-07-23 | 1 | -0/+6 |
| | | |||||
| * | Defines the return type of select / select_all method. | kennyj | 2013-07-23 | 1 | -0/+5 |
| | | |||||
| * | Don't allow `quote_value` to be called without a column | Ben Woosley | 2013-07-22 | 1 | -1/+1 |
| | | | | | | | | Some adapters require column information to do their job properly. By enforcing the provision of the column for this internal method we ensure that those using adapters that require column information will always get the proper behavior. | ||||
| * | Tidy up the "Specified column type for quote_value" changes | Ben Woosley | 2013-07-22 | 1 | -1/+0 |
| | | | | | | | This includes fixing typos in changelog, removing a deprecated mocha/setup test require, and preferring the `column_for_attribute` accessor over direct access to the columns_hash in the new code. | ||||
| * | Specified column type for quote_value | Alfred Wong | 2013-07-22 | 1 | -0/+13 |
| | | | | | | | | | | | | | | | | | | | | | | When calling quote_value the underlying connection sometimes requires more information about the column to properly return the correct quoted value. I ran into this issue when using optimistic locking in JRuby and the activerecord-jdbcmssql-adapter. In SQLSever 2000, we aren't allowed to insert a integer into a NVARCHAR column type so we need to format it as N'3' if we want to insert into the NVARCHAR type. Unfortuantely, without the column type being passed the connection adapter cannot properly return the correct quote value because it doesn't know to return N'3' or '3'. This patch is fairly straight forward where it just passes in the column type into the quote_value, as it already has the ability to take in the column, so it can properly handle at the connection level. I've added the tests required to make sure that the quote_value method is being passed the column type so that the underlying connection can determine how to quote the value. | ||||
| * | rescue from all exceptions in `ConnectionManagement#call` | Vipul A M | 2013-07-22 | 1 | -2/+2 |
| | | | | | | | | | | Fixes #11497 As `ActiveRecord::ConnectionAdapters::ConnectionManagement` middleware does not rescue from Exception (but only from StandardError), the Connection Pool quickly runs out of connections when multiple erroneous Requests come in right after each other. Recueing from all exceptions and not just StandardError, fixes this behaviour. | ||||
| * | Revert "Merge pull request #11120 from awilliams/ar_mysql2_boolean_quoting" | Yves Senn | 2013-07-17 | 1 | -25/+0 |
| | | | | | | This reverts commit cb1d07e43926bcec95cb8b4a663ca9889173395a, reversing changes made to 754a373e301d2df0b12a11083405252722bc8366. | ||||
| * | removes the obsolete private method column_methods_hash [Closes #11406] | Xavier Noria | 2013-07-16 | 3 | -30/+28 |
| | | |||||
| * | Unifies mysql and mysql2 casting of booleans | awilliams | 2013-07-16 | 1 | -0/+25 |
| | | | | | | Using the mysql2 adapter, boolean values were sometimes being incorrectly cast to 't' or 'f'. This changes the cast to match the mysql adapter behavior, ie 1 and 0. | ||||
| * | `change_column` for PG adapter respects `:array` option. | Yves Senn | 2013-07-16 | 1 | -0/+12 |
| | | |||||
| * | reorder bind parameters when merging relations | Aaron Patterson | 2013-07-15 | 2 | -1/+25 |
| | | |||||
| * | use arel rather than slapping together SQL strings | Aaron Patterson | 2013-07-15 | 1 | -3/+6 |
| | | |||||
| * | Merge pull request #11451 from ↵ | Yves Senn | 2013-07-15 | 1 | -0/+7 |
| |\ | | | | | | | | | jetthoughts/11450_do_not_resave_destroyed_association Do not re-save destroyed association on saving parent object | ||||
| | * | Do not re-save destroyed association on saving parent object | Paul Nikitochkin | 2013-07-15 | 1 | -0/+7 |
| | | | | | | | | | Closes #11450 | ||||
| * | | Remove deprecation warning from attribute_missing | Arun Agrawal | 2013-07-15 | 1 | -15/+0 |
| |/ | | | for attributes that are columns. | ||||
| * | Merge pull request #11434 from jetthoughts/new_save_transaction_bugfix | Santiago Pastorino | 2013-07-14 | 1 | -0/+14 |
| |\ | | | | | Remove extra decrement of transaction level | ||||
| | * | #4566: Remove extra decrement of transaction level | Paul Nikitochkin | 2013-07-14 | 1 | -0/+14 |
| | | | | | | | | | | | | | | | | | | | | | | | | | `rollback_active_record_state!` tries to restore model state on `Exception` by invoking `restore_transaction_record_state` it decrement deep level by `1`. After restoring it ensure that states to be cleared and level decremented by invoking `clear_transaction_record_state`, which cause the bug: because state already reduced in `restore_transaction_record_state`. Removed double derement of transaction level and removed duplicated code which clear transaction state for top level. | ||||
| * | | Blacklist->whitelist for reference scans in order! | Ernie Miller | 2013-07-14 | 1 | -0/+7 |
| |/ | | | | | | Stop special-casing Arel::Nodes as exempt from reference scanning in order. Instead, only scan order values that are strings for a table reference. | ||||
| * | Reset @column_defaults when assigning . | kennyj | 2013-07-14 | 1 | -0/+1 |
| | | |||||
| * | Make sure that a joins Relation can be merged with has_many :through + ↵ | Akira Matsuda | 2013-07-10 | 2 | -1/+11 |
| | | | | | | | association proxy Closes #11248. | ||||
| * | Fix: attribute_for_inspect truncate upto (51 => 50) characters. | namusyaka | 2013-07-09 | 1 | -1/+1 |
| | | |||||
| * | Remove redundant test about `push_with_attributes` removal. | Vipul A M | 2013-07-09 | 1 | -7/+0 |
| | | |||||
| * | close our connection when we are done | Aaron Patterson | 2013-07-08 | 2 | -14/+17 |
| | | |||||
| * | remove dead code | Aaron Patterson | 2013-07-08 | 1 | -16/+0 |
| | | |||||
| * | if we remove the connection from the pool, we should close it | Aaron Patterson | 2013-07-08 | 1 | -0/+1 |
| | | |||||
| * | use latches rather than mucking with the scheduler | Aaron Patterson | 2013-07-08 | 1 | -7/+7 |
| | | |||||
| * | Merge pull request #11274 from arunagw/deprecation-removed-build-fixed | Rafael Mendonça França | 2013-07-07 | 1 | -20/+0 |
| |\ | | | | | Deprecation removed build fixed | ||||
| | * | Removed unused test for DateTime.local_offset | Arun Agrawal | 2013-07-07 | 1 | -20/+0 |
| | | | | | | | | | see discussion here #11274 | ||||
| * | | Merge pull request #11306 from ↵ | Rafael Mendonça França | 2013-07-06 | 1 | -1/+42 |
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | jetthoughts/11288_remove_extra_queries_for_belongs_to_with_touch #11288: Removed duplicated touching Conflicts: activerecord/CHANGELOG.md | ||||
| | * | | #11288: Removed duplicated touching | Paul Nikitochkin | 2013-07-05 | 1 | -1/+42 |
| | | | | | | | | | | | | | | | | | | | if belongs to model with touch option on touch Closes #11288 | ||||
| * | | | Revert "Merge pull request #11299 from ↵ | Yves Senn | 2013-07-05 | 1 | -0/+6 |
| |/ / | | | | | | | | | | | | | | | | | | | arunagw/disable_implicit_join_references_removed" `disable_implicit_join_references=` was only deprecated on `master`, not with rails 4.0. We can remove it after 4.1 This reverts commit 3c719ead414ffd29e71efce185698af979052abb, reversing changes made to d5c3bf9722abd5733a769c8d789de3f74dbfb92d. | ||||
| * | | Cleanup belongs to tests | Paul Nikitochkin | 2013-07-05 | 1 | -2/+1 |
| | | | | | | | | | simplified logic to calculate number of queries by using assert_queries | ||||
| * | | Remove deprecated `ActiveRecord::Base.disable_implicit_join_references=`. | Arun Agrawal | 2013-07-04 | 1 | -6/+0 |
| | | | |||||
| * | | Remove deprecated String constructor from `ActiveRecord::Migrator`. | Yves Senn | 2013-07-04 | 1 | -6/+0 |
| | | | |||||
| * | | Remove deprecated `scope` use without passing a callable object. | Arun Agrawal | 2013-07-03 | 1 | -10/+0 |
| | | | | | | | | | Removed tests from deprecated code. | ||||
| * | | Remove deprecated `transaction_joinable=` | Arun Agrawal | 2013-07-03 | 1 | -9/+0 |
| |/ | | | | | in favor of `begin_transaction` with `:joinable` option. | ||||
| * | remove deprecated `PostgreSQLAdapter#outside_transaction?` method. | Yves Senn | 2013-07-03 | 1 | -10/+0 |
| | | |||||
| * | Merge pull request #11258 from frodsan/remove_deprecated_distinct | Carlos Antonio da Silva | 2013-07-02 | 1 | -46/+0 |
| |\ | | | | | Remove deprecated SchemaStatements#distinct | ||||
| | * | Remove deprecated SchemaStatements#distinct | Francesco Rodriguez | 2013-07-02 | 1 | -46/+0 |
| | | | |||||
| * | | initialize generated modules on inclusion and on inheritence | Aaron Patterson | 2013-07-02 | 1 | -7/+0 |
| | | | |||||
| * | | fix to_sql output on eager loaded relations | Aaron Patterson | 2013-07-02 | 1 | -0/+8 |
| | | | |||||
| * | | remove private attribute reader | Aaron Patterson | 2013-07-02 | 1 | -2/+2 |
| |/ | |||||
| * | remove unused `ActiveRecord::TestCase#sqlite3` method. | Yves Senn | 2013-07-02 | 1 | -6/+0 |
| | | |||||
| * | deprecated `ActiveRecord::TestCase` is no longer public. | Yves Senn | 2013-07-02 | 1 | -2/+94 |
| | | | | | /cc @tenderlove | ||||
 |
index : rails.git | |
| Mirror of official rails repo with custom fixes. | Harald Eilertsen |
| aboutsummaryrefslogtreecommitdiffstats |