aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
...
* Merge pull request #11161 from dmitry/find_in_batches_works_without_loggerCarlos Antonio da Silva2013-06-281-0/+10
|\ | | | | | | | | ActiveRecord find_in_batches should work without logger When I set logger to nil both methods from Batches module find_in_batches or find_each should work anyway.
| * find_in_batches should work without loggerDmitry Polushkin2013-06-281-0/+10
| |
* | Simplify/fix implementation of default scopesJon Leighton2013-06-281-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous implementation was necessary in order to support stuff like: class Post < ActiveRecord::Base default_scope where(published: true) scope :ordered, order("created_at") end If we didn't evaluate the default scope at the last possible moment before sending the SQL to the database, it would become impossible to do: Post.unscoped.ordered This is because the default scope would already be bound up in the "ordered" scope, and therefore wouldn't be removed by the "Post.unscoped" part. In 4.0, we have deprecated all "eager" forms of scopes. So now you must write: class Post < ActiveRecord::Base default_scope { where(published: true) } scope :ordered, -> { order("created_at") } end This prevents the default scope getting bound up inside the "ordered" scope, which means we can now have a simpler/better/more natural implementation of default scoping. A knock on effect is that some things that didn't work properly now do. For example it was previously impossible to use #except to remove a part of the default scope, since the default scope was evaluated after the call to #except.
* | Apply default scope when joining associations.Jon Leighton2013-06-281-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For example: class Post < ActiveRecord::Base default_scope -> { where published: true } end class Comment belongs_to :post end When calling `Comment.join(:post)`, we expect to receive only comments on published posts, since that is the default scope for posts. Before this change, the default scope from `Post` was not applied, so we'd get comments on unpublished posts.
* | Fix testJon Leighton2013-06-281-1/+8
| | | | | | | | | | Oops. We need to estalish/remove the connection in the setup/teardown, else it messes with the fixtures.
* | Fix rake test_sqlite3_memJon Leighton2013-06-282-11/+7
| | | | | | | | Clearly nobody uses this except me. It's fast people!
* | Remove depreacted findersŁukasz Strzałkowski2013-06-284-635/+3
| | | | | | | | They were deprecated in 4.0, planned to remove in 4.1
* | Merge pull request #10730 from ↵Carlos Antonio da Silva2013-06-251-8/+9
|\ \ | | | | | | | | | | | | tkhr/add_test_for_AR__CounterCache#update_counters Add test for AR::CounterCache.update_counters
| * | Refactor AR's counter_cache_test.rb testTakehiro Adachi2013-05-231-8/+3
| | |
| * | Add test for AR::CounterCache.update_countersTakehiro Adachi2013-05-231-0/+6
| | |
* | | Merge pull request #10853 from kennyj/deprecated-database_tasksCarlos Antonio da Silva2013-06-253-280/+0
|\ \ \ | | | | | | | | Remove Oracle / Sqlserver / Firebird database tasks were deprecated since 4.0.
| * | | Remove FirebirdDatabaseTasks was deprecated, because this was provided by ↵kennyj2013-06-051-100/+0
| | | | | | | | | | | | | | | | 3rd-party.
| * | | Remove SqlseverDatabaseTasks was deprecated, because this was provided by ↵kennyj2013-06-051-87/+0
| | | | | | | | | | | | | | | | 3rd-party.
| * | | Remove OracleDatabaseTasks was deprecated, because this was provided by ↵kennyj2013-06-051-93/+0
| | | | | | | | | | | | | | | | 3rd-party.
* | | | Merge pull request #10992 from Empact/find-each-enumeratorCarlos Antonio da Silva2013-06-251-0/+18
|\ \ \ \ | | | | | | | | | | | | | | | When .find_each is called without a block, return an Enumerator.
| * | | | When .find_each is called without a block, return an Enumerator.Ben Woosley2013-06-191-0/+18
| | | | | | | | | | | | | | | | | | | | This lets us do things like call: .find_each.with_index
* | | | | Merge pull request #10993 from Empact/result-each-enumeratorCarlos Antonio da Silva2013-06-251-0/+32
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | Change Result#each to return an Enumerator when called without a block.
| * | | | | Change Result#each to return an Enumerator when called without a block.Ben Woosley2013-06-181-0/+33
| |/ / / / | | | | | | | | | | | | | | | As with #10992, this lets us call #with_index, etc on the results.
* | | | | Fix `another_contract` not being used warningVipul A M2013-06-241-1/+1
| | | | |
* | | | | test-case to prevent regressions described in #10901.Jared Armstrong2013-06-241-0/+27
| | | | |
* | | | | test-case to prevent regressions on `Association#build` with an Array.Yves Senn2013-06-221-0/+10
| | | | | | | | | | | | | | | | | | | | Closes #11026
* | | | | flatten merged join_values before building the joinsNeeraj Singh2013-06-221-1/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fixes #10669 While joining_values special treatment is given to string values. By flattening the array it ensures that string values are detected as strings and not arrays.
* | | | | do not load all child records for inverse caseNeeraj Singh2013-06-211-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | currently `post.comments.find(Comment.first.id)` would load all comments for the given post to set the inverse association. This has a huge performance penalty. Because if post has 100k records and all these 100k records would be loaded in memory even though the comment id was supplied. Fix is to use in-memory records only if loaded? is true. Otherwise load the records using full sql. Fixes #10509
* | | | | fix bad test by making number that fits for integerNeeraj Singh2013-06-211-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PR https://github.com/rails/rails/pull/10566 had to be reverted because after applying the fix test "test_raise_record_not_found_error_when_invalid_ids_are_passed" started failing. In this test invalid_id is being assigned a really large number which was causing following failure when PR #10566 was applied. ``` RangeError: bignum too big to convert into `long long' SELECT `interests`.* FROM `interests` WHERE `interests`.`man_id` = ? AND `interests`.`id` = ? LIMIT 1 [["man_id", 970345987], ["id", 2394823094892348920348523452345]] ``` This test is not failing in master because when test code `man.interests.find(invalid_id)` is executed then interests are fully loaded in memory and no database query is executed. After PR #10566 was merged then test code `man.interests.find(invalid_id)` started executing sql query and hence the error. In case someone is wondering why the second part of query is not failing, then that's because the actual query does not require any variable substituation where the number is large. In that case the sql generate is following. ``` SELECT `interests`.* FROM `interests` WHERE `interests`.`man_id` = ? AND `interests`.`id` IN (8432342, 2390102913, 2453245234523452) [["man_id", 970345987]] ```
* | | | | `inspect` for AR model classes does not initiate a new connection.Yves Senn2013-06-201-0/+20
| |_|_|/ |/| | |
* | | | Merge pull request #10884 from dmarkow/pg_fix_default_quotesYves Senn2013-06-191-0/+25
|\ \ \ \ | | | | | | | | | | Handle single quotes in PostgreSQL default column values
| * | | | Handle single quotes in PostgreSQL default column valuesDylan Markow2013-06-191-0/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PostgreSQL escapes single quotes by using an additional single quote. When Rails queries the column information, PostgreSQL returns the default values with the escaped single quotes. #extract_value_from_default now converts these to one single quote each. Fixes #10881.
* | | | | Revert "Merge pull request #10566 from neerajdotname/10509d"Jon Leighton2013-06-191-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 2b817a5e89ac0e7aeb894a40ae7151a0cf3cef16, reversing changes made to 353a398bee68c5ea99d76ac7601de0a5fef6f4a5. Conflicts: activerecord/CHANGELOG.md Reason: the build broke
* | | | | log the sql that is actually sent to the databaseNeeraj Singh2013-06-191-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If I have a query that produces sql `WHERE "users"."name" = 'a b'` then in the log all the whitespace is being squeezed. So the sql that is printed in the log is `WHERE "users"."name" = 'a b'`. This can be confusing. This commit fixes it by ensuring that whitespace is not squeezed. fixes #10982
* | | | | do not load all child records for inverse caseNeeraj Singh2013-06-191-0/+8
| |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | currently `post.comments.find(Comment.first.id)` would load all comments for the given post to set the inverse association. This has a huge performance penalty. Because if post has 100k records and all these 100k records would be loaded in memory even though the comment id was supplied. Fix is to use in-memory records only if loaded? is true. Otherwise load the records using full sql. Fixes #10509
* | | | Merge pull request #10987 from senny/10979_association_include_returns_trueXavier Noria2013-06-181-11/+11
|\ \ \ \ | | | | | | | | | | `CollectionProxy#include?` returns `true` and `false` as documented.
| * | | | `CollectionProxy#include?` returns `true` and `false` as documented.Yves Senn2013-06-181-11/+11
| | | | |
* | | | | just construct real objects rather than mock and stubAaron Patterson2013-06-171-7/+8
| | | | |
* | | | | Merge branch 'master' into mrbrdo-fixserializationAaron Patterson2013-06-1715-32/+76
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (142 commits) Use Colspan in th Tags Added test for link_to_unless to make sure the result consistency. Escape the string even when the condition of link_to_unless is not satisfied. Add CHANGELOG entry for #10969 Use a case insensitive URI Regexp for #asset_path collection tags accept html attributes as the last element of collection Rewind StringIO instances before be parsed again Use xml instead already parsed xml Updated the doc for const_regexp [ci skip] Make test name descriptive and add reference to original regression commit fixture setup does not rely on `AR::Base.configurations`. regression test + mysql2 adapter raises correct error if conn is closed. cleanup, remove trailing whitespace from AR changelog 'json' gem is no more required under JRuby fix typos Fix AS changelog [ci skip] Update the HTML boolean attributes per the HTML 5.1 spec Changing const_regexp to check for constant name. valid_app_const? -> valid_const? Add CHANGELOG entry for #10740 ...
| * \ \ \ \ Merge pull request #10533 from vipulnsward/fix_testRafael Mendonça França2013-06-151-1/+2
| |\ \ \ \ \ | | |/ / / / | |/| | | | Fix test, addresss => address
| | * | | | Make test name descriptive and add reference to original regression commitVipul A M2013-06-151-1/+2
| | | | | |
| * | | | | fixture setup does not rely on `AR::Base.configurations`.Yves Senn2013-06-151-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As you can also configure your database connection using `ENV["DATABASE_URL"]`, the fixture setup can't reply on the `.configurations` Hash. As the fixtures are only loaded when ActiveRecord is actually used (`rails/test_help.rb`) it should be safe to drop the check for an existing configuration.
| * | | | | regression test + mysql2 adapter raises correct error if conn is closed.Yves Senn2013-06-151-0/+26
| | | | | |
| * | | | | Merge pull request #10953 from acapilleri/fix_typosYves Senn2013-06-151-1/+1
| |\ \ \ \ \ | | | | | | | | | | | | | | fix typos
| | * | | | | fix typosAngelo Capilleri2013-06-151-1/+1
| | | |_|/ / | | |/| | |
| * | | | | This test does not test anything that happens in the real world. If youAaron Patterson2013-06-131-20/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | recreate the models without mucking with internal caches of the relation objects, then the test fails. For example: class Man < ActiveRecord::Base has_many :interests end class Interest < ActiveRecord::Base belongs_to :man end Then do this test: def test_validate_presence_of_parent_fails_without_inverse_of repair_validations(Interest) do Interest.validates_presence_of(:man) assert_no_difference ['Man.count', 'Interest.count'] do man = Man.create(:name => 'John', :interests_attributes => [{:topic=>'Cars'}, {:topic=>'Sports'}]) assert_not_predicate man.errors[:"interests.man"], :empty? end end end The test will fail. This is a bad test, so I am removing it.
| * | | | | refute the predicate for better failure messagesAaron Patterson2013-06-131-1/+1
| | | | | |
| * | | | | Ambiguous reflections are on :through relationships are no longer supported.Aaron Patterson2013-06-132-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For example, you need to change this: class Author < ActiveRecord::Base has_many :posts has_many :taggings, :through => :posts end class Post < ActiveRecord::Base has_one :tagging has_many :taggings end class Tagging < ActiveRecord::Base end To this: class Author < ActiveRecord::Base has_many :posts has_many :taggings, :through => :posts, :source => :tagging end class Post < ActiveRecord::Base has_one :tagging has_many :taggings end class Tagging < ActiveRecord::Base end
| * | | | | indentationAaron Patterson2013-06-111-1/+1
| | | | | |
| * | | | | Remove fall back and column restrictions for `count`.Yves Senn2013-06-091-0/+9
| | | | | |
| * | | | | Getting rid of the +automatic_inverse_of: false+ option in associations in favorwangjohn2013-06-085-5/+5
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | of using +inverse_of: false+ option. Changing the documentation and adding a CHANGELOG entry for the automatic inverse detection feature.
| * | | | Merge pull request #10561 from Empact/nix-throwresultJon Leighton2013-06-072-2/+14
| |\ \ \ \ | | |/ / / | |/| | | Rather than raising ThrowResult when construct_limited_ids_conditions comes up empty, set the relation to NullRelation and rely on its results.
| | * | | Make NullRelation a bit more like a real relation by returning 0 for ↵Ben Woosley2013-05-101-2/+3
| | | | | | | | | | | | | | | | | | | | #calculate(:count)
| | * | | Add coverage for the fact that pluck without an argument returns all the ↵Ben Woosley2013-05-101-0/+5
| | | | | | | | | | | | | | | | | | | | table's columns.
| | * | | Fix that #pluck wasn't rescuing ThrowResult, meaning it would blow up when ↵Ben Woosley2013-05-101-0/+6
| | | | | | | | | | | | | | | | | | | | failing to construct_limited_ids_condition.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-07 16:39:21 +0000