| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
conditions and includes,
when condtions references tables from includes.
Test fail because of invalid sql:
ActiveRecord::StatementInvalid: SQLite3::SQLException: no such column: comments.id:
SELECT "posts".id FROM "posts" INNER JOIN "readers" ON "posts"."id" = "readers"."post_id"
WHERE "readers"."person_id" = 1 AND (comments.id is null)
Bug described in github#925
This commit will revert fix from https://github.com/rails/rails/commit/3436fdfc12d58925e3d981e0afa61084ea34736c , but tests is ok.
Bug described in #6569 ticket.
|
|\ \ \ \
| | | | |
| | | | | |
Addresses an inconsistency in the ActiveRecord::Base.method_missing handl
|
| | | | |
| | | | |
| | | | |
| | | | | |
of dynamic finder methods and the passing of the &block parameter for :find_by_attributes.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix failing test because of Timezone difference.
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fixed AR::Relation#sum compatibility with Array#sum
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
In order make Relation behavior closer to Array
Made Relation#sum to accept block and delegate it to Array#sum
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Fixed CollectionAssociation#find to be compatible with Array#find
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
In order to make CollectionAssociation behave closer to Array
Add the ability to pass block to #find method just like Array#find does.
|
|/ / / / / / |
|
| |_|_|/ /
|/| | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The changes broke bulk migration tests and were fixed in 4d256bc6;
however that brought back the issue of #1857 and so this commit goes
back to the original scenario and just adds change_table to the list
of methods which are to be recorded in the CommandRecorder. The
method_missing now delegates all calls to the underlying connection as
before.
|
| | | | |
| | | | |
| | | | |
| | | | | |
before_initialize callback of the record runs. Fixes #1842.
|
| | | | |
| | | | |
| | | | |
| | | | | |
joins
|
| | | | |
| | | | |
| | | | |
| | | | | |
tests in migration_test.rb under mysql. The problem was introduced in c278a2c5e109204ec8a47fcbfdfc327aad7996ce.
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
oriolgual/1571_ar_relation_order_no_longer_works_with_arel_nodes
Fix #1571 ActiveRecord::Relation#order no longer works with arel ordering nodes
|
| | | | | | |
|
| | | | | | |
|
|/ / / / /
| | | | |
| | | | | |
Use latest Arel syntax and pass each order by expression as separate argument to order method as otherwise invalid Oracle SQL is generated.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
IrreversibleMigration is not raised when a method not supported by reversible migrations is called in the change method of a migration
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
unsupported methods go through to the underlying db causing errors like duplicate columns to occur when rolling back migrations
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Allow comparison on model objects - Closes #1858
|
| | | | | | | |
|
| |/ / / / / |
|
| | | | | | |
|
|/ / / / /
| | | | |
| | | | |
| | | | | |
test surrounding create_with(nil) behavior
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix for complex ordering of multiple columns on postgresql
|
| | |_|/ /
| |/| | |
| | | | |
| | | | |
| | | | | |
* Only on postgresql, order("first asc, second asc") was invalid
* Closes #1720
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Support reversal of ARel orderings in reverse_sql_order
|
| | | | | |
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Improving PostgreSQL adapter schema-awareness
|
| |\ \ \ \ |
|
| | | | | |
| | | | | |
| | | | | | |
* amongst other things, allows meta_search to run against view-backed models
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | | |
* add/cleanup tests
|
| | | | | |
| | | | | |
| | | | | | |
* tidy test code and fix my typo
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* table_exists? scoped by schema search path unless schema is explicitly named. Added tests and doc to clarify the behaviour
* extract_schema_and_table tests and implementation extended to cover all cases
* primary_key does not ignore schema information
* add current_schema and schema_exists? methods
* more robust table referencing in insert_sql and sql_for_insert methods
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fix default options argument on ActiveRecord::ConnectionAdaptors::Table#column_exists?
|
| | |/ / / /
| |/| | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
ActiveRecord::ConnectionAdapters::Table#column_exists? from nil to an empty Hash {}.
That method calls through to ActiveRecord::ConnectionAdapters::SchemaStatements##column_exists? expects options to be a Hash.
When options was nil, an error would occur in cases where the column did exist because the called method attempted to perform a key lookup on options.
|
|/ / / / /
| | | | |
| | | | |
| | | | | |
Rack::Sendfile to function properly. See issue #1761.
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
location of the config.yml file for running the tests
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
not a single line of SQL should be sent to the database, not even stuff that is ignored by assert_queries. The argument being that if you write assert_no_queries, you really do not want there to be any queries.
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
case in assert_queries
|
|/ / / /
| | | |
| | | |
| | | | |
are not needed, so the connection adapter does not send empty BEGIN COMMIT transactions blocks to the database.
|