Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fix failure in test_preserves_existing_fixture_data from ↵ | Jon Leighton | 2011-07-12 | 1 | -2/+2 |
| | | | | test/cases/fixtures_test.rb when UTC and local time occur on different dates. | ||||
* | Fix exception if old and new targets are both nil. Fixes #1471. | Jon Leighton | 2011-07-12 | 3 | -1/+14 |
| | |||||
* | Merge pull request #1929 from sobrinho/master | Santiago Pastorino | 2011-07-11 | 1 | -0/+14 |
|\ | | | | | Create a test case for disable_referential_integrity | ||||
| * | Create a test case for disable_referential_integrity | Gabriel Sobrinho | 2011-07-01 | 1 | -0/+14 |
| | | |||||
* | | Merge pull request #1823 from gnarg/master | Santiago Pastorino | 2011-07-10 | 1 | -0/+8 |
|\ \ | | | | | | | Log instrumentation name for exists? queries | ||||
| * | | Log instrumentation name for exists? queries | Jon Guymon | 2011-06-22 | 1 | -0/+8 |
| | | | |||||
* | | | to_key on a destroyed model should return nil | Santiago Pastorino | 2011-07-09 | 1 | -1/+1 |
| | | | |||||
* | | | formats | Akira Matsuda | 2011-07-09 | 1 | -5/+5 |
| | | | |||||
* | | | fix AR having() not to raise NoMethodError when the given argument does not ↵ | Akira Matsuda | 2011-07-09 | 1 | -0/+7 |
| | | | | | | | | | | | | | | | | | | respond to empty? having raises NoMethodError: undefined method `empty?' when a Fixnum or Date/Time were passed via varargs | ||||
* | | | Foo.joins(:bar).includes(:bar) should result in a single query with :bar as ↵ | Jon Leighton | 2011-07-09 | 1 | -0/+8 |
| | | | | | | | | | | | | a join. Related: #1873. | ||||
* | | | Merge pull request #2017 from Casecommons/active_record_lint | José Valim | 2011-07-08 | 2 | -0/+12 |
|\ \ \ | | | | | | | | | ActiveRecord::Base subclasses should pass ActiveModel::Lint. | ||||
| * | | | ActiveRecord::Base should pass ActiveModel::Lint. | Grant Hutchins & Peter Jaros | 2011-07-08 | 2 | -0/+12 |
| | | | | |||||
* | | | | Destroy association habtm record before destroying the record itself. Fixes ↵ | Tomas D'Stefano | 2011-07-08 | 2 | -0/+12 |
| | | | | | | | | | | | | | | | | issue #402. | ||||
* | | | | Ensure that the foreign key gets set when doing record.create_association or ↵ | Jon Leighton | 2011-07-08 | 1 | -0/+14 |
| | | | | | | | | | | | | | | | | record.create_association. Fixes #1960. | ||||
* | | | | Refactor PostgreSQLAdapter a bit | Daniel Schierbeck | 2011-07-08 | 1 | -2/+2 |
|/ / / | | | | | | | | | | | | | Move the private method #extract_schema_and_table into a separate Utils module so that it can be tested without resorting to #send. | ||||
* | | | Use Enumerable#with_index. We're on Ruby > 1.8.7 (part II) | Akira Matsuda | 2011-07-08 | 1 | -3/+1 |
| | | | |||||
* | | | Make `ActiveRecord::Batches#find_each` to not return `self`. | knapo | 2011-07-07 | 1 | -0/+7 |
| | | | | | | | | | | | | This caused that `find_each` was producing extra db call taking all the records from db, and was less efficient than `ActiveRecord::Base#all`. | ||||
* | | | Fix bug in collection_singular_ids on has many through association with ↵ | Anatoliy Lysenko | 2011-07-06 | 1 | -0/+5 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | conditions and includes, when condtions references tables from includes. Test fail because of invalid sql: ActiveRecord::StatementInvalid: SQLite3::SQLException: no such column: comments.id: SELECT "posts".id FROM "posts" INNER JOIN "readers" ON "posts"."id" = "readers"."post_id" WHERE "readers"."person_id" = 1 AND (comments.id is null) Bug described in github#925 This commit will revert fix from https://github.com/rails/rails/commit/3436fdfc12d58925e3d981e0afa61084ea34736c , but tests is ok. Bug described in #6569 ticket. | ||||
* | | | Merge pull request #1273 from jeremyf/feature-association-proxy-send | Santiago Pastorino | 2011-07-06 | 1 | -0/+9 |
|\ \ \ | | | | | | | | | Addresses an inconsistency in the ActiveRecord::Base.method_missing handl | ||||
| * | | | Addresses an inconsistency in the ActiveRecord::Base.method_missing handling ↵ | Jeremy Friesen | 2011-05-24 | 1 | -0/+9 |
| | | | | | | | | | | | | | | | | of dynamic finder methods and the passing of the &block parameter for :find_by_attributes. | ||||
* | | | | Merge pull request #1494 from anildigital/master | Santiago Pastorino | 2011-07-06 | 1 | -2/+2 |
|\ \ \ \ | | | | | | | | | | | Fix failing test because of Timezone difference. | ||||
| * | | | | Fix failing test because of Timezone difference. | Anil Wadghule | 2011-06-05 | 1 | -2/+2 |
| | | | | | |||||
* | | | | | Merge pull request #1979 from bogdan/association_sum_array_compatibility | Jon Leighton | 2011-07-06 | 1 | -0/+4 |
|\ \ \ \ \ | | | | | | | | | | | | | Fixed AR::Relation#sum compatibility with Array#sum | ||||
| * | | | | | Fixed AR::Relation#sum compatibility with Array#sum | Bogdan Gusiev | 2011-07-05 | 1 | -0/+4 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In order make Relation behavior closer to Array Made Relation#sum to accept block and delegate it to Array#sum | ||||
* | | | | | | Merge pull request #1968 from bogdan/associations_find_array_compatibility2 | Santiago Pastorino | 2011-07-05 | 1 | -0/+4 |
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | Fixed CollectionAssociation#find to be compatible with Array#find | ||||
| * | | | | | Fixed CollectionAssociation#find to be compatible with Array#find | Bogdan Gusiev | 2011-07-05 | 1 | -0/+4 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In order to make CollectionAssociation behave closer to Array Add the ability to pass block to #find method just like Array#find does. | ||||
* | | | | | | Only call set_owner_attributes for has_one association if target exists. | Dieter Komendera | 2011-07-04 | 1 | -0/+11 |
|/ / / / / | |||||
* | | | / | Reversing the changes done in c278a2c while still resolving #1857. | Vijay Dev | 2011-07-02 | 1 | -5/+3 |
| |_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The changes broke bulk migration tests and were fixed in 4d256bc6; however that brought back the issue of #1857 and so this commit goes back to the original scenario and just adds change_table to the list of methods which are to be recorded in the CommandRecorder. The method_missing now delegates all calls to the underlying connection as before. | ||||
* | | | | Assign the association attributes to the associated record before the ↵ | Jon Leighton | 2011-06-30 | 3 | -2/+21 |
| | | | | | | | | | | | | | | | | before_initialize callback of the record runs. Fixes #1842. | ||||
* | | | | cache the plural name on the reflection so we do not pay pluralize costs on ↵ | Aaron Patterson | 2011-06-30 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | joins | ||||
* | | | | CommandRecorder should delegate in method_missing where possible. Fixes some ↵ | Jon Leighton | 2011-06-30 | 1 | -1/+6 |
| | | | | | | | | | | | | | | | | tests in migration_test.rb under mysql. The problem was introduced in c278a2c5e109204ec8a47fcbfdfc327aad7996ce. | ||||
* | | | | Merge pull request #1574 from ↵ | Aaron Patterson | 2011-06-28 | 1 | -0/+12 |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | oriolgual/1571_ar_relation_order_no_longer_works_with_arel_nodes Fix #1571 ActiveRecord::Relation#order no longer works with arel ordering nodes | ||||
| * | | | | Add more test cases | Oriol Gual | 2011-06-28 | 1 | -0/+8 |
| | | | | | |||||
| * | | | | Add failing test | Oriol Gual | 2011-06-28 | 1 | -0/+4 |
| | | | | | |||||
* | | | | | Fix test_finding_with_cross_table_order_and_limit for Oracle | Raimonds Simanovskis | 2011-06-28 | 1 | -3/+3 |
|/ / / / | | | | | | | | | Use latest Arel syntax and pass each order by expression as separate argument to order method as otherwise invalid Oracle SQL is generated. | ||||
* | | | | Merge pull request #1857 from vijaydev/irreversible-migration | Aaron Patterson | 2011-06-28 | 1 | -3/+5 |
|\ \ \ \ | | | | | | | | | | | IrreversibleMigration is not raised when a method not supported by reversible migrations is called in the change method of a migration | ||||
| * | | | | record unsupported methods in CommandRecorder instead of letting the ↵ | Vijay Dev | 2011-06-25 | 1 | -3/+5 |
| | | | | | | | | | | | | | | | | | | | | unsupported methods go through to the underlying db causing errors like duplicate columns to occur when rolling back migrations | ||||
* | | | | | Merge pull request #1860 from dmathieu/comparison | Aaron Patterson | 2011-06-28 | 1 | -0/+13 |
|\ \ \ \ \ | | | | | | | | | | | | | Allow comparison on model objects - Closes #1858 | ||||
| * | | | | | comparing different classes returns nil | Damien Mathieu | 2011-06-26 | 1 | -0/+6 |
| | | | | | | |||||
| * | | | | | allow comparison on model objects - Closes #1858 | Damien Mathieu | 2011-06-26 | 1 | -0/+7 |
| |/ / / / | |||||
* | | | | | oops! remove debugging codes | Aaron Patterson | 2011-06-27 | 1 | -1/+0 |
| | | | | | |||||
* | | | | | default create_with_value to a hash so we can eliminate conditionals, add ↵ | Aaron Patterson | 2011-06-27 | 2 | -1/+9 |
|/ / / / | | | | | | | | | | | | | test surrounding create_with(nil) behavior | ||||
* | | | | Merge pull request #1848 from raviolicode/postgresql_order_multiple_params | Santiago Pastorino | 2011-06-24 | 1 | -0/+7 |
|\ \ \ \ | | | | | | | | | | | Fix for complex ordering of multiple columns on postgresql | ||||
| * | | | | Improve ordering of multiple columns on postgresql | Lucia Escanellas | 2011-06-24 | 1 | -0/+7 |
| | |_|/ | |/| | | | | | | | | | | | | | | * Only on postgresql, order("first asc, second asc") was invalid * Closes #1720 | ||||
* / | | | Apply the default scope earlier when doing calculations. Fixes #1682. | Jon Leighton | 2011-06-23 | 2 | -0/+13 |
|/ / / | |||||
* | | | Merge pull request #1790 from ernie/reverse_sql_order_fix | Aaron Patterson | 2011-06-22 | 1 | -0/+12 |
|\ \ \ | | | | | | | | | Support reversal of ARel orderings in reverse_sql_order | ||||
| * | | | Support reversal of ARel orderings in reverse_sql_order | Ernie Miller | 2011-06-20 | 1 | -0/+12 |
| | | | | |||||
* | | | | Merge pull request #1632 from tardate/pg_schema_fu | Aaron Patterson | 2011-06-21 | 3 | -3/+213 |
|\ \ \ \ | |/ / / |/| | | | Improving PostgreSQL adapter schema-awareness | ||||
| * | | | Merge remote branch 'rails/master' into pg_schema_fu | Paul Gallagher | 2011-06-19 | 7 | -43/+372 |
| |\ \ \ | |||||
| * | | | | Make PostgreSQL adapter view-compatible | Paul Gallagher | 2011-06-19 | 2 | -1/+49 |
| | | | | | | | | | | | | | | | * amongst other things, allows meta_search to run against view-backed models |