aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | Always prefer class types to query types when casting `group`Sean Griffin2016-07-111-0/+6
| |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When `group` is used in combination with any calculation method, the resulting hash uses the grouping expression as the key. Currently we're incorrectly always favoring the type reported by the query, instead of the type known by the class. This causes differing behavior depending on whether the adaptor actually gives proper types with the query or not. After this change, the behavior will be the same on all adaptors -- we see if we know the type from the class, fall back to the type from the query, and finally fall back to the identity type. Fixes #25595
* | | fix to_param to maximize contentRob Biedenharn2016-07-081-2/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The documentation states that parameter values longer than 20 characters will be truncated by words, but the example shows that a parameter based on "David Heinemeier Hansson" (with id: 125) becomes "125-david" when "David Heinemeier".length == 16 so why so short? The answer lies in the use of the #truncate option omission: nil which seems to have been intended to mean "nothing", but which actually causes the default string "..." to be used. This causes #truncate to cleave words until the "..." can be added and still remain within the requested size of 20 characters. The better option is omission: '' (which is probably what was originally intended). Furthermore, since the use of #parameterize will remove non-alphanumeric characters, we can maximize the useful content of the output by calling parameterize first and then giving truncate a separator: /-/ rather than a space.
* | | Merge pull request #25707 from matthewd/double-reapMatthew Draper2016-07-071-1/+4
|\ \ \ | | | | | | | | Don't reap connections that have already been reassigned
| * | | Make connection stealing more explicitMatthew Draper2016-07-061-1/+4
| | | |
* | | | Merge pull request #24890 from vipulnsward/travel-to-raiseKasper Timm Hansen2016-07-051-6/+5
|\ \ \ \ | |/ / / |/| | | `travel/travel_to` travel time helpers, now raise on nested calls
| * | | `travel/travel_to` travel time helpers, now raise on nested calls,Vipul A M2016-07-021-6/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | as this can lead to confusing time stubbing. Instead of: travel_to 2.days.from_now do # 2 days from today travel_to 3.days.from_now do # 5 days from today end end preferred way to achieve above is: travel_to 2.days.from_now # 2 days from today travel_back travel_to 5.days.from_now # 5 days from today Closes #24690 Fixes #24689
* | | | Fix typo: accidently -> accidentally.Hendy Tanata2016-07-021-1/+1
| |/ / |/| |
* | | Merge pull request #25507 from ↵Rafael França2016-07-021-0/+10
|\ \ \ | | | | | | | | | | | | | | | | bquorning/optimize-for-first-result-and-remove-mysql-select_one Remove #select_one from Mysql2Adapter
| * | | Optimize ActiveRecord::Result#lastBenjamin Quorning2016-06-241-0/+5
| | | | | | | | | | | | | | | | | | | | If you only want the last element of a result set, there's no need to create all of hash_rows. Also, add a test.
| * | | Add ActiveRecord::Result#firstBenjamin Quorning2016-06-241-0/+5
| | | | | | | | | | | | | | | | | | | | When you only need the first element of a result set, you shouldn't need to instantiate all of hash_rows.
* | | | Merge pull request #25631 from yahonda/revert_rename_to_ar_internal_metadataRafael França2016-07-011-15/+0
|\ \ \ \ | | | | | | | | | | Revert "Rename `active_record_internal_metadatas` to `ar_internal_metadata"
| * | | | Revert "Rename `active_record_internal_metadatas` to `ar_internal_metadata`"Yasuo Honda2016-07-011-15/+0
| | |/ / | |/| | | | | | | | | | This reverts commit 407e0ab5e5cddf6a8b6b278b12f50772d13b4d86.
* | | | Merge pull request #25620 from kamipo/create_without_primary_keyRafael França2016-07-011-0/+8
|\ \ \ \ | |/ / / |/| | | Pass `pk: false` to `connection.insert` explicitly if do not have a primary key
| * | | Pass `pk: false` to `connection.insert` explicitly if do not have a primary keyRyuta Kamizono2016-07-011-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | Because causing an extra query by `sql_for_insert` for guessing a primary key. https://github.com/rails/rails/blob/v5.0.0/activerecord/lib/active_record/connection_adapters/postgresql/database_statements.rb#L121-L125
* | | | Add regression test for foreign key schema dump cachingeileencodes2016-07-011-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If you had a foreign key set and then decided to add `on_delete: :cascade` later in another migration that migration would run but wouldn't refresh the schema dump. The reason for this was because `create_table_info` caches the statement and sets it to be the same as the original declaration for the foreign key (without the `on_delete: :cascade`. PR #25307 ended up fixing this bug because it removes the check for `create_table_info` and relies on reading from `information_schema`. The fix however was intended to patch another bug. The reason this fixes the issue is we're no longer parsing the regex from the cached `create_table_info`. This regression test is to ensure that the issue does not return if we for some reason go back to using `create_table_info` to set the foreign keys.
* | | | Merge pull request #25307 from ↵Eileen M. Uchitelle2016-07-013-19/+29
|\ \ \ \ | |/ / / |/| | | | | | | | | | | kamipo/extract_foreign_key_action_from_information_schema Extract foreign key action from `information_schema`
| * | | Extract foreign key action from `information_schema`Ryuta Kamizono2016-06-073-19/+29
| | | | | | | | | | | | | | | | Fixes #25300.
* | | | Do not specal case inspecting associated arrays of over 10 elements, ↵Kevin McPhillips2016-06-292-3/+27
| | | | | | | | | | | | | | | | preventing infinite looping in some cases.
* | | | Remove unused `ActiveRecord::Base.connection_id`Sean Griffin2016-06-291-12/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This method appears to have been partially used in connection pool caching, but it was introduced without much reasoning or any tests. One edge case test was added later on, but it was focused on implementation details. This method is no longer used outside of tests, and as such is removed.
* | | | Merge pull request #25364 from kamipo/fix_serialize_for_date_typeRafael França2016-06-281-1/+13
|\ \ \ \ | | | | | | | | | | Fix `Type::Date#serialize` to return a date object correctly
| * | | | Fix `Type::Date#serialize` to return a date object correctlyRyuta Kamizono2016-06-161-1/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently `Type::Date#serialize` does not cast a value to a date object. It should be cast to a date object for finding by date column correctly working. Fixes #25354.
* | | | | Remove unnecessary `assert_valid_default`Ryuta Kamizono2016-06-251-7/+0
| | | | | | | | | | | | | | | | | | | | | | | | | This was added at c7c3f73 but it never raised because MySQL cannot create text/blob columns with a default value.
* | | | | Merge pull request #25506 from y-yagi/return_correct_from_enum_typeSean Griffin2016-06-241-0/+4
|\ \ \ \ \ | |_|_|/ / |/| | | | return correct type from `EnumType`
| * | | | return correct type from `EnumType`yuuji.yaginuma2016-06-241-0/+4
| | | | |
* | | | | Removed a forgotten `with_exclusive_scope` test:Edouard CHIN2016-06-241-6/+0
|/ / / / | | | | | | | | | | | | - `with_exclusive_scope` was removed in this commit d242e467819a428ad7e302968e4c9fa1e26d9326
* | | | Merge pull request #23301 from ppworks/improve_mysqldumpArthur Nogueira Neves2016-06-171-4/+4
|\ \ \ \ | | | | | | | | | | Improve mysqldump
| * | | | Skip comments when exec mysqldumpNaoto Koshikawa2016-01-281-4/+4
| | | | |
* | | | | Merge pull request #24773 from ralinc/fix-silent-fail-on-psql-commandArthur Nogueira Neves2016-06-161-2/+2
|\ \ \ \ \ | |_|/ / / |/| | | | PostgreSQL: Fix db:structure:load silent failure on SQL error
| * | | | PostgreSQL: Fix db:structure:load silent failure on SQL errorRalin Chimev2016-05-101-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The command line flag "-v ON_ERROR_STOP=1" should be used when invoking psql to make sure errors are not suppressed. Example: psql -v ON_ERROR_STOP=1 -q -f awesome-file.sql my-app-db Fixes #23818.
* | | | | Merge pull request #25271 from kamipo/prevent_range_error_for_existsSean Griffin2016-06-151-4/+2
|\ \ \ \ \ | | | | | | | | | | | | Prevent `RangeError` for `FinderMethods#exists?`
| * | | | | Prevent `RangeError` for `FinderMethods#exists?`Ryuta Kamizono2016-06-161-4/+2
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `FinderMethods#exists?` should return a boolean rather than raising an exception. `UniquenessValidator#build_relation` catches a `RangeError` because it includes type casting due to a string value truncation. But a string value truncation was removed at #23523 then type casting in `build_relation` is no longer necessary. aa06231 removes type casting in `build_relation` then a `RangeError` moves to `relation.exists?`. This change will remove the catching a `RangeError`.
* | | | | Fix postgresql query_cache testArthur Neves2016-06-141-0/+1
| | | | |
* | | | | Respect the current `connected?` method when calling `cache`Arthur Neves2016-06-141-0/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before we enable query caching we check if the connection is connected. Before this fix we were always checking against the main connection, and not the model connection.
* | | | | Remove not needed line on testArthur Neves2016-06-141-1/+0
| | | | |
* | | | | Merge pull request #25374 from ↵Sean Griffin2016-06-131-0/+4
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | kamipo/fix_calculate_with_string_in_from_and_eager_loading Fix `calculate` with a string value in `from` and eager loading
| * | | | | Fix `calculate` with a string value in `from` and eager loadingRyuta Kamizono2016-06-131-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `construct_relation_for_association_calculations` pass a string value to `construct_join_dependency` when setting a string value in `from`. It should not pass a string value, but always `joins_values`. Related #14834, #19452. Fixes #24193.
* | | | | | Merge pull request #25372 from kamipo/remove_assert_date_from_dbSean Griffin2016-06-132-5/+1
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Remove unnecessary `assert_date_from_db`
| * | | | | Remove unnecessary `assert_date_from_db`Ryuta Kamizono2016-06-122-5/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `assert_date_from_db` was added at 6a2104d for SQL Server. But latest sqlserver adapter work to pass expected behavior since 8e4624b.
* | | | | | Merge pull request #25362 from maclover7/jm-rm-ar-requireEileen M. Uchitelle2016-06-121-2/+0
|\ \ \ \ \ \ | | | | | | | | | | | | | | Remove unnecessary model requires
| * | | | | | Remove unnecessary model requiresJon Moss2016-06-101-2/+0
| |/ / / / /
* / / / / / Remove outdated comments [ci skip]Ryuta Kamizono2016-06-121-12/+0
|/ / / / / | | | | | | | | | | | | | | | | | | | | These comments were added at dd257a3ccb30ab181cd48d3d81bc7f23bb45f36f but outdated since #2086.
* | | | | Remove dead code from testsSean Griffin2016-06-091-17/+0
| | | | | | | | | | | | | | | | | | | | | | | | | This code was added in 81286f858770e0b95e15af37f19156b044ec6a95, but was not used by that commit and does not appear to have ever been used.
* | | | | Merge pull request #25329 from ↵Sean Griffin2016-06-091-1/+1
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | yahonda/allow_oracle_bind_value_syntax_in_loj_test Allow Oracle bind parameter syntax `:a1` in test_join_conditions_added_to_join_clause
| * | | | | Allow Oracle bind parameter syntax `:a1`Yasuo Honda2016-06-081-1/+1
| |/ / / /
* / / / / Fix typoAbhishek Jain2016-06-091-2/+2
|/ / / /
* | | | Fix sqlite3 test failureRyuta Kamizono2016-06-042-3/+3
| | | | | | | | | | | | | | | | Sqlite3 test failure is due to 66ebbc4952f6cfb37d719f63036441ef98149418.
* | | | Dont re-define class SQLite3Adapter on testArthur Neves2016-06-032-108/+98
| | | | | | | | | | | | | | | | | | | | | | | | | | | | We were declaring in a few tests, which depending of the order load will cause an error, as the super class could change. see https://github.com/rails/rails/commit/ac1c4e141b20c1067af2c2703db6e1b463b985da#commitcomment-17731383
* | | | Merge pull request #25243 from sukesan1984/add_i18n_validation_testYves Senn2016-06-031-4/+2
|\ \ \ \ | | | | | | | | | | Add i18n_validation_test
| * | | | Add i18n_validation_testsukesan19842016-06-021-4/+2
| | | | | | | | | | | | | | | | | | | | add active record uniqueness validation test for { on: [:create, :update] } condition.
* | | | | Ensure that records with unselected fields can be updatedSean Griffin2016-06-021-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As part of refactoring mutation detection to be more performant, we introduced the concept of `original_value` to `Attribute`. This was not overridden in `Attribute::Uninitialized` however, so assigning ot an uninitialized value and calling `.changed?` would raise `NotImplementedError`. We are using a sentinel value rather than checking the result of `original_attribute.initialized?` in `changed?` because `original_value` might go through more than one node in the tree. Fixes #25228
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-04 09:28:02 +0000