Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | AR::Integration must be included after AM::Conversion | John Firebaugh | 2012-07-17 | 1 | -0/+6 |
| | | | | | | | Integration's definition of #to_param must override Conversion's. Otherwise, there is a regression from 3.1 in the behavior of a non-persisted AR::Base instance which nevertheless has an id. | ||||
* | Merge pull request #7076 from kennyj/fix_class_eval | Aaron Patterson | 2012-07-17 | 2 | -3/+3 |
|\ | | | | | Fix class_eval without __FILE__ and __LINE__. | ||||
| * | Fix class_eval without __FILE__ and __LINE__. | kennyj | 2012-07-18 | 2 | -3/+3 |
| | | |||||
* | | Fixes "Cannot visit ..." with validates_uniqueness_of | beerlington | 2012-07-17 | 1 | -0/+16 |
|/ | | | | | | Fixes issue with overrding ActiveRecord reader methods with a composed object and using that attribute as the scope of a validates_uniqueness_of validation. | ||||
* | Fix SqlBypass.data_column= problem. SqlBypass.find_by_session_id method ↵ | kennyj | 2012-07-15 | 1 | -0/+14 |
| | | | | didn't use this assignment. | ||||
* | teaching the mysql adapter how to typecast strings returned from the database | Aaron Patterson | 2012-07-13 | 1 | -2/+2 |
| | |||||
* | fixing tests to deal with data differences between prepared statements and ↵ | Aaron Patterson | 2012-07-13 | 3 | -3/+8 |
| | | | | | | | non-prepared statements Conflicts: activerecord/test/cases/query_cache_test.rb | ||||
* | fix association :extend option | Jon Leighton | 2012-07-13 | 2 | -3/+6 |
| | |||||
* | stop using class_attribute where methods/inheritance will suffice. | Jon Leighton | 2012-07-13 | 1 | -16/+0 |
| | |||||
* | Represent association scope options as AR::Relations insternally. | Jon Leighton | 2012-07-13 | 2 | -19/+38 |
| | |||||
* | fix assertion arguments order | Jon Leighton | 2012-07-13 | 1 | -2/+2 |
| | |||||
* | Allow associations to take a lambda which builds the scope | Jon Leighton | 2012-07-13 | 4 | -23/+32 |
| | |||||
* | support relations created with a table alias | Jon Leighton | 2012-07-13 | 1 | -0/+10 |
| | |||||
* | Add teardown method to AR::Mig::RenameTableTest | Robb Kidd | 2012-07-10 | 1 | -18/+13 |
| | | | | | | | Dry up reseting the renamed table after each test. Also made use of the AR::Base.connection object already available from AR::MigrationTest#connection. | ||||
* | Merge pull request #6874 from robbkidd/rename_sequences_too | Aaron Patterson | 2012-07-10 | 1 | -0/+13 |
|\ | | | | | Rename default sequence when table is renamed? [AR:postgres] | ||||
| * | Update psql adapter to rename a default pkey sequence when renaming a table. | Robb Kidd | 2012-06-27 | 1 | -0/+13 |
| | | |||||
* | | Merge pull request #6838 from kennyj/added_registration_task | Carlos Antonio da Silva | 2012-07-07 | 1 | -0/+16 |
|\ \ | | | | | | | Allow to register database tasks from different adapters | ||||
| * | | Added a feature to add a database task. e.g. OracleDatabaseTasks | kennyj | 2012-06-24 | 1 | -0/+16 |
| | | | |||||
* | | | Relation#inspect handles doesn't perform a new query on an already-loaded ↵ | Jon Leighton | 2012-07-07 | 1 | -1/+12 |
| | | | | | | | | | | | | relation | ||||
* | | | Merge pull request #6997 from kennyj/fix_stored_attributes | José Valim | 2012-07-07 | 2 | -0/+14 |
|\ \ \ | | | | | | | | | Added *instance_writer: false* to stored/serialized attributes. | ||||
| * | | | Added *instance_writer: false* for stored/serialized attributes. | kennyj | 2012-07-07 | 2 | -0/+14 |
| | | | | |||||
* | | | | Limit the number of records in Relation#inspect | Damien Mathieu | 2012-07-06 | 1 | -0/+5 |
|/ / / | | | | | | | | | | While it's interesting to have the results array, it can make a console or a webpage freeze if there are a lot of them. So this limits the number of records displayed in #inspect to 10 and tells how much were effectively found. | ||||
* | | | Merge pull request #6985 from sidonath/disable-query-cache-for-locks | Rafael Mendonça França | 2012-07-06 | 1 | -0/+8 |
|\ \ \ | | | | | | | | | Disable query cache for lock queries | ||||
| * | | | Disable query cache for lock queries | Damir Zekic | 2012-07-06 | 1 | -0/+8 |
| | | | | | | | | | | | | | | | | Fixes #867 | ||||
* | | | | Show the records in Relation#inspect | Jon Leighton | 2012-07-06 | 1 | -0/+5 |
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The reason for removing the previous implementation of `#inspect` was that it hid from you that you were dealing with a `Relation` rather than an `Array`. But it is still useful to be able to see the records, particularly if you're writing something like the following in tests: assert_equal [foo], Post.where(:bar) If the assertion fails, you want to see what records were actually loaded. So this implementation makes it clear that you've got a `Relation`, but also shows your records. | ||||
* | | | Merge pull request #6927 from parndt/patch-3 | Carlos Antonio da Silva | 2012-07-05 | 1 | -1/+1 |
|\ \ \ | | | | | | | | | Make ArgumentError message more consistent in nested attributes | ||||
| * | | | Made ArgumentError messages consistent. | Philip Arndt | 2012-07-06 | 1 | -1/+1 |
| | | | | |||||
* | | | | fix quoting for ActiveSupport::Duration instances | Francesco Rodriguez | 2012-07-04 | 2 | -0/+14 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch fixes quoting for ActiveSupport::Duration instances: # before >> ActiveRecord::Base.connection.quote 30.minutes => "'--- 1800\n...\n'" # after >> ActiveRecord::Base.connection.quote 30.minutes => "1800" Also, adds a test for type casting ActiveSupport::Duration instances. Related to #1119. | ||||
* | | | | remove duplicate requires of mocha. | Aaron Patterson | 2012-07-03 | 1 | -1/+0 |
| | | | | | | | | | | | | | | | | | | | | Mocha is already required by AS::TestCase, so remove the duplicate requires. | ||||
* | | | | Refactor references schema definitions | Aleksey Magusev | 2012-07-03 | 1 | -16/+12 |
| | | | | |||||
* | | | | Make references statements reversible | Aleksey Magusev | 2012-07-03 | 1 | -3/+27 |
| | | | | |||||
* | | | | Add references schema statements | Aleksey Magusev | 2012-07-03 | 2 | -1/+112 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Examples: add_reference :products, :supplier, polymorphic: true, index: true remove_reference :products, :user `add_belongs_to` and `remove_belongs_to` are acceptable. | ||||
* | | | | Don't mark the store as changed if an attribute isn't changed. | kennyj | 2012-07-03 | 1 | -0/+5 |
|/ / / | |||||
* | | | Use strings for the table names | Rafael Mendonça França | 2012-07-01 | 1 | -1/+1 |
| | | | | | | | | | | | | connection.tables returns an array of strings | ||||
* | | | Unify the collation API for the database adpters | Rafael Mendonça França | 2012-07-01 | 3 | -8/+8 |
| | | | |||||
* | | | Merge pull request #6914 from lexmag/migration_tests | Rafael Mendonça França | 2012-07-01 | 2 | -37/+11 |
|\ \ \ | | | | | | | | | Refactor migration test_helper | ||||
| * | | | Refactor migration test_helper | Aleksey Magusev | 2012-07-01 | 2 | -37/+11 |
| | | | | | | | | | | | | | | | | and create_join_table_test | ||||
* | | | | Merge pull request #6913 from lexmag/column_exists_options | Carlos Antonio da Silva | 2012-06-30 | 1 | -6/+12 |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add :default and :null options to column_exists? method Examples: column_exists?(:testings, :taggable_id, :integer, null: false) column_exists?(:testings, :taggable_type, :string, default: 'Photo') | ||||
| * | | | | Add more options to column_exists? method | Aleksey Magusev | 2012-06-30 | 1 | -6/+12 |
| |/ / / | | | | | | | | | | | | | Also fix failures in check options for nil | ||||
* | | | | Extract collation tasks to database tasks. | kennyj | 2012-07-01 | 4 | -0/+68 |
| | | | | |||||
* | | | | Remove ActiveRelation#inspect | Brian Cardarella | 2012-06-29 | 1 | -1/+1 |
| | | | | |||||
* | | | | Support collate and ctype on the PostgreSQL. | kennyj | 2012-06-29 | 3 | -0/+20 |
| | | | | |||||
* | | | | Remove some aggregation tests related to composed_of | Carlos Antonio da Silva | 2012-06-28 | 2 | -21/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since composed_of was removed in 051747449e7afc817c599e4135bc629d4de064eb, these tests were working "by mistake", due to the matching "address" string in the error message, but with a different error message than the expected multiparameter assignment error. Since "address" is not an attribute from Customer anymore, the error was "undefined method klass for nil", where nil was supposed to be the column object. | ||||
* | | | | Move newly added multiparameter tests to base_test file | Carlos Antonio da Silva | 2012-06-28 | 2 | -35/+36 |
| | | | | | | | | | | | | | | | | | | | | All other multiparameter assignment tests are in the same file, so it makes sense to have all of them here. | ||||
* | | | | Skip test_setting_time_attribute because Oracle database | Yasuo Honda | 2012-06-28 | 1 | -0/+2 |
| | | | | | | | | | | | | | | | | does not have TIME data type. | ||||
* | | | | fix: limit of enum columns of mysql | Yamada Masaki | 2012-06-28 | 4 | -0/+39 |
| | | | | |||||
* | | | | Fixes #6825, adds tests covering cases and error possibilities, also changes ↵ | Mauricio Linhares | 2012-06-27 | 1 | -0/+33 |
|/ / / | | | | | | | | | | SQLite3 driver to correctly generate a time column instead of datetime | ||||
* | / | Address test_basic_model test error with Oracle enhanced adapter | Yasuo Honda | 2012-06-27 | 1 | -1/+1 |
| |/ |/| | | | | | which ids start from 1000 as a default. | ||||
* | | Setup each test with default ActiveRecord timezone settings to ensure each ↵ | Erich Menge | 2012-06-26 | 1 | -20/+8 |
| | | | | | | | | | | | | test starts with a clean slate. Fixes #6867. | ||||
* | | Merge pull request #6544 from flexoid/issue-6431 | Piotr Sarnacki | 2012-06-25 | 1 | -0/+4 |
|\ \ | | | | | | | exists?(false) returns false |