aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
...
* Add block setting of attributes to singular associationsAndrew White2011-05-172-0/+42
|
* Pass the attribute and option hashes to build_associationAndrew White2011-05-173-0/+42
| | | | | | | The build_association method was added as an API for plugins to hook into in 1398db0. This commit restores this API and the ability to override class.new to return a subclass based on a virtual attribute in the attributes hash.
* Fixed InnerJoinAssociationTest. Need to load essays fixture.Arun Agrawal2011-05-171-1/+1
|
* Adding missing requireGuillermo Iguaran2011-05-161-0/+1
|
* Merge pull request #560 from guilleiguaran/fix_pluralize_table_names_falseJon Leighton2011-05-163-0/+18
|\ | | | | Fixing has_many when ActiveRecord::Base.pluralize_table_names is false
| * Fixing has_many association when ActiveRecord::Base.pluralize_table_names is ↵Guillermo Iguaran2011-05-153-0/+18
| | | | | | | | false. fixes #557
* | Add ActiveRecord::attribute_names to retrieve a list of attribute names. ↵Prem Sichanugrist2011-05-151-0/+13
| | | | | | | | This method will also return an empty array on an abstract class or a model that the table doesn't exists.
* | CollectionAssociation#merge_target_lists should write to the underlying ↵Jon Leighton2011-05-143-0/+15
|/ | | | attributes when copying, rather than using the assignment method
* supporting infinity and -infinity for timestamps in PG. fixes #544Aaron Patterson2011-05-131-0/+26
|
* Don't use mass-assignment protection when setting foreign keys or ↵Jon Leighton2011-05-122-0/+36
| | | | association conditions on singular associations. Fixes #481 (again).
* updated AR#create! to accept an options hash so the mass-assignment security ↵Josh Kalderimis2011-05-121-0/+24
| | | | role can be passed in, also updated the Changelog to mention the change to some of the AR method signatures.
* Merge pull request #512 from pivotalneutron/fix_eager_load_with_calculationsJon Leighton2011-05-112-1/+14
|\ | | | | Bug fixes for calculations with includes
| * Bug fixes:Fadzril Muhamad & Joseph Palermo2011-05-122-1/+14
| | | | | | | | | | | | - If doing a count on a relation that has an :include and a :join, it does a distinct even though it should not. - When doing a count on a relation that has an :include, it always falls back to a old style left join when performing the count. Looks like it was broken here: https://github.com/rails/rails/commit/b9599502c9e738a5a1513e75d08f8d40ed408265
* | Add missing requiresSantiago Pastorino2011-05-111-0/+1
| |
* | Fix assigning protected attributes by attributes=knapo2011-05-111-2/+7
| |
* | Don't remove the target if it has already been destroyedAndrew White2011-05-111-0/+9
| |
* | Modified NamedScopeTest to use CollectionAssociation.Michael Ebens2011-05-111-1/+1
|/
* Don't use select() values from the join model of a through association. ↵Jon Leighton2011-05-114-0/+19
| | | | Fixes #508.
* Bring back obj.association_loaded? as a deprecated method. Fixes #472.Jon Leighton2011-05-111-0/+9
|
* Add test to specify that attributes from an association's conditions should ↵Jon Leighton2011-05-104-4/+28
| | | | be assigned without mass-assignment protection when a record is built on the association.
* Don't use mass-assignment protection when applying the ↵Jon Leighton2011-05-101-0/+9
| | | | scoped.scope_for_create. Fixes #481.
* minor cleaning with new api methodVishnu Atrai2011-05-111-11/+11
|
* deprecating CSV fixture supportAaron Patterson2011-05-102-1/+3
|
* Merge pull request #495 from vatrai/minor_fixesPiotr Sarnacki2011-05-102-2/+2
|\ | | | | minor cleaning
| * minor cleaningVishnu Atrai2011-05-102-2/+2
| |
* | Methods that return nil should not be considered YAMLJoshua Wehner2011-05-101-4/+1
|/
* Puts ActiveRecord::SessionStore attributes in white list, fixes #483slainer682011-05-101-0/+6
|
* Add failing tests according to #479.José Valim2011-05-101-0/+15
|
* Add failing tests, according to #480.José Valim2011-05-101-0/+14
|
* Ensure assign_attributes and update_attributes do not fail on nil, closes #478.José Valim2011-05-102-0/+8
|
* use a null byte as a bind parameter substitute as it is not allowed in ↵Aaron Patterson2011-05-091-0/+50
| | | | normal SQL. fixes #411, #417
* Merge pull request #451 from baroquebobcat/fixing_last_for_issue_371Jon Leighton2011-05-081-0/+21
|\
| * Fix for #371Nick Howard2011-05-081-0/+21
| | | | | | | | | | | | | | | | | | | | | | | | if a query contains a limit or an offset, ActiveRecord::FinderMethods#find_last had inconsistent behavior. If the records were loaded, it returned the last record in the cached list. If they were not, it reversed the order of the query and changed the limit to one. If the earlier limit was less than the total matching the query in the db, it would return a different record than if the records had been cached. This commit changes find_last so that it loads the records when getting the last record on a query containing a limit or an offset, which makes the behavior consistent.
* | Ensure that ORDER BY clauses from default scopes are not included in ↵Jon Leighton2011-05-081-0/+4
| | | | | | | | calculation queries. Fixes #406.
* | Don't quote ID's as Arel will quote them -- follow same conventions as the ↵Christopher Meiklejohn2011-05-084-1/+51
| | | | | | | | delete method.
* | renamed mass-assignment scopes to roles, updated code, tests, docs and ↵Josh Kalderimis2011-05-081-27/+27
|/ | | | security guide
* Namespace Fixtures in ActiveRecordJason Noble2011-05-076-30/+30
| | | [Fixes #439]
* Revert "Revert the merge because tests did not pass."José Valim2011-05-071-0/+35
| | | | This reverts commit 886818d2bab40585c0cea763002ffc16917dd0b3.
* fix yield not working from around filter of observers, fixes Github#329Hemant Kumar2011-05-071-0/+25
|
* Merge pull request #396 from asanghi/lh_4346Xavier Noria2011-05-061-0/+135
|\ | | | | Multiparameter POLA (principle of least authority) with respect to time_select fixes. See LH4346
| * Multiparameter POLA, time_select fixes. See LH4346Aditya Sanghi2011-05-051-0/+135
| |
* | Merge pull request #399 from ernie/join_conditions_on_joinJon Leighton2011-05-051-0/+11
|\ \ | | | | | | Add association join conditions to JOIN clause, not WHERE
| * | Add a test for outer joins with conditions where value IS NULLErnie Miller2011-05-051-0/+5
| | |
| * | Add join conditions to JOIN clause, not WHEREErnie Miller2011-05-051-0/+6
| |/
* | Merge pull request #358 from baroquebobcat/fix_find_or_create_masterAaron Patterson2011-05-051-0/+24
|\ \ | |/ |/| Fix for lighthouse #6741
| * Fix for lighthouse #6741Nick Howard2011-05-011-0/+24
| | | | | | | | | | | | | | - adds tests for find_or_create_by and find_or_initialize_by on has_many associations - changes the behavior of ActiveRecord::Associations::CollectionProxy#method_missing to differ to ActiveRecord::FinderMethods#find_or_instantiator_by_attributes for arg processing and saving so find_or_create_by's api on associations will be consistent w/ the api for model classes.
* | ensure query cache is cleared when Rack body is closed, fixes bug reported ↵Aaron Patterson2011-05-041-0/+11
| | | | | | | | on 951e18abea9c116fc5d6b330ca1dcd2890abe006
* | added the mysql schema test to mysql2 adapter, and fixed the corresponding ↵Josh Kalderimis2011-05-032-1/+37
| | | | | | | | failures
* | make sure IM repository is cleared after body is closedAaron Patterson2011-05-031-0/+11
| |
* | proxying the body in the IM middleware so that IM is available for streaming ERbAaron Patterson2011-05-031-0/+26
| |