aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #20041 from akshay-vishnoi/sqlite_collationRafael Mendonça França2015-05-283-5/+58
|\ | | | | | | SQLite3: Add collation support for string and text columns
| * Add collation support for string and text columns in SQLite3Akshay Vishnoi2015-05-283-5/+58
| |
* | Add test to 57daaefRafael Mendonça França2015-05-281-1/+1
|/
* Merge pull request #20171 from georgeclaghorn/enums-in-fixturesRafael Mendonça França2015-05-274-32/+50
|\ | | | | | | Allow the use of symbols or strings to specify enum values in test fixtures
| * Resolve enums in test fixturesGeorge Claghorn2015-05-274-32/+50
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, values for columns backing Active Record enums must be specified as integers in test fixtures: awdr: title: "Agile Web Development with Rails" status: 2 rfr: title: "Ruby for Rails" status: <%= Book.statuses[:proposed] %> This is potentially confusing, since enum values are typically specified as symbols or strings in application code. To resolve the confusion, this change permits the use of symbols or strings to specify enum values: awdr: status: :published It is compatible with fixtures that specify enum values as integers.
* | Merge pull request #19886 from henders/henders/reload_wipe_query_cacheRafael Mendonça França2015-05-271-0/+27
|\ \ | | | | | | | | | Cause ActiveRecord::Base::reload to also ignore the QueryCache.
| * | Cause ActiveRecord::Base::reload to also ignore the QueryCache.Shane Hender2015-04-281-0/+27
| | |
* | | Merge pull request #17654 from kamipo/strict_mode_explicitlyRafael Mendonça França2015-05-272-0/+18
|\ \ \ | |_|/ |/| | If specify `strict: :default` explicitly, do not set sql_mode.
| * | If specify `strict: :default` explicitly, do not set sql_mode.Ryuta Kamizono2015-05-262-0/+18
| | | | | | | | | | | | Related with #17370.
* | | Merge pull request #20269 from wojobucco/masterRafael Mendonça França2015-05-271-4/+4
|\ \ \ | |/ / |/| | | | | Changed mysqldump to include sprocs and functions
| * | Changed mysqldump to include sprocs and functionsJonathan Worek2015-05-221-4/+4
| | |
* | | add `extend` option on `has_and_belongs_to_many`.keepcosmos2015-05-261-0/+15
| | |
* | | Remove unused variableArun Agrawal2015-05-261-1/+1
| | | | | | | | | | | | Was left in adfab2dcf4003ca564d78d4425566dd2d9cd8b4f
* | | deprecate `Relation#uniq` use `Relation#distinct` instead.Yves Senn2015-05-268-28/+41
|/ / | | | | | | | | | | | | | | | | See #9683 for the reasons we switched to `distinct`. Here is the discussion that triggered the actual deprecation #20198. `uniq`, `uniq!` and `uniq_value` are still around. They will be removed in the next minor release after Rails 5.
* | Merge pull request #20175 from eugeneius/copy_schema_cache_after_forkRafael Mendonça França2015-05-182-23/+46
|\ \ | | | | | | Add schema cache to new connection pool after fork
| * | Add schema cache to new connection pool after forkEugene Kenny2015-05-172-23/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Active Record detects when the process has forked and automatically creates a new connection pool to avoid sharing file descriptors. If the existing connection pool had a schema cache associated with it, the new pool should copy it to avoid unnecessarily querying the database for its schema. The code to detect that the process has forked is in ConnectionHandler, but the existing test for it was in the ConnectionManagement test file. I moved it to the right place while I was writing the new test for this change.
* | | Merge pull request #20190 from kamipo/fix_serial_with_quoted_sequence_nameRafael Mendonça França2015-05-181-0/+8
|\ \ \ | | | | | | | | Fix `serial?` with quoted sequence name
| * | | Fix `serial?` with quoted sequence nameRyuta Kamizono2015-05-181-0/+8
| |/ /
* / / sqlite3_mem has an existing connectionMatthew Draper2015-05-181-1/+3
|/ / | | | | | | | | We must account for receiving one less call to #new_connection, but the test otherwise remains valid.
* | AR::ConPool - remove synchronization around connection cache.thedarkone2015-05-141-4/+132
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Renamed `@reserved_connections` -> `@thread_cached_conns`. New name clearly conveys the purpose of the cache, which is to speed-up `#connection` method. The new `@thread_cached_conns` now also uses `Thread` objects as keys (instead of previously `Thread.current.object_id`). Since there is no longer any synchronization around `@thread_cached_conns`, `disconnect!` and `clear_reloadable_connections!` methods now pre-emptively obtain ownership (via `checkout`) of all existing connections, before modifying internal data structures. A private method `release` has been renamed `thread_conn_uncache` to clear-up its purpose. Fixed some brittle `thread.status == "sleep"` tests (threads can go into sleep even without locks).
* | AR::ConPool - establish connections outside of critical section.thedarkone2015-05-142-1/+35
| |
* | AR::ConPool - reduce post checkout critical section.thedarkone2015-05-141-1/+3
| | | | | | | | Move post checkout connection verification out of mutex.synchronize.
* | Merge pull request #20150 from karanarora/Typo-fixRafael Mendonça França2015-05-131-1/+1
|\ \ | | | | | | remove redundant parenthesis
| * | remove redundant parenthesiskaranarora2015-05-141-1/+1
| | |
* | | invalid sti error message contains the full class name.Yves Senn2015-05-131-0/+11
| | | | | | | | | | | | | | | | | | | | | This can resolve confusing situation when a top level constant exists but a namespaced version is identified. Related to #19531.
* | | Merge branch 'sti-subclass-from-attributes' of ↵Yves Senn2015-05-132-0/+10
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | https://github.com/agrobbin/rails into agrobbin-sti-subclass-from-attributes Conflicts: activerecord/CHANGELOG.md
| * | | allow setting of a demodulized class name when using STIAlex Robbin2015-05-112-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If your STI class looks like this: ```ruby class Company < ActiveRecord::Base self.store_full_sti_class = false class GoodCo < Company end class BadCo < Company end end ``` The expectation (which is valid) is that the `type` in the database is saved as `GoodCo` or `BadCo`. However, another expectation should be that setting `type` to `GoodCo` would correctly instantiate the object as a `Company::GoodCo`. That second expectation is what this should fix.
* | | | Add full set of MySQL CLI options to support SSL authentication when using ↵Alex Coomans2015-05-121-1/+10
|/ / / | | | | | | | | | db:structure dump and load
* | | remove duplicate test.Yves Senn2015-05-081-10/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | The old `test_create_bang_returns_falsy_when_join_record_has_errors` had a missleading name and was a duplicate of `test_save_should_not_raise_exception_when_join_record_has_errors`. Since it had an assertion on the return value I renamed it accordingly and got rid of the duplicate test.
* | | tests, extract helpers to modify global state.Yves Senn2015-05-071-46/+55
| | | | | | | | | | | | | | | | | | | | | | | | | | | Make sure that tests do not hardcode the default value. For example `test_instantiation_doesnt_try_to_require_corresponding_file` always restored the configuration to `true` regardless of what it's original value was. Extract a helper to make the global modification consistent across tests.
* | | Merge pull request #17632 from eugeneius/schema_cache_dump_connection_poolAaron Patterson2015-05-041-0/+15
|\ \ \ | | | | | | | | Apply schema cache dump when creating connections
| * | | Apply schema cache dump when creating connectionsEugene Kenny2015-04-291-0/+15
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `db:schema:cache:dump` rake task dumps the database schema structure to `db/schema_cache.dump`. If this file is present, the schema details are loaded into the currently checked out connection by a railtie while Rails is booting, to avoid having to query the database for its schema. The schema cache dump is only applied to the initial connection used to boot the application though; other connections from the same pool are created with an empty schema cache, and still have to load the structure of each table directly from the database. With this change, a copy of the schema cache is associated with the connection pool and applied to connections as they are created.
* | | More exercise the create index sql testsRyuta Kamizono2015-05-042-0/+74
| | |
* | | Merge pull request #19994 from kamipo/dump_indexes_in_create_tableRafael Mendonça França2015-05-031-10/+10
|\ \ \ | | | | | | | | | | | | Dump indexes in `create_table` instead of `add_index`
| * | | Dump indexes in `create_table` instead of `add_index`Ryuta Kamizono2015-05-031-10/+10
| | | | | | | | | | | | | | | | | | | | If the adapter supports indexes in create table, generated SQL is slightly more efficient.
* | | | Merge pull request #17824 from ↵Rafael Mendonça França2015-05-032-1/+4
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | yuki24/change-record-not-saved-and-not-destroyed-to-include-error-msg AR::RecordNotSaved & RecordNotDestroyed from save!/destroy! should include an error message
| * | | | AR::RecordNotSaved & RecordNotDestroyed should include an error messageYuki Nishijima2015-05-012-1/+4
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | When `AR::Base.save!` or `AR::Base.destroy!` is called and an exception is raised, the exception doesn't have any error message or has a weird message like `#<FailedBulb:0x0000000907b4b8>`. Give a better message so we can easily understand why it's failing to save/destroy.
* | | | Merge pull request #17569 from kamipo/dump_table_optionsRafael Mendonça França2015-05-032-0/+84
|\ \ \ \ | | | | | | | | | | | | | | | Correctly dump `:options` on `create_table` for MySQL
| * | | | Correctly dump `:options` on `create_table` for MySQLRyuta Kamizono2015-05-032-0/+84
| |/ / /
* | | | Merge pull request #19987 from kamipo/move_postgresql_specific_schemaRafael Mendonça França2015-05-032-14/+11
|\ \ \ \ | | | | | | | | | | Move PostgreSQL specific schema to postgresql_specific_schema.rb
| * | | | Move PostgreSQL specific schema to postgresql_specific_schema.rbRyuta Kamizono2015-05-032-14/+11
| | |/ / | |/| |
* / | | PostgreSQL: `:collation` support for string and text columnsRyuta Kamizono2015-05-041-0/+53
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | Example: create_table :foos do |t| t.string :string_en, collation: 'en_US.UTF-8' t.text :text_ja, collation: 'ja_JP.UTF-8' end
* / / Remove unused requireRyuta Kamizono2015-05-032-2/+0
|/ /
* | Merge pull request #19546 from DianthuDia/fix_unscope_for_less_thanYves Senn2015-04-281-0/+12
|\ \ | | | | | | | | | Fix unscope for less than
| * | Fix unscope for less thanTAKAHASHI Kazuaki2015-03-271-0/+12
| | | | | | | | | | | | | | | | | | Code such as the following will be corrected. Developer.where(id: -Float::INFINITY...2).unscope(where: :id)
* | | Merge pull request #19718 from eagletmt/find_by-without-argYves Senn2015-04-281-0/+8
|\ \ \ | | | | | | | | | | | | Raise ArgumentError when find_by receives no arguments
| * | | Raise ArgumentError when find_by receives no argumentsKohei Suzuki2015-04-111-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It fixes the strange error saying undefined method `take'. ``` RelationTest#test_find_by_without_arg_behaves_same_with_find_by({}): NoMethodError: undefined method `take' for #<ActiveRecord::QueryMethods::WhereChain:0x007f9c55db1d68> ```
* | | | test, for `create_table` and `foreign_key: true` no-op. Closes #19794.Yves Senn2015-04-271-0/+20
| |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | Add a test-case to make sure that `create_table` with a `foreign_key: true` and an adapter without foreign key support does not blow up. Motivated by #19794. Originating from: https://github.com/rails/rails/commit/99a6f9e60ea55924b44f894a16f8de0162cf2702#commitcomment-10855210
* | | Silence warning from MySQL::Error object in testPrem Sichanugrist2015-04-231-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When running Active Record MySQL test, this warning is printed in the console: warning: instance variable errno not initialized It turns out that this is a warning from `mysql` gem in MySQL::Error object. However, since the `mysql` gem is no longer maintained, and there won't be a newer version, it make sense for us to just silence this warning to make the output cleaner.
* | | Merge pull request #18880 from mudge/timestamp-index-bugRafael Mendonça França2015-04-231-0/+11
|\ \ \ | | | | | | | | | | | | Fix missing index when using timestamps with index
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-28 06:29:16 +0000