Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | add a comment for sanity of other people to come | Aaron Patterson | 2013-09-10 | 1 | -0/+8 |
| | |||||
* | More unused associations in AR test models | Akira Matsuda | 2013-09-10 | 8 | -13/+0 |
| | |||||
* | :scissors: [ci skip] | Carlos Antonio da Silva | 2013-09-10 | 1 | -1/+1 |
| | |||||
* | change function def self.table_name to self.table_name | Rajarshi Das | 2013-09-10 | 2 | -5/+3 |
| | | | | | | change def self.primary_key to self.primary_key change def self.primary_key to self.primary_key | ||||
* | Clean up unused associations in AR test model | Akira Matsuda | 2013-09-10 | 1 | -3/+0 |
| | |||||
* | make @bitsweat happy. :heart: | Aaron Patterson | 2013-09-09 | 1 | -0/+6 |
| | |||||
* | stop using deprecated api in the tests | Aaron Patterson | 2013-09-09 | 1 | -1/+1 |
| | |||||
* | Fix fixtures regression that required table names to map to classes only, ↵ | Jeremy Kemper | 2013-09-08 | 1 | -1/+1 |
| | | | | not class names | ||||
* | hm:t join tables may not have a primary key | Aaron Patterson | 2013-09-06 | 1 | -0/+18 |
| | |||||
* | auto link hm:t fixture join tables like habtm | Aaron Patterson | 2013-09-06 | 1 | -0/+35 |
| | |||||
* | Add a test case for exists? with multiple values | Rafael Mendonça França + Kassio Borges | 2013-09-04 | 1 | -0/+1 |
| | |||||
* | Merge pull request #11958 from jetthoughts/extract_pre_process_orders_args | Yves Senn | 2013-09-04 | 3 | -2/+32 |
|\ | | | | | Re-use order arguments pre-processing for reorder | ||||
| * | Extracted from `order` processing of arguments, and use it for `reorder` to ↵ | Paul Nikitochkin | 2013-09-04 | 3 | -2/+32 |
| | | | | | | | | be consistent. | ||||
* | | adding a hm:t test for singleton ar objects | Aaron Patterson | 2013-09-03 | 1 | -0/+27 |
| | | |||||
* | | support anonymous classes on has_many associations | Aaron Patterson | 2013-09-03 | 1 | -0/+18 |
| | | |||||
* | | clear all connections before forking | Aaron Patterson | 2013-08-31 | 1 | -0/+3 |
| | | |||||
* | | Revert "Do not dup the binds when visiting the AST" | Rafael Mendonça França + Kassio Borges | 2013-08-31 | 1 | -8/+0 |
| | | | | | | | | | | | | This reverts commit 71ff7d9c6592b93e2c810a1f464943dd7bd02c7f. Reason: I need to check with @jeremy if we can do this. | ||||
* | | Don't need to check if the scope respond to call | Rafael Mendonça França + Kassio Borges | 2013-08-31 | 2 | -2/+2 |
| | | | | | | | | | | We are checking this when defining the default scope and raising an ArgumentError | ||||
* | | Revert "reconnect after the fork returns" | Rafael Mendonça França | 2013-08-31 | 1 | -2/+0 |
| | | | | | | | | | | | | | | | | | | This reverts commit baf5f47b8768c7ec0164ed5ab60e369cdd936d71. Reason: This is breaking the sqlite3 tests with a missing transacion. Could not investigate right now. cc @tenderlove | ||||
* | | Do not dup the binds when visiting the AST | Rafael Mendonça França | 2013-08-31 | 1 | -0/+8 |
| | | | | | | | | | | | | | | The visitor have to consume the bind parameters to make the statements work when the prepared statement option is disabled. Fixes #12023 | ||||
* | | reconnect after the fork returns | Aaron Patterson | 2013-08-30 | 1 | -0/+2 |
| | | |||||
* | | remove unused variable | Aaron Patterson | 2013-08-30 | 1 | -1/+1 |
| | | |||||
* | | move the cache to the AR models and populate it on inherited | Aaron Patterson | 2013-08-30 | 1 | -4/+19 |
| | | |||||
* | | add a failing test for marshal + cache problems | Aaron Patterson | 2013-08-30 | 1 | -0/+26 |
| | | |||||
* | | add missing fixtures file | Aaron Patterson | 2013-08-30 | 1 | -1/+2 |
| | | |||||
* | | Merge pull request #12076 from dabit/master | Carlos Antonio da Silva | 2013-08-29 | 1 | -1/+1 |
|\ \ | | | | | | | Fix broken link to Fixtures documentation on guides and activerecord tests [ci skip] | ||||
| * | | Fix broken link to Fixtures documentation on guides | David Padilla | 2013-08-29 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | and activerecord tests [ci skip] | ||||
* | | | make sure there are actually some categories when running the test | Aaron Patterson | 2013-08-29 | 1 | -0/+1 |
| | | | |||||
* | | | pk should not be required for hm:t associations | Aaron Patterson | 2013-08-29 | 2 | -0/+15 |
|/ / | |||||
* | | Merge pull request #12051 from bcherry/preserve_datetime_milliseconds | Andrew White | 2013-08-28 | 1 | -0/+5 |
|\ \ | |/ |/| | ActiveRecord: Include usecs when quoting DateTime in PostgreSQL adapter | ||||
| * | Test that PostgreSQL adapter includes `usec` when quoting `DateTime` | Ben Cherry | 2013-08-28 | 1 | -0/+5 |
| | | |||||
* | | query the association rather than send the method for the association name | Aaron Patterson | 2013-08-27 | 1 | -6/+4 |
|/ | |||||
* | check class hierarchy with is_a? in PredicateBuilder.expand | Mikhail Dieterle | 2013-08-27 | 1 | -0/+25 |
| | | | | add changelog entry for #11945 | ||||
* | Add config to method calls in fixtures. | wangjohn | 2013-08-26 | 1 | -1/+1 |
| | | | | | | | Allows you to change your configuration for calls to `table_name_prefix`, `table_name_suffix`, and `pluralize_table_names`. The default configuration is still ActiveRecord::Base, but you are now able to change the configuration easily. | ||||
* | PG adapter deals with negative money values formatted with parenthesis. | Yves Senn | 2013-08-26 | 1 | -0/+8 |
| | | | | Closes #11899. | ||||
* | Removing instances of string class_names in fixtures. | wangjohn | 2013-08-24 | 1 | -7/+7 |
| | | | | | | | Also, constantizing the default_fixture_model_name when it gets loaded in from the file. Later, when the class_name is passed to a new FixtureSet, a deprecation warning will occur if the class_name is a string. | ||||
* | Adding deprecation assertions for proper_table_name. | wangjohn | 2013-08-24 | 1 | -7/+21 |
| | | | | This prevents deprecation warnings from popping up. | ||||
* | Making proper_table_name take in options. | wangjohn | 2013-08-22 | 1 | -1/+28 |
| | | | | | | | | | | | The options will specify the prefix and the suffix. Also, I'm moving the method to be an instance method on the +Migration+ instance. This makes more sense than being a class method on the +Migrator+ class because the only place that uses it is on a +Migration+ instance (in a method_missing hook). The logic for the Migrator shouldn't be doing any work to calculate the table name, it should be the Migration itself. Also made some small indentation fixes. | ||||
* | Avoid compiling regexs in AR::Base.respond_to? | John Hawthorn | 2013-08-21 | 1 | -0/+5 |
| | | | | | Caches the patterns of ActiveRecord::DynamicMatchers in a class instance variable. | ||||
* | Merge pull request #11922 from Empact/string-confusion | Yves Senn | 2013-08-20 | 1 | -1/+1 |
|\ | | | | | Stop interpreting SQL 'string' columns as :string type. | ||||
| * | Stop interpreting SQL 'string' columns as :string type. | Ben Woosley | 2013-08-17 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | SQL doesn't have a string type, and interpreting 'string' as text is contrary to at least SQLite3's behavior: "Note that a declared type of 'STRING' has an affinity of NUMERIC, not TEXT." http://www.sqlite.org/datatype3.html | ||||
* | | let AR::FinderMethods#exists? return singletons in all cases [closes #11592] | Xavier Noria | 2013-08-19 | 1 | -27/+29 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes a regression. The documentation said in its introduction paragraph that the method returns truthy/falsy, but then below it was said that if there were no arguments you'd get `true` or `false`. Also when the argument is exactly `false` a singleton is documented to be returned. The method was not returning the singletons so it didn't conform to those special cases. The best solution here seems to be to just return singletons in all cases. This solution is backwards compatible. Also, the contract has been revised because it has no sense that the predicate varies that way depending on the input. I bet the previous contract was just an accident, not something mixed on purpose. Conflicts: activerecord/lib/active_record/relation/finder_methods.rb activerecord/test/cases/finder_test.rb | ||||
* | | Merge branch 'master' of github.com:rails/docrails | Vijay Dev | 2013-08-17 | 13 | -9/+22 |
|\ \ | |/ |/| | | | | | | | | | | | Conflicts: actionview/README.rdoc activerecord/lib/active_record/migration.rb guides/source/development_dependencies_install.md guides/source/getting_started.md | ||||
| * | Revert "Merge branch 'master' of github.com:rails/docrails" | Vijay Dev | 2013-08-17 | 13 | -9/+22 |
| | | | | | | | | | | | | | | This reverts commit 70d6e16fbad75b89dd1798ed697e7732b8606fa3, reversing changes made to ea4db3bc078fb3093ecdddffdf4f2f4ff3e1e8f9. Seems to be a code merge done by mistake. | ||||
* | | Fixing multi-word automatic inverse detection. | wangjohn | 2013-08-15 | 3 | -0/+17 |
| | | | | | | | | | | Currently, ActiveRecord models with multiple words cannot have their inverse associations detected automatically. | ||||
* | | Merge pull request #11574 from jetthoughts/11552_rescue_on_invalid_inet_assign | Yves Senn | 2013-08-14 | 1 | -0/+14 |
|\ \ | | | | | | | Fix assign ip address with invalid values raise exception | ||||
| * | | Rescue invalid ip address exceptions on assign. | Paul Nikitochkin | 2013-08-14 | 1 | -0/+14 |
| | | | | | | | | | | | | In order that set attribute should not be bang method | ||||
* | | | Removed redundant asserts for assigns attribute operation | Paul Nikitochkin | 2013-08-14 | 1 | -28/+28 |
|/ / | |||||
* | | test-case for fixed issue #11870. | Yves Senn | 2013-08-14 | 1 | -0/+4 |
| | | |||||
* | | using assert_not instead of refute | Rajarshi Das | 2013-08-13 | 2 | -4/+4 |
| | |