aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
* Fix broken test_exists_query_logging from the table_exists? changeJon Leighton2011-12-081-0/+1
|
* moving ignored regexp to the instanceAaron Patterson2011-12-071-6/+8
|
* speeding up ignored sql testingAaron Patterson2011-12-071-1/+4
|
* avoid deprecated methodsAaron Patterson2011-12-061-1/+1
|
* add prefix and suffix to renamed tables, closes #1510Vasiliy Ermolovich2011-12-063-0/+51
|
* Merge pull request #3854 from exviva/validates_associated_marked_for_destructionJosé Valim2011-12-041-0/+10
|\ | | | | Do not validate associated records marked for destruction
| * Do not validate associated records marked for destructionOlek Janiszewski2011-12-051-0/+10
| | | | | | | | | | | | The main reason for this change is to fix a bug where `validates_associated` would prevent `accepts_nested_attributes_for` with `allow_destroy: true` from destroying invalid associated records.
* | Merge pull request #3851 from ebeigarts/fix_sequence_nameJon Leighton2011-12-041-0/+10
|\ \ | |/ |/| Fix sequence name with abstract classes.
| * Fix sequence name with abstract classes.Edgars Beigarts2011-12-041-0/+10
| |
* | implements a much faster auto EXPLAIN, closes #3843 [José Valim & Xavier Noria]Xavier Noria2011-12-041-29/+31
|/ | | | | | | | | | | | | | | | | | | | | | | | | This commit vastly reduces the impact of auto explain logging when enabled, while keeping a negligible cost when disabled. The first implementation was based on the idea of subscribing to "sql.active_record" when needed, and unsubscribing once done. This is the idea behind AR::Relation#explain. Subscribe, collect, unsubscribe. But with the current implementation of notifications unsubscribing is costly, because it wipes an internal cache and that puts a penalty on the next event. So we are switching to an approach where a long-running subscriber is listening. Instead of collecting the queries with a closure in a dedicated subscriber, now we setup a thread local. If the feature is disabled by setting the threshold to nil, the subscriber will call a method that does nothing. That's totally cheap.
* Add missing requireJon Leighton2011-12-031-0/+2
|
* Avoid postgres 9.X syntaxJon Leighton2011-12-031-1/+5
|
* Fix #3837.Jon Leighton2011-12-031-0/+12
| | | | | We also need to time zone convert time zone aware attributes when accessed via read_attribute, not only when via direct access.
* removes the convenience instance version of AR::Base.silence_auto_explainXavier Noria2011-12-031-5/+2
| | | | | | | Rationale: As discussed with José and Jon, this convenience shortcut is not clearly justified and it could let the user thing the disabled EXPLAINs are related to the model instance rather than being globally disabled.
* Merge pull request #3820 from jaylevitt/nested_loading_through_assocJon Leighton2011-12-031-0/+35
|\ | | | | reintroduce patch from #726 to handle nested eager loading via associations
| * reintroduce patch from #726 to handle nested eager loading via associationsJay Levitt2011-11-301-0/+35
| |
* | implements AR::Base(.|#)silence_auto_explainXavier Noria2011-12-021-0/+11
| |
* | implements automatic EXPLAIN logging for slow queriesXavier Noria2011-12-021-0/+91
| |
* | Create method with known identifier then alias into place.Jon Leighton2011-12-011-0/+2
| | | | | | | | | | | | | | | | This means we never have to rely on define_method (which is slower and uses more memory), even when we have attributes containing characters that are not allowed in standard method names. (I am mainly changing this because the duplication annoys me, though.)
* | Add test for read_attribute(:id) with non-standard PK.Jon Leighton2011-12-011-0/+5
| | | | | | | | | | | | | | | | Also make it actually work. It slows down all read_attribute accesses to map 'id' to whatever the PK actually is, inside read_attribute. So instead make sure the necessary methods are defined and that they redirect wherever they need to go.
* | Fix up test altering global state that was causing me griefJon Leighton2011-12-011-2/+4
| |
* | Get rid of the underscore versions of attribute methods!Jon Leighton2011-12-011-0/+5
| | | | | | | | This makes me happy!
* | Add hackery to make Syck use encode_with/init_with. Fixes 1.8 after recent ↵Jon Leighton2011-12-011-0/+5
| | | | | | | | changes to attribute serialization.
* | don't alter global state in testJon Leighton2011-11-301-2/+3
| |
* | If the table behind has no primary key, do not ask again and just return nil.Julius de Bruijn2011-11-301-0/+5
| |
* | omg computer science!Jon Leighton2011-11-301-5/+1
| | | | | | | | | | | | | | Implement a mini state machine for serialized attributes. This means we do not have to deserialize the values upon initialization, which means that if we never actually access the attribute, we never have to deserialize it.
* | Fix typoJon Leighton2011-11-301-2/+2
| |
* | Use inheritance to avoid special-case code for the 'id' methodJon Leighton2011-11-301-1/+1
|/
* ActiveRecord::Relation#pluck methodBogdan Gusiev2011-11-301-0/+25
|
* Automatic closure of connections in threads is deprecated. For exampleAaron Patterson2011-11-292-26/+8
| | | | | | | | | | | | | | | | | the following code is deprecated: Thread.new { Post.find(1) }.join It should be changed to close the database connection at the end of the thread: Thread.new { Post.find(1) Post.connection.close }.join Only people who spawn threads in their application code need to worry about this change.
* AbstractAdapter#close can be called to add the connection back to theAaron Patterson2011-11-291-0/+16
| | | | pool.
* expire will set in_use to falseAaron Patterson2011-11-291-0/+7
|
* last_use is set on connection leaseAaron Patterson2011-11-291-0/+6
|
* Leased connections return false on second leaseAaron Patterson2011-11-291-2/+11
|
* Adapters keep in_use flag when leasedAaron Patterson2011-11-291-0/+16
|
* namespace the adapter testAaron Patterson2011-11-291-121/+123
|
* Deprecated `define_attr_method` in `ActiveModel::AttributeMethods`Jon Leighton2011-11-292-22/+15
| | | | | This only existed to support methods like `set_table_name` in Active Record, which are themselves being deprecated.
* Deprecate set_locking_column in favour of self.locking_column=Jon Leighton2011-11-292-2/+42
|
* Deprecate set_primary_key in favour of self.primary_key=Jon Leighton2011-11-2915-22/+43
|
* Make sure the original_foo accessor still works (but deprecated) if we are ↵Jon Leighton2011-11-291-7/+55
| | | | using self.foo=
* Deprecate set_sequence_name in favour of self.sequence_name=Jon Leighton2011-11-292-3/+7
|
* Add tests for set_sequence_name etcJon Leighton2011-11-291-0/+22
|
* Deprecate set_inheritance_column in favour of self.inheritance_column=Jon Leighton2011-11-293-5/+11
|
* Deprecate set_table_name in favour of self.table_name= or defining your own ↵Jon Leighton2011-11-2916-39/+52
| | | | method.
* respond_to? information of AR is not the responsibility of the specAaron Patterson2011-11-291-1/+1
| | | | resolver.
* Merge pull request #3636 from joshsusser/masterJon Leighton2011-11-295-2/+50
|\ | | | | association methods are now generated in modules
| * don't change class definition in test caseJosh Susser2011-11-292-6/+4
| |
| * use GeneratedFeatureMethods module for associationsJosh Susser2011-11-273-2/+30
| |
| * add test for super-ing to association methodsJosh Susser2011-11-151-2/+12
| |
| * association methods are now generated in modulesJosh Susser2011-11-151-0/+12
| | | | | | | | | | | | | | | | | | | | Instead of generating association methods directly in the model class, they are generated in an anonymous module which is then included in the model class. There is one such module for each association. The only subtlety is that the generated_attributes_methods module (from ActiveModel) must be forced to be included before association methods are created so that attribute methods will not shadow association methods.