aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #23407 from jeremy/corrupt-before-commitJeremy Daer2016-02-011-0/+26
|\ | | | | Fix corrupt transaction state caused by `before_commit` exceptions
| * Fix corrupt transaction state caused by `before_commit` exceptionsJeremy Daer2016-02-011-0/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a `before_commit` callback raises, the database is rolled back but AR's record of the current transaction is not, leaving the connection in a perpetually broken state that affects all future users of the connection: subsequent requests, jobs, etc. They'll think a transaction is active when none is, so they won't BEGIN on their own. This manifests as missing `after_commit` callbacks and broken ROLLBACKs. This happens because `before_commit` callbacks fire before the current transaction is popped from the stack, but the exception-handling path they hit assumes that the current transaction was already popped. So the database ROLLBACK is issued, but the transaction stack is left intact. Common cause: deadlocked `#touch`, which is now implemented with `before_commit` callbacks. What's next: * We shouldn't allow active transaction state when checking in or out from the connection pool. Verify that conns are clean. * Closer review of txn manager sad paths. Are we missing other spots where we'd end up with incorrect txn state? What's the worst that can happen if txn state drifts? How can we guarantee it doesn't and contain the fallout if it does? Thanks for @tomafro for expert diagnosis!
* | Revert "Merge pull request #16400 from bogdan/last-with-sql"Sean Griffin2016-02-011-23/+9
|/ | | | | | | | | | This reverts commit 9f3730a516f30beb0050caea9539f8d6b808e58a, reversing changes made to 2637fb75d82e1c69333855abd58c2470994995d3. There are additional issues with this commit that need to be addressed before this change is ready (see #23377). This is a temporary revert in order for us to have more time to address the issues with that PR, without blocking the release of beta2.
* Rename `active_record_internal_metadatas` to `ar_internal_metadata`Yasuo Honda2016-02-011-0/+15
| | | | for those who already migrated to Rails 5.0.0 beta
* Shorten ActiveRecord::InternalMetadata.table_name to ar_internal_metadataYasuo Honda2016-02-012-9/+9
| | | | to support Oracle database which only supports 30 byte identifier length
* tabenai (typo)Akira Matsuda2016-02-011-6/+6
|
* Avoid extra `show variables` in migrationRyuta Kamizono2016-02-011-5/+0
| | | | | | | | | | | | | `initialize_schema_migrations_table` is called in every migrations. https://github.com/rails/rails/blob/v5.0.0.beta1/activerecord/lib/active_record/migration.rb#L1080 https://github.com/rails/rails/blob/v5.0.0.beta1/activerecord/lib/active_record/schema.rb#L51 This means that extra `show variables` is called regardless of the existence of `schema_migrations` table. This change is to avoid extra `show variables` if `schema_migrations` table exists.
* Merge pull request #23359 from kamipo/make_to_primary_keyRafael França2016-02-012-25/+1
|\ | | | | Make to primary key instead of an unique index for internal tables
| * Make to primary key instead of an unique index for internal tablesRyuta Kamizono2016-01-312-25/+1
| |
* | Remove duplicated composite primary key testsRyuta Kamizono2016-02-013-17/+1
| |
* | Merge pull request #23372 from kamipo/use_index_in_create_in_test_schemaRafael França2016-02-012-11/+9
|\ \ | | | | | | Use `t.index` in `create_table` instead of `add_index` in test schema
| * | Use `t.index` in `create_table` instead of `add_index` in test schemaRyuta Kamizono2016-01-312-11/+9
| |/ | | | | | | For reduce bootstrap queries in tests.
* | Merge pull request #23374 from prathamesh-sonpatki/migration-compatiblity-testsRafael França2016-01-311-0/+30
|\ \ | | | | | | Added test for backward compatibility of null constraints on timestamp columns
| * | Added test for backward compatibility of null constraints on timestamp columnsPrathamesh Sonpatki2016-01-311-0/+30
| |/
* / :speak_no_evil: :warning:Akira Matsuda2016-02-012-2/+6
|/
* Merge pull request #23345 from ↵Rafael França2016-01-301-0/+7
|\ | | | | | | | | yui-knk/warning_when_composite_primary_key_is_detected Warn if `AR.primary_key` is called for a table who has composite prim…
| * Warn if `AR.primary_key` is called for a table who has composite primary keyyui-knk2016-01-301-0/+7
| | | | | | | | | | | | | | | | If `AR.primary_key` is called for a table who has composite primary key, the method returns `nil`. This behavior sometimes generates invalid SQL. The first time developers notice to invalid SQL is when they execute SQL. This commit enables developers to know they are doing something dangerous as soon as possible.
* | Merge pull request #23355 from kamipo/fix_bigint_for_enum_columnsRafael França2016-01-302-1/+6
|\ \ | | | | | | Fix `bigint?` for Enum columns in MySQL
| * | Fix `bigint?` for Enum columns in MySQLRyuta Kamizono2016-01-312-1/+6
| |/ | | | | | | Follow up to #22896.
* / There is no need to define test if a connection does not support primary_keyyui-knk2016-01-311-11/+9
|/
* Reworked ActiveRecord::Relation#last to always use SQLBogdan Gusiev2016-01-281-9/+23
| | | | instead of loading relation
* Merge pull request #18928 from bogdan/unreversable-orderSean Griffin2016-01-271-0/+34
|\ | | | | Raise AR::IrreversibleOrderError when #reverse_order can not do it's job
| * Introduce ActiveRecord::IrreversibleOrderErrorBogdan Gusiev2016-01-271-0/+34
| | | | | | | | | | Raises when #reverse_order can not process SQL order instead of making invalid SQL before this patch
* | Do not use default attributes for STI when instantiating a subclassSean Griffin2016-01-271-0/+4
|/ | | | | | | | | | The commit which originally added this behavior did not consider that doing `Subclass.new` does not actually populate the `type` field in the attributes (though perhaps it should). We simply need to not use the defaults for STI related things unless we are instantiating the base class. Fixes #23285.
* Merge branch '5-0-beta-sec'Aaron Patterson2016-01-251-0/+13
|\ | | | | | | | | | | | | | | | | | | | | * 5-0-beta-sec: bumping version fix version update task to deal with .beta1.1 Eliminate instance level writers for class accessors allow :file to be outside rails root, but anything else must be inside the rails view directory Don't short-circuit reject_if proc stop caching mime types globally use secure string comparisons for basic auth username / password
| * Don't short-circuit reject_if procAndrew White2016-01-221-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | When updating an associated record via nested attribute hashes the reject_if proc could be bypassed if the _destroy flag was set in the attribute hash and allow_destroy was set to false. The fix is to only short-circuit if the _destroy flag is set and the option allow_destroy is set to true. It also fixes an issue where a new record wasn't created if _destroy was set and the option allow_destroy was set to false. CVE-2015-7577
* | Merge pull request #23161 from schneems/schneems/fix-mysql-internalmetadataRichard Schneeman2016-01-251-7/+29
|\ \ | | | | | | [close #23009] Limit key length
| * | [close #23009] Limit key lengthschneems2016-01-211-7/+29
| | | | | | | | | | | | | | | | | | | | | Mysql has a weird bug where it cannot index a string column of utf8mb4 if it is over a certain character limit. To get compatibility with msql we can add a limit to the key column. 191 characters is a very long key, it seems reasonable to limit across all adapters since using a longer key wouldn't be supported in mysql. Thanks to @kamipo for the original PR and the test refactoring. Conversation: https://github.com/rails/rails/pull/23009#issuecomment-171416629
* | | When verifying size of relation, also verify count is ok.Vipul A M2016-01-251-0/+1
| | |
* | | Merge pull request #23221 from vipulnsward/23209-fix-missin_source_typeRafael França2016-01-245-0/+21
|\ \ \ | | | | | | | | Add missing source_type if provided on hmt which belongs to an sti re…
| * | | Add missing source_type if provided on hmt which belongs to an sti recordVipul A M2016-01-245-0/+21
| | | | | | | | | | | | | | | | Fixes #23209
* | | | Fix AR::Relation#cache_key to remove select scope added by userPrathamesh Sonpatki2016-01-241-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - We don't need the select scope added by user as we only want to max timestamp and size of the collection. So we already know which columns to select. - Additionally having user defined columns in select scope blows the cache_key method with PostGreSQL because it needs all `selected` columns in the group_by clause or aggregate function. - Fixes #23038.
* | | | Merge pull request #23081 from ↵Kasper Timm Hansen2016-01-241-0/+5
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | prathamesh-sonpatki/fix-cache-key-for-queries-with-offset Fix ActiveRecord::Relation#cache_key for relations with no results
| * | | | Fix ActiveRecord::Relation#cache_key for relations with no resultsPrathamesh Sonpatki2016-01-221-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - When relations return no result or 0 result then cache_key should handle it gracefully instead of blowing up trying to access `result[:size]` and `result[:timestamp]`. - Fixes #23063.
* | | | | Pare back default `index` option for the migration generatorPrathamesh Sonpatki2016-01-244-11/+29
| |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Using `references` or `belongs_to` in migrations will always add index for the referenced column by default, without adding `index:true` option to generated migration file. - Users can opt out of this by passing `index: false`. - Legacy migrations won't be affected by this change. They will continue to run as they were before. - Fixes #18146
* | | | Use the database type to deserialize enumSean Griffin2016-01-233-0/+12
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes incorrect assumptions made by e991c7b that we can assume the DB is already casting the value for us. The enum type needs additional information to perform casting, and needs a subtype. I've opted not to call `super` in `cast`, as we have a known set of types which we accept there, and the subtype likely doesn't accept them (symbol -> integer doesn't make sense) Close #23190
* | | Merge pull request #23080 from ↵Matthew Draper2016-01-221-0/+8
|\ \ \ | |/ / |/| | | | | | | | prathamesh-sonpatki/fix-cache-key-for-loaded-empty-collection Fix ActiveRecord::Relation#cache_key for loaded empty collection
| * | Fix ActiveRecord::Relation#cache_key for loaded empty collectionPrathamesh Sonpatki2016-01-161-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | - Before this patch if we try to find cache_key of a loaded but empty collection it used to give error because of trying to call `updated_at` on `nil` value generated by `collection.max_by(&timestamp_column).public_send(timestamp_column)`. - This commit fixes above error by checking if size is greater than zero or not.
* | | Fix test failure on PostgreSQL by sorting the result before comparisonPrathamesh Sonpatki2016-01-191-4/+5
| | |
* | | run `type` column through attribtues API type casting.Yves Senn2016-01-191-0/+75
| | | | | | | | | | | | | | | | | | | | | Closes #21986. This makes it possible to write custom types that define a different mapping for STI columns.
* | | Changed options for find_each and variants to have options start/finish ↵Vipul A M2016-01-181-33/+12
| | | | | | | | | | | | | | | | | | instead of start_at/end_at based on comments at https://github.com/rails/rails/pull/12257#issuecomment-74688344
* | | Merge pull request #20005 from kamipo/default_expression_supportRafael França2016-01-164-24/+54
|\ \ \ | | | | | | | | Add `:expression` option support on the schema default
| * | | Fix extract default with CURRENT_TIMESTUMPRyuta Kamizono2016-01-132-0/+18
| | | |
| * | | Add expression support on the schema defaultRyuta Kamizono2016-01-133-24/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Example: create_table :posts do |t| t.datetime :published_at, default: -> { 'NOW()' } end
* | | | Merge pull request #23067 from ↵Rafael França2016-01-161-2/+2
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | kamipo/sql_for_insert_returns_values_for_passing_to_exec_insert `sql_for_insert` returns values for passing to `exec_insert`
| * | | `sql_for_insert` returns values for passing to `exec_insert`Ryuta Kamizono2016-01-151-2/+2
| | | |
* | | | Fix intermittent test failuresschneems2016-01-141-0/+1
| | | | | | | | | | | | 😳
* | | | Revert "Revert "Set environment even when no migration runs""schneems2016-01-141-1/+28
|/ / / | | | | | | | | | This reverts commit 11e85b91731ca6125ee1db33553f984549a3bc2b.
* | | Revert "Set environment even when no migration runs"Sean Griffin2016-01-141-28/+1
| | |
* | | Revert "Merge pull request #20835 from ↵Kasper Timm Hansen2016-01-143-18/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | glittershark/if-and-unless-in-secure-token" This reverts commit 224eddfc0eeff6555ae88691306e61c7a9e8b758, reversing changes made to 9d681fc74c6251d5f2b93fa9576c9b2113116680. When merging the pull request, I misunderstood `has_secure_token` as declaring a model has a token from birth and through the rest of its lifetime. Therefore, supporting conditional creation doesn't make sense. You should never mark a model as having a secure token if there's a time when it shouldn't have it on creation.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-07 01:38:46 +0000