| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | |
| | | |
| | | |
| | | | |
HasManyAssociation#inverse_updates_counter_cache?. Fixes #2755, where a counter cache could be decremented twice as far as it was supposed to be.
|
| | | |
| | | |
| | | |
| | | | |
have been failing intermittently for a long while due to what appears to be a Ruby bug. If anyone has the skills/expertise/time to debug this, please speak to the Travis guys.
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Last orders the records by id
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix bad options order in AR::Migration::CommandRecorder#invert_rename_index
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
ActiveRecord::Migration::CommandRecorder#invert_rename_index
|
| |/ / / /
|/| | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | | |
Fixes #2832
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This reverts commit 0df27c98d982ec87d2fb48cfda82694eb267993e.
Reverted due to failing test, see #2845.
|
| | | | |
| | | | |
| | | | |
| | | | | |
link in fixture template [closes #2840]
|
| | | | |
| | | | |
| | | | | |
As in previous commit it's removed.
|
| | | | | |
|
| | | | |
| | | | |
| | | | | |
Replace split on comma with a regexp that will reverse all ASC/DESC specifically
|
| |_|/ /
|/| | |
| | | |
| | | |
| | | |
| | | | |
test_update_all_with_joins_and_offset_and_order
Last two asserts in this test assume that all_comments are ordered by posts.id and then by comments.id therefore additional ordering is added. Without it test was failing on Oracle which returned results in different order.
|
| | | |
| | | |
| | | |
| | | | |
Fix test column names are escaped for oracle
|
|\ \ \ \
| | | | |
| | | | | |
Make #extract_schema_and_table an instance method in Utils
|
| | | | |
| | | | |
| | | | |
| | | | | |
Also, move the utils test into its own test case.
|
| | | | |
| | | | |
| | | | |
| | | | | |
therefore counted by the alias tracker. This is because the association_joins are aliased on initialization and then the tables are cached, so it is no use to alias the join_nodes later. Fixes #2556.
|
| | | | |
| | | | |
| | | | |
| | | | | |
MysqlAdapter and Mysql2Adapter.
|
| | | | | |
|
| |/ / /
|/| | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
error. Strings tagged as binary will be stored in sqlite3 as blobs. It
is an error to insert binary data to a string column, so an error is
emitted in the log file. People are highly encouraged to track down the
source of the binary strings and make sure that the encoding is set
correctly before inserting to the database.
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
This reverts commit 87152f2604e73b218df90befda576f0acfed0bbf, reversing
changes made to 0d3615f04c79f6e90d8ab33fdfc920b8faac9cb8.
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
loaded. Fixes #2054.
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Allow ActiveRecord observers to be disabled.
|
| | |/ /
| |/| |
| | | | |
We have to use Observer#update rather than Observer#send since the enabled state is checked in #update before forwarding the method call on.
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We were experiencing CI test failures, for example:
* 3-1-stable: http://travis-ci.org/#!/rails/rails/builds/79473/L407
* master: http://travis-ci.org/#!/rails/rails/builds/79507/L80
These failures only happened on 1.8.7-p352, and we were only able to
reproduce on the Travis CI VM worker. We even tried creating a new 32
bit Ubuntu VM and running the tests on that, and it all worked fine.
After some epic trial and error, we discovered that replacing the
following:
fuu = Marshal.load(Marshal.dump(fuu))
with:
marshalled = Marshal.dump(fuu)
fuu = Marshal.load(marshalled)
seemed to prevent the failure.
We have NO IDEA why this is. If anyone has some great insight to
contribute then that is welcome. Otherwise, hopefully this will just
help us get the CI green again.
Many thanks to @joshk for help with sorting this out.
|
| | | |
|
| | |
| | |
| | |
| | | |
for generating SQL. This improves the code architecture generally, and solves some problems with marshalling. Adapter authors please take note: you now need to define an Adapter.visitor_for method, but it degrades gracefully with a deprecation warning for now.
|
| | |
| | |
| | | |
On Oracle disable_referential_integrity before execution of block will disable foreign key constraints and after block will enable them but when constraints are enabled then they are validated. Therefore created record with invalid foreign key should be deleted before enabling foreign key constraints.
|
| | |
| | |
| | |
| | | |
This reverts commit c5448721b5054b8a467958d60427fdee15eac604.
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
is 00:50 GMT+1. Without the quoting, the YAML parser would parse this as 00:50 UTC, into the local time of 01:50 GMT+1. Then, it would get written into the database in local time as 01:50. When it came back out the UTC date from the database and the UTC date of two weeks ago would be compared. The former would be 23:50, and the latter would be 00:50, so the two dates would differ, causing the assertion to fail. Quoting it prevents the YAML parser from getting involved.
|
| | | |
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
skiping magic comment test for < 1.9
|