| Commit message (Collapse) | Author | Age | Files | Lines | |
|---|---|---|---|---|---|
| * | Grouping thread locals in the ActiveRecord scopes so that the | wangjohn | 2013-04-08 | 1 | -2/+2 |
| | | | | | | current_scope and ignore_default_scope locals are brought together under a registry object. | ||||
| * | each to each_value; remove unused vars | Vipul A M | 2013-04-07 | 1 | -2/+2 |
| | | |||||
| * | Removed space and unused class | Anupam Choudhury | 2013-04-06 | 2 | -2/+1 |
| | | |||||
| * | Removed unnecessary class | Anupam Choudhury | 2013-04-06 | 1 | -1/+0 |
| | | |||||
| * | Merge pull request #10098 from subwindow/postgres_dump_bigint_default | Rafael Mendonça França | 2013-04-05 | 2 | -0/+6 |
| |\ | | | | | | | | | | | | | Correctly parse bigint defaults in PostgreSQL Conflicts: activerecord/CHANGELOG.md | ||||
| | * | Correctly parse bigint defaults in PostgreSQL | Erik Peterson | 2013-04-05 | 2 | -0/+6 |
| | | | |||||
| * | | Merge pull request #9996 from mikz/master | Jon Leighton | 2013-04-05 | 1 | -0/+16 |
| |\ \ | | | | | | | Association with inverse_of does not set the parent in association building block | ||||
| | * | | fix inverse_of association in block of new child | Michal Cichra | 2013-04-01 | 1 | -0/+16 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes inconsistency when building children of association which has inverse_of set properly. When creating new association object with a block: parent.association.build do |child| child.parent.equal?(parent) # false end So the block the `child.parent` did not point to the same object. But when the object is created it points to same instance: child = parent.association.build child.parent.equal?(parent) # true | ||||
| * | | | Fix scope chaining + STI | Jon Leighton | 2013-04-05 | 2 | -2/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See #9869 and #9929. The problem arises from the following example: class Project < ActiveRecord::Base scope :completed, -> { where completed: true } end class MajorProject < Project end When calling: MajorProject.where(tasks_count: 10).completed This expands to: MajorProject.where(tasks_count: 10).scoping { MajorProject.completed } However the lambda for the `completed` scope is defined on Project. This means that when it is called, `self` is Project rather than MajorProject. So it expands to: MajorProject.where(tasks_count: 10).scoping { Project.where(completed: true) } Since the scoping was applied on MajorProject, and not Project, this fails to apply the tasks_count condition. The solution is to make scoping apply across STI classes. I am slightly concerned about the possible side-effects of this, but no tests fail and it seems ok. I guess we'll see. | ||||
| * | | | failing test for #9869 | Neeraj Singh | 2013-04-05 | 2 | -0/+6 |
| | | | | |||||
| * | | | Improve `belongs_to touch: true` timestamp test | Andrew White | 2013-04-05 | 1 | -7/+21 |
| | |/ |/| | | | | | | | | | Round off time to a whole second value to compensate for databases that don't support fractional timestamps. Also add a assertion to check that the old record is touched when the association is cleared. | ||||
| * | | Use inspect when writing the foreign key from the reflection | Andrew White | 2013-04-05 | 1 | -0/+6 |
| | | | | | | | | | | | | | If we don't use inspect inside the class_eval block then the foreign key is written without quotes causing us to fetch the foreign key value and not the column name. | ||||
| * | | has_many through obeys order on through association | Neeraj Singh | 2013-04-04 | 5 | -3/+20 |
| | | | | | | | | | fixes #10016 | ||||
| * | | Remove duplicated require from AR base test | Carlos Antonio da Silva | 2013-04-03 | 1 | -1/+0 |
| | | | |||||
| * | | Add missing require to inheritance test | Carlos Antonio da Silva | 2013-04-03 | 2 | -3/+1 |
| | | | |||||
| * | | Merge pull request #9141 from adamgamble/issue-9091 | David Heinemeier Hansson | 2013-04-03 | 2 | -0/+30 |
| |\ \ | | | | | | | belongs_to :touch should touch old record when transitioning. | ||||
| | * | | Modifies belong_to touch callback to touch old associations also #9091 | Adam Gamble | 2013-03-14 | 1 | -10/+2 |
| | | | | |||||
| | * | | + Add test for auto timestamps update of both old & new parent records | PikachuEXE | 2013-03-14 | 2 | -0/+38 |
| | | | | |||||
| * | | | Per #9999 revert the revert changing so columns are only tested for empty? ↵ | Sam | 2013-04-03 | 1 | -11/+25 |
| | | | | | | | | | | | | | | | | | | | as opposed to blank? This is both faster and more correct, added tests to make sure this is not reverted again. | ||||
| * | | | Merge pull request #9975 from ↵ | Aaron Patterson | 2013-04-02 | 1 | -2/+12 |
| |\ \ \ | | | | | | | | | | | | | | | | | mmangino/raise_when_attributes_cant_be_unserialized Unserializing YAML attributes can silently fail in development mode | ||||
| | * | | | Remove all error masking when decoding serialized data fails? | Mike Mangino | 2013-04-02 | 1 | -2/+4 |
| | | | | | |||||
| | * | | | Raise an exception when unserialization fails due to a missing class | Mike Mangino | 2013-03-28 | 1 | -0/+8 |
| | | | | | |||||
| * | | | | Show deprecated messages only when target database adapters defined | Yasuo Honda | 2013-04-03 | 3 | -3/+3 |
| | | | | | |||||
| * | | | | Fix tiny problem: change method order for consistency and fix wrong method name. | kennyj | 2013-04-03 | 1 | -1/+1 |
| | | | | | |||||
| * | | | | Suppress deprecation messages for deprecated database tasks, when executing ↵ | kennyj | 2013-04-03 | 3 | -0/+21 |
| | | | | | | | | | | | | | | | | | rails's testcases. | ||||
| * | | | | Extract Oracle database tasks. | kennyj | 2013-04-03 | 1 | -0/+86 |
| | | | | | |||||
| * | | | | Extract Sqlserver database tasks. | kennyj | 2013-04-03 | 1 | -0/+80 |
| | | | | | |||||
| * | | | | Extract Firebird database tasks. | kennyj | 2013-04-03 | 1 | -0/+93 |
| | | | | | |||||
| * | | | | Merge pull request #10048 from ↵ | Rafael Mendonça França | 2013-04-02 | 1 | -17/+13 |
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | senny/replace_merge_with_relation_calls_in_count_api replace #merge with relation API calls in calculations_test. | ||||
| | * | | | | replace #merge with relation API calls in calculations_test. | Yves Senn | 2013-04-02 | 1 | -17/+13 |
| | | | | | | |||||
| * | | | | | Fix #new with an STI object with complex inheritance | Nate Berkopec | 2013-04-02 | 1 | -0/+4 |
| |/ / / / | |||||
| * | | | | Updated the error message for +find+ on an inverse_of association | wangjohn | 2013-04-01 | 1 | -2/+0 |
| | | | | | | | | | | | | | | | | | | | | | so that it is consistent with the error thrown for +find+ without an inverse_of association. | ||||
| * | | | | Throwing a RecordNotFound exception when a record is scanned using the | wangjohn | 2013-04-01 | 1 | -0/+18 |
| | | | | | | | | | | | | | | | | | | | | | inverse_of option. I've also refactored the code for raising a RecordNotFound exception when searching for records with ids. | ||||
| * | | | | fix detect column type of enum | masarakki | 2013-04-01 | 4 | -4/+4 |
| | | | | | | | | | | | | | | | | | enum includes text or blob or ... hooked by wrong regex | ||||
| * | | | | Fix indent and change "or" usage to "||" in schema dumper tests | Carlos Antonio da Silva | 2013-03-30 | 1 | -5/+5 |
| | | | | | |||||
| * | | | | split relation_scoping_test.rb's default scoping tests into another file | Takehiro Adachi | 2013-03-30 | 2 | -357/+360 |
| | | | | | |||||
| * | | | | rename named_scope_test.rb to a proper file name | Takehiro Adachi | 2013-03-30 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | The file name should be name_scoping_test.rb and the class should be `NamedScopingTest` according to ActiveRecord::Scoping::Name | ||||
| * | | | | move tests for NamedScope and DefaultScope under test/cases/scoping/ | Takehiro Adachi | 2013-03-30 | 2 | -0/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | | The scoping/default.rb and scoping/named.rb got moved under scoping/ in commit 2b22564c4efaa63d4bbc006762838c4025c1bdca, but the tests never did. | ||||
| * | | | | Merge pull request #9984 from ranjaykrishna/col-prob | Rafael Mendonça França | 2013-03-28 | 1 | -0/+4 |
| |\ \ \ \ | | | | | | | | | | | valid_type? added to super class abstract_adapter | ||||
| | * | | | | added comments to test_invalid_type in sqlite3 adapter test and added ↵ | Ranjay Krishna | 2013-03-28 | 1 | -0/+4 |
| | | |_|/ | |/| | | | | | | | | | | valid_type? method to abstract_adapter.rb and removed unnecessary method from sqlite3 adapter | ||||
| * / | | | anual_salary => annual_salary | Vipul A M | 2013-03-28 | 1 | -3/+3 |
| |/ / / | |||||
| * | | | Merge pull request #9972 from divineforest/fix-overriden-typo | Rafael Mendonça França | 2013-03-28 | 3 | -3/+3 |
| |\ \ \ | | | | | | | | | Fix typo: overriden => overriDDen | ||||
| | * | | | Fix typo: overriden => overriDDen | Alexander Balashov | 2013-03-28 | 3 | -3/+3 |
| | | | | | |||||
| * | | | | Fixed typos in ActiveRecord | Prathamesh Sonpatki | 2013-03-28 | 3 | -5/+5 |
| | |/ / |/| | | |||||
| * | | | Merge pull request #9970 from divineforest/fix-typo | Rafael Mendonça França | 2013-03-28 | 1 | -1/+1 |
| |\ \ \ | | | | | | | | | Fix typo | ||||
| | * | | | Fix typo | Alexander Balashov | 2013-03-28 | 1 | -1/+1 |
| | |/ / | |||||
| * | | | Use snake case variable names, stick with the convention | Carlos Antonio da Silva | 2013-03-28 | 1 | -13/+13 |
| | | | | |||||
| * | | | Merge pull request #9963 from obrie/fix/after_create_updates | Carlos Antonio da Silva | 2013-03-28 | 1 | -0/+16 |
| |\ \ \ | |/ / |/| | | Fix updates not working within after_create hooks | ||||
| | * | | Fix updates not working within after_create hooks | Aaron Pfeifer | 2013-03-27 | 1 | -0/+16 |
| | | | | |||||
| * | | | Add support for FULLTEXT and SPATIAL indexes using the :type flag for MySQL. | Ken Mazaika | 2013-03-27 | 7 | -30/+72 |
| | | | | |||||
 |
index : rails.git | |
| Mirror of official rails repo with custom fixes. | Harald Eilertsen |
| aboutsummaryrefslogtreecommitdiffstats |