aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #14372 from arthurnn/fix_query_cache_bindsRafael Mendonça França2014-03-131-0/+8
|\ | | | | Make select_all on query cache accept a Relation without binds.
| * Make select_all on query cache accept a Relation without binds.Arthur Neves2014-03-131-0/+8
| | | | | | | | | | [fixes #14361] [related #13886]
* | Add test for deprecation warning for passing an AR object to `find`.Lauro Caetano2014-03-131-0/+6
| |
* | Test deprecation warning for passing an ActiveRecord object toLauro Caetano2014-03-131-0/+6
|/ | | | `exists?`
* passing an instance of an AR object to `find` is deprecatedAaron Patterson2014-03-133-5/+5
| | | | please pass the id of the AR object by calling `.id` on the model first.
* passing an ActiveRecord object to `exists?` is deprecated.Aaron Patterson2014-03-132-2/+2
| | | | | Pass the id of the object to the method by calling `.id` on the AR object.
* Change usec to 0 on tests that compare secondsArthur Neves2014-03-121-3/+3
| | | | | Avoid rounding problems with `.usec` method rounding the seconds when the field doesn't persist the `.usec` piece.
* Unit test for mysql quote time usecArthur Neves2014-03-121-0/+7
|
* Merge pull request #13040 from kamipo/case_sensitive_comparisonRafael Mendonça França2014-03-122-4/+44
|\ | | | | | | | | | | | | Only use BINARY for mysql case sensitive uniqueness check when column has a case insensitive collation. Conflicts: activerecord/CHANGELOG.md
| * Only use BINARY for mysql case sensitive uniqueness check when column has a ↵Ryuta Kamizono2013-11-262-4/+44
| | | | | | | | case insensitive collation.
* | Test microsecond on mysql 5.6Arthur Neves2014-03-123-2/+11
| |
* | Remove mocking on save, when not necessaryArthur Neves2014-03-111-3/+1
| |
* | Merge pull request #14345 from arthurnn/revert_14052Godfrey Chan2014-03-111-0/+13
|\ \ | | | | | | Fixes STI when 2+ levels deep.
| * | Fixes STI when 2+ levels deep.Arthur Neves2014-03-101-0/+13
| | | | | | | | | | | | | | | | | | PR #14052 Added a regression where it was only looking for methods in one level up, So when the method was defined in a 2+ levels up the inheritance chain, the method was not found as defined.
* | | `change_table` supports `citext`. Follow up to #12523.Yves Senn2014-03-111-8/+27
| | |
* | | register OID for PostgreSQL citex datatype [Troy Kruthoff & Lachlan Sylvester]lsylvester2014-03-113-1/+75
|/ / | | | | | | citext makes it possible to use AR Hash finders for case-insensitive matching as sql UPPER/LOWER functions are not needed.
* | Merge pull request #8313 from alan/only_save_changed_has_one_objectsRafael Mendonça França2014-03-101-0/+15
|\ \ | | | | | | | | | | | | | | | | | | Save has_one associations only if record has changes Conflicts: activerecord/CHANGELOG.md
| * | Save has_one associations only if record has changesAlan Kennedy2013-10-311-0/+15
| | | | | | | | | | | | | | | | | | Prevents save related callbacks such as `after_commit` being triggered when `has_one` objects are already persisted and have no changes.
* | | current_adapter? accepts multiple argumentsRafael Mendonça França2014-03-101-2/+2
| | |
* | | mysql adapter also fails with a number bigger than intRafael Mendonça França2014-03-101-2/+5
| | |
* | | Change the assertions depending in the database adapterRafael Mendonça França2014-03-101-14/+9
| | | | | | | | | | | | This will avoid the confusing flunk logic
* | | Do proper adapter checkRafael Mendonça França2014-03-101-2/+2
| | |
* | | Cleanup Parrot after each test.Guo Xiang Tan2014-03-091-7/+3
| | |
* | | Merge pull request #14262 from sferik/flat_mapAndrew White2014-03-092-3/+3
|\ \ \ | | | | | | | | Replace additional instances of map.flatten with flat_map
| * | | Replace map.flatten with flat_map in activerecordErik Michaels-Ober2014-03-032-3/+3
| | | |
* | | | we only need to support `asc` and `ASC`. No need for mixed cases. #14263Yves Senn2014-03-051-21/+11
| | | | | | | | | | | | | | | | This is a result of the discussion at https://github.com/rails/rails/pull/14263/files#r10291489
* | | | Merge pull request #14263 from robin850/allow_passing_string_to_order_hashYves Senn2014-03-051-2/+36
|\ \ \ \ | | | | | | | | | | Follow up of #10732 - Allow string hash values on AR order method
| * | | | Allow string hash values on AR order methodMarcelo Casiraghi2014-03-041-2/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This behavior has almost no performance impact: String not allowed 66.910000 0.030000 66.940000 ( 67.024976) String allowed 69.360000 0.030000 69.390000 ( 69.503096) Benchmarked with http://git.io/Y0YuRw.
* | | | | Merge pull request #14261 from MSch/bound-parameters-for-existsAaron Patterson2014-03-041-2/+14
|\ \ \ \ \ | |/ / / / |/| | | | Make exists? use bound values.
| * | | | Make exists? use bound values.Martin Schürrer2014-03-041-2/+14
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we build a query with an inline value that is a numeric (e.g. because it's out of range for an int4) PostgreSQL doesn't use an index on the column, since it's now comparing numerics and not int4s. This leads to a _very_ slow query. When we use bound parameters instead of inline values PostgreSQL raises numeric_value_out_of_range since no automatic coercion happens.
* | | | Inline block to fix indent [ci skip]Carlos Antonio da Silva2014-03-041-3/+1
| | | |
* | | | Fix enum test unused variable warning.Vipul A M2014-03-041-1/+1
| | | | | | | | | | | | | | | | Related - https://github.com/rails/rails/commit/5c55aafd38f45ac019573f98438ffdbdc8c580f9
* | | | Add Enum type to postgresql adapter's oids to prevent unknown OID warnings.Dieter Komendera2014-03-041-0/+28
|/ / /
* | | Fix warnings due to:Vipul A M2014-03-031-1/+1
| | | | | | | | | | | | | | | - unused variable in PG Adapter. - Ambiguous argument warning from range_test for use - to + Infinity range without brackets.
* | | Remove unnecessary db call when replacing.Arthur Neves2014-02-281-0/+10
| | | | | | | | | | | | | | | | | | | | | When replacing a has_many association with the same one, there is no need to do a round-trip to the db to create/and drop a new transaction. [fixes #14220]
* | | `includes` uses SQL parsing when String joins are involved.Yves Senn2014-02-281-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a partial revert of 22b3481ba2aa55fad1f9a5db94072312b345fb55. The current implementation of `references_eager_loaded_tables?` needs to know every table involved in the query. With the current API this is not possible without SQL parsing. While a2dab46cae35a06fd5c5500037177492a047c252 deprecated SQL parsing for `includes`. It did not issue deprecation warnings when String joins are involved. This resulted in a breaking change after the deprecated behavior was removed (22b3481ba2aa55fad1f9a5db94072312b345fb55). We will need to rethink the usage of `includes`, `preload` and `eager_load` but for now, this brings back the old *working* behavior.
* | | Fix a bug affecting validations of enum attributesTheMonster2014-02-271-0/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes a bug where any enum attribute of a model would be evaluated always as 0 when calling the database on validations. This fix converts the value of the enum attribute to its integer value rather than the string before building the relation as the bug occured when the string finally gets converted to integer using string.to_i which converts it to 0. [Vilius Luneckas, Ahmed AbouElhamayed]
* | | extract common code in `uuid_test.rb`.Yves Senn2014-02-261-60/+57
| | |
* | | move PostgreSQL UUID tests from `datatype_test.rb` to `uuid_test.rb`.Yves Senn2014-02-262-16/+36
| | |
* | | test case for custom PostgreSQL enum type.Yves Senn2014-02-261-0/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This test currently outputs the following warning: ``` unknown OID: current_mood(3567879) (SELECT "postgresql_enums".* FROM "postgresql_enums" ORDER BY "postgresql_enums"."id" ASC LIMIT 1) unknown OID: current_mood(3567879) (SELECT "postgresql_enums".* FROM "postgresql_enums" WHERE "postgresql_enums"."id" = $1 LIMIT 1) ``` We have an open PR to deal with this issue. It will dynamically register the OID for enum columns. This test case is merely to exhibit the current behavior of PostgreSQL enum columns.
* | | let `insert_record` actuall save the object.Aaron Patterson2014-02-251-0/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `before_add` callbacks are fired before the record is saved on `has_and_belongs_to_many` assocations *and* on `has_many :through` associations. Before this change, `before_add` callbacks would be fired before the record was saved on `has_and_belongs_to_many` associations, but *not* on `has_many :through` associations. Fixes #14144
* | | Merge remote-tracking branch ↵Jon Leighton2014-02-253-11/+21
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | 'chancancode/fix_instance_method_already_implemented' Conflicts: activerecord/CHANGELOG.md
| * | | Fixed STI classes not defining an attribute method if there is aGodfrey Chan2014-02-233-11/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | conflicting private method defined on its ancestors. The problem is that `method_defined_within?(name, klass, superklass)` only works correclty when `klass` and `superklass` are both `Class`es. If both `klass` and `superklass` are both `Class`es, they share the same inheritance chain, so if a method is defined on `klass` but not `superklass`, this method must be introduced at some point between `klass` and `superklass`. This does not work when `superklass` is a `Module`. A `Module`'s inheritance chain contains just itself. So if a method is defined on `klass` but not on `superklass`, the method could still be defined somewhere upstream, e.g. in `Object`. This fix works by avoiding calling `method_defined_within?` with a module while still fufilling the requirement (checking that the method is defined withing `superclass` but not is not a generated attribute method). 4d8ee288 is likely an attempted partial fix for this problem. This unrolls that fix and properly check the `superclass` as intended. Fixes #11569.
* | | | Merge pull request #14152 from ↵Aaron Patterson2014-02-251-15/+8
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | schneems/schneems/fix-ar-wtf-why-is-there-no-environment Handle missing environment from non empty config
| * | | | Handle missing environment from non empty configschneems2014-02-211-15/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If using a `DATABASE_URL` and a `database.yml`. The connection information in `DATABASE_URL` should be merged into whatever environment we are in. As released in 4.1.0rc1 if someone has a database.yml but is missing a key like production: ```yml development: host: localhost ``` Then the check for blank config will return false so the information from the `DATABASE_URL` will not be used when attempting to connect to the `production` database and the connection will incorrectly fail. This commit fixes this problem and adds a test for the behavior. In addition the ability to specify a connection url in a `database.yml` like this: ``` production: postgres://localhost/foo ``` Was introduced in 4.1.0rc1 though should not be used, instead using a url sub key ``` production: url: postgres://localhost/foo ``` This url sub key was also introduced in 4.1.0rc1 though the `production: postgres://localhost/foo` was not removed. As a result we should not test this behavior.
* | | | | Skip test_migrate_revert_add_index_with_name if databasesYasuo Honda2014-02-251-10/+13
| | | | | | | | | | | | | | | | | | | | do not allow to create duplicate indexes on the same columns
* | | | | Coerce strings when reading attributes.Yves Senn2014-02-231-0/+18
| |/ / / |/| | |
* | | | deprecate support for pg ranges with excluding beginnings.Yves Senn2014-02-231-23/+55
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Ruby Range object does not support excluding beginnings. We currently support excluding beginnings for some subtypes using manually by incrementing them (now using the `#succ` method). This is approach is flawed as it's not equal to an excluding beginning. This commit deprecates the current support for excluding beginnings. It also raises an `ArgumentError` for subtypes that do not implement the `succ` method. This is a temporary solution to get rid of the broken state. We might still add complete support for excluding beginnings afterwards. (Probably with a new `PGRange` object, which acts like a `Range` but has excluding beginnings.
* | | | dynamically define PostgreSQL OID range types.Yves Senn2014-02-231-11/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This gets AR working with custom defined range types. It also removes the need for subtype specific branches in `OID::Range`. This expands the interface of all `OID` types with the `infinity` method. It's responsible to provide a value for positive and negative infinity.
* | | | Add tests for default scope behaviour changeJon Leighton2014-02-232-0/+20
|/ / / | | | | | | | | | See #13875
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 20:50:17 +0000