aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
* applies new string literal convention in activerecord/testXavier Noria2016-08-06280-5678/+5678
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* Merge pull request #25998 from kamipo/enum_with_alias_attributeEileen M. Uchitelle2016-08-061-0/+16
|\ | | | | Fix `enum` with `alias_attribute`
| * Fix `enum` with `alias_attribute`Ryuta Kamizono2016-07-311-0/+16
| | | | | | | | Fixes #25892.
* | Don't assume all hashes are from multiparameter assignment in `composed_of`Sean Griffin2016-08-052-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | So this bug is kinda funky. The code path is basically "if we weren't passed an instance of the class we compose to, and we have a converter, call that". Ignoring the hash case for a moment, everything after that was roughly intended to be the "else" clause, meaning that we are expected to have an instance of the class we compose to. Really, we should be blowing up in that case, as we can give a much better error message than what they user will likely get (e.g. `NameError: No method first for String` or something). Still, Ruby is duck typed, so if the object you're assigning responds to the same methods as the type you compose to, knock yourself out. The hash case was added in 36e9be8 to remove a bunch of special cased code from multiparameter assignment. I wrongly assumed that the only time we'd get a hash there is in that case. Multiparameter assignment will construct a very specific hash though, where the keys are integers, and we will have a set of keys covering `1..part.size` exactly. I'm pretty sure this could actually be passed around as an array, but that's a different story. Really I should convert this to something like `class MultiParameterAssignment < Hash; end`, which I might do soon. However for a change that I'm willing to backport to 4-2-stable, this is what I want to go with for the time being. Fixes #25978
* | The problem isn't the detection but the deadlock itselfDavid Heinemeier Hansson2016-08-042-4/+4
| |
* | Merge pull request #25107 from Erol/introduce-new-ar-transaction-error-classesRafael Mendonça França2016-08-032-22/+40
|\ \ | |/ |/| | | | | | | Introduce new ActiveRecord transaction error classes Closes #26018
| * Introduce new ActiveRecord transaction error classesErol Fornoles2016-05-242-22/+40
| |
* | Merge pull request #25941 from kamipo/finder_methods_uses_load_targetRafael França2016-07-281-0/+2
|\ \ | | | | | | `FinderMethods` uses `records` (`load_target`) when `loaded?` is true
| * | `FinderMethods` uses `records` (`load_target`) when `loaded?` is trueRyuta Kamizono2016-07-281-0/+2
| | |
* | | Merge pull request #25940 from kamipo/fix_collection_proxy_loadRafael França2016-07-281-0/+8
|\ \ \ | | | | | | | | Fix to `CollectionProxy#load` does `load_target`
| * | | Fix to `CollectionProxy#load` does `load_target`Ryuta Kamizono2016-07-251-0/+8
| |/ /
* | | Merge pull request #25767 from ↵Rafael França2016-07-273-0/+17
|\ \ \ | | | | | | | | | | | | | | | | kamipo/association_name_is_the_same_as_join_table_name Correctly return `associated_table` when `associated_with?` is true
| * | | Correctly return `associated_table` when `associated_with?` is trueRyuta Kamizono2016-07-103-0/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | `AssociationQueryHandler` requires `association` initialized `TableMetadata` even if `table_name == arel_table.name`. Fixes #25689.
* | | | Remove circular join references in join_dependencyTakashi Kokubun2016-07-281-0/+7
| | | | | | | | | | | | | | | | Fixes #25653.
* | | | Merge pull request #25958 from kamipo/should_be_target_loadedYves Senn2016-07-271-0/+38
|\ \ \ \ | | | | | | | | | | Add an assertion to the tests that should be loaded the target.
| * | | | Add an assertion to the tests that should be loaded the target.Ryuta Kamizono2016-07-271-0/+38
| | | | | | | | | | | | | | | | | | | | These test cases tests exactly mutating loaded target.
* | | | | Merge pull request #25408 from kamipo/should_not_reuse_quoted_trueYves Senn2016-07-271-0/+16
|\ \ \ \ \ | |/ / / / |/| | | | Quoting booleans should return a frozen string
| * | | | Quoting booleans should return a frozen stringRyuta Kamizono2016-07-271-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If reuse `QUOTED_TRUE` and `QUOTED_FALSE` without frozen, causing the following issue. ``` Loading development environment (Rails 5.1.0.alpha) irb(main):001:0> ActiveRecord::Base.connection.quote(true) << ' foo' => "1 foo" irb(main):002:0> ActiveRecord::Base.connection.quote(true) << ' foo' => "1 foo foo" irb(main):003:0> type = ActiveRecord::ConnectionAdapters::AbstractMysqlAdapter::MysqlString.new => #<ActiveRecord::ConnectionAdapters::AbstractMysqlAdapter::MysqlString:0x007fd40c15e018 @precision=nil, @scale=nil, @limit=nil> irb(main):004:0> type.serialize(true) << ' bar' => "1 foo foo bar" irb(main):005:0> type.cast(true) << ' bar' => "1 foo foo bar bar" ```
* | | | | Merge pull request #25929 from kamipo/load_target_is_public_methodSantiago Pastorino2016-07-262-6/+4
|\ \ \ \ \ | | | | | | | | | | | | `load_target` is a public method
| * | | | | `load_target` is a public methodRyuta Kamizono2016-07-232-6/+4
| | | | | | | | | | | | | | | | | | | | | | | | `send` is unnecessary.
* | | | | | Make `force_signal37_to_load_all_clients_of_firm` to privateRyuta Kamizono2016-07-261-4/+6
| |/ / / / |/| | | | | | | | | | | | | | This is not a test case.
* | | | | Correct the behavior of virtual attributes on models loaded from the dbSean Griffin2016-07-251-0/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously we had primarily tested the behavior of these attributes by calling `.new`, allowing this to slip through the cracks. There were a few ways in which they were behaving incorrectly. The biggest issue was that attempting to read the attribute would through a `MissingAttribute` error. We've corrected this by returning the default value when the attribute isn't backed by a database column. This is super special cased, but I don't see a way to avoid this conditional. I had considered handling this higher up in `define_default_attribute`, but we don't have the relevant information there as users can provide new defaults for database columns as well. Once I corrected this, I had noticed that the attributes were always being marked as changed. This is because the behavior of `define_default_attribute` was treating them as assigned from `Attribute::Null`. Finally, with our new implementation, `LazyAttributeHash` could no longer be marshalled, as it holds onto a proc. This has been corrected as well. I've not handled YAML in that class, as we do additional work higher up to avoid YAML dumping it at all. Fixes #25787 Close #25841
* | | | | adds missing requiresXavier Noria2016-07-243-0/+3
| |_|/ / |/| | |
* | | | removes spurious lineXavier Noria2016-07-241-1/+0
| | | |
* | | | give some love to this test fileXavier Noria2016-07-231-151/+155
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It all started noticing some foo.method({ ... }) method calls in passing. This is a whole pass modernizing this file. While some string literals are edited where I touched code, this pass does not uniformizes quotes. A ton are left untouched on purposes. We have no defined style.
* | | | systematic revision of =~ usage in ARXavier Noria2016-07-238-12/+12
|/ / / | | | | | | | | | | | | Where appropriatei, prefer the more concise Regexp#match?, String#include?, String#start_with?, or String#end_with?
* | | Merge pull request #25885 from kamipo/fix_explain_logging_with_bindsRafael França2016-07-203-8/+8
|\ \ \ | | | | | | | | Fix explain logging with binds
| * | | Fix explain logging with bindsRyuta Kamizono2016-07-203-8/+8
| | | | | | | | | | | | | | | | `binds` is an array of a query attribute since Active Record 5.0.
* | | | Merge pull request #25786 from ↵Rafael França2016-07-201-0/+20
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | kamipo/add_exists_and_update_all_to_collection_proxy Add `exists?` and `update_all` to `CollectionProxy` for respects an association scope
| * | | | Add `exists?` and `update_all` to `CollectionProxy` for respects an ↵Ryuta Kamizono2016-07-201-0/+20
| |/ / / | | | | | | | | | | | | | | | | | | | | association scope Fixes #25732.
* | | | Merge pull request #25897 from ↵Rafael França2016-07-202-14/+1
|\ \ \ \ | |/ / / |/| | | | | | | | | | | yahonda/remove_set_date_columns_and_modify_attributes_test Remove Oracle specific tests based on deprecated behaviors
| * | | Oracle TIMESTAMP sql type is associated with Rails `DateTime` type nowYasuo Honda2016-07-202-14/+1
| | | | | | | | | | | | | | | | | | | | | | | | - Refer https://github.com/rsim/oracle-enhanced/pull/845 Remove `set_date_columns` which has been deprecated in Oracle enhanced adapter - Refer https://github.com/rsim/oracle-enhanced/pull/869
* | | | Merge pull request #25578 from ↵Rafael França2016-07-202-3/+9
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | kamipo/move_warning_about_composite_primary_key_to_attribute_methods_primary_key Move the warning about composite primary key to `AttributeMethods::PrimaryKey`
| * | | | Move the warning about composite primary key to `AttributeMethods::PrimaryKey`Ryuta Kamizono2016-07-022-3/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Actually schema dumper/creation supports composite primary key (#21614). Therefore it should not show the warning about composite primary key in connection adapter. This change moves the warning to `AttributeMethods::PrimaryKey` and suppress the warning for habtm join table. Fixes #25388.
* | | | | Merge pull request #25849 from suginoy/fix_merge_in_scopeRafael Mendonça França2016-07-201-0/+7
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | Fix the calling `merge` method at first in a scope
| * | | | | Fix the calling `merge` method at first in a scopesuginoy2016-07-191-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changing the order of method chaining `merge` and other query method such as `joins` should produce the same result. ```ruby class Topic < ApplicationRecord scope :safe_chaininig, -> { joins(:comments).merge(Comment.newest) } scope :unsafe_chaininig, -> { merge(Comment.newest).joins(:comments) } #=> NoMethodError end ```
* | | | | | Merge pull request #25828 from bogdanvlviv/ref_default_sequence_nameRafael França2016-07-201-1/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | Refactored method `ActiveRecord::ConnectionAdapters::PostgreSQL::SchemaStatements#default_sequence_name`. Refactored test `HasManyAssociationsTest#test_do_not_call_callbacks_for_delete_all`.
| * | | | | | Refactored test ↵bogdanvlviv2016-07-171-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | `HasManyAssociationsTest#test_do_not_call_callbacks_for_delete_all`
* | | | | | | Merge pull request #25834 from ↵Rafael França2016-07-201-0/+14
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | alpaca-tc/fixes_multiparameter_attributes_on_time_with_time_zone_aware_attributes Fix bug in method AR TimeZoneConverter#set_time_zone_without_conversion
| * | | | | | | Fixes multiparameter attributes conversion with time_zone_aware_attributes ↵alpaca-tc2016-07-191-0/+14
| | |_|_|/ / / | |/| | | | | | | | | | | | | | | | | | | and invalid params
* | | | | | | Merge pull request #25868 from kamipo/fix_payload_class_name_to_spec_nameRafael França2016-07-203-4/+6
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | Fix `payload[:class_name]` to `payload[:spec_name]`
| * | | | | | Fix `payload[:class_name]` to `payload[:spec_name]`Ryuta Kamizono2016-07-173-4/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow up to #20818. `retrieve_connection` is passed `spec_name` instead of `klass` since #24844.
* | | | | | | Pass `type_casted_binds` to log subscriber for logging bind values properlyRyuta Kamizono2016-07-191-1/+10
| |_|/ / / / |/| | | | | | | | | | | | | | | | | Address to https://github.com/rails/rails/commit/5a302bf553af0e6fedfc63299fc5cd6e79599ef3#commitcomment-18288388.
* | | | | | deprecates the error_on_ignored_order_or_limit instance readerXavier Noria2016-07-181-2/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Albeit the previous existence of this method is not seen in the patch itself, the declaration mattr_accessor :error_on_ignored_order_or_limit, instance_writer: false was present before. It was removed recently in 210012f.
* | | | | | adds coverage for the deprecation of error_on_ignored_orderXavier Noria2016-07-181-0/+8
| |/ / / / |/| | | |
* | | | | No need `public_send`Ryuta Kamizono2016-07-171-2/+2
|/ / / /
* | | | Merge pull request #20818 from ↵Rafael França2016-07-172-0/+52
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | jeremywadsack/use_transactional_fixtures_all_databases Use notification to ensure that lazy-loaded model classes have transactions
| * | | | Create connection.active_record notification and use that to ensure that lazy-Jeremy Wadsack2016-07-122-0/+52
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | loaded model classes have their connections wrapped in transactions. See #17776 In Rails 4 config.eager_load was changed to false in the test environment. This means that model classes that connect to alternate databases with establish_connection are not loaded at start up. If use_transactional_fixtures is enabled, transactions are wrapped around the connections that have been established only at the start of the test suite. So model classes loaded later don't have transactions causing data created in the alternate database not to be removed. This change resolves that by creating a new connection.active_record notification that gets fired whenever a connection is established. I then added a subscriber after we set up transactions in the test environment to listen for additional connections and wrap those in transactions as well.
* | | | | Fix wrong test namePrathamesh Sonpatki2016-07-161-1/+1
| | | | | | | | | | | | | | | | | | | | - Followup of https://github.com/rails/rails/pull/23179
* | | | | adds support for limits in batch processingXavier Noria2016-07-131-10/+122
|/ / / /
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-01 00:57:52 +0000