aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
* reorder bind parameters when merging relationsAaron Patterson2013-07-152-1/+25
|
* use arel rather than slapping together SQL stringsAaron Patterson2013-07-151-3/+6
|
* Merge pull request #11451 from ↵Yves Senn2013-07-151-0/+7
|\ | | | | | | | | jetthoughts/11450_do_not_resave_destroyed_association Do not re-save destroyed association on saving parent object
| * Do not re-save destroyed association on saving parent objectPaul Nikitochkin2013-07-151-0/+7
| | | | | | | | Closes #11450
* | Remove deprecation warning from attribute_missing Arun Agrawal2013-07-151-15/+0
|/ | | for attributes that are columns.
* Merge pull request #11434 from jetthoughts/new_save_transaction_bugfixSantiago Pastorino2013-07-141-0/+14
|\ | | | | Remove extra decrement of transaction level
| * #4566: Remove extra decrement of transaction levelPaul Nikitochkin2013-07-141-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | `rollback_active_record_state!` tries to restore model state on `Exception` by invoking `restore_transaction_record_state` it decrement deep level by `1`. After restoring it ensure that states to be cleared and level decremented by invoking `clear_transaction_record_state`, which cause the bug: because state already reduced in `restore_transaction_record_state`. Removed double derement of transaction level and removed duplicated code which clear transaction state for top level.
* | Blacklist->whitelist for reference scans in order!Ernie Miller2013-07-141-0/+7
|/ | | | | | Stop special-casing Arel::Nodes as exempt from reference scanning in order. Instead, only scan order values that are strings for a table reference.
* Reset @column_defaults when assigning .kennyj2013-07-141-0/+1
|
* Make sure that a joins Relation can be merged with has_many :through + ↵Akira Matsuda2013-07-102-1/+11
| | | | | | association proxy Closes #11248.
* Fix: attribute_for_inspect truncate upto (51 => 50) characters.namusyaka2013-07-091-1/+1
|
* Remove redundant test about `push_with_attributes` removal.Vipul A M2013-07-091-7/+0
|
* close our connection when we are doneAaron Patterson2013-07-082-14/+17
|
* remove dead codeAaron Patterson2013-07-081-16/+0
|
* if we remove the connection from the pool, we should close itAaron Patterson2013-07-081-0/+1
|
* use latches rather than mucking with the schedulerAaron Patterson2013-07-081-7/+7
|
* Merge pull request #11274 from arunagw/deprecation-removed-build-fixedRafael Mendonça França2013-07-071-20/+0
|\ | | | | Deprecation removed build fixed
| * Removed unused test for DateTime.local_offsetArun Agrawal2013-07-071-20/+0
| | | | | | | | see discussion here #11274
* | Merge pull request #11306 from ↵Rafael Mendonça França2013-07-061-1/+42
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | jetthoughts/11288_remove_extra_queries_for_belongs_to_with_touch #11288: Removed duplicated touching Conflicts: activerecord/CHANGELOG.md
| * | #11288: Removed duplicated touchingPaul Nikitochkin2013-07-051-1/+42
| | | | | | | | | | | | | | | | | | if belongs to model with touch option on touch Closes #11288
* | | Revert "Merge pull request #11299 from ↵Yves Senn2013-07-051-0/+6
|/ / | | | | | | | | | | | | | | | | | | arunagw/disable_implicit_join_references_removed" `disable_implicit_join_references=` was only deprecated on `master`, not with rails 4.0. We can remove it after 4.1 This reverts commit 3c719ead414ffd29e71efce185698af979052abb, reversing changes made to d5c3bf9722abd5733a769c8d789de3f74dbfb92d.
* | Cleanup belongs to testsPaul Nikitochkin2013-07-051-2/+1
| | | | | | | | simplified logic to calculate number of queries by using assert_queries
* | Remove deprecated `ActiveRecord::Base.disable_implicit_join_references=`.Arun Agrawal2013-07-041-6/+0
| |
* | Remove deprecated String constructor from `ActiveRecord::Migrator`.Yves Senn2013-07-041-6/+0
| |
* | Remove deprecated `scope` use without passing a callable object.Arun Agrawal2013-07-031-10/+0
| | | | | | | | Removed tests from deprecated code.
* | Remove deprecated `transaction_joinable=`Arun Agrawal2013-07-031-9/+0
|/ | | | | in favor of `begin_transaction` with `:joinable` option.
* remove deprecated `PostgreSQLAdapter#outside_transaction?` method.Yves Senn2013-07-031-10/+0
|
* Merge pull request #11258 from frodsan/remove_deprecated_distinctCarlos Antonio da Silva2013-07-021-46/+0
|\ | | | | Remove deprecated SchemaStatements#distinct
| * Remove deprecated SchemaStatements#distinctFrancesco Rodriguez2013-07-021-46/+0
| |
* | initialize generated modules on inclusion and on inheritenceAaron Patterson2013-07-021-7/+0
| |
* | fix to_sql output on eager loaded relationsAaron Patterson2013-07-021-0/+8
| |
* | remove private attribute readerAaron Patterson2013-07-021-2/+2
|/
* remove unused `ActiveRecord::TestCase#sqlite3` method.Yves Senn2013-07-021-6/+0
|
* deprecated `ActiveRecord::TestCase` is no longer public.Yves Senn2013-07-021-2/+94
| | | | /cc @tenderlove
* Dropped deprecated option `:restrict` for `:dependent` in associationsNeeraj Singh2013-07-033-38/+0
|
* Removed support for deprecated `delete_sql` in associations.Neeraj Singh2013-07-032-30/+0
|
* Removed support for deprecated `finder_sql` in associations.Neeraj Singh2013-07-025-156/+0
|
* Add CHANGELOG enty for #11235Rafael Mendonça França2013-07-021-1/+0
|
* Removed support for deprecated `counter_sql`Neeraj Singh2013-07-023-61/+1
|
* Removing not useful test related to reflect_on_all_associationsNeeraj Singh2013-07-021-8/+0
| | | | | | | | | | | | | | | | The comment in the test pretty much summarizes the issue. `FIXME these assertions bust a lot` Adding any type of association in class `Firm` will break this test. I removed some deprecated stuff and this test failed. I do not think this test provides any useful value. First of all who counted last that 39 is the right number of associations. Secondly there are a large number of tests which depend on reflection returning right information about associations. Those tests will start failing if there is a bug in the code.
* Merge pull request #10604 from ↵Rafael Mendonça França2013-07-016-2/+73
|\ | | | | | | | | | | | | | | | | neerajdotname/delete_all_should_not_call_callbacks Do not invoke callbacks when delete_all is called Conflicts: activerecord/CHANGELOG.md
| * Do not invoke callbacks when delete_all is calledNeeraj Singh2013-06-306-2/+73
| | | | | | | | | | | | | | | | | | | | | | Method `delete_all` should not be invoking callbacks and this feature was deprecated in Rails 4.0. This is being removed. `delete_all` will continue to honor the `:dependent` option. However if `:dependent` value is `:destroy` then the default deletion strategy for that collection will be applied. User can also force a deletion strategy by passing parameter to `delete_all`. For example you can do `@post.comments.delete_all(:nullify)`
* | calling default_scope without a proc will raise ArgumentErrorNeeraj Singh2013-07-021-3/+2
| | | | | | | | Calling default_scope without a proc will now raise `ArgumentError`.
* | Removed deprecated options for assocationsNeeraj Singh2013-07-022-22/+0
| | | | | | | | | | Deprecated options `delete_sql`, `insert_sql`, `finder_sql` and `counter_sql` have been deleted.
* | remove deprecated `ActiveRecord::Base#connection` method.Yves Senn2013-07-011-4/+0
| |
* | Remove deprecated `:distinct` option from `Relation#count`.Yves Senn2013-07-011-10/+0
| |
* | Removed deprecated methods partial_updates and familyNeeraj Singh2013-07-021-14/+0
|/ | | | | Removed deprecated methods `partial_updates`, `partial_updates?` and `partial_updates=`
* remove deprecated implicit join references.Yves Senn2013-06-293-43/+7
|
* Merge pull request #11161 from dmitry/find_in_batches_works_without_loggerCarlos Antonio da Silva2013-06-281-0/+10
|\ | | | | | | | | ActiveRecord find_in_batches should work without logger When I set logger to nil both methods from Batches module find_in_batches or find_each should work anyway.
| * find_in_batches should work without loggerDmitry Polushkin2013-06-281-0/+10
| |