rails.git - Mirror of official rails repo with custom fixes.

	Commit message (Collapse)	Author	Age	Files	Lines
...
\| * \| \| \| \| \| \| \|	Add explicit ordering to nested_has_many_through_associations_test.rb as ↵	Jon Leighton	2010-10-19	1	-32/+37
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	this was causing failures under postgres
\| * \| \| \| \| \| \| \|	Merge branch 'master' into nested_has_many_through	Jon Leighton	2010-10-19	3	-14/+38
\| \|\ \ \ \ \ \ \ \
\| * \| \| \| \| \| \| \| \|	Remove various comments and code which were just being used during the ↵	Jon Leighton	2010-10-19	1	-5/+0
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	development of nested through association support (OMFGZ, I might just have nearly finished this\!
\| * \| \| \| \| \| \| \| \|	Add explicit tests for the nested through association changes in reflection.rb	Jon Leighton	2010-10-19	4	-0/+67
\| \| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \| \|	Fix broken test	Jon Leighton	2010-10-19	1	-1/+5
\| \| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \| \|	Support the :primary_key option on a through reflection in a nested through ↵	Jon Leighton	2010-10-19	5	-2/+30
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	association
\| * \| \| \| \| \| \| \| \|	Support for :primary_key option on the source reflection of a through ↵	Jon Leighton	2010-10-19	7	-10/+27
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	association, where the source is a has_one or has_many
\| * \| \| \| \| \| \| \| \|	Respect the :primary_key option on the through_reflection of (non-nested) ↵	Jon Leighton	2010-10-19	6	-3/+57
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	through associations
\| * \| \| \| \| \| \| \| \|	Properly support conditions on any of the reflections involved in a nested ↵	Jon Leighton	2010-10-19	13	-22/+116
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	through association
\| * \| \| \| \| \| \| \| \|	Make sure nested through associations are read only	Jon Leighton	2010-10-15	1	-0/+42
\| \| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \| \|	Add assertions for nested through associations loaded by includes with ↵	Jon Leighton	2010-10-15	1	-81/+75
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	conditions (uses the single-query strategy). Currently one failure to fix.
\| * \| \| \| \| \| \| \| \|	Support preloading nested through associations (using the default ↵	Jon Leighton	2010-10-15	1	-61/+140
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	multi-query strategy)
\| * \| \| \| \| \| \| \| \|	Remove unnecessary requires from nested_has_many_through_associations_test.rb	Jon Leighton	2010-10-14	1	-6/+0
\| \| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \| \|	Add test_has_one_through_has_one_through_with_belongs_to_source_reflection	Jon Leighton	2010-10-14	7	-4/+31
\| \| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \| \|	Add test_has_many_through_belongs_to_with_has_many_through_source_reflection ↵	Jon Leighton	2010-10-14	2	-2/+15
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	(which already passes)
\| * \| \| \| \| \| \| \| \|	Add test_has_many_through_has_many_through_with_belongs_to_source_reflection ↵	Jon Leighton	2010-10-14	2	-1/+13
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	(which already works)
\| * \| \| \| \| \| \| \| \|	Added ↵	Jon Leighton	2010-10-14	4	-2/+24
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	test_has_many_through_has_many_with_has_many_through_habtm_source_reflection and make it pass
\| * \| \| \| \| \| \| \| \|	Merge branch 'master' into nested_has_many_through	Jon Leighton	2010-10-14	13	-41/+331
\| \|\ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Conflicts: activerecord/lib/active_record/associations.rb activerecord/test/cases/associations/cascaded_eager_loading_test.rb
\| * \| \| \| \| \| \| \| \| \|	Add ↵	Jon Leighton	2010-10-13	2	-1/+13
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	test_has_many_through_has_and_belongs_to_many_with_has_many_source_reflection and make it work
\| * \| \| \| \| \| \| \| \| \|	First bit of support for habtm in through assocs - ↵	Jon Leighton	2010-10-13	4	-7/+17
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	test_has_many_through_has_many_with_has_and_belongs_to_many_source_reflection now passes
\| * \| \| \| \| \| \| \| \| \|	Add a commented, failing test for using a habtm in a has many through ↵	Jon Leighton	2010-10-12	4	-9/+24
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	association. I want to refactor how aliasing works first.
\| * \| \| \| \| \| \| \| \| \|	Add test_has_many_through_has_one_through_with_has_many_source_reflection	Jon Leighton	2010-10-12	2	-1/+19
\| \| \| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \| \| \|	Adding test_has_many_through_has_one_with_has_many_through_source_reflection ↵	Jon Leighton	2010-10-12	4	-2/+28
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	and modifying ThroughAssociationScope to make it work correctly.
\| * \| \| \| \| \| \| \| \| \|	Rename some tests for consistency	Jon Leighton	2010-10-12	1	-3/+3
\| \| \| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \| \| \|	Add test_has_many_through_has_one_through	Jon Leighton	2010-10-12	2	-2/+17
\| \| \| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \| \| \|	Support has_one through assocs as the source association	Jon Leighton	2010-10-12	6	-10/+50
\| \| \| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \| \| \|	A load of tests that need to be written	Jon Leighton	2010-10-12	1	-0/+63
\| \| \| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \| \| \|	Add support for nested through associations in JoinAssociation. Hence ↵	Jon Leighton	2010-10-09	9	-5/+86
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Foo.joins(:bar) will work for through associations. There is some duplicated code now, which will be refactored.
\| * \| \| \| \| \| \| \| \| \|	Merge branch 'master' into nested_has_many_through	Jon Leighton	2010-10-06	5	-1/+51
\| \|\ \ \ \ \ \ \ \ \ \
\| * \| \| \| \| \| \| \| \| \| \|	Refactoring JoinDependency and friends. This improves the code (IMO) ↵	Jon Leighton	2010-10-06	7	-12/+43
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	including adding some explanatory comments, but more importantly structures it in such a way as to allow a JoinAssociation to produce an arbitrary number of actual joins, which will be necessary for nested has many through support. Also added 3 tests covering functionality which existed but was not previously covered.
\| * \| \| \| \| \| \| \| \| \| \|	A failing test for a nested has many through association loaded via ↵	Jon Leighton	2010-10-05	1	-0/+6
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Foo.joins(:bar)
\| * \| \| \| \| \| \| \| \| \| \|	Fix the tests (I have actually verified that these are also the 'right' ↵	Jon Leighton	2010-10-03	6	-24/+24
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	fixes, rather than just making the tests pass again)
\| * \| \| \| \| \| \| \| \| \| \|	Add support for table aliasing, with a test that needs aliasing in order to ↵	Jon Leighton	2010-10-02	6	-2/+38
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	work correctly. This test incidentally provides a more complicated test case (4 inner joins, 2 using polymorphism).
\| * \| \| \| \| \| \| \| \| \| \|	Integrate nested support into ThroughAssociationScope, using my concept of ↵	Jon Leighton	2010-10-02	1	-12/+12
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	generating a 'chain' of reflections to be joined. It seems to work at the moment, all existing tests are passing. There may be further complications as we add more test cases for nested associations, though.
\| * \| \| \| \| \| \| \| \| \| \|	Started implementing nested :through associations by using the existing ↵	Jon Leighton	2010-10-01	1	-13/+13
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	structure of ThroughAssociationScope rather than layering a module over the top
\| * \| \| \| \| \| \| \| \| \| \|	Prevent ↵	Jon Leighton	2010-09-30	1	-2/+2
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	test_has_many_through_a_has_many_through_association_on_through_reflection failing for me due to ordering of the results
\| * \| \| \| \| \| \| \| \| \| \|	Merge branch 'master' into nested_has_many_through_2	Jon Leighton	2010-09-30	12	-56/+209
\| \|\ \ \ \ \ \ \ \ \ \ \
\| * \| \| \| \| \| \| \| \| \| \| \|	Initial nested_has_many_through support [#1152]	Bodaniel Jeanes	2010-09-26	6	-12/+58
\| \| \| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \| \| \|	Change behavior of count(:limit => x, :offset => y) to limit/offset before ↵	John Mileham	2011-03-03	2	-11/+54
\| \|_\|_\|_\|_\|_\|_\|_\|_\|_\|_\|/ \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	counting.
* \| \| \| \| \| \| \| \| \| \| \|	Rewrote AssociationPreload.	Jon Leighton	2011-02-28	4	-18/+18
\| \| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \| \|	skip this on oracle	Aaron Patterson	2011-02-28	1	-0/+2
\| \| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \| \|	use an attribute rather than a SQL literal	Aaron Patterson	2011-02-26	1	-0/+1
\| \| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \| \|	removing limits and offsets from COUNT queries unless both are specified. ↵	Aaron Patterson	2011-02-25	1	-0/+28
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	[#6268 state:resolved]
* \| \| \| \| \| \| \| \| \| \| \|	fixes: ActiveRecord::Base.scopes includes all scopes defined in all subclasses	Eric Allam	2011-02-24	1	-0/+4
\| \| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \| \|	observers leak across tests, so rather than modify the object, we should ↵	Aaron Patterson	2011-02-23	1	-6/+12
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	just count the number of times the observer was called
* \| \| \| \| \| \| \| \| \| \| \|	Fix observer callbacks firing multiple times on descendant instances	Kamal Fariz Mahyuddin	2011-02-22	1	-0/+14
\| \| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \| \|	expectations change when using IM. Change oracle tests to reflect that	Aaron Patterson	2011-02-22	1	-2/+6
\| \| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \| \|	adding a test case for custom locking	Aaron Patterson	2011-02-21	1	-0/+17
\| \| \| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \| \|	Use proper objects to do the work to build the associations (adding methods, ↵	Jon Leighton	2011-02-21	2	-12/+16
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	callbacks etc) rather than calling a whole bunch of methods with rather long names.
* \| \| \| \| \| \| \| \| \| \| \|	Merge branch 'master' of git://github.com/lifo/docrails	Xavier Noria	2011-02-21	1	-1/+1
\|\ \ \ \ \ \ \ \ \ \ \ \