rails.git - Mirror of official rails repo with custom fixes.

	Commit message (Collapse)	Author	Age	Files	Lines
...
*	In a number of places in the tests, we only need to turn off transactional ↵	Jon Leighton	2011-01-11	9	-43/+51
\| \| \| \|	fixtures when the DB does not support savepoints. This speeds the test run up by about 8-9% on my computer, when running rake test_sqlite3_mem :)
*	When assigning a has_one, if the new record fails to save, raise an error	Jon Leighton	2011-01-11	2	-16/+16
\|
*	When assigning a has_one, if the existing record fails to be removed from ↵	Jon Leighton	2011-01-11	1	-0/+12
\| \| \| \|	the association, raise an error
*	Have a separate test connection directory for sqlite3 in-memory so that the ↵	Jon Leighton	2011-01-11	1	-0/+0
\| \| \| \|	tests can be run without having to specifically rename the connection file (which then causes git to pick up the changes)
*	Enable the sqlite3 in-memory test connection to work	Jon Leighton	2011-01-11	5	-17/+25
\|
*	has_one should always remove the old record (properly), even if not saving ↵	Jon Leighton	2011-01-11	3	-10/+30
\| \| \| \|	the new record, so we don't get the database into a pickle
*	Fix polymorphic belongs_to associationproxy raising errors when loading target.	Ernie Miller	2011-01-11	2	-0/+11
\|
*	Always return decimal average of integer fields	Raimonds Simanovskis	2011-01-10	1	-0/+5
\| \| \| \|	In previous version if database adapter (e.g. SQLite and Oracle) returned non-String calculated values then type_cast_using_column converted decimal average value of intefer field to integer value. Now operation parameter is always checked to decide which conversion of calculated value should be done.
*	use SQLite3::VERSION rather than the deprecated class	Aaron Patterson	2011-01-10	1	-1/+1
\|
*	Add test for e0e3adf	Jeremy Kemper	2011-01-07	1	-0/+6
\|
*	Don't not remove double negatives	Jon Leighton	2011-01-07	1	-1/+1
\|
*	Construct an actual ActiveRecord::Relation object for the association scope, ↵	Jon Leighton	2011-01-07	4	-12/+4
\| \| \| \|	rather than a hash which is passed to apply_finder_options. This allows more flexibility in how the scope is created, for example because scope.where(a, b) and scope.where(a).where(b) mean different things.
*	Use encode_with for marshalling	Jon Leighton	2011-01-07	1	-0/+7
\|
*	send() will raise an ArgumentError, so we should leverage ruby	Aaron Patterson	2011-01-07	1	-1/+1
\|
*	just use a hash for doing association caching	Aaron Patterson	2011-01-07	3	-4/+3
\|
*	adding an `encode_with` method for Psych dump/load methods	Aaron Patterson	2011-01-05	1	-0/+7
\|
*	make sure new objects can round trip	Aaron Patterson	2011-01-05	1	-0/+6
\|
*	make sure that Psych can roundtrip an AR object	Aaron Patterson	2011-01-05	1	-0/+13
\|
*	fixing merge errors	Aaron Patterson	2011-01-04	2	-78/+0
\|
*	Remove undocumented feature from has_one where you could pass false as the ↵	Jon Leighton	2011-01-03	2	-36/+7
\| \| \| \| \| \| \| \| \| \| \| \|	second parameter to build_assoc or create_assoc, and the existing associated object would be untouched (the foreign key would not be nullified, and it would not be deleted). If you want behaviour similar to this you can do the following things: * Use :dependent => :nullify (or don't specify :dependent) if you want to prevent the existing associated object from being deleted * Use has_many if you actually want multiple associated objects * Explicitly set the foreign key if, for some reason, you really need to have multiple objects associated with the same has_one. E.g. previous = obj.assoc obj.create_assoc previous.update_attributes(:obj_id => obj.id)
*	ActiveRecord::Relation#primary_key should return a string, just like ↵	Jon Leighton	2011-01-03	1	-0/+4
\| \| \| \|	ActiveRecord::Base.primary_key does.
*	Implement deprecated version of AssociationReflection#primary_key_name, ↵	Jon Leighton	2011-01-03	1	-0/+12
\| \| \| \|	which has been renamed to #foreign_key. Also bumping the deprecation_horizon in Active Support to 3.1.
*	When preloading a belongs_to, the target should still be set (to nil) if ↵	Jon Leighton	2011-01-03	1	-0/+9
\| \| \| \|	there is no foreign key present. And the loaded flag should be set on the association proxy. This then allows us to remove the foreign_key_present? check from BelongsToAssociation#find_target. Also added a test for the same thing on polymorphic associations.
*	Make Relation#create_with always merge rather than overwrite, not just when ↵	Jon Leighton	2011-01-03	1	-0/+10
\| \| \| \|	merging two relations. If you wish to overwrite, you can do relation.create_with(nil), or for a specific attribute, relation.create_with(:attr => nil).
*	Let AssociationCollection#find use #scoped to do its finding. Note that I am ↵	Jon Leighton	2011-01-03	6	-15/+22
\| \| \| \|	removing test_polymorphic_has_many_going_through_join_model_with_disabled_include, since this specifies different behaviour for an association than for a regular scope. It seems reasonable to expect scopes and association proxies to behave in roughly the same way rather than having subtle differences.
*	Fix test_any in relations_test.rb, which was failing when relations_test.rb ↵	Jon Leighton	2011-01-03	1	-0/+8
\| \| \| \|	is run on its own (it passes when the entire suite is run). This is a hacky fix for a problem I didn't quite get to the bottom of, so I'd welcome a better solution...
*	Allow assignment on has_one :through where the owner is a new record [#5137 ↵	Jon Leighton	2011-01-03	6	-23/+61
\| \| \| \| \| \| \| \| \| \|	state:resolved] This required changing the code to keep the association proxy for a belongs_to around, despite its target being nil. Which in turn required various changes to the way that stale target checking is handled, in order to support various edge cases (loaded target is nil then foreign key added, foreign key is changed and then changed back, etc). A side effect is that the code is nicer and more succinct. Note that I am removing test_no_unexpected_aliasing since that is basically checking that the proxy for a belongs_to does change, which is the exact opposite of the intention of this commit. Also adding various tests for various edge cases and related things. Phew, long commit message!
*	Have a proper AssociationReflection#foreign_type method rather than using ↵	Jon Leighton	2011-01-03	1	-0/+6
\| \| \| \|	options[:foreign_type]
*	Some basic tests for the :foreign_type option on belongs_to, which was ↵	Jon Leighton	2011-01-03	3	-2/+33
\| \| \| \|	previously completely untested.
*	herp derpricating add_limit_offset!	Aaron Patterson	2011-01-03	1	-12/+0
\|
*	Added one more failing test for bug #6036	Robert Pankowecki (Gavdi)	2011-01-04	1	-0/+6
\|
*	Rename AssociationReflection#primary_key_name to foreign_key, since the ↵	Jon Leighton	2010-12-31	1	-3/+5
\| \| \| \|	options key which it relates to is :foreign_key
*	Support for :counter_cache on polymorphic belongs_to	Jon Leighton	2010-12-31	2	-0/+13
\|
*	Refactor BelongsToAssociation to allow BelongsToPolymorphicAssociation to ↵	Jon Leighton	2010-12-31	1	-6/+36
\| \| \| \|	inherit from it
*	Specify the STI type condition using SQL IN rather than a whole load of ORs. ↵	Jon Leighton	2010-12-31	1	-0/+7
\| \| \| \|	Required a fix to ActiveRecord::Relation#merge for properly merging create_with_value. This also fixes a situation where the type condition was appearing twice in the resultant SQL query.
*	Verify that when has_many associated objects are destroyed via :dependent => ↵	Jon Leighton	2010-12-31	2	-1/+25
\| \| \| \|	:destroy, when the parent is destroyed, the callbacks are run
*	Refactor configure_dependency_for_has_many to use ↵	Jon Leighton	2010-12-31	1	-3/+4
\| \| \| \|	AssociationCollection#delete_all. It was necessary to change test_before_destroy in lifecycle_test.rb so that it checks topic.replies.size before doing the destroy, as afterwards it will now (correctly) be 0.
*	Make sure Model#touch doesn't try to update non existing columns	Pratik Naik	2010-12-30	1	-1/+3
\|
*	Make serialized fixtures work again	Pratik Naik	2010-12-29	5	-4/+18
\|
*	Allow primary_key to be an attribute when the model is a new record	Santiago Pastorino	2010-12-28	1	-1/+1
\|
*	stop calling deprecated apis	Aaron Patterson	2010-12-26	2	-5/+5
\|
*	Associations: DRY up the code which is generating conditions, and make it ↵	Jon Leighton	2010-12-26	1	-1/+0
\| \| \| \|	all use arel rather than SQL strings
*	Fix dodgy tests which were effectively asserting nil == nil	Jon Leighton	2010-12-26	2	-3/+4
\|
*	using arel to compile sql statements	Aaron Patterson	2010-12-25	2	-1/+2
\|
*	take more advantage of arel sql compiler	Aaron Patterson	2010-12-25	1	-1/+1
\|
*	stop redifining methods on every call to set_primary_key	Aaron Patterson	2010-12-24	2	-4/+12
\|
*	Verify that there is no unwanted implicit readonly set on ↵	oleg dashevskii	2010-12-23	1	-1/+13
\| \| \| \|	Model.has_many_through.find(id) [#5442 state:resolved]
*	Raise an error for associations which try to go :through a polymorphic ↵	Jon Leighton	2010-12-23	2	-4/+10
\| \| \| \|	association [#6212 state:resolved]
*	If a has_many goes :through a belongs_to, and the foreign key of the ↵	Jon Leighton	2010-12-23	8	-31/+88
\| \| \| \|	belongs_to changes, then the has_many should be considered stale.
*	Improved strategy for updating a belongs_to association when the foreign key ↵	Jon Leighton	2010-12-23	2	-2/+5
\| \| \| \|	changes. Rather than resetting each affected association when the foreign key changes, we should lazily check for 'staleness' (where fk does not match target id) when the association is accessed.