aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test
Commit message (Collapse)AuthorAgeFilesLines
* Fix test failures caused by d99db6b8b3e4Sean Griffin2015-10-201-1/+1
| | | | | I messed up the merge conflict, and accidentally removed a schema query that needed to be ignored.
* Qualify column names in calculationSoutaro Matsumoto2015-10-201-0/+19
| | | | Column names inserted via `group` have to be qualified with table name.
* Fix merge conflicts for #18856Sean Griffin2015-10-201-1/+1
|\
| * Match table names exactly on MySQLMatt Jones2015-02-083-15/+3
| | | | | | | | | | | | | | | | The `SHOW TABLES LIKE` command accepts metacharacters `%` and `_` in potentially unexpected ways. This can be avoided by querying `information_schema.tables` directly. Fixes #17897
* | Merge pull request #21883 from tarzan/cache-key-too-preciseSean Griffin2015-10-203-6/+39
|\ \ | | | | | | Fix precision on cache_key
| * | fixes #21815Maarten Jacobs2015-10-163-6/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The default timestamp used for AR is `updated_at` in nanoseconds! (:nsec) This causes issues on any machine that runs an OS that supports nanoseconds timestamps, i.e. not-OS X, where the cache_key of the record persisted in the database (milliseconds precision) is out-of-sync with the cache_key in the ruby VM. This commit adds: A test that shows the issue, it can be found in the separate file `cache_key_test.rb`, because - model couldn't be defined inline - transactional testing needed to be turned off to get it to pass the MySQL tests This seemed cleaner than putting it in an existing testcase file. It adds :usec as a dateformat that calculates datetime in microseconds It sets precision of cache_key to :usec instead of :nsec, as no db supports nsec precision on timestamps
* | | Do not cache prepared statements that are unlikely to have cache hitsSean Griffin2015-10-202-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prior to this commit, Rails makes no differentiation between whether a query uses bind parameters, and whether or not we cache that query as a prepared statement. This leads to the cache populating extremely fast in some cases, with the statements never being reused. In particular, the two problematic cases are `where(foo: [1, 2, 3])` and `where("foo = ?", 1)`. In both cases we'll end up quoting the values rather than using a bind param, causing a cache entry for every value ever used in that query. It was noted that we can probably eventually change `where("foo = ?", 1)` to use a bind param, which would resolve that case. Additionally, on PG we can change our generated query to be `WHERE foo = ANY($1)`, and pass an array for the bind param. I hope to accomplish both in the future. For SQLite and MySQL, we still end up preparing the statements anyway, we just don't cache it. The statement will be cleaned up after it is executed. On postgres, we skip the prepare step entirely, as an API is provided to execute with bind params without preparing the statement. I'm not 100% happy on the way this ended up being structured. I was hoping to use a decorator on the visitor, rather than mixing a module into the object, but the way Arel has it's visitor pattern set up makes it very difficult to extend without inheritance. I'd like to remove the duplication from the various places that are extending it, but that'll require a larger restructuring of that initialization logic. I'm going to take another look at the structure of it soon. This changes the signature of one of the adapter's internals, and will require downstream changes from third party adapters. I'm not too worried about this, as worst case they can simply add the parameter and always ignore it, and just keep their previous behavior. Fixes #21992.
* | | Merge pull request #21932 from kamipo/add_stored_procedure_test_in_mysql2Sean Griffin2015-10-206-17/+62
|\ \ \ | | | | | | | | Add stored procedure test in mysql2
| * | | Add stored procedure test in mysql2Ryuta Kamizono2015-10-155-16/+61
| | | |
| * | | Make `AbstractMysqlAdapter#version` publicRyuta Kamizono2015-10-151-1/+1
| | | |
* | | | Merge pull request #21962 from kamipo/fix_tinyblobSean Griffin2015-10-205-5/+5
|\ \ \ \ | | | | | | | | | | Fix to correctly schema dump the `tinyblob`
| * | | | Fix to correctly schema dump the `tinyblob`Ryuta Kamizono2015-10-155-5/+5
| |/ / / | | | | | | | | | | | | | | | | | | | | Currently `tinyblob` is dumped to `t.binary "tiny_blob", limit: 255`. But `t.binary ... limit: 255` is generating SQL to `varchar(255)`. It is incorrect. This commit fixes this problem.
* | | | Merge pull request #21974 from ↵Rafael Mendonça França2015-10-202-5/+20
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | jbranchaud/reorder-has-many-assocation-constraints Reorder application of has_many association constraints.
| * | | | Reorder application of has_many association constraints.jbranchaud2015-10-191-0/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With `unscope!` called last, it undoes `where` constraints of the same value when the `where` is chained after the `unscope`. This is what a `rewhere` does. This is undesirable behavior. The included tests demonstrate both the `unscope(...).where(...)` behavior as well as the direct use of `rewhere(...)`. This is in reference to #21955.
* | | | | Changed the order of Association constraints from where->order->unscope to ↵kal2015-10-202-0/+5
| | | | | | | | | | | | | | | | | | | | unscope->where->order
* | | | | Green version of moving the handling of supported arguments to `where`yui-knk2015-10-181-7/+4
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit follow up of 4d8f62d. The difference from 4d8f62d are below: * Change `WhereClauseFactory` to accept `Arel::Nodes::Node` * Change test cases of `relation_test.rb`
* | | | Suppress warnings of `assigned but unused variable`yui-knk2015-10-171-2/+0
| | | |
* | | | `where` raises ArgumentError on unsupported types.Jake Worth2015-10-161-0/+6
| |/ / |/| | | | | | | | [#20473]
* | | Add deprecation warning to `ActiveRecord::Relation#update`Ted Johansson2015-10-151-0/+7
|/ / | | | | | | | | | | | | | | When passing an instance of `ActiveRecord::Base` to `#update`, it would internally call `#find`, resulting in a misleading deprecation warning. This change gives this deprecated use of `#update` its own, meaningful warning.
* | `:to_table` when adding a fk through `add_reference`.Yves Senn2015-10-131-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | Closes #21563. The `name` argument of `add_references` was both used to generate the column name `<name>_id` and as the target table for the foreign key `name.pluralize`. It's primary purpose is to define the column name. In cases where the `to_table` of the foreign key is different than the column name we should be able to specify it individually.
* | Merge pull request #21288 from yahonda/mysql_requires_passwordArthur Nogueira Neves2015-10-121-1/+1
|\ \ | | | | | | Allow mysql and mysql2 tests run by database user with password
| * | Allow mysql and mysql2 tests run by database user with passwordYasuo Honda2015-08-181-1/+1
| | |
* | | Merge pull request #21931 from paul/bugfix/remove-deprecated-pg_dump-flagYves Senn2015-10-121-4/+4
| | | | | | | | | | | | Remove deprecated pg_dump -i flag
* | | Merge pull request #11410 from bogdan/increment-concurencyJeremy Daer2015-10-101-0/+9
|\ \ \ | | | | | | | | | | | | Make AR#increment! and #decrement! concurrency-safe
| * | | Make #increment! and #decrement! methods concurency safeBogdan Gusiev2015-10-051-0/+9
| | | |
* | | | Merge pull request #21913 from kamipo/fix_subsecond_precision_supported_versionSean Griffin2015-10-081-3/+1
|\ \ \ \ | | | | | | | | | | Fix subsecond precision supported version
| * | | | Fix subsecond precision supported versionRyuta Kamizono2015-10-081-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fractional Seconds supported version is 5.6.4 or higher. http://dev.mysql.com/doc/refman/5.6/en/fractional-seconds.html
* | | | | Remove unused `pk_and_sequence_for` in AbstractMysqlAdapterRyuta Kamizono2015-10-081-24/+0
|/ / / / | | | | | | | | | | | | | | | | | | | | `pk_and_sequence_for` is implemented for PG and MySQL adapters (not implemented for Sqlite3 adapter). But MySQL adapters are not using `pk_and_sequence_for` already.
* | | | Implement equality comparison on `AttributeSet` and friendsSean Griffin2015-10-061-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Any gems or libraries which do work with serialization or YAML will ultimately need to compare these objects (albeit indirectly) to ensure correctness. These will likely never get used internally (as they're slow), but we should still expose them for others.
* | | | Merge pull request #21839 from andyatkinson/remove-unusued-scopesSean Griffin2015-10-023-10/+0
|\ \ \ \ | | | | | | | | | | Remove unused scopes
| * | | | Remove unused scopesAndy Atkinson2015-10-013-10/+0
| | | | |
* | | | | Merge pull request #21539 from tgxworld/parameters_not_sanitizedSean Griffin2015-10-022-0/+58
|\ \ \ \ \ | | | | | | | | | | | | Fix AC::Parameters not being sanitized for query methods.
| * | | | | Fix AC::Parameters not being sanitized for query methods.Guo Xiang Tan2015-10-022-0/+58
| |/ / / /
* | | | | 💣Sean Griffin2015-10-021-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | I misread this test in https://github.com/rails/rails/commit/1a693c79c32cba070256fdb7bd1990c3d07d554f
* | | | | Fix test failures on MySQLSean Griffin2015-10-022-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | There were a few places where I missed a `create` vs `new` before_type_cast check, and the semantics of `reload` became wrong.
* | | | | Further encapsulate dirty checking on `Attribute`Sean Griffin2015-10-022-4/+38
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We can skip the allocation of a full `AttributeSet` by changing the semantics of how we structure things. Instead of comparing two separate `AttributeSet` objects, and `Attribute` is now a singly linked list of every change that has happened to it. Since the attribute objects are immutable, to apply the changes we simply need to copy the head of the list. It's worth noting that this causes one subtle change in the behavior of AR. When a record is saved successfully, the `before_type_cast` version of everything will be what was sent to the database. I honestly think these semantics make more sense, as we could have just as easily had the DB do `RETURNING *` and updated the record with those if we had things like timestamps implemented at the DB layer. This brings our performance closer to 4.2, but we're still not quite there.
* | | | Merge pull request #20574 from repinel/fix-db-fixtures-loadYves Senn2015-09-305-1/+68
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allow fixtures YAML files to set the model class in the file itself Conflicts: activerecord/CHANGELOG.md
| * | | | Allow fixtures YAML files to set the model class in the file itselfRoque Pinel2015-09-116-1/+69
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, `set_fixture_class` is only available using the `TestFixtures` concern and it is ignored for `rake db:fixtures:load`. Using the correct model class, it is possible for the fixture load to also load the associations from the YAML files (e.g., `:belongs_to` and `:has_many`).
* | | | | Separate `dup` from `deep_dup` in the attributes hashSean Griffin2015-09-281-1/+19
| |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I'm looking to move towards a tree-like structure for dirty checking that involves an attribute holding onto the attribute that it was created from. This means that `changed?` can be fully encapsulated on that object. Since the objects are immutable, in `changes_applied`, we can simply perform a shallow dup, instead of a deep one. I'm not sure if that will actually end up in a performance boost, but I'd like to semantically separate these concepts regardless
* | | | Fix regression in inverse_of on through associationseileencodes2015-09-265-0/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `inverse_of` on through associations was accidently removed/caused to stop working in commit f8d2899 which was part of a refactoring on `ThroughReflection`. To fix we moved `inverse_of` and `check_validity_of_inverse!` to the `AbstractReflection` so it's available to the `ThroughReflection` without having to dup any methods. We then need to delegate `inverse_name` method in `ThroughReflection`. `inverse_name` can't be moved to `AbstractReflection` without moving methods that set the instance variable `@automatic_inverse_of`. This adds a test that ensures that `inverse_of` on a `ThroughReflection` returns the correct class name, and the correct record for the inverse relationship. Fixes #21692
* | | | `validates_acceptance_of` shouldn't require a database connectionSean Griffin2015-09-251-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The implementation of `attribute_method?` on Active Record requires establishing a database connection and querying the schema. As a general rule, we don't want to require database connections for any class macro, as the class should be able to be loaded without a database (e.g. for things like compiling assets). Instead of eagerly defining these methods, we do it lazily the first time they are accessed via `method_missing`. This should not cause any performance hits, as it will only hit `method_missing` once for the entire class.
* | | | Merge pull request #21758 from yui-knk/fix_sanitize_test_exampleEileen M. Uchitelle2015-09-251-4/+4
|\ \ \ \ | | | | | | | | | | Quote prepared statements of `sanitize_sql_array`
| * | | | Quote prepared statements of `sanitize_sql_array`yui-knk2015-09-251-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Sure unquoted SQL code pass test, but this % style prepared statements are dangerous. Test codes and code examples are also "Rails" codes, so quote placeholder of prepared statements.
* | | | | Don't assert fractional seconds can be applied on unsupported adaptersSean Griffin2015-09-241-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was passing prior to 20b177b78ef5d21c8cc255f0376f6b2e948de234, because we were not properly applying our contract that `model.attr == model.tap(&:save).reload.attr` for this case. Now that that has been resolved, this test is invalid on some adapters
* | | | | Remove debug statementsSean Griffin2015-09-241-4/+1
| | | | | | | | | | | | | | | | | | | | They didn't help.
* | | | | Add a few debug statements to figure out the build failureSean Griffin2015-09-241-0/+3
| | | | | | | | | | | | | | | | | | | | Nobody can replicate locally and the failure makes no sense
* | | | | Clean up the implementation of AR::DirtySean Griffin2015-09-242-0/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This moves a bit more of the logic required for dirty checking into the attribute objects. I had hoped to remove the `with_value_from_database` stuff, but unfortunately just calling `dup` on the attribute objects isn't enough, since the values might contain deeply nested data structures. I think this can be cleaned up further. This makes most dirty checking become lazy, and reduces the number of object allocations and amount of CPU time when assigning a value. This opens the door (but doesn't quite finish) to improving the performance of writes to a place comparable to 4.1
* | | | | Fix typo in ignored_columns test [skip ci]Jon Atack2015-09-241-1/+1
| | | | | | | | | | | | | | | | | | | | Follow-up to #21720.
* | | | | Implement ActiveRecord::Base.ignored_columnsJean Boussier2015-09-243-0/+24
|/ / / /
* | | | Merge pull request #21550 from didacte/unscope-associationsSean Griffin2015-09-241-0/+21
|\ \ \ \ | | | | | | | | | | | | | | | ActiveRecord: use association's `unscope` when preloading
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 22:39:46 +0000